Skip to content

Factor "X not available when isolation disabled" into common function #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RalfJung opened this issue Oct 11, 2019 · 4 comments · Fixed by #996
Closed

Factor "X not available when isolation disabled" into common function #986

RalfJung opened this issue Oct 11, 2019 · 4 comments · Fixed by #996
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement

Comments

@RalfJung
Copy link
Member

@christianpoveda added that same check half a dozen times or so. I think it would make sense to factor that into a small helper function that's called everywhere to avoid duplication.

The error message should also mention -Zmiri-disable-isolation so that people know how to make the error go away.

@RalfJung RalfJung added A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement labels Oct 11, 2019
@pvdrz
Copy link
Contributor

pvdrz commented Oct 11, 2019

Should this go in src/helpers.rs as an standalone function? this doesn't need anything from ecx to be inside the extension trait

@RalfJung
Copy link
Member Author

Well it needs to access the "are we in isolation" flag, right?

@pvdrz
Copy link
Contributor

pvdrz commented Oct 11, 2019

Oh yeah I was thinking in just factoring the error, not the isolation check. Time to work

@RalfJung
Copy link
Member Author

Ah I see. I meant all the common code, including the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants