Add SIMD shuffles for SimdType{2,4,8,16,32,64} #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check failures seem to be spurious, i.e. due to under-resourced computers rather than actually being compile or test failures. |
| pub(crate) fn simd_shuffle8<T, U>(x: T, y: T, idx: [u32; 8]) -> U; | ||
| pub(crate) fn simd_shuffle16<T, U>(x: T, y: T, idx: [u32; 16]) -> U; | ||
| pub(crate) fn simd_shuffle32<T, U>(x: T, y: T, idx: [u32; 32]) -> U; | ||
| pub(crate) fn simd_shuffle64<T, U>(x: T, y: T, idx: [u32; 64]) -> U; |
There was a problem hiding this comment.
So if we extend rustc to have fn simd_shuffle<T, U, M>(x: T, y: T, idx: M) -> U we could make this fully generic, right?
There was a problem hiding this comment.
Possibly! I am currently poking people in the const generics crew to better understand what is required, so I'm optimistic but not completely certain what's going to happen next.
calebzulawski
approved these changes
Feb 4, 2021
calebzulawski
requested changes
Feb 5, 2021
calebzulawski
approved these changes
Feb 5, 2021
This const generic implementation for certain lane sizes represents a more limited interface than what LLVM's shufflevector instruction can handle, as normally the length of U can be different from the length of T, but offers an interface that it is expected to be able to expand the capabilities of in the future.
workingjubilee
force-pushed
the
feature/shuffle-self
branch
from
d9844a9 to
5424140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This const generic implementation for certain lane sizes represents
a more limited interface than what LLVM's shufflevector instruction
can handle, as normally the length of U can be different from the
length of T, but offers an interface that it is expected to be able
to expand the capabilities of in the future.