Skip to content

Commit 2131b40

Browse files
committed
Fix unneeded mutability
The `#![cfg_attr(test, deny(warnings))]` caused CI failures from `error: variable does not need to be mutable`, which would otherwise just be a warning. Every case here is simply binding a `&mut`, so the variables themselves indeed don't need to be mutable.
1 parent a852378 commit 2131b40

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/backtrack.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ impl<'a, 'm, 'r, 's, I: Input> Bounded<'a, 'm, 'r, 's, I> {
100100
start: usize,
101101
) -> bool {
102102
let mut cache = cache.borrow_mut();
103-
let mut cache = &mut cache.backtrack;
103+
let cache = &mut cache.backtrack;
104104
let start = input.at(start);
105105
let mut b = Bounded {
106106
prog: prog,

src/dfa.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ impl<'a> Fsm<'a> {
464464
at: usize,
465465
) -> Result<usize> {
466466
let mut cache = cache.borrow_mut();
467-
let mut cache = &mut cache.dfa;
467+
let cache = &mut cache.dfa;
468468
let mut dfa = Fsm {
469469
prog: prog,
470470
start: 0, // filled in below
@@ -497,7 +497,7 @@ impl<'a> Fsm<'a> {
497497
at: usize,
498498
) -> Result<usize> {
499499
let mut cache = cache.borrow_mut();
500-
let mut cache = &mut cache.dfa_reverse;
500+
let cache = &mut cache.dfa_reverse;
501501
let mut dfa = Fsm {
502502
prog: prog,
503503
start: 0, // filled in below
@@ -531,7 +531,7 @@ impl<'a> Fsm<'a> {
531531
) -> Result<usize> {
532532
debug_assert!(matches.len() == prog.matches.len());
533533
let mut cache = cache.borrow_mut();
534-
let mut cache = &mut cache.dfa;
534+
let cache = &mut cache.dfa;
535535
let mut dfa = Fsm {
536536
prog: prog,
537537
start: 0, // filled in below

src/pikevm.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ impl<'r, I: Input> Fsm<'r, I> {
109109
start: usize,
110110
) -> bool {
111111
let mut cache = cache.borrow_mut();
112-
let mut cache = &mut cache.pikevm;
112+
let cache = &mut cache.pikevm;
113113
cache.clist.resize(prog.len(), prog.captures.len());
114114
cache.nlist.resize(prog.len(), prog.captures.len());
115115
let at = input.at(start);
@@ -341,7 +341,7 @@ impl<'r, I: Input> Fsm<'r, I> {
341341
ip = inst.goto1;
342342
}
343343
Match(_) | Char(_) | Ranges(_) | Bytes(_) => {
344-
let mut t = &mut nlist.caps(ip);
344+
let t = &mut nlist.caps(ip);
345345
for (slot, val) in t.iter_mut().zip(thread_caps.iter()) {
346346
*slot = *val;
347347
}

0 commit comments

Comments
 (0)