Merge #766

766: Formatting code into ra_fmt r=matklad a=eulerdisk

As discussed #762 (comment)

I did only move the code without other improvements.

Co-authored-by: Andrea Pretto <[email protected]>

Author: bors[bot]

Cargo.lock

@@ -7,9 +7,9 @@ authors = ["Aleksey Kladov <[email protected]>"]
 [dependencies]
 join_to_string = "0.1.3"
 
-ra_ide_api_light = { path = "../ra_ide_api_light" }
 ra_syntax = { path = "../ra_syntax" }
 ra_text_edit = { path = "../ra_text_edit" }
+ra_fmt = { path = "../ra_fmt" }
 ra_db = { path = "../ra_db" }
 hir = { path = "../ra_hir", package = "ra_hir" }
 

crates/ra_assists/Cargo.toml

@@ -5,7 +5,7 @@ use ra_syntax::{
     SourceFile, TextRange, AstNode, TextUnit, SyntaxNode,
     algo::{find_leaf_at_offset, find_node_at_offset, find_covering_node, LeafAtOffset},
 };
-use ra_ide_api_light::formatting::{leading_indent, reindent};
+use ra_fmt::{leading_indent, reindent};
 
 use crate::{AssistLabel, AssistAction};
 

crates/ra_assists/src/assist_ctx.rs

@@ -1,5 +1,5 @@
 use ra_syntax::{AstNode, ast};
-use ra_ide_api_light::formatting::extract_trivial_expression;
+use ra_fmt::extract_trivial_expression;
 use hir::db::HirDatabase;
 
 use crate::{AssistCtx, Assist};

crates/ra_assists/src/replace_if_let_with_match.rs

@@ -0,0 +1,11 @@
+[package]
+edition = "2018"
+name = "ra_fmt"
+version = "0.1.0"
+authors = ["Aleksey Kladov <[email protected]>"]
+publish = false
+
+[dependencies]
+itertools = "0.8.0"
+
+ra_syntax = { path = "../ra_syntax" }

crates/ra_fmt/Cargo.toml

@@ -1,3 +1,5 @@
+//! This crate provides some utilities for indenting rust code.
+//!
 use itertools::Itertools;
 use ra_syntax::{
     AstNode,
@@ -50,7 +52,7 @@ pub fn extract_trivial_expression(block: &ast::Block) -> Option<&ast::Expr> {
     Some(expr)
 }
 
-pub(crate) fn compute_ws(left: &SyntaxNode, right: &SyntaxNode) -> &'static str {
+pub fn compute_ws(left: &SyntaxNode, right: &SyntaxNode) -> &'static str {
     match left.kind() {
         L_PAREN | L_BRACK => return "",
         L_CURLY => {

crates/ra_ide_api_light/src/formatting.rs renamed to crates/ra_fmt/src/lib.rs

@@ -13,6 +13,7 @@ rustc-hash = "1.0"
 
 ra_syntax = { path = "../ra_syntax" }
 ra_text_edit = { path = "../ra_text_edit" }
+ra_fmt = { path = "../ra_fmt" }
 
 [dev-dependencies]
 test_utils = { path = "../test_utils" }

crates/ra_ide_api_light/Cargo.toml

@@ -5,10 +5,11 @@ use ra_syntax::{
     algo::find_covering_node,
     ast,
 };
-
+use ra_fmt::{
+    compute_ws, extract_trivial_expression
+};
 use crate::{
     LocalEdit, TextEditBuilder,
-    formatting::{compute_ws, extract_trivial_expression},
 };
 
 pub fn join_lines(file: &SourceFile, range: TextRange) -> LocalEdit {

crates/ra_ide_api_light/src/join_lines.rs

@@ -3,7 +3,6 @@
 //! This usually means functions which take syntax tree as an input and produce
 //! an edit or some auxiliary info.
 
-pub mod formatting;
 mod extend_selection;
 mod folding_ranges;
 mod line_index;

crates/ra_ide_api_light/src/lib.rs

@@ -4,8 +4,8 @@ use ra_syntax::{
     algo::{find_node_at_offset, find_leaf_at_offset, LeafAtOffset},
     ast::{self, AstToken},
 };
-
-use crate::{LocalEdit, TextEditBuilder, formatting::leading_indent};
+use ra_fmt::leading_indent;
+use crate::{LocalEdit, TextEditBuilder};
 
 pub fn on_enter(file: &SourceFile, offset: TextUnit) -> Option<LocalEdit> {
     let comment =