RA is now highlighting / analyzing code with async-trait incorrectly...

[dtzxporter]

rust-analyzer version: d6ed146 2022-02-22 stable
rustc version: (eg. output of rustc -V) rustc 1.56.0 (09c42c458 2021-10-18)

relevant settings: Default, not modified

A few weeks ago, RA started incorrectly labeling syntax that is wrapped in #[async_trait]

For example, hovering on a trait function:

Hovering on function brackets (which are now the wrong color):

Just doing:

#[async_trait]
pub trait Test {
    async fn test(&mut self) {
        panic!("");
    }
}

this used to work properly

[Veykril]

This is kind of expected, due to the attribute re-using the spans for its expansion pervasively.

Here is an example of it using the brace tokens span for unreachable_code https://github.com/dtolnay/async-trait/blob/master/src/expand.rs#L369

So hover on those tokens will show all the things the token resolves to after expansion.

Now this is not that ideal here for hover, but I don't think we are able to do much here as resolving these tokens down to the expansion is intentional.

Edit: We could probably sort the hover messages by putting the same thing at the top that the original token covers. Example being a function name is being hovered -> sort all hover messages for function items to the top etc.

[jhgg]

In the interm however, you can tell rust-analyzer to not expand async-trait via the following config:

{
  "rust-analyzer.procMacro.ignored": {
    "async-trait": ["async_trait"]
  }
}

[Veykril]

We now prefer similar kinded tokens on highlighting and hovering. The async token is still shown wrong as async-trait attaches almost the entire expansion to the async keyword except for the one async keyword usage it has. So that's not an issue on our side.