Inlay hints highlighted

[YounessBird]

First of all, massive thanks for creating this tool.
I have been using rust analyzer's "Inlay hints" for quite a while and I noticed yesterday that this feature is now somehow highlighted in my code. I thought maybe it was an automatic update, so I tried previous version of rust analyser but I still could see the highlight, I have also tried the options in the settings, and that didn't work either.

I am using VsCode, version: 1.65.2.
here is a screenshot of what the highlight looks like

Please let me know if there are any more information required.

[lnicola]

This is the styling of the native inlay hints (released this week, see https://rust-analyzer.github.io/thisweek/2022/03/14/changelog-120.html). They can be configured, though.

But never mind the styling, what happened with the function argument there?

[bayedieng]

How to revert to making the inlay transparent like it used to?

[YounessBird]

@lnicola

what happened with the function argument there?

I have only noticed that after I took the screenshot, I also couldn't reproduce whatever glitch that was. Maybe it's worth noting though, that at least in my case I have noticed that the inlay hints take longer now to render in my VsCode for whatever reason.
I also couldn't find an option to disable the inlay hints background colour, maybe because of this merged pull request it says there that:

"rust_analyzer.inlayHints.foreground.typeHints": "#fdb6fdf0",
 "rust_analyzer.inlayHints.foreground.paramHints": "#fdb6fdf0",
 "rust_analyzer.inlayHints.background.chainingHints": "#6b0c0c81"

are now customized using native VSCode settings instead of rust-analyzer-specific ones and that possibly there is no equivalent for the chainingHints color available in VScode settings yet.
I have looked in the VSCode setting as well but to no avail.
I have also tried different themes to see what the background color will look like and in some themes it doesn't look good at all, I can post a screenshot as an example if required.
if there is a way to disable this new feature please provide guidance.

[jhgg]

FYI - I opened an issue about making the inlay hints look more like the old-style inlay hints via a config in vs-code here: microsoft/vscode#145191

Discussion is ongoing!

[lnicola]

See also the docs: https://github.com/rust-analyzer/rust-analyzer/blob/master/docs/user/manual.adoc#color-configurations (the rendered version of the PR you've linked to).

the inlay hints take longer now to render in my VsCode for whatever reason

They're slower while typing because Code intentionally delays updating them.

[lnicola]

Let's close this, since there's nothing we can do about the formatting (except coordinating with Code, like jhgg did). If you run into glitchy hints again, please check the Rust Analyzer Language Server output channel for any errors and file a new issue.

[YounessBird]

@lnicola Thanks for the link, maybe it's worth noting that those changes are not reflected in the rust-analyser website specifically in the link provided under configuration in the extension's home page. I will be happy to contribute if you can provide me guidance.

[lnicola]

The published manual is updated automatically on Monday after the release. So there's no need to do anything about it.

[Fenex]

New style of infered types is SO MUCH YELLING... For now I can't read my value code with default style settings anymore :(

[lnicola]

@Fenex what if you set the hint background to black or transparent?

[YounessBird]

@Fenex using this settings made it look almost like how it used to be except for the padding
add to your settings.json

"workbench.colorCustomizations": {
    "editor.inlayHints.fontFamily": "Courier New",
    "editor.inlayHints.fontSize": 11,
    "[Your-theme-name]": {
      "editorInlayHint.foreground": "#868686f0",
      "editorInlayHint.background": "#ff000000",
      "editorInlayHint.typeForeground": "#aaa5aaf0",
      "editorInlayHint.parameterForeground": "#fdb6fdf0"
    }

don't forget to substitute Your-theme-name

[Fenex]

@lnicola @YounessBird thanks very much for your help. Your listing is really help me and now I'm happy again!

Howver. By the way.

I don't think that this change was really indeed.

An infered types are not importantly in a code, it's just an optional notes (notes that can make more clear of small piece of the code). A code must explains general sense of alghorithm and infered types is secondary stuffs. I'm sure any secondary stuff must be smaller, opacitier and non-yellier by default. I want pay your attention to my above screenshot: there is a default theme and result view is very-very awful (my opinion). I guess this will afraid new little rustaceans (hope i wrong) :(

[lnicola]

@Fenex this change replaced a hacky implementation of inlay hints (using CSS :after pseudo-elements via Code decorations) with the native one, which is better when using word wrapping, screen readers and probably other things. And we have no wish to maintain the previous implementation, so it was needed.

About the styling itself, that's the decision of the Code maintainers. The background was added because the hints themselves looked very similar to the inline completion suggestions. Fortunately, it's relatively customizable, and it will probably get better in time.

[Fenex]

Wow. Thanks for exhaustive explanation! My fail I thought this was only visual change. Now it's clear. Thank you for support!

[jhgg]

They're slower while typing because Code intentionally delays updating them.

microsoft/vscode#145377

I've opened a feature request on vscode's end to allow the delay to be user configurable!