Skip to content

vscode middleware does not pass all the attributes through #5117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kjeremy opened this issue Jun 29, 2020 · 0 comments
Open

vscode middleware does not pass all the attributes through #5117

kjeremy opened this issue Jun 29, 2020 · 0 comments
Labels
A-assists A-vscode vscode plugin issues C-enhancement Category: enhancement E-has-instructions Issue has some instructions and pointers to code to get started E-medium S-actionable Someone could pick this issue up and work on it right now

Comments

@kjeremy
Copy link
Contributor

kjeremy commented Jun 29, 2020 •
edited by Veykril
Loading

Found while working on #5116

We do not everything on to vscode (isPreferred, diagnostics etc.)

rust-analyzer/editors/code/src/client.ts

Line 234 in f1b257f

const action = new vscode.CodeAction(item.title, kind);

@matklad matklad added E-medium E-has-instructions Issue has some instructions and pointers to code to get started labels Jul 11, 2020
@lnicola lnicola added the S-actionable Someone could pick this issue up and work on it right now label Jan 18, 2021
@Veykril Veykril added A-vscode vscode plugin issues A-assists labels Nov 11, 2022
@Veykril Veykril added the C-enhancement Category: enhancement label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-assists A-vscode vscode plugin issues C-enhancement Category: enhancement E-has-instructions Issue has some instructions and pointers to code to get started E-medium S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lnicola @matklad @Veykril @kjeremy