Skip to content

proc macro server dies too easily and loses panic messages #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lnicola opened this issue Dec 14, 2020 · 6 comments · Fixed by #7047
Closed

proc macro server dies too easily and loses panic messages #6880

lnicola opened this issue Dec 14, 2020 · 6 comments · Fixed by #7047
Labels
A-macro macro expansion S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@lnicola
Copy link
Member

lnicola commented Dec 14, 2020

I was playing with the example in #6868 (comment) and it seems really easy to make it crash:

image

image

@lnicola lnicola changed the title proc macro server dies too easily proc macro server dies too easily and loses panic messages Dec 14, 2020
@lnicola lnicola added the A-macro macro expansion label Dec 14, 2020
@jonas-schievink
Copy link
Contributor

I've noticed this too, the loss of backtraces is due to the macro-side proc_macro crate turning them off intentionally. Not sure if we can do much about that.

I don't know why the double panic happens, but that would be great to fix as it tears down the whole process.

@lnicola
Copy link
Member Author

lnicola commented Dec 19, 2020

Another example: the server is crashing on the rust-analyzer repository.

@edwin0cheng
Copy link
Member

edwin0cheng commented Dec 20, 2020

I just checked that the code mentioned do not crash now (052e722) ?!

Screenshot 2020-12-20 134041

@lnicola
Copy link
Member Author

lnicola commented Dec 20, 2020

I'm not sure how exactly I've made it crash -- are you getting no errors in the RA output channel?

It should also crash on its own in three RA repo.

@edwin0cheng
Copy link
Member

I'm not sure how exactly I've made it crash -- are you getting no errors in the RA output channel?

Yes, no errors.

@lnicola
Copy link
Member Author

lnicola commented Dec 20, 2020

I'm using a nightly Rust, maybe that's why?

2020-12-20.08-36-22.mp4

(Firefox doesn't play that video, try to download it or use Chrome)

@lnicola lnicola added the S-unactionable Issue requires feedback, design decisions or is blocked on other work label Dec 20, 2020
@bors bors bot closed this as completed in 0fd75c9 Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-macro macro expansion S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants