Skip to content

Semantic Highlighting: Tuple field is considered a number #9220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CryZe opened this issue Jun 11, 2021 · 2 comments · Fixed by #9221
Closed

Semantic Highlighting: Tuple field is considered a number #9220

CryZe opened this issue Jun 11, 2021 · 2 comments · Fixed by #9221
Labels
S-actionable Someone could pick this issue up and work on it right now

Comments

@CryZe
Copy link
Contributor

CryZe commented Jun 11, 2021

https://i.imgur.com/AsgnyAF.png

When accessing a field, it is usually marked as the semantic token type property, but when accessing a field of a tuple, it is not considered a property but instead a number.
@Veykril Veykril added the S-actionable Someone could pick this issue up and work on it right now label Jun 11, 2021
@lnicola
Copy link
Member

lnicola commented Jun 11, 2021

CC #1109

@Veykril Veykril mentioned this issue Jun 11, 2021
Merged
@Veykril
Copy link
Member

Veykril commented Jun 11, 2021

This isn't due to that issue actually, we just didn't highlight tuple field accesses properly.

@bors bors bot closed this as completed in 187d55a Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Highlight tuple field accesses correctly Veykril/rust-analyzer
3 participants
@lnicola @CryZe @Veykril