-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: into_iterator
not completed on Vec<{unknown}>
#10373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ah, I didn't manage to write a test here. Should we do the same thing in |
Actually there are more: |
I couldn't reproduce this in tests but RA definetely fails on it ( struct Foo<T>;
struct Bar;
trait Trait {
fn quux(&self) {}
}
impl<T> core::ops::Deref for Foo<T> {
type Target = Bar;
fn deref(&self) -> &Self::Target;
}
impl Trait for Bar {}
fn main() {
let x: Foo<_>;
x.$0
// missing `quux` method in completions
} I had tried to fix struct Vec<T>;
impl<T> IntoIterator for Vec<T> {
type Item = ();
type IntoIter = ();
fn into_iter(self);
}
fn main() {
let x: Vec<_>;
x.$0;
// missing postfix completion "for"
} Leave this and others for next time? |
into_iterator
not completed on Vec<{unknown}>
417bbfb
to
a683b3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
✌️ iDawer can now approve this pull request. To approve and merge a pull request, simply reply with |
a683b3b
to
f222665
Compare
bors r+ |
Fixes #10297