Skip to content

internal: Try to publish the universal VSIX before the other ones #12359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2022

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented May 23, 2022

@lnicola lnicola marked this pull request as ready for review May 23, 2022 15:05
@lnicola lnicola force-pushed the universal-vsix-part-2 branch from 1f83ef3 to abc541e Compare May 23, 2022 15:11
@@ -248,9 +248,9 @@ jobs:
if: github.ref == 'refs/heads/release' && (github.repository == 'rust-analyzer/rust-analyzer' || github.repository == 'rust-lang/rust-analyzer')
working-directory: ./editors/code
# token from https://dev.azure.com/rust-analyzer/
run: npx vsce publish --pat ${{ secrets.MARKETPLACE_TOKEN }} --packagePath ../../dist/rust-analyzer-*.vsix
run: npx vsce publish --pat ${{ secrets.MARKETPLACE_TOKEN }} --packagePath ../../dist/rust-analyzer-no-server.vsix ../../dist/rust-analyzer-alpine-x64.vsix ../../dist/rust-analyzer-darwin-arm64.vsix ../../dist/rust-analyzer-darwin-x64.vsix ../../dist/rust-analyzer-linux-arm64.vsix ../../dist/rust-analyzer-linux-x64.vsix ../../dist/rust-analyzer-win32-arm64.vsix ../../dist/rust-analyzer-win32-x64.vsix
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know a nicer way to do this 😞.

@lnicola
Copy link
Member Author

lnicola commented May 23, 2022

@bors r+

@bors
Copy link
Contributor

bors commented May 23, 2022

📌 Commit abc541e has been approved by lnicola

@bors
Copy link
Contributor

bors commented May 23, 2022

⌛ Testing commit abc541e with merge 7be85a5...

@bors
Copy link
Contributor

bors commented May 23, 2022

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 7be85a5 to master...

@bors bors merged commit 7be85a5 into rust-lang:master May 23, 2022
@lnicola lnicola deleted the universal-vsix-part-2 branch May 23, 2022 15:54
bors added a commit that referenced this pull request May 23, 2022
…r=lnicola

Revert "internal: Try to publish the universal VSIX before the other ones"

Reverts #12359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants