diff --git a/crates/rust-analyzer/src/config.rs b/crates/rust-analyzer/src/config.rs index 68b2a2abdd0c..6870d032bd6f 100644 --- a/crates/rust-analyzer/src/config.rs +++ b/crates/rust-analyzer/src/config.rs @@ -177,6 +177,11 @@ impl Config { pub fn update(&mut self, json: serde_json::Value) { log::info!("Config::update({:#})", json); + + if json.is_null() || json.as_object().map_or(false, |it| it.is_empty()) { + return; + } + let data = ConfigData::from_json(json); self.with_sysroot = data.withSysroot; diff --git a/crates/rust-analyzer/src/main_loop.rs b/crates/rust-analyzer/src/main_loop.rs index a41f7f56466c..bb7c4c0c64f9 100644 --- a/crates/rust-analyzer/src/main_loop.rs +++ b/crates/rust-analyzer/src/main_loop.rs @@ -468,6 +468,8 @@ impl GlobalState { } (None, Some(mut configs)) => { if let Some(json) = configs.get_mut(0) { + // Note that json can be null according to the spec if the client can't + // provide a configuration. This is handled in Config::update below. let mut config = this.config.clone(); config.update(json.take()); this.update_configuration(config);