Fix workspace warning.

Author: xiongmao86

clippy_lints/src/from_instead_of_into.rs

@@ -2,7 +2,7 @@ use crate::utils::span_lint_and_sugg;
 use crate::utils::{snippet, snippet_opt};
 use if_chain::if_chain;
 use rustc_errors::Applicability;
-use rustc_hir::*;
+use rustc_hir::{GenericBound, GenericBounds, WherePredicate};
 use rustc_lint::{LateContext, LateLintPass};
 use rustc_session::{declare_lint_pass, declare_tool_lint};
 use rustc_span::symbol::sym;
@@ -87,57 +87,54 @@ impl LateLintPass<'tcx> for FromInsteadOfInto {
             }
         }
 
-        match wp {
-            WherePredicate::BoundPredicate(wbp) => {
-                if_chain! {
-                    let bounds = wbp.bounds;
-                    if let Some(position) = bounds.iter().position(|b| is_target_generic_bound(cx, b));
-                    let target_bound = &bounds[position];
-                    if let Some(tr_ref) = target_bound.trait_ref();
-                    if let Some(def_id) = tr_ref.trait_def_id();
-                    if let Some(last_seg) = tr_ref.path.segments.last();
-                    if let Some(generic_arg) = last_seg.args().args.first();
-                    if let Some(bounded_ty) = snippet_opt(cx, wbp.bounded_ty.span);
-                    if let Some(generic_arg_of_from_or_try_from) = snippet_opt(cx, generic_arg.span());
-                    then {
-                        let replace_trait_name;
-                        let target_trait_name;
-                        if cx.tcx.is_diagnostic_item(sym::from_trait, def_id) {
-                            replace_trait_name = "Into";
-                            target_trait_name = "From";
-                        } else if cx.tcx.is_diagnostic_item(sym::try_from_trait, def_id) {
-                            replace_trait_name = "TryInto";
-                            target_trait_name = "TryFrom";
-                        } else {
-                            replace_trait_name = "";
-                            target_trait_name = "";
-                        }
+        if let WherePredicate::BoundPredicate(wbp) = wp {
+            if_chain! {
+                let bounds = wbp.bounds;
+                if let Some(position) = bounds.iter().position(|b| is_target_generic_bound(cx, b));
+                let target_bound = &bounds[position];
+                if let Some(tr_ref) = target_bound.trait_ref();
+                if let Some(def_id) = tr_ref.trait_def_id();
+                if let Some(last_seg) = tr_ref.path.segments.last();
+                if let Some(generic_arg) = last_seg.args().args.first();
+                if let Some(bounded_ty) = snippet_opt(cx, wbp.bounded_ty.span);
+                if let Some(generic_arg_of_from_or_try_from) = snippet_opt(cx, generic_arg.span());
+                then {
+                    let replace_trait_name;
+                    let target_trait_name;
+                    if cx.tcx.is_diagnostic_item(sym::from_trait, def_id) {
+                        replace_trait_name = "Into";
+                        target_trait_name = "From";
+                    } else if cx.tcx.is_diagnostic_item(sym::try_from_trait, def_id) {
+                        replace_trait_name = "TryInto";
+                        target_trait_name = "TryFrom";
+                    } else {
+                        replace_trait_name = "";
+                        target_trait_name = "";
+                    }
 
-                        if !replace_trait_name.is_empty() && !target_trait_name.is_empty() {
-                            let message = format!("{} trait is preferable than {} as a generic bound", replace_trait_name, target_trait_name);
+                    if !replace_trait_name.is_empty() && !target_trait_name.is_empty() {
+                        let message = format!("{} trait is preferable than {} as a generic bound", replace_trait_name, target_trait_name);
 
-                            let extracted_where_predicate = format!("{}: {}<{}>", generic_arg_of_from_or_try_from, replace_trait_name, bounded_ty);
-                            let sugg;
-                            if bounds.len() == 1 {
-                                sugg = extracted_where_predicate;
-                            } else {
-                                let bounds = get_reduced_bounds_str(cx, position, bounds);
-                                sugg = format!("{}, {}: {}", extracted_where_predicate, bounded_ty, bounds);
-                            }
-                            span_lint_and_sugg(
-                                cx,
-                                FROM_INSTEAD_OF_INTO,
-                                wp.span(),
-                                &message,
-                                "try",
-                                sugg,
-                                Applicability::MaybeIncorrect
-                            );
+                        let extracted_where_predicate = format!("{}: {}<{}>", generic_arg_of_from_or_try_from, replace_trait_name, bounded_ty);
+                        let sugg;
+                        if bounds.len() == 1 {
+                            sugg = extracted_where_predicate;
+                        } else {
+                            let bounds = get_reduced_bounds_str(cx, position, bounds);
+                            sugg = format!("{}, {}: {}", extracted_where_predicate, bounded_ty, bounds);
                         }
+                        span_lint_and_sugg(
+                            cx,
+                            FROM_INSTEAD_OF_INTO,
+                            wp.span(),
+                            &message,
+                            "try",
+                            sugg,
+                            Applicability::MaybeIncorrect
+                        );
                     }
                 }
-            },
-            _ => (),
-        };
+            }
+        }
     }
 }