Remove the tons of allows

Author: Centri3

CHANGELOG.md

@@ -5465,5 +5465,5 @@ Released 2018-09-13
 [`accept-comment-above-attributes`]: https://doc.rust-lang.org/clippy/lint_configuration.html#accept-comment-above-attributes
 [`allow-one-hash-in-raw-strings`]: https://doc.rust-lang.org/clippy/lint_configuration.html#allow-one-hash-in-raw-strings
 [`absolute-symbol-paths-max-segments`]: https://doc.rust-lang.org/clippy/lint_configuration.html#absolute-symbol-paths-max-segments
-[`absolute-symbol-paths-allow-std`]: https://doc.rust-lang.org/clippy/lint_configuration.html#absolute-symbol-paths-allow-std
+[`absolute-symbol-paths-allowed-crates`]: https://doc.rust-lang.org/clippy/lint_configuration.html#absolute-symbol-paths-allowed-crates
 <!-- end autogenerated links to configuration documentation -->

book/src/lint_configuration.md

@@ -740,10 +740,10 @@ The maximum number of segments a path can have before being linted
 * [`absolute_symbol_paths`](https://rust-lang.github.io/rust-clippy/master/index.html#absolute_symbol_paths)
 
 
-## `absolute-symbol-paths-allow-std`
-Whether to allow paths originating from `core`/`std`/`alloc`
+## `absolute-symbol-paths-allowed-crates`
+Which crates to allow absolute symbols, `crate` will allow the local crate
 
-**Default Value:** `false` (`bool`)
+**Default Value:** `{}` (`rustc_data_structures::fx::FxHashSet<String>`)
 
 ---
 **Affected lints:**

clippy_lints/src/absolute_symbol_paths.rs

@@ -10,13 +10,16 @@ use rustc_span::symbol::kw;
 
 declare_clippy_lint! {
     /// ### What it does
-    /// Checks for usage of symbols through absolute paths, like `std::env::current_dir`.
+    /// Checks for usage of items through absolute paths, like `std::env::current_dir`.
     ///
     /// ### Why is this bad?
     /// Many codebases have their own style when it comes to symbol importing, but one that is
     /// seldom used is using absolute paths *everywhere*. This is generally considered unidiomatic,
     /// and you should add a `use` statement.
     ///
+    /// The default maximum segments (2) is pretty strict, you may want to increase this in
+    /// clippy.toml.
+    ///
     /// Note: One exception to this is code from macro expansion - this does not lint such cases, as
     /// using absolute paths is the proper way of referencing symbols in one.
     ///

clippy_lints/src/lib.rs

@@ -10,11 +10,7 @@
 #![feature(stmt_expr_attributes)]
 #![recursion_limit = "512"]
 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
-#![allow(
-    clippy::absolute_symbol_paths,
-    clippy::missing_docs_in_private_items,
-    clippy::must_use_candidate
-)]
+#![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
 #![warn(trivial_casts, trivial_numeric_casts)]
 // warn on lints, that are included in `rust-lang/rust`s bootstrap
 #![warn(rust_2018_idioms, unused_lifetimes)]

clippy_lints/src/utils/conf.rs

@@ -553,8 +553,9 @@ define_Conf! {
     (allow_one_hash_in_raw_strings: bool = false),
     /// Lint: ABSOLUTE_SYMBOL_PATHS.
     ///
-    /// The maximum number of segments a path can have before being linted
-    (absolute_symbol_paths_max_segments: u64 = 3),
+    /// The maximum number of segments a path can have before being linted, anything above this will
+    /// be linted.
+    (absolute_symbol_paths_max_segments: u64 = 2),
     /// Lint: ABSOLUTE_SYMBOL_PATHS.
     ///
     /// Which crates to allow absolute symbols, `crate` will allow the local crate

clippy_utils/src/check_proc_macro.rs

@@ -354,7 +354,7 @@ pub trait WithSearchPat<'cx> {
     fn span(&self) -> Span;
 }
 macro_rules! impl_with_search_pat {
-    ($cx:ident: $ty:ident with $fn:ident $(($tcx:ident))? && $span_method:ident$($par:tt)?) => {
+    ($cx:ident: $ty:ident with $fn:ident $(($tcx:ident))?) => {
         impl<'cx> WithSearchPat<'cx> for $ty<'cx> {
             type Context = $cx<'cx>;
             #[allow(unused_variables)]
@@ -363,19 +363,18 @@ macro_rules! impl_with_search_pat {
                 $fn($($tcx,)? self)
             }
             fn span(&self) -> Span {
-                self.$span_method$($par)?
+                self.span
             }
         }
     };
 }
-impl_with_search_pat!(LateContext: Expr with expr_search_pat(tcx) && span);
-impl_with_search_pat!(LateContext: Item with item_search_pat && span);
-impl_with_search_pat!(LateContext: TraitItem with trait_item_search_pat && span);
-impl_with_search_pat!(LateContext: ImplItem with impl_item_search_pat && span);
-impl_with_search_pat!(LateContext: FieldDef with field_def_search_pat && span);
-impl_with_search_pat!(LateContext: Variant with variant_search_pat && span);
-impl_with_search_pat!(LateContext: Ty with ty_search_pat && span);
-impl_with_search_pat!(LateContext: QPath with qpath_search_pat && span());
+impl_with_search_pat!(LateContext: Expr with expr_search_pat(tcx));
+impl_with_search_pat!(LateContext: Item with item_search_pat);
+impl_with_search_pat!(LateContext: TraitItem with trait_item_search_pat);
+impl_with_search_pat!(LateContext: ImplItem with impl_item_search_pat);
+impl_with_search_pat!(LateContext: FieldDef with field_def_search_pat);
+impl_with_search_pat!(LateContext: Variant with variant_search_pat);
+impl_with_search_pat!(LateContext: Ty with ty_search_pat);
 
 impl<'cx> WithSearchPat<'cx> for (&FnKind<'cx>, &Body<'cx>, HirId, Span) {
     type Context = LateContext<'cx>;

tests/ui-cargo/module_style/fail_mod/src/main.rs

@@ -1,4 +1,3 @@
-#![allow(clippy::absolute_symbol_paths)]
 #![warn(clippy::self_named_module_files)]
 
 mod bad;

tests/ui-internal/interning_defined_symbol.fixed

@@ -1,7 +1,6 @@
 //@run-rustfix
 #![deny(clippy::internal)]
 #![allow(
-    clippy::absolute_symbol_paths,
     clippy::missing_clippy_version_attribute,
     clippy::let_unit_value
 )]

tests/ui-internal/interning_defined_symbol.rs

@@ -1,10 +1,6 @@
 //@run-rustfix
 #![deny(clippy::internal)]
-#![allow(
-    clippy::absolute_symbol_paths,
-    clippy::missing_clippy_version_attribute,
-    clippy::let_unit_value
-)]
+#![allow(clippy::missing_clippy_version_attribute, clippy::let_unit_value)]
 #![feature(rustc_private)]
 
 extern crate rustc_span;

tests/ui-internal/unnecessary_def_path.fixed

@@ -1,6 +1,5 @@
 //@run-rustfix
 //@aux-build:paths.rs
-#![allow(clippy::absolute_symbol_paths)]
 #![deny(clippy::internal)]
 #![feature(rustc_private)]
 

tests/ui-internal/unnecessary_def_path.rs

@@ -1,6 +1,5 @@
 //@run-rustfix
 //@aux-build:paths.rs
-#![allow(clippy::absolute_symbol_paths)]
 #![deny(clippy::internal)]
 #![feature(rustc_private)]
 

tests/ui-internal/unnecessary_symbol_str.fixed

@@ -2,7 +2,6 @@
 #![feature(rustc_private)]
 #![deny(clippy::internal)]
 #![allow(
-    clippy::absolute_symbol_paths,
     clippy::borrow_deref_ref,
     clippy::unnecessary_operation,
     unused_must_use,

tests/ui-internal/unnecessary_symbol_str.rs

@@ -2,7 +2,6 @@
 #![feature(rustc_private)]
 #![deny(clippy::internal)]
 #![allow(
-    clippy::absolute_symbol_paths,
     clippy::borrow_deref_ref,
     clippy::unnecessary_operation,
     unused_must_use,

tests/ui-toml/toml_disallowed_types/conf_disallowed_types.rs

@@ -1,4 +1,3 @@
-#![allow(clippy::absolute_symbol_paths)]
 #![warn(clippy::disallowed_types)]
 
 extern crate quote;

tests/ui-toml/toml_disallowed_types/conf_disallowed_types.stderr

@@ -1,129 +1,129 @@
 error: `std::sync::atomic::AtomicU32` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:8:1
+  --> $DIR/conf_disallowed_types.rs:7:1
    |
 LL | use std::sync::atomic::AtomicU32;
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D clippy::disallowed-types` implied by `-D warnings`
 
 error: `std::time::Instant` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:9:1
+  --> $DIR/conf_disallowed_types.rs:8:1
    |
 LL | use std::time::Instant as Sneaky;
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: `std::time::Instant` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:13:33
+  --> $DIR/conf_disallowed_types.rs:12:33
    |
 LL | fn bad_return_type() -> fn() -> Sneaky {
    |                                 ^^^^^^
 
 error: `std::time::Instant` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:17:28
+  --> $DIR/conf_disallowed_types.rs:16:28
    |
 LL | fn bad_arg_type(_: impl Fn(Sneaky) -> foo::atomic::AtomicU32) {}
    |                            ^^^^^^
 
 error: `std::sync::atomic::AtomicU32` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:17:39
+  --> $DIR/conf_disallowed_types.rs:16:39
    |
 LL | fn bad_arg_type(_: impl Fn(Sneaky) -> foo::atomic::AtomicU32) {}
    |                                       ^^^^^^^^^^^^^^^^^^^^^^
 
 error: `std::io::Read` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:19:22
+  --> $DIR/conf_disallowed_types.rs:18:22
    |
 LL | fn trait_obj(_: &dyn std::io::Read) {}
    |                      ^^^^^^^^^^^^^
 
 error: `usize` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:21:33
+  --> $DIR/conf_disallowed_types.rs:20:33
    |
 LL | fn full_and_single_path_prim(_: usize, _: bool) {}
    |                                 ^^^^^
 
 error: `bool` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:21:43
+  --> $DIR/conf_disallowed_types.rs:20:43
    |
 LL | fn full_and_single_path_prim(_: usize, _: bool) {}
    |                                           ^^^^
 
 error: `usize` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:23:28
+  --> $DIR/conf_disallowed_types.rs:22:28
    |
 LL | fn const_generics<const C: usize>() {}
    |                            ^^^^^
 
 error: `usize` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:25:24
+  --> $DIR/conf_disallowed_types.rs:24:24
    |
 LL | struct GenArg<const U: usize>([u8; U]);
    |                        ^^^^^
 
 error: `std::net::Ipv4Addr` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:29:10
+  --> $DIR/conf_disallowed_types.rs:28:10
    |
 LL | fn ip(_: std::net::Ipv4Addr) {}
    |          ^^^^^^^^^^^^^^^^^^
    |
    = note: no IPv4 allowed (from clippy.toml)
 
 error: `std::net::TcpListener` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:31:16
+  --> $DIR/conf_disallowed_types.rs:30:16
    |
 LL | fn listener(_: std::net::TcpListener) {}
    |                ^^^^^^^^^^^^^^^^^^^^^
 
 error: `std::collections::HashMap` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:35:48
+  --> $DIR/conf_disallowed_types.rs:34:48
    |
 LL |     let _: std::collections::HashMap<(), ()> = std::collections::HashMap::new();
    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: `std::collections::HashMap` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:35:12
+  --> $DIR/conf_disallowed_types.rs:34:12
    |
 LL |     let _: std::collections::HashMap<(), ()> = std::collections::HashMap::new();
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: `std::time::Instant` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:36:13
+  --> $DIR/conf_disallowed_types.rs:35:13
    |
 LL |     let _ = Sneaky::now();
    |             ^^^^^^
 
 error: `std::sync::atomic::AtomicU32` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:37:13
+  --> $DIR/conf_disallowed_types.rs:36:13
    |
 LL |     let _ = foo::atomic::AtomicU32::new(0);
    |             ^^^^^^^^^^^^^^^^^^^^^^
 
 error: `std::sync::atomic::AtomicU32` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:38:17
+  --> $DIR/conf_disallowed_types.rs:37:17
    |
 LL |     static FOO: std::sync::atomic::AtomicU32 = foo::atomic::AtomicU32::new(1);
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: `std::sync::atomic::AtomicU32` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:38:48
+  --> $DIR/conf_disallowed_types.rs:37:48
    |
 LL |     static FOO: std::sync::atomic::AtomicU32 = foo::atomic::AtomicU32::new(1);
    |                                                ^^^^^^^^^^^^^^^^^^^^^^
 
 error: `syn::TypePath` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:39:43
+  --> $DIR/conf_disallowed_types.rs:38:43
    |
 LL |     let _: std::collections::BTreeMap<(), syn::TypePath> = Default::default();
    |                                           ^^^^^^^^^^^^^
 
 error: `syn::Ident` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:40:13
+  --> $DIR/conf_disallowed_types.rs:39:13
    |
 LL |     let _ = syn::Ident::new("", todo!());
    |             ^^^^^^^^^^
 
 error: `usize` is not allowed according to config
-  --> $DIR/conf_disallowed_types.rs:42:12
+  --> $DIR/conf_disallowed_types.rs:41:12
    |
 LL |     let _: usize = 64_usize;
    |            ^^^^^

tests/ui/cast_alignment.rs

@@ -2,7 +2,6 @@
 
 #![feature(rustc_private)]
 #![feature(core_intrinsics)]
-#![allow(clippy::absolute_symbol_paths)]
 extern crate libc;
 
 #[warn(clippy::cast_ptr_alignment)]

tests/ui/cast_alignment.stderr

@@ -1,25 +1,25 @@
 error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) (1 < 2 bytes)
-  --> $DIR/cast_alignment.rs:20:5
+  --> $DIR/cast_alignment.rs:19:5
    |
 LL |     (&1u8 as *const u8) as *const u16;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D clippy::cast-ptr-alignment` implied by `-D warnings`
 
 error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u16`) (1 < 2 bytes)
-  --> $DIR/cast_alignment.rs:21:5
+  --> $DIR/cast_alignment.rs:20:5
    |
 LL |     (&mut 1u8 as *mut u8) as *mut u16;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) (1 < 2 bytes)
-  --> $DIR/cast_alignment.rs:24:5
+  --> $DIR/cast_alignment.rs:23:5
    |
 LL |     (&1u8 as *const u8).cast::<u16>();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u16`) (1 < 2 bytes)
-  --> $DIR/cast_alignment.rs:25:5
+  --> $DIR/cast_alignment.rs:24:5
    |
 LL |     (&mut 1u8 as *mut u8).cast::<u16>();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

tests/ui/default_trait_access.fixed

@@ -2,7 +2,7 @@
 //@aux-build: proc_macros.rs:proc-macro
 #![deny(clippy::default_trait_access)]
 #![allow(dead_code, unused_imports)]
-#![allow(clippy::absolute_symbol_paths, clippy::uninlined_format_args)]
+#![allow(clippy::uninlined_format_args)]
 
 extern crate proc_macros;
 

tests/ui/default_trait_access.rs

@@ -2,7 +2,7 @@
 //@aux-build: proc_macros.rs:proc-macro
 #![deny(clippy::default_trait_access)]
 #![allow(dead_code, unused_imports)]
-#![allow(clippy::absolute_symbol_paths, clippy::uninlined_format_args)]
+#![allow(clippy::uninlined_format_args)]
 
 extern crate proc_macros;
 

tests/ui/entry.fixed

@@ -1,12 +1,7 @@
 //@needs-asm-support
 //@run-rustfix
 
-#![allow(
-    unused,
-    clippy::absolute_symbol_paths,
-    clippy::needless_pass_by_value,
-    clippy::collapsible_if
-)]
+#![allow(unused, clippy::needless_pass_by_value, clippy::collapsible_if)]
 #![warn(clippy::map_entry)]
 
 use std::arch::asm;

tests/ui/entry.rs

@@ -1,12 +1,7 @@
 //@needs-asm-support
 //@run-rustfix
 
-#![allow(
-    unused,
-    clippy::absolute_symbol_paths,
-    clippy::needless_pass_by_value,
-    clippy::collapsible_if
-)]
+#![allow(unused, clippy::needless_pass_by_value, clippy::collapsible_if)]
 #![warn(clippy::map_entry)]
 
 use std::arch::asm;