Skip to content

Commit 85e1646

Browse files
more tests
1 parent 2177f2c commit 85e1646

6 files changed

+32
-2
lines changed

tests/ui/iter_filter_is_ok.fixed

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ fn main() {
66
let _ = vec![Ok(1), Err(2), Ok(3)].into_iter().flatten();
77
//~^ HELP: consider using `flatten` instead
88

9+
#[rustfmt::skip]
10+
let _ = vec![Ok(1), Err(2)].into_iter().flatten();
11+
//~^ HELP: consider using `flatten` instead
12+
913
// Don't lint below
1014
let mut counter = 0;
1115
let _ = vec![Ok(1), Err(2)].into_iter().filter(|o| {

tests/ui/iter_filter_is_ok.rs

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ fn main() {
66
let _ = vec![Ok(1), Err(2), Ok(3)].into_iter().filter(|a| a.is_ok());
77
//~^ HELP: consider using `flatten` instead
88

9+
#[rustfmt::skip]
10+
let _ = vec![Ok(1), Err(2)].into_iter().filter(|o| { o.is_ok() });
11+
//~^ HELP: consider using `flatten` instead
12+
913
// Don't lint below
1014
let mut counter = 0;
1115
let _ = vec![Ok(1), Err(2)].into_iter().filter(|o| {

tests/ui/iter_filter_is_ok.stderr

+7-1
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,11 @@ error: `filter` for `is_ok` on iterator over `Result`s
1313
LL | let _ = vec![Ok(1), Err(2), Ok(3)].into_iter().filter(|a| a.is_ok());
1414
| ^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
1515

16-
error: aborting due to 2 previous errors
16+
error: `filter` for `is_ok` on iterator over `Result`s
17+
--> $DIR/iter_filter_is_ok.rs:10:45
18+
|
19+
LL | let _ = vec![Ok(1), Err(2)].into_iter().filter(|o| { o.is_ok() });
20+
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
21+
22+
error: aborting due to 3 previous errors
1723

tests/ui/iter_filter_is_some.fixed

+5
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,17 @@ fn main() {
66
let _ = vec![Some(1)].into_iter().flatten();
77
//~^ HELP: consider using `flatten` instead
88

9+
#[rustfmt::skip]
10+
let _ = vec![Some(1)].into_iter().flatten();
11+
//~^ HELP: consider using `flatten` instead
12+
913
// Don't lint below
1014
let mut counter = 0;
1115
let _ = vec![Some(1)].into_iter().filter(|o| {
1216
counter += 1;
1317
o.is_some()
1418
});
19+
1520
let _ = vec![Some(1)].into_iter().filter(|o| {
1621
// Roses are red,
1722
// Violets are blue,

tests/ui/iter_filter_is_some.rs

+5
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,17 @@ fn main() {
66
let _ = vec![Some(1)].into_iter().filter(|o| o.is_some());
77
//~^ HELP: consider using `flatten` instead
88

9+
#[rustfmt::skip]
10+
let _ = vec![Some(1)].into_iter().filter(|o| { o.is_some() });
11+
//~^ HELP: consider using `flatten` instead
12+
913
// Don't lint below
1014
let mut counter = 0;
1115
let _ = vec![Some(1)].into_iter().filter(|o| {
1216
counter += 1;
1317
o.is_some()
1418
});
19+
1520
let _ = vec![Some(1)].into_iter().filter(|o| {
1621
// Roses are red,
1722
// Violets are blue,

tests/ui/iter_filter_is_some.stderr

+7-1
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,11 @@ error: `filter` for `is_some` on iterator over `Option`
1313
LL | let _ = vec![Some(1)].into_iter().filter(|o| o.is_some());
1414
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
1515

16-
error: aborting due to 2 previous errors
16+
error: `filter` for `is_some` on iterator over `Option`
17+
--> $DIR/iter_filter_is_some.rs:10:39
18+
|
19+
LL | let _ = vec![Some(1)].into_iter().filter(|o| { o.is_some() });
20+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
21+
22+
error: aborting due to 3 previous errors
1723

0 commit comments

Comments
 (0)