Rename to ambiguous_method_names

Author: sjwang05

CHANGELOG.md

@@ -4776,7 +4776,7 @@ Released 2018-09-13
 [`almost_complete_letter_range`]: https://rust-lang.github.io/rust-clippy/master/index.html#almost_complete_letter_range
 [`almost_complete_range`]: https://rust-lang.github.io/rust-clippy/master/index.html#almost_complete_range
 [`almost_swapped`]: https://rust-lang.github.io/rust-clippy/master/index.html#almost_swapped
-[`ambiguous_method_calls`]: https://rust-lang.github.io/rust-clippy/master/index.html#ambiguous_method_calls
+[`ambiguous_method_names`]: https://rust-lang.github.io/rust-clippy/master/index.html#ambiguous_method_names
 [`approx_constant`]: https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
 [`arc_with_non_send_sync`]: https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
 [`arithmetic_side_effects`]: https://rust-lang.github.io/rust-clippy/master/index.html#arithmetic_side_effects

clippy_lints/src/ambiguous_method_calls.rs renamed to clippy_lints/src/ambiguous_method_names.rs

@@ -67,18 +67,18 @@ declare_clippy_lint! {
     /// Base.ambiguous(); // prints "trait impl"
     /// ```
     #[clippy::version = "1.74.0"]
-    pub AMBIGUOUS_METHOD_CALLS,
+    pub AMBIGUOUS_METHOD_NAMES,
     pedantic,
     "declarations and calls for same-named methods in struct impls and trait impls"
 }
 
 #[derive(Clone)]
-pub struct AmbiguousMethodCalls<'tcx> {
+pub struct AmbiguousMethodNames<'tcx> {
     trait_methods: FxHashMap<(Ty<'tcx>, Symbol), Span>,
     inherent_methods: Vec<(Ty<'tcx>, Symbol, Span)>,
 }
 
-impl<'tcx> AmbiguousMethodCalls<'tcx> {
+impl<'tcx> AmbiguousMethodNames<'tcx> {
     pub fn new() -> Self {
         Self {
             trait_methods: FxHashMap::default(),
@@ -95,9 +95,9 @@ impl<'tcx> AmbiguousMethodCalls<'tcx> {
     }
 }
 
-impl_lint_pass!(AmbiguousMethodCalls<'_> => [AMBIGUOUS_METHOD_CALLS]);
+impl_lint_pass!(AmbiguousMethodNames<'_> => [AMBIGUOUS_METHOD_NAMES]);
 
-impl<'tcx> LateLintPass<'tcx> for AmbiguousMethodCalls<'tcx> {
+impl<'tcx> LateLintPass<'tcx> for AmbiguousMethodNames<'tcx> {
     fn check_fn(
         &mut self,
         cx: &LateContext<'tcx>,
@@ -130,7 +130,7 @@ impl<'tcx> LateLintPass<'tcx> for AmbiguousMethodCalls<'tcx> {
             if let Some(tm_span) = self.trait_methods.get(k) {
                 span_lint_and_note(
                     cx,
-                    AMBIGUOUS_METHOD_CALLS,
+                    AMBIGUOUS_METHOD_NAMES,
                     *span,
                     "ambiguous inherent method name",
                     Some(*tm_span),

clippy_lints/src/declared_lints.rs

@@ -40,7 +40,7 @@ pub(crate) static LINTS: &[&crate::LintInfo] = &[
     crate::absolute_paths::ABSOLUTE_PATHS_INFO,
     crate::allow_attributes::ALLOW_ATTRIBUTES_INFO,
     crate::almost_complete_range::ALMOST_COMPLETE_RANGE_INFO,
-    crate::ambiguous_method_calls::AMBIGUOUS_METHOD_CALLS_INFO,
+    crate::ambiguous_method_names::AMBIGUOUS_METHOD_NAMES_INFO,
     crate::approx_const::APPROX_CONSTANT_INFO,
     crate::arc_with_non_send_sync::ARC_WITH_NON_SEND_SYNC_INFO,
     crate::as_conversions::AS_CONVERSIONS_INFO,

clippy_lints/src/lib.rs

@@ -68,7 +68,7 @@ mod renamed_lints;
 mod absolute_paths;
 mod allow_attributes;
 mod almost_complete_range;
-mod ambiguous_method_calls;
+mod ambiguous_method_names;
 mod approx_const;
 mod arc_with_non_send_sync;
 mod as_conversions;
@@ -1118,7 +1118,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
             msrv(),
         ))
     });
-    store.register_late_pass(|_| Box::new(ambiguous_method_calls::AmbiguousMethodCalls::new()));
+    store.register_late_pass(|_| Box::new(ambiguous_method_names::AmbiguousMethodNames::new()));
     // add lints here, do not remove this comment, it's used in `new_lint`
 }
 

tests/ui/ambiguous_method_calls.stderr

@@ -1,5 +1,5 @@
 #![allow(dead_code)]
-#![warn(clippy::ambiguous_method_calls)]
+#![warn(clippy::ambiguous_method_names)]
 
 fn main() {
     Base.ambiguous();
@@ -14,6 +14,9 @@ fn main() {
     Base.another();
 
     ambiguous();
+
+    S::<u64>(42).f();
+    S::<i32>(-42).f();
 }
 
 fn ambiguous() {}
@@ -66,3 +69,13 @@ impl MyTrait for Other {
         println!("not actually ambiguous either")
     }
 }
+
+struct S<T>(T);
+
+impl S<i32> {
+    fn f(&self) {}
+}
+
+impl S<u64> {
+    fn f(&self) {}
+}

tests/ui/ambiguous_method_calls.rs renamed to tests/ui/ambiguous_method_names.rs

@@ -0,0 +1,40 @@
+error: ambiguous inherent method name
+  --> $DIR/ambiguous_method_names.rs:36:8
+   |
+LL |     fn ambiguous(&self) {
+   |        ^^^^^^^^^
+   |
+note: trait method defined here
+  --> $DIR/ambiguous_method_names.rs:50:8
+   |
+LL |     fn ambiguous(&self) {
+   |        ^^^^^^^^^
+   = note: `-D clippy::ambiguous-method-names` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(clippy::ambiguous_method_names)]`
+
+error: ambiguous inherent method name
+  --> $DIR/ambiguous_method_names.rs:40:8
+   |
+LL |     fn also_ambiguous(&self) {}
+   |        ^^^^^^^^^^^^^^
+   |
+note: trait method defined here
+  --> $DIR/ambiguous_method_names.rs:54:8
+   |
+LL |     fn also_ambiguous(&self) {}
+   |        ^^^^^^^^^^^^^^
+
+error: ambiguous inherent method name
+  --> $DIR/ambiguous_method_names.rs:46:8
+   |
+LL |     fn another(&self) {}
+   |        ^^^^^^^
+   |
+note: trait method defined here
+  --> $DIR/ambiguous_method_names.rs:58:8
+   |
+LL |     fn another(&self) {}
+   |        ^^^^^^^
+
+error: aborting due to 3 previous errors
+