Skip to content

Stop linting assert!(x == y) #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
birkenfeld opened this issue Sep 28, 2017 · 1 comment · Fixed by #2156
Closed

Stop linting assert!(x == y) #2090

birkenfeld opened this issue Sep 28, 2017 · 1 comment · Fixed by #2156
Labels
good-first-issue These issues are a good way to get started with Clippy L-style Lint: Belongs in the style lint group

Comments

@birkenfeld
Copy link
Contributor

While RFC 2011 isn't implemented yet, the earlier we stop telling people to rewrite their asserts, the less they will be pissed once we tell them to change it back :)
@oli-obk oli-obk added L-style Lint: Belongs in the style lint group good-first-issue These issues are a good way to get started with Clippy labels Sep 28, 2017
@thelearnerofcode thelearnerofcode mentioned this issue Sep 29, 2017
Closed
@cgm616 cgm616 mentioned this issue Oct 20, 2017
Merged
@cgm616
Copy link
Contributor

cgm616 commented Oct 20, 2017

I created another pull request to deprecate because @thelearnerofcode seemed to disappear.

@Bobo1239 Bobo1239 mentioned this issue Nov 10, 2017
Merged
@alex-700 alex-700 mentioned this issue Oct 18, 2021
Closed
@jruderman jruderman mentioned this issue Oct 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue These issues are a good way to get started with Clippy L-style Lint: Belongs in the style lint group
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate should_assert_eq lint
Stop linting assert!(x == y)
4 participants
@birkenfeld @oli-obk @Manishearth @cgm616