Skip to content

Make mini-macro use AstBuilder or proc macros #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Manishearth opened this issue Dec 20, 2017 · 1 comment · Fixed by #2284
Closed

Make mini-macro use AstBuilder or proc macros #2283

Manishearth opened this issue Dec 20, 2017 · 1 comment · Fixed by #2284
Assignees
@Manishearth
Labels
good-first-issue These issues are a good way to get started with Clippy

Comments

@Manishearth
Copy link
Member

We use the mini-macro crate to test how lints behave under macros.

It currently uses quasi quoting.

We should switch that to AstBuilder, or change it to a new-type procedural macro. I want to remove quote_*! from libsyntax and this is the only consumer.
rust-lang/rust#46849

(might fix this myself)
@Manishearth Manishearth mentioned this issue Dec 20, 2017
Closed
@Manishearth
Copy link
Member Author

ideally we should just replace it with a single derive macro that triggers a lint

@oli-obk oli-obk added the good-first-issue These issues are a good way to get started with Clippy label Dec 20, 2017
@Manishearth Manishearth mentioned this issue Dec 20, 2017
Merged
@Manishearth Manishearth self-assigned this Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move mini-macro to proc macro rust-lang/rust-clippy
2 participants
@oli-obk @Manishearth