diff --git a/clippy_dev/src/fmt.rs b/clippy_dev/src/fmt.rs
index 111c79c332d0..1517cdc94196 100644
--- a/clippy_dev/src/fmt.rs
+++ b/clippy_dev/src/fmt.rs
@@ -68,7 +68,7 @@ pub fn run(check: bool, verbose: bool) {
continue;
}
- success &= rustfmt(context, &path)?;
+ success &= rustfmt(context, path)?;
}
Ok(success)
diff --git a/clippy_dev/src/lib.rs b/clippy_dev/src/lib.rs
index a5e94683878e..1e5a140e9648 100644
--- a/clippy_dev/src/lib.rs
+++ b/clippy_dev/src/lib.rs
@@ -101,7 +101,7 @@ impl Lint {
#[must_use]
pub fn gen_lint_group_list<'a>(lints: impl Iterator<Item = &'a Lint>) -> Vec<String> {
lints
- .map(|l| format!(" LintId::of(&{}::{}),", l.module, l.name.to_uppercase()))
+ .map(|l| format!(" LintId::of({}::{}),", l.module, l.name.to_uppercase()))
.sorted()
.collect::<Vec<String>>()
}
@@ -154,17 +154,17 @@ pub fn gen_register_lint_list<'a>(
let header = " store.register_lints(&[".to_string();
let footer = " ]);".to_string();
let internal_lints = internal_lints
- .sorted_by_key(|l| format!(" &{}::{},", l.module, l.name.to_uppercase()))
+ .sorted_by_key(|l| format!(" {}::{},", l.module, l.name.to_uppercase()))
.map(|l| {
format!(
- " #[cfg(feature = \"internal-lints\")]\n &{}::{},",
+ " #[cfg(feature = \"internal-lints\")]\n {}::{},",
l.module,
l.name.to_uppercase()
)
});
let other_lints = usable_lints
- .sorted_by_key(|l| format!(" &{}::{},", l.module, l.name.to_uppercase()))
- .map(|l| format!(" &{}::{},", l.module, l.name.to_uppercase()))
+ .sorted_by_key(|l| format!(" {}::{},", l.module, l.name.to_uppercase()))
+ .map(|l| format!(" {}::{},", l.module, l.name.to_uppercase()))
.sorted();
let mut lint_list = vec![header];
lint_list.extend(internal_lints);
@@ -550,9 +550,9 @@ fn test_gen_lint_group_list() {
Lint::new("internal", "internal_style", "abc", None, "module_name"),
];
let expected = vec![
- " LintId::of(&module_name::ABC),".to_string(),
- " LintId::of(&module_name::INTERNAL),".to_string(),
- " LintId::of(&module_name::SHOULD_ASSERT_EQ),".to_string(),
+ " LintId::of(module_name::ABC),".to_string(),
+ " LintId::of(module_name::INTERNAL),".to_string(),
+ " LintId::of(module_name::SHOULD_ASSERT_EQ),".to_string(),
];
assert_eq!(expected, gen_lint_group_list(lints.iter()));
}
diff --git a/clippy_lints/src/absurd_extreme_comparisons.rs b/clippy_lints/src/absurd_extreme_comparisons.rs
index 33c720c666e4..5fbf4bdbd187 100644
--- a/clippy_lints/src/absurd_extreme_comparisons.rs
+++ b/clippy_lints/src/absurd_extreme_comparisons.rs
@@ -44,7 +44,7 @@ declare_lint_pass!(AbsurdExtremeComparisons => [ABSURD_EXTREME_COMPARISONS]);
impl<'tcx> LateLintPass<'tcx> for AbsurdExtremeComparisons {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::Binary(ref cmp, ref lhs, ref rhs) = expr.kind {
+ if let ExprKind::Binary(ref cmp, lhs, rhs) = expr.kind {
if let Some((culprit, result)) = detect_absurd_comparison(cx, cmp.node, lhs, rhs) {
if !expr.span.from_expansion() {
let msg = "this comparison involving the minimum or maximum element for this \
@@ -95,7 +95,7 @@ enum AbsurdComparisonResult {
}
fn is_cast_between_fixed_and_target<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) -> bool {
- if let ExprKind::Cast(ref cast_exp, _) = expr.kind {
+ if let ExprKind::Cast(cast_exp, _) = expr.kind {
let precast_ty = cx.typeck_results().expr_ty(cast_exp);
let cast_ty = cx.typeck_results().expr_ty(expr);
diff --git a/clippy_lints/src/assertions_on_constants.rs b/clippy_lints/src/assertions_on_constants.rs
index 16905781c56b..a0993bb6913e 100644
--- a/clippy_lints/src/assertions_on_constants.rs
+++ b/clippy_lints/src/assertions_on_constants.rs
@@ -71,7 +71,7 @@ impl<'tcx> LateLintPass<'tcx> for AssertionsOnConstants {
return;
}
if_chain! {
- if let ExprKind::Unary(_, ref lit) = e.kind;
+ if let ExprKind::Unary(_, lit) = e.kind;
if let Some((Constant::Bool(is_true), _)) = constant(cx, cx.typeck_results(), lit);
if is_true;
then {
@@ -82,7 +82,7 @@ impl<'tcx> LateLintPass<'tcx> for AssertionsOnConstants {
if assert_span.from_expansion() {
return;
}
- if let Some(assert_match) = match_assert_with_message(&cx, e) {
+ if let Some(assert_match) = match_assert_with_message(cx, e) {
match assert_match {
// matched assert but not message
AssertKind::WithoutMessage(false) => lint_false_without_message(),
@@ -113,17 +113,17 @@ enum AssertKind {
/// where `message` is any expression and `c` is a constant bool.
fn match_assert_with_message<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) -> Option<AssertKind> {
if_chain! {
- if let ExprKind::If(ref cond, ref then, _) = expr.kind;
- if let ExprKind::Unary(UnOp::Not, ref expr) = cond.kind;
+ if let ExprKind::If(cond, then, _) = expr.kind;
+ if let ExprKind::Unary(UnOp::Not, expr) = cond.kind;
// bind the first argument of the `assert!` macro
if let Some((Constant::Bool(is_true), _)) = constant(cx, cx.typeck_results(), expr);
// block
- if let ExprKind::Block(ref block, _) = then.kind;
+ if let ExprKind::Block(block, _) = then.kind;
if block.stmts.is_empty();
if let Some(block_expr) = &block.expr;
// inner block is optional. unwrap it if it exists, or use the expression as is otherwise.
if let Some(begin_panic_call) = match block_expr.kind {
- ExprKind::Block(ref inner_block, _) => &inner_block.expr,
+ ExprKind::Block(inner_block, _) => &inner_block.expr,
_ => &block.expr,
};
// function call
diff --git a/clippy_lints/src/atomic_ordering.rs b/clippy_lints/src/atomic_ordering.rs
index dfb181993256..7ceb01f5590f 100644
--- a/clippy_lints/src/atomic_ordering.rs
+++ b/clippy_lints/src/atomic_ordering.rs
@@ -85,7 +85,7 @@ fn match_ordering_def_path(cx: &LateContext<'_>, did: DefId, orderings: &[&str])
fn check_atomic_load_store(cx: &LateContext<'_>, expr: &Expr<'_>) {
if_chain! {
- if let ExprKind::MethodCall(ref method_path, _, args, _) = &expr.kind;
+ if let ExprKind::MethodCall(method_path, _, args, _) = &expr.kind;
let method = method_path.ident.name.as_str();
if type_is_atomic(cx, &args[0]);
if method == "load" || method == "store";
@@ -120,7 +120,7 @@ fn check_atomic_load_store(cx: &LateContext<'_>, expr: &Expr<'_>) {
fn check_memory_fence(cx: &LateContext<'_>, expr: &Expr<'_>) {
if_chain! {
- if let ExprKind::Call(ref func, ref args) = expr.kind;
+ if let ExprKind::Call(func, args) = expr.kind;
if let ExprKind::Path(ref func_qpath) = func.kind;
if let Some(def_id) = cx.qpath_res(func_qpath, func.hir_id).opt_def_id();
if ["fence", "compiler_fence"]
@@ -152,7 +152,7 @@ fn opt_ordering_defid(cx: &LateContext<'_>, ord_arg: &Expr<'_>) -> Option<DefId>
fn check_atomic_compare_exchange(cx: &LateContext<'_>, expr: &Expr<'_>) {
if_chain! {
- if let ExprKind::MethodCall(ref method_path, _, args, _) = &expr.kind;
+ if let ExprKind::MethodCall(method_path, _, args, _) = &expr.kind;
let method = method_path.ident.name.as_str();
if type_is_atomic(cx, &args[0]);
if method == "compare_exchange" || method == "compare_exchange_weak" || method == "fetch_update";
diff --git a/clippy_lints/src/attrs.rs b/clippy_lints/src/attrs.rs
index 0ce46e1c2145..382fb03d9200 100644
--- a/clippy_lints/src/attrs.rs
+++ b/clippy_lints/src/attrs.rs
@@ -602,7 +602,7 @@ fn check_mismatched_target_os(cx: &EarlyContext<'_>, attr: &Attribute) {
if let NestedMetaItem::MetaItem(meta) = item {
match &meta.kind {
MetaItemKind::List(list) => {
- mismatched.extend(find_mismatched_target_os(&list));
+ mismatched.extend(find_mismatched_target_os(list));
},
MetaItemKind::Word => {
if_chain! {
@@ -629,7 +629,7 @@ fn check_mismatched_target_os(cx: &EarlyContext<'_>, attr: &Attribute) {
then {
let mess = "operating system used in target family position";
- span_lint_and_then(cx, MISMATCHED_TARGET_OS, attr.span, &mess, |diag| {
+ span_lint_and_then(cx, MISMATCHED_TARGET_OS, attr.span, mess, |diag| {
// Avoid showing the unix suggestion multiple times in case
// we have more than one mismatch for unix-like systems
let mut unix_suggested = false;
diff --git a/clippy_lints/src/await_holding_invalid.rs b/clippy_lints/src/await_holding_invalid.rs
index 68eee0520b38..1739a57a240b 100644
--- a/clippy_lints/src/await_holding_invalid.rs
+++ b/clippy_lints/src/await_holding_invalid.rs
@@ -101,7 +101,7 @@ impl LateLintPass<'_> for AwaitHolding {
let typeck_results = cx.tcx.typeck_body(body_id);
check_interior_types(
cx,
- &typeck_results.generator_interior_types.as_ref().skip_binder(),
+ typeck_results.generator_interior_types.as_ref().skip_binder(),
body.value.span,
);
}
diff --git a/clippy_lints/src/bytecount.rs b/clippy_lints/src/bytecount.rs
index 1546d8231672..877ae002d36e 100644
--- a/clippy_lints/src/bytecount.rs
+++ b/clippy_lints/src/bytecount.rs
@@ -38,17 +38,17 @@ declare_lint_pass!(ByteCount => [NAIVE_BYTECOUNT]);
impl<'tcx> LateLintPass<'tcx> for ByteCount {
fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
if_chain! {
- if let ExprKind::MethodCall(ref count, _, ref count_args, _) = expr.kind;
+ if let ExprKind::MethodCall(count, _, count_args, _) = expr.kind;
if count.ident.name == sym!(count);
if count_args.len() == 1;
- if let ExprKind::MethodCall(ref filter, _, ref filter_args, _) = count_args[0].kind;
+ if let ExprKind::MethodCall(filter, _, filter_args, _) = count_args[0].kind;
if filter.ident.name == sym!(filter);
if filter_args.len() == 2;
if let ExprKind::Closure(_, _, body_id, _, _) = filter_args[1].kind;
let body = cx.tcx.hir().body(body_id);
if body.params.len() == 1;
- if let Some(argname) = get_pat_name(&body.params[0].pat);
- if let ExprKind::Binary(ref op, ref l, ref r) = body.value.kind;
+ if let Some(argname) = get_pat_name(body.params[0].pat);
+ if let ExprKind::Binary(ref op, l, r) = body.value.kind;
if op.node == BinOpKind::Eq;
if match_type(cx,
cx.typeck_results().expr_ty(&filter_args[0]).peel_refs(),
@@ -64,7 +64,7 @@ impl<'tcx> LateLintPass<'tcx> for ByteCount {
if ty::Uint(UintTy::U8) != *cx.typeck_results().expr_ty(needle).peel_refs().kind() {
return;
}
- let haystack = if let ExprKind::MethodCall(ref path, _, ref args, _) =
+ let haystack = if let ExprKind::MethodCall(path, _, args, _) =
filter_args[0].kind {
let p = path.ident.name;
if (p == sym::iter || p == sym!(iter_mut)) && args.len() == 1 {
@@ -98,10 +98,10 @@ fn check_arg(name: Symbol, arg: Symbol, needle: &Expr<'_>) -> bool {
fn get_path_name(expr: &Expr<'_>) -> Option<Symbol> {
match expr.kind {
- ExprKind::Box(ref e) | ExprKind::AddrOf(BorrowKind::Ref, _, ref e) | ExprKind::Unary(UnOp::Deref, ref e) => {
+ ExprKind::Box(e) | ExprKind::AddrOf(BorrowKind::Ref, _, e) | ExprKind::Unary(UnOp::Deref, e) => {
get_path_name(e)
},
- ExprKind::Block(ref b, _) => {
+ ExprKind::Block(b, _) => {
if b.stmts.is_empty() {
b.expr.as_ref().and_then(|p| get_path_name(p))
} else {
diff --git a/clippy_lints/src/casts/cast_ptr_alignment.rs b/clippy_lints/src/casts/cast_ptr_alignment.rs
index 5208156ffd2f..62a119d662bb 100644
--- a/clippy_lints/src/casts/cast_ptr_alignment.rs
+++ b/clippy_lints/src/casts/cast_ptr_alignment.rs
@@ -10,7 +10,7 @@ use rustc_target::abi::LayoutOf;
use super::CAST_PTR_ALIGNMENT;
pub(super) fn check(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::Cast(ref cast_expr, cast_to) = expr.kind {
+ if let ExprKind::Cast(cast_expr, cast_to) = expr.kind {
if is_hir_ty_cfg_dependant(cx, cast_to) {
return;
}
diff --git a/clippy_lints/src/casts/cast_sign_loss.rs b/clippy_lints/src/casts/cast_sign_loss.rs
index bf722d0a3f49..040e0ca88645 100644
--- a/clippy_lints/src/casts/cast_sign_loss.rs
+++ b/clippy_lints/src/casts/cast_sign_loss.rs
@@ -30,7 +30,7 @@ fn should_lint(cx: &LateContext<'_>, cast_op: &Expr<'_>, cast_from: Ty<'_>, cast
}
// Don't lint for positive constants.
- let const_val = constant(cx, &cx.typeck_results(), cast_op);
+ let const_val = constant(cx, cx.typeck_results(), cast_op);
if_chain! {
if let Some((Constant::Int(n), _)) = const_val;
if let ty::Int(ity) = *cast_from.kind();
@@ -41,14 +41,14 @@ fn should_lint(cx: &LateContext<'_>, cast_op: &Expr<'_>, cast_from: Ty<'_>, cast
}
// Don't lint for the result of methods that always return non-negative values.
- if let ExprKind::MethodCall(ref path, _, _, _) = cast_op.kind {
+ if let ExprKind::MethodCall(path, _, _, _) = cast_op.kind {
let mut method_name = path.ident.name.as_str();
let allowed_methods = ["abs", "checked_abs", "rem_euclid", "checked_rem_euclid"];
if_chain! {
if method_name == "unwrap";
if let Some(arglist) = method_chain_args(cast_op, &["unwrap"]);
- if let ExprKind::MethodCall(ref inner_path, _, _, _) = &arglist[0][0].kind;
+ if let ExprKind::MethodCall(inner_path, _, _, _) = &arglist[0][0].kind;
then {
method_name = inner_path.ident.name.as_str();
}
diff --git a/clippy_lints/src/casts/mod.rs b/clippy_lints/src/casts/mod.rs
index d9e172c01a70..ae4fdd12c41e 100644
--- a/clippy_lints/src/casts/mod.rs
+++ b/clippy_lints/src/casts/mod.rs
@@ -372,7 +372,7 @@ impl<'tcx> LateLintPass<'tcx> for Casts {
return;
}
- if let ExprKind::Cast(ref cast_expr, cast_to) = expr.kind {
+ if let ExprKind::Cast(cast_expr, cast_to) = expr.kind {
if is_hir_ty_cfg_dependant(cx, cast_to) {
return;
}
diff --git a/clippy_lints/src/checked_conversions.rs b/clippy_lints/src/checked_conversions.rs
index b38c70bcc413..d7136f84cc3a 100644
--- a/clippy_lints/src/checked_conversions.rs
+++ b/clippy_lints/src/checked_conversions.rs
@@ -64,7 +64,7 @@ impl<'tcx> LateLintPass<'tcx> for CheckedConversions {
let result = if_chain! {
if !in_external_macro(cx.sess(), item.span);
- if let ExprKind::Binary(op, ref left, ref right) = &item.kind;
+ if let ExprKind::Binary(op, left, right) = &item.kind;
then {
match op.node {
@@ -200,7 +200,7 @@ impl ConversionType {
/// Check for `expr <= (to_type::MAX as from_type)`
fn check_upper_bound<'tcx>(expr: &'tcx Expr<'tcx>) -> Option<Conversion<'tcx>> {
if_chain! {
- if let ExprKind::Binary(ref op, ref left, ref right) = &expr.kind;
+ if let ExprKind::Binary(ref op, left, right) = &expr.kind;
if let Some((candidate, check)) = normalize_le_ge(op, left, right);
if let Some((from, to)) = get_types_from_cast(check, INTS, "max_value", "MAX");
@@ -219,7 +219,7 @@ fn check_lower_bound<'tcx>(expr: &'tcx Expr<'tcx>) -> Option<Conversion<'tcx>> {
}
// First of we need a binary containing the expression & the cast
- if let ExprKind::Binary(ref op, ref left, ref right) = &expr.kind {
+ if let ExprKind::Binary(ref op, left, right) = &expr.kind {
normalize_le_ge(op, right, left).and_then(|(l, r)| check_function(l, r))
} else {
None
@@ -260,7 +260,7 @@ fn get_types_from_cast<'a>(
// or `to_type::MAX as from_type`
let call_from_cast: Option<(&Expr<'_>, &str)> = if_chain! {
// to_type::max_value(), from_type
- if let ExprKind::Cast(ref limit, ref from_type) = &expr.kind;
+ if let ExprKind::Cast(limit, from_type) = &expr.kind;
if let TyKind::Path(ref from_type_path) = &from_type.kind;
if let Some(from_sym) = int_ty_to_sym(from_type_path);
@@ -275,7 +275,7 @@ fn get_types_from_cast<'a>(
let limit_from: Option<(&Expr<'_>, &str)> = call_from_cast.or_else(|| {
if_chain! {
// `from_type::from, to_type::max_value()`
- if let ExprKind::Call(ref from_func, ref args) = &expr.kind;
+ if let ExprKind::Call(from_func, args) = &expr.kind;
// `to_type::max_value()`
if args.len() == 1;
if let limit = &args[0];
@@ -317,9 +317,9 @@ fn get_types_from_cast<'a>(
/// Gets the type which implements the called function
fn get_implementing_type<'a>(path: &QPath<'_>, candidates: &'a [&str], function: &str) -> Option<&'a str> {
if_chain! {
- if let QPath::TypeRelative(ref ty, ref path) = &path;
+ if let QPath::TypeRelative(ty, path) = &path;
if path.ident.name.as_str() == function;
- if let TyKind::Path(QPath::Resolved(None, ref tp)) = &ty.kind;
+ if let TyKind::Path(QPath::Resolved(None, tp)) = &ty.kind;
if let [int] = &*tp.segments;
then {
let name = &int.ident.name.as_str();
@@ -333,7 +333,7 @@ fn get_implementing_type<'a>(path: &QPath<'_>, candidates: &'a [&str], function:
/// Gets the type as a string, if it is a supported integer
fn int_ty_to_sym<'tcx>(path: &QPath<'_>) -> Option<&'tcx str> {
if_chain! {
- if let QPath::Resolved(_, ref path) = *path;
+ if let QPath::Resolved(_, path) = *path;
if let [ty] = &*path.segments;
then {
let name = &ty.ident.name.as_str();
diff --git a/clippy_lints/src/cognitive_complexity.rs b/clippy_lints/src/cognitive_complexity.rs
index 4cc542f723cc..f62c6a9c3251 100644
--- a/clippy_lints/src/cognitive_complexity.rs
+++ b/clippy_lints/src/cognitive_complexity.rs
@@ -152,7 +152,7 @@ impl<'tcx> Visitor<'tcx> for CcHelper {
ExprKind::If(_, _, _) => {
self.cc += 1;
},
- ExprKind::Match(_, ref arms, _) => {
+ ExprKind::Match(_, arms, _) => {
if arms.len() > 1 {
self.cc += 1;
}
diff --git a/clippy_lints/src/comparison_chain.rs b/clippy_lints/src/comparison_chain.rs
index d601cb7c2247..31ae63b51849 100644
--- a/clippy_lints/src/comparison_chain.rs
+++ b/clippy_lints/src/comparison_chain.rs
@@ -71,10 +71,8 @@ impl<'tcx> LateLintPass<'tcx> for ComparisonChain {
}
for cond in conds.windows(2) {
- if let (
- &ExprKind::Binary(ref kind1, ref lhs1, ref rhs1),
- &ExprKind::Binary(ref kind2, ref lhs2, ref rhs2),
- ) = (&cond[0].kind, &cond[1].kind)
+ if let (&ExprKind::Binary(ref kind1, lhs1, rhs1), &ExprKind::Binary(ref kind2, lhs2, rhs2)) =
+ (&cond[0].kind, &cond[1].kind)
{
if !kind_is_cmp(kind1.node) || !kind_is_cmp(kind2.node) {
return;
diff --git a/clippy_lints/src/copies.rs b/clippy_lints/src/copies.rs
index 1b982221b065..8b503c9a0306 100644
--- a/clippy_lints/src/copies.rs
+++ b/clippy_lints/src/copies.rs
@@ -160,7 +160,7 @@ impl<'tcx> LateLintPass<'tcx> for CopyAndPaste {
if let ExprKind::If(_, _, _) = expr.kind {
// skip ifs directly in else, it will be checked in the parent if
if let Some(&Expr {
- kind: ExprKind::If(_, _, Some(ref else_expr)),
+ kind: ExprKind::If(_, _, Some(else_expr)),
..
}) = get_parent_expr(cx, expr)
{
@@ -247,7 +247,7 @@ fn lint_same_then_else<'tcx>(
for value in &end_walker.uses {
// Well we can't move this and all prev statements. So reset
- if block_defs.contains(&value) {
+ if block_defs.contains(value) {
moved_start = Some(index + 1);
end_walker.defs.drain().for_each(|x| {
block_defs.insert(x);
@@ -555,7 +555,7 @@ impl<'a, 'tcx> Visitor<'tcx> for UsedValueFinderVisitor<'a, 'tcx> {
}
fn visit_qpath(&mut self, qpath: &'tcx rustc_hir::QPath<'tcx>, id: HirId, _span: rustc_span::Span) {
- if let rustc_hir::QPath::Resolved(_, ref path) = *qpath {
+ if let rustc_hir::QPath::Resolved(_, path) = *qpath {
if path.segments.len() == 1 {
if let rustc_hir::def::Res::Local(var) = self.cx.qpath_res(qpath, id) {
self.uses.insert(var);
diff --git a/clippy_lints/src/create_dir.rs b/clippy_lints/src/create_dir.rs
index ac890c90c97c..7b5cce6462a4 100644
--- a/clippy_lints/src/create_dir.rs
+++ b/clippy_lints/src/create_dir.rs
@@ -33,7 +33,7 @@ declare_lint_pass!(CreateDir => [CREATE_DIR]);
impl LateLintPass<'_> for CreateDir {
fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
if_chain! {
- if let ExprKind::Call(ref func, ref args) = expr.kind;
+ if let ExprKind::Call(func, args) = expr.kind;
if let ExprKind::Path(ref path) = func.kind;
if let Some(def_id) = cx.qpath_res(path, func.hir_id).opt_def_id();
if match_def_path(cx, def_id, &paths::STD_FS_CREATE_DIR);
diff --git a/clippy_lints/src/default.rs b/clippy_lints/src/default.rs
index 8a2146d93e86..710da8fe9e03 100644
--- a/clippy_lints/src/default.rs
+++ b/clippy_lints/src/default.rs
@@ -77,7 +77,7 @@ impl LateLintPass<'_> for Default {
if_chain! {
// Avoid cases already linted by `field_reassign_with_default`
if !self.reassigned_linted.contains(&expr.span);
- if let ExprKind::Call(ref path, ..) = expr.kind;
+ if let ExprKind::Call(path, ..) = expr.kind;
if !any_parent_is_automatically_derived(cx.tcx, expr.hir_id);
if let ExprKind::Path(ref qpath) = path.kind;
if let Some(def_id) = cx.qpath_res(qpath, path.hir_id).opt_def_id();
@@ -246,7 +246,7 @@ impl LateLintPass<'_> for Default {
/// Checks if the given expression is the `default` method belonging to the `Default` trait.
fn is_expr_default<'tcx>(expr: &'tcx Expr<'tcx>, cx: &LateContext<'tcx>) -> bool {
if_chain! {
- if let ExprKind::Call(ref fn_expr, _) = &expr.kind;
+ if let ExprKind::Call(fn_expr, _) = &expr.kind;
if let ExprKind::Path(qpath) = &fn_expr.kind;
if let Res::Def(_, def_id) = cx.qpath_res(qpath, fn_expr.hir_id);
then {
@@ -262,11 +262,11 @@ fn is_expr_default<'tcx>(expr: &'tcx Expr<'tcx>, cx: &LateContext<'tcx>) -> bool
fn field_reassigned_by_stmt<'tcx>(this: &Stmt<'tcx>, binding_name: Symbol) -> Option<(Ident, &'tcx Expr<'tcx>)> {
if_chain! {
// only take assignments
- if let StmtKind::Semi(ref later_expr) = this.kind;
- if let ExprKind::Assign(ref assign_lhs, ref assign_rhs, _) = later_expr.kind;
+ if let StmtKind::Semi(later_expr) = this.kind;
+ if let ExprKind::Assign(assign_lhs, assign_rhs, _) = later_expr.kind;
// only take assignments to fields where the left-hand side field is a field of
// the same binding as the previous statement
- if let ExprKind::Field(ref binding, field_ident) = assign_lhs.kind;
+ if let ExprKind::Field(binding, field_ident) = assign_lhs.kind;
if let ExprKind::Path(QPath::Resolved(_, path)) = binding.kind;
if let Some(second_binding_name) = path.segments.last();
if second_binding_name.ident.name == binding_name;
diff --git a/clippy_lints/src/derive.rs b/clippy_lints/src/derive.rs
index 9fad85f8ef43..647af3bdc04d 100644
--- a/clippy_lints/src/derive.rs
+++ b/clippy_lints/src/derive.rs
@@ -199,7 +199,7 @@ fn check_hash_peq<'tcx>(
then {
// Look for the PartialEq implementations for `ty`
cx.tcx.for_each_relevant_impl(peq_trait_def_id, ty, |impl_id| {
- let peq_is_automatically_derived = is_automatically_derived(&cx.tcx.get_attrs(impl_id));
+ let peq_is_automatically_derived = is_automatically_derived(cx.tcx.get_attrs(impl_id));
if peq_is_automatically_derived == hash_is_automatically_derived {
return;
@@ -253,7 +253,7 @@ fn check_ord_partial_ord<'tcx>(
then {
// Look for the PartialOrd implementations for `ty`
cx.tcx.for_each_relevant_impl(partial_ord_trait_def_id, ty, |impl_id| {
- let partial_ord_is_automatically_derived = is_automatically_derived(&cx.tcx.get_attrs(impl_id));
+ let partial_ord_is_automatically_derived = is_automatically_derived(cx.tcx.get_attrs(impl_id));
if partial_ord_is_automatically_derived == ord_is_automatically_derived {
return;
diff --git a/clippy_lints/src/doc.rs b/clippy_lints/src/doc.rs
index b5796ccf43fd..fb53b55ebd6a 100644
--- a/clippy_lints/src/doc.rs
+++ b/clippy_lints/src/doc.rs
@@ -710,8 +710,8 @@ impl<'a, 'tcx> Visitor<'tcx> for FindPanicUnwrap<'a, 'tcx> {
// check for `begin_panic`
if_chain! {
- if let ExprKind::Call(ref func_expr, _) = expr.kind;
- if let ExprKind::Path(QPath::Resolved(_, ref path)) = func_expr.kind;
+ if let ExprKind::Call(func_expr, _) = expr.kind;
+ if let ExprKind::Path(QPath::Resolved(_, path)) = func_expr.kind;
if let Some(path_def_id) = path.res.opt_def_id();
if match_panic_def_id(self.cx, path_def_id);
if is_expn_of(expr.span, "unreachable").is_none();
diff --git a/clippy_lints/src/double_comparison.rs b/clippy_lints/src/double_comparison.rs
index 1d291565ec19..58543ae6e4e3 100644
--- a/clippy_lints/src/double_comparison.rs
+++ b/clippy_lints/src/double_comparison.rs
@@ -47,7 +47,7 @@ impl<'tcx> DoubleComparisons {
},
_ => return,
};
- if !(eq_expr_value(cx, &llhs, &rlhs) && eq_expr_value(cx, &lrhs, &rrhs)) {
+ if !(eq_expr_value(cx, llhs, rlhs) && eq_expr_value(cx, lrhs, rrhs)) {
return;
}
macro_rules! lint_double_comparison {
@@ -88,7 +88,7 @@ impl<'tcx> DoubleComparisons {
impl<'tcx> LateLintPass<'tcx> for DoubleComparisons {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::Binary(ref kind, ref lhs, ref rhs) = expr.kind {
+ if let ExprKind::Binary(ref kind, lhs, rhs) = expr.kind {
Self::check_binop(cx, kind.node, lhs, rhs, expr.span);
}
}
diff --git a/clippy_lints/src/double_parens.rs b/clippy_lints/src/double_parens.rs
index 5afdcb3c09f5..e4e4a93b011f 100644
--- a/clippy_lints/src/double_parens.rs
+++ b/clippy_lints/src/double_parens.rs
@@ -50,7 +50,7 @@ impl EarlyLintPass for DoubleParens {
match expr.kind {
ExprKind::Paren(ref in_paren) => match in_paren.kind {
ExprKind::Paren(_) | ExprKind::Tup(_) => {
- span_lint(cx, DOUBLE_PARENS, expr.span, &msg);
+ span_lint(cx, DOUBLE_PARENS, expr.span, msg);
},
_ => {},
},
@@ -58,7 +58,7 @@ impl EarlyLintPass for DoubleParens {
if params.len() == 1 {
let param = ¶ms[0];
if let ExprKind::Paren(_) = param.kind {
- span_lint(cx, DOUBLE_PARENS, param.span, &msg);
+ span_lint(cx, DOUBLE_PARENS, param.span, msg);
}
}
},
@@ -66,7 +66,7 @@ impl EarlyLintPass for DoubleParens {
if params.len() == 2 {
let param = ¶ms[1];
if let ExprKind::Paren(_) = param.kind {
- span_lint(cx, DOUBLE_PARENS, param.span, &msg);
+ span_lint(cx, DOUBLE_PARENS, param.span, msg);
}
}
},
diff --git a/clippy_lints/src/drop_forget_ref.rs b/clippy_lints/src/drop_forget_ref.rs
index 7e7ec017bbbc..b5b29760636b 100644
--- a/clippy_lints/src/drop_forget_ref.rs
+++ b/clippy_lints/src/drop_forget_ref.rs
@@ -113,7 +113,7 @@ declare_lint_pass!(DropForgetRef => [DROP_REF, FORGET_REF, DROP_COPY, FORGET_COP
impl<'tcx> LateLintPass<'tcx> for DropForgetRef {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
if_chain! {
- if let ExprKind::Call(ref path, ref args) = expr.kind;
+ if let ExprKind::Call(path, args) = expr.kind;
if let ExprKind::Path(ref qpath) = path.kind;
if args.len() == 1;
if let Some(def_id) = cx.qpath_res(qpath, path.hir_id).opt_def_id();
diff --git a/clippy_lints/src/duration_subsec.rs b/clippy_lints/src/duration_subsec.rs
index 746c1f6df916..529807770f3c 100644
--- a/clippy_lints/src/duration_subsec.rs
+++ b/clippy_lints/src/duration_subsec.rs
@@ -43,8 +43,8 @@ declare_lint_pass!(DurationSubsec => [DURATION_SUBSEC]);
impl<'tcx> LateLintPass<'tcx> for DurationSubsec {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
if_chain! {
- if let ExprKind::Binary(Spanned { node: BinOpKind::Div, .. }, ref left, ref right) = expr.kind;
- if let ExprKind::MethodCall(ref method_path, _ , ref args, _) = left.kind;
+ if let ExprKind::Binary(Spanned { node: BinOpKind::Div, .. }, left, right) = expr.kind;
+ if let ExprKind::MethodCall(method_path, _ , args, _) = left.kind;
if match_type(cx, cx.typeck_results().expr_ty(&args[0]).peel_refs(), &paths::DURATION);
if let Some((Constant::Int(divisor), _)) = constant(cx, cx.typeck_results(), right);
then {
diff --git a/clippy_lints/src/entry.rs b/clippy_lints/src/entry.rs
index 25eb048448ca..a815df1691a1 100644
--- a/clippy_lints/src/entry.rs
+++ b/clippy_lints/src/entry.rs
@@ -57,14 +57,14 @@ declare_lint_pass!(HashMapPass => [MAP_ENTRY]);
impl<'tcx> LateLintPass<'tcx> for HashMapPass {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::If(ref check, ref then_block, ref else_block) = expr.kind {
- if let ExprKind::Unary(UnOp::Not, ref check) = check.kind {
+ if let ExprKind::If(check, then_block, ref else_block) = expr.kind {
+ if let ExprKind::Unary(UnOp::Not, check) = check.kind {
if let Some((ty, map, key)) = check_cond(cx, check) {
// in case of `if !m.contains_key(&k) { m.insert(k, v); }`
// we can give a better error message
let sole_expr = {
else_block.is_none()
- && if let ExprKind::Block(ref then_block, _) = then_block.kind {
+ && if let ExprKind::Block(then_block, _) = then_block.kind {
(then_block.expr.is_some() as usize) + then_block.stmts.len() == 1
} else {
true
@@ -81,9 +81,9 @@ impl<'tcx> LateLintPass<'tcx> for HashMapPass {
sole_expr,
};
- walk_expr(&mut visitor, &**then_block);
+ walk_expr(&mut visitor, then_block);
}
- } else if let Some(ref else_block) = *else_block {
+ } else if let Some(else_block) = *else_block {
if let Some((ty, map, key)) = check_cond(cx, check) {
let mut visitor = InsertVisitor {
cx,
@@ -103,10 +103,10 @@ impl<'tcx> LateLintPass<'tcx> for HashMapPass {
fn check_cond<'a>(cx: &LateContext<'_>, check: &'a Expr<'a>) -> Option<(&'static str, &'a Expr<'a>, &'a Expr<'a>)> {
if_chain! {
- if let ExprKind::MethodCall(ref path, _, ref params, _) = check.kind;
+ if let ExprKind::MethodCall(path, _, params, _) = check.kind;
if params.len() >= 2;
if path.ident.name == sym!(contains_key);
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref key) = params[1].kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, key) = params[1].kind;
then {
let map = ¶ms[0];
let obj_ty = cx.typeck_results().expr_ty(map).peel_refs();
@@ -140,7 +140,7 @@ impl<'a, 'tcx, 'b> Visitor<'tcx> for InsertVisitor<'a, 'tcx, 'b> {
fn visit_expr(&mut self, expr: &'tcx Expr<'_>) {
if_chain! {
- if let ExprKind::MethodCall(ref path, _, ref params, _) = expr.kind;
+ if let ExprKind::MethodCall(path, _, params, _) = expr.kind;
if params.len() == 3;
if path.ident.name == sym!(insert);
if get_item_name(self.cx, self.map) == get_item_name(self.cx, ¶ms[0]);
diff --git a/clippy_lints/src/eq_op.rs b/clippy_lints/src/eq_op.rs
index 6d7046ac8b7b..90f391b5f5c8 100644
--- a/clippy_lints/src/eq_op.rs
+++ b/clippy_lints/src/eq_op.rs
@@ -65,12 +65,12 @@ const ASSERT_MACRO_NAMES: [&str; 4] = ["assert_eq", "assert_ne", "debug_assert_e
impl<'tcx> LateLintPass<'tcx> for EqOp {
#[allow(clippy::similar_names, clippy::too_many_lines)]
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
- if let ExprKind::Block(ref block, _) = e.kind {
+ if let ExprKind::Block(block, _) = e.kind {
for stmt in block.stmts {
for amn in &ASSERT_MACRO_NAMES {
if_chain! {
if is_expn_of(stmt.span, amn).is_some();
- if let StmtKind::Semi(ref matchexpr) = stmt.kind;
+ if let StmtKind::Semi(matchexpr) = stmt.kind;
if let Some(macro_args) = higher::extract_assert_macro_args(matchexpr);
if macro_args.len() == 2;
let (lhs, rhs) = (macro_args[0], macro_args[1]);
@@ -88,12 +88,12 @@ impl<'tcx> LateLintPass<'tcx> for EqOp {
}
}
}
- if let ExprKind::Binary(op, ref left, ref right) = e.kind {
+ if let ExprKind::Binary(op, left, right) = e.kind {
if e.span.from_expansion() {
return;
}
let macro_with_not_op = |expr_kind: &ExprKind<'_>| {
- if let ExprKind::Unary(_, ref expr) = *expr_kind {
+ if let ExprKind::Unary(_, expr) = *expr_kind {
in_macro(expr.span)
} else {
false
@@ -135,7 +135,7 @@ impl<'tcx> LateLintPass<'tcx> for EqOp {
// do not suggest to dereference literals
(&ExprKind::Lit(..), _) | (_, &ExprKind::Lit(..)) => {},
// &foo == &bar
- (&ExprKind::AddrOf(BorrowKind::Ref, _, ref l), &ExprKind::AddrOf(BorrowKind::Ref, _, ref r)) => {
+ (&ExprKind::AddrOf(BorrowKind::Ref, _, l), &ExprKind::AddrOf(BorrowKind::Ref, _, r)) => {
let lty = cx.typeck_results().expr_ty(l);
let rty = cx.typeck_results().expr_ty(r);
let lcpy = is_copy(cx, lty);
@@ -198,7 +198,7 @@ impl<'tcx> LateLintPass<'tcx> for EqOp {
}
},
// &foo == bar
- (&ExprKind::AddrOf(BorrowKind::Ref, _, ref l), _) => {
+ (&ExprKind::AddrOf(BorrowKind::Ref, _, l), _) => {
let lty = cx.typeck_results().expr_ty(l);
let lcpy = is_copy(cx, lty);
if (requires_ref || lcpy)
@@ -222,7 +222,7 @@ impl<'tcx> LateLintPass<'tcx> for EqOp {
}
},
// foo == &bar
- (_, &ExprKind::AddrOf(BorrowKind::Ref, _, ref r)) => {
+ (_, &ExprKind::AddrOf(BorrowKind::Ref, _, r)) => {
let rty = cx.typeck_results().expr_ty(r);
let rcpy = is_copy(cx, rty);
if (requires_ref || rcpy)
diff --git a/clippy_lints/src/erasing_op.rs b/clippy_lints/src/erasing_op.rs
index 596026167811..f95ca86a2d01 100644
--- a/clippy_lints/src/erasing_op.rs
+++ b/clippy_lints/src/erasing_op.rs
@@ -34,7 +34,7 @@ impl<'tcx> LateLintPass<'tcx> for ErasingOp {
if e.span.from_expansion() {
return;
}
- if let ExprKind::Binary(ref cmp, ref left, ref right) = e.kind {
+ if let ExprKind::Binary(ref cmp, left, right) = e.kind {
match cmp.node {
BinOpKind::Mul | BinOpKind::BitAnd => {
check(cx, left, e.span);
diff --git a/clippy_lints/src/eta_reduction.rs b/clippy_lints/src/eta_reduction.rs
index 99253555a95e..2f1aa53236d3 100644
--- a/clippy_lints/src/eta_reduction.rs
+++ b/clippy_lints/src/eta_reduction.rs
@@ -87,7 +87,7 @@ impl<'tcx> LateLintPass<'tcx> for EtaReduction {
}
fn check_closure(cx: &LateContext<'_>, expr: &Expr<'_>) {
- if let ExprKind::Closure(_, ref decl, eid, _, _) = expr.kind {
+ if let ExprKind::Closure(_, decl, eid, _, _) = expr.kind {
let body = cx.tcx.hir().body(eid);
let ex = &body.value;
@@ -109,7 +109,7 @@ fn check_closure(cx: &LateContext<'_>, expr: &Expr<'_>) {
}
if_chain!(
- if let ExprKind::Call(ref caller, ref args) = ex.kind;
+ if let ExprKind::Call(caller, args) = ex.kind;
if let ExprKind::Path(_) = caller.kind;
@@ -142,7 +142,7 @@ fn check_closure(cx: &LateContext<'_>, expr: &Expr<'_>) {
);
if_chain!(
- if let ExprKind::MethodCall(ref path, _, ref args, _) = ex.kind;
+ if let ExprKind::MethodCall(path, _, args, _) = ex.kind;
// Not the same number of arguments, there is no way the closure is the same as the function return;
if args.len() == decl.inputs.len();
@@ -178,7 +178,7 @@ fn get_ufcs_type_name(cx: &LateContext<'_>, method_def_id: def_id::DefId, self_a
let actual_type_of_self = &cx.typeck_results().node_type(self_arg.hir_id);
if let Some(trait_id) = cx.tcx.trait_of_item(method_def_id) {
- if match_borrow_depth(expected_type_of_self, &actual_type_of_self)
+ if match_borrow_depth(expected_type_of_self, actual_type_of_self)
&& implements_trait(cx, actual_type_of_self, trait_id, &[])
{
return Some(cx.tcx.def_path_str(trait_id));
@@ -187,8 +187,8 @@ fn get_ufcs_type_name(cx: &LateContext<'_>, method_def_id: def_id::DefId, self_a
cx.tcx.impl_of_method(method_def_id).and_then(|_| {
//a type may implicitly implement other type's methods (e.g. Deref)
- if match_types(expected_type_of_self, &actual_type_of_self) {
- return Some(get_type_name(cx, &actual_type_of_self));
+ if match_types(expected_type_of_self, actual_type_of_self) {
+ return Some(get_type_name(cx, actual_type_of_self));
}
None
})
@@ -196,7 +196,7 @@ fn get_ufcs_type_name(cx: &LateContext<'_>, method_def_id: def_id::DefId, self_a
fn match_borrow_depth(lhs: Ty<'_>, rhs: Ty<'_>) -> bool {
match (&lhs.kind(), &rhs.kind()) {
- (ty::Ref(_, t1, mut1), ty::Ref(_, t2, mut2)) => mut1 == mut2 && match_borrow_depth(&t1, &t2),
+ (ty::Ref(_, t1, mut1), ty::Ref(_, t2, mut2)) => mut1 == mut2 && match_borrow_depth(t1, t2),
(l, r) => !matches!((l, r), (ty::Ref(_, _, _), _) | (_, ty::Ref(_, _, _))),
}
}
@@ -218,7 +218,7 @@ fn match_types(lhs: Ty<'_>, rhs: Ty<'_>) -> bool {
fn get_type_name(cx: &LateContext<'_>, ty: Ty<'_>) -> String {
match ty.kind() {
ty::Adt(t, _) => cx.tcx.def_path_str(t.did),
- ty::Ref(_, r, _) => get_type_name(cx, &r),
+ ty::Ref(_, r, _) => get_type_name(cx, r),
_ => ty.to_string(),
}
}
@@ -230,7 +230,7 @@ fn compare_inputs(
for (closure_input, function_arg) in closure_inputs.zip(call_args) {
if let PatKind::Binding(_, _, ident, _) = closure_input.pat.kind {
// XXXManishearth Should I be checking the binding mode here?
- if let ExprKind::Path(QPath::Resolved(None, ref p)) = function_arg.kind {
+ if let ExprKind::Path(QPath::Resolved(None, p)) = function_arg.kind {
if p.segments.len() != 1 {
// If it's a proper path, it can't be a local variable
return false;
diff --git a/clippy_lints/src/eval_order_dependence.rs b/clippy_lints/src/eval_order_dependence.rs
index ea33a4d98fd2..762f64fe37ad 100644
--- a/clippy_lints/src/eval_order_dependence.rs
+++ b/clippy_lints/src/eval_order_dependence.rs
@@ -71,7 +71,7 @@ impl<'tcx> LateLintPass<'tcx> for EvalOrderDependence {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
// Find a write to a local variable.
match expr.kind {
- ExprKind::Assign(ref lhs, ..) | ExprKind::AssignOp(_, ref lhs, _) => {
+ ExprKind::Assign(lhs, ..) | ExprKind::AssignOp(_, lhs, _) => {
if let Some(var) = path_to_local(lhs) {
let mut visitor = ReadVisitor {
cx,
@@ -87,12 +87,12 @@ impl<'tcx> LateLintPass<'tcx> for EvalOrderDependence {
}
fn check_stmt(&mut self, cx: &LateContext<'tcx>, stmt: &'tcx Stmt<'_>) {
match stmt.kind {
- StmtKind::Local(ref local) => {
- if let Local { init: Some(ref e), .. } = **local {
+ StmtKind::Local(local) => {
+ if let Local { init: Some(e), .. } = local {
DivergenceVisitor { cx }.visit_expr(e);
}
},
- StmtKind::Expr(ref e) | StmtKind::Semi(ref e) => DivergenceVisitor { cx }.maybe_walk_expr(e),
+ StmtKind::Expr(e) | StmtKind::Semi(e) => DivergenceVisitor { cx }.maybe_walk_expr(e),
StmtKind::Item(..) => {},
}
}
@@ -106,7 +106,7 @@ impl<'a, 'tcx> DivergenceVisitor<'a, 'tcx> {
fn maybe_walk_expr(&mut self, e: &'tcx Expr<'_>) {
match e.kind {
ExprKind::Closure(..) => {},
- ExprKind::Match(ref e, arms, _) => {
+ ExprKind::Match(e, arms, _) => {
self.visit_expr(e);
for arm in arms {
if let Some(Guard::If(if_expr)) = arm.guard {
@@ -130,7 +130,7 @@ impl<'a, 'tcx> Visitor<'tcx> for DivergenceVisitor<'a, 'tcx> {
fn visit_expr(&mut self, e: &'tcx Expr<'_>) {
match e.kind {
ExprKind::Continue(_) | ExprKind::Break(_, _) | ExprKind::Ret(_) => self.report_diverging_sub_expr(e),
- ExprKind::Call(ref func, _) => {
+ ExprKind::Call(func, _) => {
let typ = self.cx.typeck_results().expr_ty(func);
match typ.kind() {
ty::FnDef(..) | ty::FnPtr(_) => {
@@ -266,10 +266,10 @@ fn check_expr<'a, 'tcx>(vis: &mut ReadVisitor<'a, 'tcx>, expr: &'tcx Expr<'_>) -
fn check_stmt<'a, 'tcx>(vis: &mut ReadVisitor<'a, 'tcx>, stmt: &'tcx Stmt<'_>) -> StopEarly {
match stmt.kind {
- StmtKind::Expr(ref expr) | StmtKind::Semi(ref expr) => check_expr(vis, expr),
+ StmtKind::Expr(expr) | StmtKind::Semi(expr) => check_expr(vis, expr),
// If the declaration is of a local variable, check its initializer
// expression if it has one. Otherwise, keep going.
- StmtKind::Local(ref local) => local
+ StmtKind::Local(local) => local
.init
.as_ref()
.map_or(StopEarly::KeepGoing, |expr| check_expr(vis, expr)),
@@ -343,7 +343,7 @@ impl<'a, 'tcx> Visitor<'tcx> for ReadVisitor<'a, 'tcx> {
/// Returns `true` if `expr` is the LHS of an assignment, like `expr = ...`.
fn is_in_assignment_position(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
if let Some(parent) = get_parent_expr(cx, expr) {
- if let ExprKind::Assign(ref lhs, ..) = parent.kind {
+ if let ExprKind::Assign(lhs, ..) = parent.kind {
return lhs.hir_id == expr.hir_id;
}
}
diff --git a/clippy_lints/src/exit.rs b/clippy_lints/src/exit.rs
index 84fac9986623..16246e548b61 100644
--- a/clippy_lints/src/exit.rs
+++ b/clippy_lints/src/exit.rs
@@ -28,7 +28,7 @@ declare_lint_pass!(Exit => [EXIT]);
impl<'tcx> LateLintPass<'tcx> for Exit {
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
if_chain! {
- if let ExprKind::Call(ref path_expr, ref _args) = e.kind;
+ if let ExprKind::Call(path_expr, _args) = e.kind;
if let ExprKind::Path(ref path) = path_expr.kind;
if let Some(def_id) = cx.qpath_res(path, path_expr.hir_id).opt_def_id();
if match_def_path(cx, def_id, &paths::EXIT);
diff --git a/clippy_lints/src/explicit_write.rs b/clippy_lints/src/explicit_write.rs
index 4146b7baa102..da4936ff25b6 100644
--- a/clippy_lints/src/explicit_write.rs
+++ b/clippy_lints/src/explicit_write.rs
@@ -34,11 +34,11 @@ impl<'tcx> LateLintPass<'tcx> for ExplicitWrite {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
if_chain! {
// match call to unwrap
- if let ExprKind::MethodCall(ref unwrap_fun, _, ref unwrap_args, _) = expr.kind;
+ if let ExprKind::MethodCall(unwrap_fun, _, unwrap_args, _) = expr.kind;
if unwrap_fun.ident.name == sym::unwrap;
// match call to write_fmt
if !unwrap_args.is_empty();
- if let ExprKind::MethodCall(ref write_fun, _, write_args, _) =
+ if let ExprKind::MethodCall(write_fun, _, write_args, _) =
unwrap_args[0].kind;
if write_fun.ident.name == sym!(write_fmt);
// match calls to std::io::stdout() / std::io::stderr ()
@@ -135,10 +135,10 @@ fn write_output_string(write_args: &[Expr<'_>]) -> Option<String> {
if_chain! {
// Obtain the string that should be printed
if write_args.len() > 1;
- if let ExprKind::Call(_, ref output_args) = write_args[1].kind;
+ if let ExprKind::Call(_, output_args) = write_args[1].kind;
if !output_args.is_empty();
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref output_string_expr) = output_args[0].kind;
- if let ExprKind::Array(ref string_exprs) = output_string_expr.kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, output_string_expr) = output_args[0].kind;
+ if let ExprKind::Array(string_exprs) = output_string_expr.kind;
// we only want to provide an automatic suggestion for simple (non-format) strings
if string_exprs.len() == 1;
if let ExprKind::Lit(ref lit) = string_exprs[0].kind;
diff --git a/clippy_lints/src/fallible_impl_from.rs b/clippy_lints/src/fallible_impl_from.rs
index 52a5a7acf0d0..2937fcb9ca0f 100644
--- a/clippy_lints/src/fallible_impl_from.rs
+++ b/clippy_lints/src/fallible_impl_from.rs
@@ -81,8 +81,8 @@ fn lint_impl_body<'tcx>(cx: &LateContext<'tcx>, impl_span: Span, impl_items: &[h
fn visit_expr(&mut self, expr: &'tcx Expr<'_>) {
// check for `begin_panic`
if_chain! {
- if let ExprKind::Call(ref func_expr, _) = expr.kind;
- if let ExprKind::Path(QPath::Resolved(_, ref path)) = func_expr.kind;
+ if let ExprKind::Call(func_expr, _) = expr.kind;
+ if let ExprKind::Path(QPath::Resolved(_, path)) = func_expr.kind;
if let Some(path_def_id) = path.res.opt_def_id();
if match_panic_def_id(self.lcx, path_def_id);
if is_expn_of(expr.span, "unreachable").is_none();
diff --git a/clippy_lints/src/float_equality_without_abs.rs b/clippy_lints/src/float_equality_without_abs.rs
index 0c59db360f9a..b5ebe5f90ba2 100644
--- a/clippy_lints/src/float_equality_without_abs.rs
+++ b/clippy_lints/src/float_equality_without_abs.rs
@@ -48,7 +48,7 @@ impl<'tcx> LateLintPass<'tcx> for FloatEqualityWithoutAbs {
let rhs;
// check if expr is a binary expression with a lt or gt operator
- if let ExprKind::Binary(op, ref left, ref right) = expr.kind {
+ if let ExprKind::Binary(op, left, right) = expr.kind {
match op.node {
BinOpKind::Lt => {
lhs = left;
@@ -88,8 +88,8 @@ impl<'tcx> LateLintPass<'tcx> for FloatEqualityWithoutAbs {
if let ty::Float(_) = t_val_r.kind();
then {
- let sug_l = sugg::Sugg::hir(cx, &val_l, "..");
- let sug_r = sugg::Sugg::hir(cx, &val_r, "..");
+ let sug_l = sugg::Sugg::hir(cx, val_l, "..");
+ let sug_r = sugg::Sugg::hir(cx, val_r, "..");
// format the suggestion
let suggestion = format!("{}.abs()", sugg::make_assoc(AssocOp::Subtract, &sug_l, &sug_r).maybe_par());
// spans the lint
diff --git a/clippy_lints/src/floating_point_arithmetic.rs b/clippy_lints/src/floating_point_arithmetic.rs
index 0b5f0379ce64..e0b687b02052 100644
--- a/clippy_lints/src/floating_point_arithmetic.rs
+++ b/clippy_lints/src/floating_point_arithmetic.rs
@@ -131,7 +131,7 @@ fn prepare_receiver_sugg<'a>(cx: &LateContext<'_>, mut expr: &'a Expr<'a>) -> Su
let mut suggestion = Sugg::hir(cx, expr, "..");
if let ExprKind::Unary(UnOp::Neg, inner_expr) = &expr.kind {
- expr = &inner_expr;
+ expr = inner_expr;
}
if_chain! {
@@ -313,8 +313,8 @@ fn check_powi(cx: &LateContext<'_>, expr: &Expr<'_>, args: &[Expr<'_>]) {
Spanned {
node: BinOpKind::Add, ..
},
- ref lhs,
- ref rhs,
+ lhs,
+ rhs,
) = parent.kind
{
let other_addend = if lhs.hir_id == expr.hir_id { rhs } else { lhs };
@@ -329,7 +329,7 @@ fn check_powi(cx: &LateContext<'_>, expr: &Expr<'_>, args: &[Expr<'_>]) {
"{}.mul_add({}, {})",
Sugg::hir(cx, &args[0], ".."),
Sugg::hir(cx, &args[0], ".."),
- Sugg::hir(cx, &other_addend, ".."),
+ Sugg::hir(cx, other_addend, ".."),
),
Applicability::MachineApplicable,
);
@@ -356,18 +356,18 @@ fn detect_hypot(cx: &LateContext<'_>, args: &[Expr<'_>]) -> Option<String> {
Spanned {
node: BinOpKind::Add, ..
},
- ref add_lhs,
- ref add_rhs,
+ add_lhs,
+ add_rhs,
) = args[0].kind
{
// check if expression of the form x * x + y * y
if_chain! {
- if let ExprKind::Binary(Spanned { node: BinOpKind::Mul, .. }, ref lmul_lhs, ref lmul_rhs) = add_lhs.kind;
- if let ExprKind::Binary(Spanned { node: BinOpKind::Mul, .. }, ref rmul_lhs, ref rmul_rhs) = add_rhs.kind;
+ if let ExprKind::Binary(Spanned { node: BinOpKind::Mul, .. }, lmul_lhs, lmul_rhs) = add_lhs.kind;
+ if let ExprKind::Binary(Spanned { node: BinOpKind::Mul, .. }, rmul_lhs, rmul_rhs) = add_rhs.kind;
if eq_expr_value(cx, lmul_lhs, lmul_rhs);
if eq_expr_value(cx, rmul_lhs, rmul_rhs);
then {
- return Some(format!("{}.hypot({})", Sugg::hir(cx, &lmul_lhs, ".."), Sugg::hir(cx, &rmul_lhs, "..")));
+ return Some(format!("{}.hypot({})", Sugg::hir(cx, lmul_lhs, ".."), Sugg::hir(cx, rmul_lhs, "..")));
}
}
@@ -376,13 +376,13 @@ fn detect_hypot(cx: &LateContext<'_>, args: &[Expr<'_>]) -> Option<String> {
if let ExprKind::MethodCall(
PathSegment { ident: lmethod_name, .. },
ref _lspan,
- ref largs,
+ largs,
_
) = add_lhs.kind;
if let ExprKind::MethodCall(
PathSegment { ident: rmethod_name, .. },
ref _rspan,
- ref rargs,
+ rargs,
_
) = add_rhs.kind;
if lmethod_name.as_str() == "powi" && rmethod_name.as_str() == "powi";
@@ -416,11 +416,11 @@ fn check_hypot(cx: &LateContext<'_>, expr: &Expr<'_>, args: &[Expr<'_>]) {
// and suggest usage of `x.exp_m1() - (y - 1)` instead
fn check_expm1(cx: &LateContext<'_>, expr: &Expr<'_>) {
if_chain! {
- if let ExprKind::Binary(Spanned { node: BinOpKind::Sub, .. }, ref lhs, ref rhs) = expr.kind;
+ if let ExprKind::Binary(Spanned { node: BinOpKind::Sub, .. }, lhs, rhs) = expr.kind;
if cx.typeck_results().expr_ty(lhs).is_floating_point();
if let Some((value, _)) = constant(cx, cx.typeck_results(), rhs);
if F32(1.0) == value || F64(1.0) == value;
- if let ExprKind::MethodCall(ref path, _, ref method_args, _) = lhs.kind;
+ if let ExprKind::MethodCall(path, _, method_args, _) = lhs.kind;
if cx.typeck_results().expr_ty(&method_args[0]).is_floating_point();
if path.ident.name.as_str() == "exp";
then {
@@ -442,7 +442,7 @@ fn check_expm1(cx: &LateContext<'_>, expr: &Expr<'_>) {
fn is_float_mul_expr<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<(&'a Expr<'a>, &'a Expr<'a>)> {
if_chain! {
- if let ExprKind::Binary(Spanned { node: BinOpKind::Mul, .. }, ref lhs, ref rhs) = &expr.kind;
+ if let ExprKind::Binary(Spanned { node: BinOpKind::Mul, .. }, lhs, rhs) = &expr.kind;
if cx.typeck_results().expr_ty(lhs).is_floating_point();
if cx.typeck_results().expr_ty(rhs).is_floating_point();
then {
@@ -604,8 +604,8 @@ fn check_custom_abs(cx: &LateContext<'_>, expr: &Expr<'_>) {
fn are_same_base_logs(cx: &LateContext<'_>, expr_a: &Expr<'_>, expr_b: &Expr<'_>) -> bool {
if_chain! {
- if let ExprKind::MethodCall(PathSegment { ident: method_name_a, .. }, _, ref args_a, _) = expr_a.kind;
- if let ExprKind::MethodCall(PathSegment { ident: method_name_b, .. }, _, ref args_b, _) = expr_b.kind;
+ if let ExprKind::MethodCall(PathSegment { ident: method_name_a, .. }, _, args_a, _) = expr_a.kind;
+ if let ExprKind::MethodCall(PathSegment { ident: method_name_b, .. }, _, args_b, _) = expr_b.kind;
then {
return method_name_a.as_str() == method_name_b.as_str() &&
args_a.len() == args_b.len() &&
@@ -630,8 +630,8 @@ fn check_log_division(cx: &LateContext<'_>, expr: &Expr<'_>) {
rhs,
) = &expr.kind;
if are_same_base_logs(cx, lhs, rhs);
- if let ExprKind::MethodCall(_, _, ref largs, _) = lhs.kind;
- if let ExprKind::MethodCall(_, _, ref rargs, _) = rhs.kind;
+ if let ExprKind::MethodCall(_, _, largs, _) = lhs.kind;
+ if let ExprKind::MethodCall(_, _, rargs, _) = rhs.kind;
then {
span_lint_and_sugg(
cx,
@@ -675,7 +675,7 @@ fn check_radians(cx: &LateContext<'_>, expr: &Expr<'_>) {
expr.span,
"conversion to degrees can be done more accurately",
"consider using",
- format!("{}.to_degrees()", Sugg::hir(cx, &mul_lhs, "..")),
+ format!("{}.to_degrees()", Sugg::hir(cx, mul_lhs, "..")),
Applicability::MachineApplicable,
);
} else if
@@ -688,7 +688,7 @@ fn check_radians(cx: &LateContext<'_>, expr: &Expr<'_>) {
expr.span,
"conversion to radians can be done more accurately",
"consider using",
- format!("{}.to_radians()", Sugg::hir(cx, &mul_lhs, "..")),
+ format!("{}.to_radians()", Sugg::hir(cx, mul_lhs, "..")),
Applicability::MachineApplicable,
);
}
@@ -698,7 +698,7 @@ fn check_radians(cx: &LateContext<'_>, expr: &Expr<'_>) {
impl<'tcx> LateLintPass<'tcx> for FloatingPointArithmetic {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::MethodCall(ref path, _, args, _) = &expr.kind {
+ if let ExprKind::MethodCall(path, _, args, _) = &expr.kind {
let recv_ty = cx.typeck_results().expr_ty(&args[0]);
if recv_ty.is_floating_point() {
diff --git a/clippy_lints/src/format.rs b/clippy_lints/src/format.rs
index a33f987b423a..4729abbd8e3f 100644
--- a/clippy_lints/src/format.rs
+++ b/clippy_lints/src/format.rs
@@ -78,8 +78,8 @@ fn span_useless_format<T: LintContext>(cx: &T, span: Span, help: &str, mut sugg:
fn on_argumentv1_new<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, arms: &'tcx [Arm<'_>]) -> Option<String> {
if_chain! {
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref format_args) = expr.kind;
- if let ExprKind::Array(ref elems) = arms[0].body.kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, format_args) = expr.kind;
+ if let ExprKind::Array(elems) = arms[0].body.kind;
if elems.len() == 1;
if let Some(args) = match_function_call(cx, &elems[0], &paths::FMT_ARGUMENTV1_NEW);
// matches `core::fmt::Display::fmt`
@@ -88,10 +88,10 @@ fn on_argumentv1_new<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, arms: &
if let Some(did) = cx.qpath_res(qpath, args[1].hir_id).opt_def_id();
if match_def_path(cx, did, &paths::DISPLAY_FMT_METHOD);
// check `(arg0,)` in match block
- if let PatKind::Tuple(ref pats, None) = arms[0].pat.kind;
+ if let PatKind::Tuple(pats, None) = arms[0].pat.kind;
if pats.len() == 1;
then {
- let ty = cx.typeck_results().pat_ty(&pats[0]).peel_refs();
+ let ty = cx.typeck_results().pat_ty(pats[0]).peel_refs();
if *ty.kind() != rustc_middle::ty::Str && !is_type_diagnostic_item(cx, ty, sym::string_type) {
return None;
}
@@ -101,7 +101,7 @@ fn on_argumentv1_new<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, arms: &
}
} else {
let snip = snippet(cx, format_args.span, "<arg>");
- if let ExprKind::MethodCall(ref path, _, _, _) = format_args.kind {
+ if let ExprKind::MethodCall(path, _, _, _) = format_args.kind {
if path.ident.name == sym!(to_string) {
return Some(format!("{}", snip));
}
@@ -120,16 +120,16 @@ fn on_new_v1<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) -> Option<Strin
if let Some(args) = match_function_call(cx, expr, &paths::FMT_ARGUMENTS_NEW_V1);
if args.len() == 2;
// Argument 1 in `new_v1()`
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref arr) = args[0].kind;
- if let ExprKind::Array(ref pieces) = arr.kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, arr) = args[0].kind;
+ if let ExprKind::Array(pieces) = arr.kind;
if pieces.len() == 1;
if let ExprKind::Lit(ref lit) = pieces[0].kind;
if let LitKind::Str(ref s, _) = lit.node;
// Argument 2 in `new_v1()`
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref arg1) = args[1].kind;
- if let ExprKind::Match(ref matchee, ref arms, MatchSource::Normal) = arg1.kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, arg1) = args[1].kind;
+ if let ExprKind::Match(matchee, arms, MatchSource::Normal) = arg1.kind;
if arms.len() == 1;
- if let ExprKind::Tup(ref tup) = matchee.kind;
+ if let ExprKind::Tup(tup) = matchee.kind;
then {
// `format!("foo")` expansion contains `match () { () => [], }`
if tup.is_empty() {
@@ -152,16 +152,16 @@ fn on_new_v1_fmt<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) -> Option<S
if args.len() == 3;
if check_unformatted(&args[2]);
// Argument 1 in `new_v1_formatted()`
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref arr) = args[0].kind;
- if let ExprKind::Array(ref pieces) = arr.kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, arr) = args[0].kind;
+ if let ExprKind::Array(pieces) = arr.kind;
if pieces.len() == 1;
if let ExprKind::Lit(ref lit) = pieces[0].kind;
if let LitKind::Str(..) = lit.node;
// Argument 2 in `new_v1_formatted()`
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref arg1) = args[1].kind;
- if let ExprKind::Match(ref matchee, ref arms, MatchSource::Normal) = arg1.kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, arg1) = args[1].kind;
+ if let ExprKind::Match(matchee, arms, MatchSource::Normal) = arg1.kind;
if arms.len() == 1;
- if let ExprKind::Tup(ref tup) = matchee.kind;
+ if let ExprKind::Tup(tup) = matchee.kind;
then {
return on_argumentv1_new(cx, &tup[0], arms);
}
@@ -182,14 +182,14 @@ fn on_new_v1_fmt<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) -> Option<S
/// ```
fn check_unformatted(expr: &Expr<'_>) -> bool {
if_chain! {
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref expr) = expr.kind;
- if let ExprKind::Array(ref exprs) = expr.kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, expr) = expr.kind;
+ if let ExprKind::Array(exprs) = expr.kind;
if exprs.len() == 1;
// struct `core::fmt::rt::v1::Argument`
- if let ExprKind::Struct(_, ref fields, _) = exprs[0].kind;
+ if let ExprKind::Struct(_, fields, _) = exprs[0].kind;
if let Some(format_field) = fields.iter().find(|f| f.ident.name == sym::format);
// struct `core::fmt::rt::v1::FormatSpec`
- if let ExprKind::Struct(_, ref fields, _) = format_field.expr.kind;
+ if let ExprKind::Struct(_, fields, _) = format_field.expr.kind;
if let Some(precision_field) = fields.iter().find(|f| f.ident.name == sym::precision);
if let ExprKind::Path(ref precision_path) = precision_field.expr.kind;
if last_path_segment(precision_path).ident.name == sym::Implied;
diff --git a/clippy_lints/src/functions/must_use.rs b/clippy_lints/src/functions/must_use.rs
index 9e943c647fef..db5fe90b663a 100644
--- a/clippy_lints/src/functions/must_use.rs
+++ b/clippy_lints/src/functions/must_use.rs
@@ -25,12 +25,12 @@ pub(super) fn check_item(cx: &LateContext<'tcx>, item: &'tcx hir::Item<'_>) {
let is_public = cx.access_levels.is_exported(item.hir_id());
let fn_header_span = item.span.with_hi(sig.decl.output.span().hi());
if let Some(attr) = attr {
- check_needless_must_use(cx, &sig.decl, item.hir_id(), item.span, fn_header_span, attr);
+ check_needless_must_use(cx, sig.decl, item.hir_id(), item.span, fn_header_span, attr);
return;
} else if is_public && !is_proc_macro(cx.sess(), attrs) && attr_by_name(attrs, "no_mangle").is_none() {
check_must_use_candidate(
cx,
- &sig.decl,
+ sig.decl,
cx.tcx.hir().body(*body_id),
item.span,
item.hir_id(),
@@ -48,11 +48,11 @@ pub(super) fn check_impl_item(cx: &LateContext<'tcx>, item: &'tcx hir::ImplItem<
let attrs = cx.tcx.hir().attrs(item.hir_id());
let attr = must_use_attr(attrs);
if let Some(attr) = attr {
- check_needless_must_use(cx, &sig.decl, item.hir_id(), item.span, fn_header_span, attr);
+ check_needless_must_use(cx, sig.decl, item.hir_id(), item.span, fn_header_span, attr);
} else if is_public && !is_proc_macro(cx.sess(), attrs) && trait_ref_of_method(cx, item.hir_id()).is_none() {
check_must_use_candidate(
cx,
- &sig.decl,
+ sig.decl,
cx.tcx.hir().body(*body_id),
item.span,
item.hir_id(),
@@ -71,13 +71,13 @@ pub(super) fn check_trait_item(cx: &LateContext<'tcx>, item: &'tcx hir::TraitIte
let attrs = cx.tcx.hir().attrs(item.hir_id());
let attr = must_use_attr(attrs);
if let Some(attr) = attr {
- check_needless_must_use(cx, &sig.decl, item.hir_id(), item.span, fn_header_span, attr);
+ check_needless_must_use(cx, sig.decl, item.hir_id(), item.span, fn_header_span, attr);
} else if let hir::TraitFn::Provided(eid) = *eid {
let body = cx.tcx.hir().body(eid);
if attr.is_none() && is_public && !is_proc_macro(cx.sess(), attrs) {
check_must_use_candidate(
cx,
- &sig.decl,
+ sig.decl,
body,
item.span,
item.hir_id(),
@@ -160,8 +160,8 @@ fn check_must_use_candidate<'tcx>(
fn returns_unit(decl: &hir::FnDecl<'_>) -> bool {
match decl.output {
hir::FnRetTy::DefaultReturn(_) => true,
- hir::FnRetTy::Return(ref ty) => match ty.kind {
- hir::TyKind::Tup(ref tys) => tys.is_empty(),
+ hir::FnRetTy::Return(ty) => match ty.kind {
+ hir::TyKind::Tup(tys) => tys.is_empty(),
hir::TyKind::Never => true,
_ => false,
},
@@ -170,7 +170,7 @@ fn returns_unit(decl: &hir::FnDecl<'_>) -> bool {
fn has_mutable_arg(cx: &LateContext<'_>, body: &hir::Body<'_>) -> bool {
let mut tys = DefIdSet::default();
- body.params.iter().any(|param| is_mutable_pat(cx, ¶m.pat, &mut tys))
+ body.params.iter().any(|param| is_mutable_pat(cx, param.pat, &mut tys))
}
fn is_mutable_pat(cx: &LateContext<'_>, pat: &hir::Pat<'_>, tys: &mut DefIdSet) -> bool {
@@ -178,7 +178,7 @@ fn is_mutable_pat(cx: &LateContext<'_>, pat: &hir::Pat<'_>, tys: &mut DefIdSet)
return false; // ignore `_` patterns
}
if cx.tcx.has_typeck_results(pat.hir_id.owner.to_def_id()) {
- is_mutable_ty(cx, &cx.tcx.typeck(pat.hir_id.owner).pat_ty(pat), pat.span, tys)
+ is_mutable_ty(cx, cx.tcx.typeck(pat.hir_id.owner).pat_ty(pat), pat.span, tys)
} else {
false
}
@@ -190,12 +190,12 @@ fn is_mutable_ty<'tcx>(cx: &LateContext<'tcx>, ty: Ty<'tcx>, span: Span, tys: &m
match *ty.kind() {
// primitive types are never mutable
ty::Bool | ty::Char | ty::Int(_) | ty::Uint(_) | ty::Float(_) | ty::Str => false,
- ty::Adt(ref adt, ref substs) => {
+ ty::Adt(adt, substs) => {
tys.insert(adt.did) && !ty.is_freeze(cx.tcx.at(span), cx.param_env)
|| KNOWN_WRAPPER_TYS.iter().any(|path| match_def_path(cx, adt.did, path))
&& substs.types().any(|ty| is_mutable_ty(cx, ty, span, tys))
},
- ty::Tuple(ref substs) => substs.types().any(|ty| is_mutable_ty(cx, ty, span, tys)),
+ ty::Tuple(substs) => substs.types().any(|ty| is_mutable_ty(cx, ty, span, tys)),
ty::Array(ty, _) | ty::Slice(ty) => is_mutable_ty(cx, ty, span, tys),
ty::RawPtr(ty::TypeAndMut { ty, mutbl }) | ty::Ref(_, ty, mutbl) => {
mutbl == hir::Mutability::Mut || is_mutable_ty(cx, ty, span, tys)
@@ -239,7 +239,7 @@ impl<'a, 'tcx> intravisit::Visitor<'tcx> for StaticMutVisitor<'a, 'tcx> {
tys.clear();
}
},
- Assign(ref target, ..) | AssignOp(_, ref target, _) | AddrOf(_, hir::Mutability::Mut, ref target) => {
+ Assign(target, ..) | AssignOp(_, target, _) | AddrOf(_, hir::Mutability::Mut, target) => {
self.mutates_static |= is_mutated_static(target)
},
_ => {},
@@ -257,7 +257,7 @@ fn is_mutated_static(e: &hir::Expr<'_>) -> bool {
match e.kind {
Path(QPath::Resolved(_, path)) => !matches!(path.res, Res::Local(_)),
Path(_) => true,
- Field(ref inner, _) | Index(ref inner, _) => is_mutated_static(inner),
+ Field(inner, _) | Index(inner, _) => is_mutated_static(inner),
_ => false,
}
}
diff --git a/clippy_lints/src/functions/not_unsafe_ptr_arg_deref.rs b/clippy_lints/src/functions/not_unsafe_ptr_arg_deref.rs
index cc69f4aed0ce..b8ea69908665 100644
--- a/clippy_lints/src/functions/not_unsafe_ptr_arg_deref.rs
+++ b/clippy_lints/src/functions/not_unsafe_ptr_arg_deref.rs
@@ -27,7 +27,7 @@ pub(super) fn check_fn(
pub(super) fn check_trait_item(cx: &LateContext<'tcx>, item: &'tcx hir::TraitItem<'_>) {
if let hir::TraitItemKind::Fn(ref sig, hir::TraitFn::Provided(eid)) = item.kind {
let body = cx.tcx.hir().body(eid);
- check_raw_ptr(cx, sig.header.unsafety, &sig.decl, body, item.hir_id());
+ check_raw_ptr(cx, sig.header.unsafety, sig.decl, body, item.hir_id());
}
}
@@ -77,7 +77,7 @@ impl<'a, 'tcx> intravisit::Visitor<'tcx> for DerefVisitor<'a, 'tcx> {
fn visit_expr(&mut self, expr: &'tcx hir::Expr<'_>) {
match expr.kind {
- hir::ExprKind::Call(ref f, args) => {
+ hir::ExprKind::Call(f, args) => {
let ty = self.typeck_results.expr_ty(f);
if type_is_unsafe_function(self.cx, ty) {
@@ -96,7 +96,7 @@ impl<'a, 'tcx> intravisit::Visitor<'tcx> for DerefVisitor<'a, 'tcx> {
}
}
},
- hir::ExprKind::Unary(hir::UnOp::Deref, ref ptr) => self.check_arg(ptr),
+ hir::ExprKind::Unary(hir::UnOp::Deref, ptr) => self.check_arg(ptr),
_ => (),
}
diff --git a/clippy_lints/src/functions/result_unit_err.rs b/clippy_lints/src/functions/result_unit_err.rs
index 3d1092ce21f6..c073f312d386 100644
--- a/clippy_lints/src/functions/result_unit_err.rs
+++ b/clippy_lints/src/functions/result_unit_err.rs
@@ -18,7 +18,7 @@ pub(super) fn check_item(cx: &LateContext<'tcx>, item: &'tcx hir::Item<'_>) {
let is_public = cx.access_levels.is_exported(item.hir_id());
let fn_header_span = item.span.with_hi(sig.decl.output.span().hi());
if is_public {
- check_result_unit_err(cx, &sig.decl, item.span, fn_header_span);
+ check_result_unit_err(cx, sig.decl, item.span, fn_header_span);
}
}
}
@@ -28,7 +28,7 @@ pub(super) fn check_impl_item(cx: &LateContext<'tcx>, item: &'tcx hir::ImplItem<
let is_public = cx.access_levels.is_exported(item.hir_id());
let fn_header_span = item.span.with_hi(sig.decl.output.span().hi());
if is_public && trait_ref_of_method(cx, item.hir_id()).is_none() {
- check_result_unit_err(cx, &sig.decl, item.span, fn_header_span);
+ check_result_unit_err(cx, sig.decl, item.span, fn_header_span);
}
}
}
@@ -38,7 +38,7 @@ pub(super) fn check_trait_item(cx: &LateContext<'tcx>, item: &'tcx hir::TraitIte
let is_public = cx.access_levels.is_exported(item.hir_id());
let fn_header_span = item.span.with_hi(sig.decl.output.span().hi());
if is_public {
- check_result_unit_err(cx, &sig.decl, item.span, fn_header_span);
+ check_result_unit_err(cx, sig.decl, item.span, fn_header_span);
}
}
}
@@ -46,7 +46,7 @@ pub(super) fn check_trait_item(cx: &LateContext<'tcx>, item: &'tcx hir::TraitIte
fn check_result_unit_err(cx: &LateContext<'_>, decl: &hir::FnDecl<'_>, item_span: Span, fn_header_span: Span) {
if_chain! {
if !in_external_macro(cx.sess(), item_span);
- if let hir::FnRetTy::Return(ref ty) = decl.output;
+ if let hir::FnRetTy::Return(ty) = decl.output;
let ty = hir_ty_to_ty(cx.tcx, ty);
if is_type_diagnostic_item(cx, ty, sym::result_type);
if let ty::Adt(_, substs) = ty.kind();
diff --git a/clippy_lints/src/functions/too_many_arguments.rs b/clippy_lints/src/functions/too_many_arguments.rs
index 62b1e6bd7ca4..63a14d8d4cde 100644
--- a/clippy_lints/src/functions/too_many_arguments.rs
+++ b/clippy_lints/src/functions/too_many_arguments.rs
@@ -49,7 +49,7 @@ pub(super) fn check_trait_item(
if sig.header.abi == Abi::Rust {
check_arg_number(
cx,
- &sig.decl,
+ sig.decl,
item.span.with_hi(sig.decl.output.span().hi()),
too_many_arguments_threshold,
);
diff --git a/clippy_lints/src/get_last_with_len.rs b/clippy_lints/src/get_last_with_len.rs
index cbcef567c532..3707e792177d 100644
--- a/clippy_lints/src/get_last_with_len.rs
+++ b/clippy_lints/src/get_last_with_len.rs
@@ -51,7 +51,7 @@ impl<'tcx> LateLintPass<'tcx> for GetLastWithLen {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
if_chain! {
// Is a method call
- if let ExprKind::MethodCall(ref path, _, ref args, _) = expr.kind;
+ if let ExprKind::MethodCall(path, _, args, _) = expr.kind;
// Method name is "get"
if path.ident.name == sym!(get);
diff --git a/clippy_lints/src/identity_op.rs b/clippy_lints/src/identity_op.rs
index 8bed5e1bf640..366b3b46a8ae 100644
--- a/clippy_lints/src/identity_op.rs
+++ b/clippy_lints/src/identity_op.rs
@@ -35,7 +35,7 @@ impl<'tcx> LateLintPass<'tcx> for IdentityOp {
if e.span.from_expansion() {
return;
}
- if let ExprKind::Binary(cmp, ref left, ref right) = e.kind {
+ if let ExprKind::Binary(cmp, left, right) = e.kind {
if is_allowed(cx, cmp, left, right) {
return;
}
diff --git a/clippy_lints/src/if_let_mutex.rs b/clippy_lints/src/if_let_mutex.rs
index 56dfcc6a5064..f661f7ede821 100644
--- a/clippy_lints/src/if_let_mutex.rs
+++ b/clippy_lints/src/if_let_mutex.rs
@@ -55,8 +55,8 @@ impl<'tcx> LateLintPass<'tcx> for IfLetMutex {
cx,
};
if let ExprKind::Match(
- ref op,
- ref arms,
+ op,
+ arms,
MatchSource::IfLetDesugar {
contains_else_clause: true,
},
@@ -64,7 +64,7 @@ impl<'tcx> LateLintPass<'tcx> for IfLetMutex {
{
op_visit.visit_expr(op);
if op_visit.mutex_lock_called {
- for arm in *arms {
+ for arm in arms {
arm_visit.visit_arm(arm);
}
diff --git a/clippy_lints/src/if_let_some_result.rs b/clippy_lints/src/if_let_some_result.rs
index 6e9280c8c7e0..611da3744eee 100644
--- a/clippy_lints/src/if_let_some_result.rs
+++ b/clippy_lints/src/if_let_some_result.rs
@@ -44,9 +44,9 @@ declare_lint_pass!(OkIfLet => [IF_LET_SOME_RESULT]);
impl<'tcx> LateLintPass<'tcx> for OkIfLet {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
if_chain! { //begin checking variables
- if let ExprKind::Match(ref op, ref body, MatchSource::IfLetDesugar { .. }) = expr.kind; //test if expr is if let
- if let ExprKind::MethodCall(_, ok_span, ref result_types, _) = op.kind; //check is expr.ok() has type Result<T,E>.ok(, _)
- if let PatKind::TupleStruct(QPath::Resolved(_, ref x), ref y, _) = body[0].pat.kind; //get operation
+ if let ExprKind::Match(op, body, MatchSource::IfLetDesugar { .. }) = expr.kind; //test if expr is if let
+ if let ExprKind::MethodCall(_, ok_span, result_types, _) = op.kind; //check is expr.ok() has type Result<T,E>.ok(, _)
+ if let PatKind::TupleStruct(QPath::Resolved(_, x), y, _) = body[0].pat.kind; //get operation
if method_chain_args(op, &["ok"]).is_some(); //test to see if using ok() methoduse std::marker::Sized;
if is_type_diagnostic_item(cx, cx.typeck_results().expr_ty(&result_types[0]), sym::result_type);
if rustc_hir_pretty::to_string(rustc_hir_pretty::NO_ANN, |s| s.print_path(x, false)) == "Some";
diff --git a/clippy_lints/src/if_then_some_else_none.rs b/clippy_lints/src/if_then_some_else_none.rs
index 0b5bf060d4cd..ee16519692f9 100644
--- a/clippy_lints/src/if_then_some_else_none.rs
+++ b/clippy_lints/src/if_then_some_else_none.rs
@@ -72,15 +72,15 @@ impl LateLintPass<'_> for IfThenSomeElseNone {
}
if_chain! {
- if let ExprKind::If(ref cond, ref then, Some(ref els)) = expr.kind;
- if let ExprKind::Block(ref then_block, _) = then.kind;
- if let Some(ref then_expr) = then_block.expr;
- if let ExprKind::Call(ref then_call, [then_arg]) = then_expr.kind;
+ if let ExprKind::If(cond, then, Some(els)) = expr.kind;
+ if let ExprKind::Block(then_block, _) = then.kind;
+ if let Some(then_expr) = then_block.expr;
+ if let ExprKind::Call(then_call, [then_arg]) = then_expr.kind;
if let ExprKind::Path(ref then_call_qpath) = then_call.kind;
if match_qpath(then_call_qpath, &clippy_utils::paths::OPTION_SOME);
- if let ExprKind::Block(ref els_block, _) = els.kind;
+ if let ExprKind::Block(els_block, _) = els.kind;
if els_block.stmts.is_empty();
- if let Some(ref els_expr) = els_block.expr;
+ if let Some(els_expr) = els_block.expr;
if let ExprKind::Path(ref els_call_qpath) = els_expr.kind;
if match_qpath(els_call_qpath, &clippy_utils::paths::OPTION_NONE);
then {
diff --git a/clippy_lints/src/implicit_hasher.rs b/clippy_lints/src/implicit_hasher.rs
index 0b748b4d72de..77a38544edc8 100644
--- a/clippy_lints/src/implicit_hasher.rs
+++ b/clippy_lints/src/implicit_hasher.rs
@@ -207,7 +207,7 @@ enum ImplicitHasherType<'tcx> {
impl<'tcx> ImplicitHasherType<'tcx> {
/// Checks that `ty` is a target type without a `BuildHasher`.
fn new(cx: &LateContext<'tcx>, hir_ty: &hir::Ty<'_>) -> Option<Self> {
- if let TyKind::Path(QPath::Resolved(None, ref path)) = hir_ty.kind {
+ if let TyKind::Path(QPath::Resolved(None, path)) = hir_ty.kind {
let params: Vec<_> = path
.segments
.last()
@@ -330,8 +330,8 @@ impl<'a, 'b, 'tcx> Visitor<'tcx> for ImplicitHasherConstructorVisitor<'a, 'b, 't
fn visit_expr(&mut self, e: &'tcx Expr<'_>) {
if_chain! {
- if let ExprKind::Call(ref fun, ref args) = e.kind;
- if let ExprKind::Path(QPath::TypeRelative(ref ty, ref method)) = fun.kind;
+ if let ExprKind::Call(fun, args) = e.kind;
+ if let ExprKind::Path(QPath::TypeRelative(ty, method)) = fun.kind;
if let TyKind::Path(QPath::Resolved(None, ty_path)) = ty.kind;
then {
if !TyS::same_type(self.target.ty(), self.maybe_typeck_results.unwrap().expr_ty(e)) {
diff --git a/clippy_lints/src/implicit_return.rs b/clippy_lints/src/implicit_return.rs
index 6863645a92db..6b379b0d59b2 100644
--- a/clippy_lints/src/implicit_return.rs
+++ b/clippy_lints/src/implicit_return.rs
@@ -100,10 +100,10 @@ fn expr_match(cx: &LateContext<'_>, expr: &Expr<'_>) {
if check_all_arms {
for arm in arms {
- expr_match(cx, &arm.body);
+ expr_match(cx, arm.body);
}
} else {
- expr_match(cx, &arms.first().expect("`if let` doesn't have a single arm").body);
+ expr_match(cx, arms.first().expect("`if let` doesn't have a single arm").body);
}
},
// skip if it already has a return statement
diff --git a/clippy_lints/src/implicit_saturating_sub.rs b/clippy_lints/src/implicit_saturating_sub.rs
index 5207c6289872..cba3183e8695 100644
--- a/clippy_lints/src/implicit_saturating_sub.rs
+++ b/clippy_lints/src/implicit_saturating_sub.rs
@@ -46,21 +46,21 @@ impl<'tcx> LateLintPass<'tcx> for ImplicitSaturatingSub {
if let ExprKind::If(cond, then, None) = &expr.kind;
// Check if the conditional expression is a binary operation
- if let ExprKind::Binary(ref cond_op, ref cond_left, ref cond_right) = cond.kind;
+ if let ExprKind::Binary(ref cond_op, cond_left, cond_right) = cond.kind;
// Ensure that the binary operator is >, != and <
if BinOpKind::Ne == cond_op.node || BinOpKind::Gt == cond_op.node || BinOpKind::Lt == cond_op.node;
// Check if the true condition block has only one statement
- if let ExprKind::Block(ref block, _) = then.kind;
+ if let ExprKind::Block(block, _) = then.kind;
if block.stmts.len() == 1 && block.expr.is_none();
// Check if assign operation is done
- if let StmtKind::Semi(ref e) = block.stmts[0].kind;
+ if let StmtKind::Semi(e) = block.stmts[0].kind;
if let Some(target) = subtracts_one(cx, e);
// Extracting out the variable name
- if let ExprKind::Path(QPath::Resolved(_, ref ares_path)) = target.kind;
+ if let ExprKind::Path(QPath::Resolved(_, ares_path)) = target.kind;
then {
// Handle symmetric conditions in the if statement
@@ -104,7 +104,7 @@ impl<'tcx> LateLintPass<'tcx> for ImplicitSaturatingSub {
print_lint_and_sugg(cx, &var_name, expr);
};
},
- ExprKind::Call(ref func, _) => {
+ ExprKind::Call(func, _) => {
if let ExprKind::Path(ref cond_num_path) = func.kind {
if INT_TYPES.iter().any(|int_type| match_qpath(cond_num_path, &[int_type, "min_value"])) {
print_lint_and_sugg(cx, &var_name, expr);
@@ -120,7 +120,7 @@ impl<'tcx> LateLintPass<'tcx> for ImplicitSaturatingSub {
fn subtracts_one<'a>(cx: &LateContext<'_>, expr: &Expr<'a>) -> Option<&'a Expr<'a>> {
match expr.kind {
- ExprKind::AssignOp(ref op1, ref target, ref value) => {
+ ExprKind::AssignOp(ref op1, target, value) => {
if_chain! {
if BinOpKind::Sub == op1.node;
// Check if literal being subtracted is one
@@ -133,9 +133,9 @@ fn subtracts_one<'a>(cx: &LateContext<'_>, expr: &Expr<'a>) -> Option<&'a Expr<'
}
}
},
- ExprKind::Assign(ref target, ref value, _) => {
+ ExprKind::Assign(target, value, _) => {
if_chain! {
- if let ExprKind::Binary(ref op1, ref left1, ref right1) = value.kind;
+ if let ExprKind::Binary(ref op1, left1, right1) = value.kind;
if BinOpKind::Sub == op1.node;
if SpanlessEq::new(cx).eq_expr(left1, target);
diff --git a/clippy_lints/src/indexing_slicing.rs b/clippy_lints/src/indexing_slicing.rs
index 94d39019608f..1c54599abc40 100644
--- a/clippy_lints/src/indexing_slicing.rs
+++ b/clippy_lints/src/indexing_slicing.rs
@@ -88,7 +88,7 @@ declare_lint_pass!(IndexingSlicing => [INDEXING_SLICING, OUT_OF_BOUNDS_INDEXING]
impl<'tcx> LateLintPass<'tcx> for IndexingSlicing {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::Index(ref array, ref index) = &expr.kind {
+ if let ExprKind::Index(array, index) = &expr.kind {
let ty = cx.typeck_results().expr_ty(array).peel_refs();
if let Some(range) = higher::range(index) {
// Ranged indexes, i.e., &x[n..m], &x[n..], &x[..n] and &x[..]
diff --git a/clippy_lints/src/infinite_iter.rs b/clippy_lints/src/infinite_iter.rs
index fb35bc1e7805..bbb4ddc613af 100644
--- a/clippy_lints/src/infinite_iter.rs
+++ b/clippy_lints/src/infinite_iter.rs
@@ -139,7 +139,7 @@ const HEURISTICS: [(&str, usize, Heuristic, Finiteness); 19] = [
fn is_infinite(cx: &LateContext<'_>, expr: &Expr<'_>) -> Finiteness {
match expr.kind {
- ExprKind::MethodCall(ref method, _, ref args, _) => {
+ ExprKind::MethodCall(method, _, args, _) => {
for &(name, len, heuristic, cap) in &HEURISTICS {
if method.ident.name.as_str() == name && args.len() == len {
return (match heuristic {
@@ -159,9 +159,9 @@ fn is_infinite(cx: &LateContext<'_>, expr: &Expr<'_>) -> Finiteness {
}
Finite
},
- ExprKind::Block(ref block, _) => block.expr.as_ref().map_or(Finite, |e| is_infinite(cx, e)),
- ExprKind::Box(ref e) | ExprKind::AddrOf(BorrowKind::Ref, _, ref e) => is_infinite(cx, e),
- ExprKind::Call(ref path, _) => {
+ ExprKind::Block(block, _) => block.expr.as_ref().map_or(Finite, |e| is_infinite(cx, e)),
+ ExprKind::Box(e) | ExprKind::AddrOf(BorrowKind::Ref, _, e) => is_infinite(cx, e),
+ ExprKind::Call(path, _) => {
if let ExprKind::Path(ref qpath) = path.kind {
match_qpath(qpath, &paths::REPEAT).into()
} else {
@@ -215,7 +215,7 @@ const INFINITE_COLLECTORS: [&[&str]; 8] = [
fn complete_infinite_iter(cx: &LateContext<'_>, expr: &Expr<'_>) -> Finiteness {
match expr.kind {
- ExprKind::MethodCall(ref method, _, ref args, _) => {
+ ExprKind::MethodCall(method, _, args, _) => {
for &(name, len) in &COMPLETING_METHODS {
if method.ident.name.as_str() == name && args.len() == len {
return is_infinite(cx, &args[0]);
@@ -240,7 +240,7 @@ fn complete_infinite_iter(cx: &LateContext<'_>, expr: &Expr<'_>) -> Finiteness {
}
}
},
- ExprKind::Binary(op, ref l, ref r) => {
+ ExprKind::Binary(op, l, r) => {
if op.node.is_comparison() {
return is_infinite(cx, l).and(is_infinite(cx, r)).and(MaybeInfinite);
}
diff --git a/clippy_lints/src/invalid_upcast_comparisons.rs b/clippy_lints/src/invalid_upcast_comparisons.rs
index d183fc41f315..c67c02eefa5f 100644
--- a/clippy_lints/src/invalid_upcast_comparisons.rs
+++ b/clippy_lints/src/invalid_upcast_comparisons.rs
@@ -86,7 +86,7 @@ impl Ord for FullInt {
}
fn numeric_cast_precast_bounds<'a>(cx: &LateContext<'_>, expr: &'a Expr<'_>) -> Option<(FullInt, FullInt)> {
- if let ExprKind::Cast(ref cast_exp, _) = expr.kind {
+ if let ExprKind::Cast(cast_exp, _) = expr.kind {
let pre_cast_ty = cx.typeck_results().expr_ty(cast_exp);
let cast_ty = cx.typeck_results().expr_ty(expr);
// if it's a cast from i32 to u32 wrapping will invalidate all these checks
@@ -131,7 +131,7 @@ fn node_as_const_fullint<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) ->
}
fn err_upcast_comparison(cx: &LateContext<'_>, span: Span, expr: &Expr<'_>, always: bool) {
- if let ExprKind::Cast(ref cast_val, _) = expr.kind {
+ if let ExprKind::Cast(cast_val, _) = expr.kind {
span_lint(
cx,
INVALID_UPCAST_COMPARISONS,
@@ -203,7 +203,7 @@ fn upcast_comparison_bounds_err<'tcx>(
impl<'tcx> LateLintPass<'tcx> for InvalidUpcastComparisons {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::Binary(ref cmp, ref lhs, ref rhs) = expr.kind {
+ if let ExprKind::Binary(ref cmp, lhs, rhs) = expr.kind {
let normalized = comparisons::normalize_comparison(cmp.node, lhs, rhs);
let (rel, normalized_lhs, normalized_rhs) = if let Some(val) = normalized {
val
diff --git a/clippy_lints/src/large_enum_variant.rs b/clippy_lints/src/large_enum_variant.rs
index 76584dc18222..f166748d86b8 100644
--- a/clippy_lints/src/large_enum_variant.rs
+++ b/clippy_lints/src/large_enum_variant.rs
@@ -113,7 +113,7 @@ impl<'tcx> LateLintPass<'tcx> for LargeEnumVariant {
);
if variant.fields.len() == 1 {
let span = match def.variants[i].data {
- VariantData::Struct(ref fields, ..) | VariantData::Tuple(ref fields, ..) => {
+ VariantData::Struct(fields, ..) | VariantData::Tuple(fields, ..) => {
fields[0].ty.span
},
VariantData::Unit(..) => unreachable!(),
diff --git a/clippy_lints/src/len_zero.rs b/clippy_lints/src/len_zero.rs
index 78152ad90199..bb57adff7bea 100644
--- a/clippy_lints/src/len_zero.rs
+++ b/clippy_lints/src/len_zero.rs
@@ -121,7 +121,7 @@ impl<'tcx> LateLintPass<'tcx> for LenZero {
return;
}
- if let ItemKind::Trait(_, _, _, _, ref trait_items) = item.kind {
+ if let ItemKind::Trait(_, _, _, _, trait_items) = item.kind {
check_trait_items(cx, item, trait_items);
}
}
@@ -162,7 +162,7 @@ impl<'tcx> LateLintPass<'tcx> for LenZero {
return;
}
- if let ExprKind::Binary(Spanned { node: cmp, .. }, ref left, ref right) = expr.kind {
+ if let ExprKind::Binary(Spanned { node: cmp, .. }, left, right) = expr.kind {
match cmp {
BinOpKind::Eq => {
check_cmp(cx, expr.span, left, right, "", 0); // len == 0
@@ -372,8 +372,7 @@ fn check_for_is_empty(
}
fn check_cmp(cx: &LateContext<'_>, span: Span, method: &Expr<'_>, lit: &Expr<'_>, op: &str, compare_to: u32) {
- if let (&ExprKind::MethodCall(ref method_path, _, ref args, _), &ExprKind::Lit(ref lit)) = (&method.kind, &lit.kind)
- {
+ if let (&ExprKind::MethodCall(method_path, _, args, _), &ExprKind::Lit(ref lit)) = (&method.kind, &lit.kind) {
// check if we are in an is_empty() method
if let Some(name) = get_item_name(cx, method) {
if name.as_str() == "is_empty" {
@@ -451,7 +450,7 @@ fn is_empty_string(expr: &Expr<'_>) -> bool {
}
fn is_empty_array(expr: &Expr<'_>) -> bool {
- if let ExprKind::Array(ref arr) = expr.kind {
+ if let ExprKind::Array(arr) = expr.kind {
return arr.is_empty();
}
false
@@ -480,17 +479,17 @@ fn has_is_empty(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
cx.tcx
.associated_items(*imp)
.in_definition_order()
- .any(|item| is_is_empty(cx, &item))
+ .any(|item| is_is_empty(cx, item))
})
}
let ty = &cx.typeck_results().expr_ty(expr).peel_refs();
match ty.kind() {
- ty::Dynamic(ref tt, ..) => tt.principal().map_or(false, |principal| {
+ ty::Dynamic(tt, ..) => tt.principal().map_or(false, |principal| {
cx.tcx
.associated_items(principal.def_id())
.in_definition_order()
- .any(|item| is_is_empty(cx, &item))
+ .any(|item| is_is_empty(cx, item))
}),
ty::Projection(ref proj) => has_is_empty_impl(cx, proj.item_def_id),
ty::Adt(id, _) => has_is_empty_impl(cx, id.did),
diff --git a/clippy_lints/src/let_if_seq.rs b/clippy_lints/src/let_if_seq.rs
index 2d7d9c9befbb..67eae4d87bbd 100644
--- a/clippy_lints/src/let_if_seq.rs
+++ b/clippy_lints/src/let_if_seq.rs
@@ -61,13 +61,13 @@ impl<'tcx> LateLintPass<'tcx> for LetIfSeq {
while let Some(stmt) = it.next() {
if_chain! {
if let Some(expr) = it.peek();
- if let hir::StmtKind::Local(ref local) = stmt.kind;
+ if let hir::StmtKind::Local(local) = stmt.kind;
if let hir::PatKind::Binding(mode, canonical_id, ident, None) = local.pat.kind;
- if let hir::StmtKind::Expr(ref if_) = expr.kind;
- if let hir::ExprKind::If(ref cond, ref then, ref else_) = if_.kind;
+ if let hir::StmtKind::Expr(if_) = expr.kind;
+ if let hir::ExprKind::If(cond, then, ref else_) = if_.kind;
let mut used_visitor = LocalUsedVisitor::new(cx, canonical_id);
if !used_visitor.check_expr(cond);
- if let hir::ExprKind::Block(ref then, _) = then.kind;
+ if let hir::ExprKind::Block(then, _) = then.kind;
if let Some(value) = check_assign(cx, canonical_id, &*then);
if !used_visitor.check_expr(value);
then {
@@ -79,20 +79,20 @@ impl<'tcx> LateLintPass<'tcx> for LetIfSeq {
);
if has_interior_mutability { return; }
- let (default_multi_stmts, default) = if let Some(ref else_) = *else_ {
- if let hir::ExprKind::Block(ref else_, _) = else_.kind {
+ let (default_multi_stmts, default) = if let Some(else_) = *else_ {
+ if let hir::ExprKind::Block(else_, _) = else_.kind {
if let Some(default) = check_assign(cx, canonical_id, else_) {
(else_.stmts.len() > 1, default)
- } else if let Some(ref default) = local.init {
- (true, &**default)
+ } else if let Some(default) = local.init {
+ (true, default)
} else {
continue;
}
} else {
continue;
}
- } else if let Some(ref default) = local.init {
- (false, &**default)
+ } else if let Some(default) = local.init {
+ (false, default)
} else {
continue;
};
@@ -144,8 +144,8 @@ fn check_assign<'tcx>(
if_chain! {
if block.expr.is_none();
if let Some(expr) = block.stmts.iter().last();
- if let hir::StmtKind::Semi(ref expr) = expr.kind;
- if let hir::ExprKind::Assign(ref var, ref value, _) = expr.kind;
+ if let hir::StmtKind::Semi(expr) = expr.kind;
+ if let hir::ExprKind::Assign(var, value, _) = expr.kind;
if path_to_local_id(var, decl);
then {
let mut v = LocalUsedVisitor::new(cx, decl);
diff --git a/clippy_lints/src/let_underscore.rs b/clippy_lints/src/let_underscore.rs
index 7e3a76ded2cf..17e23781db7d 100644
--- a/clippy_lints/src/let_underscore.rs
+++ b/clippy_lints/src/let_underscore.rs
@@ -116,7 +116,7 @@ impl<'tcx> LateLintPass<'tcx> for LetUnderscore {
if_chain! {
if let PatKind::Wild = local.pat.kind;
- if let Some(ref init) = local.init;
+ if let Some(init) = local.init;
then {
let init_ty = cx.typeck_results().expr_ty(init);
let contains_sync_guard = init_ty.walk().any(|inner| match inner.unpack() {
diff --git a/clippy_lints/src/lib.rs b/clippy_lints/src/lib.rs
index 43e89c2475f3..cd92b551abd6 100644
--- a/clippy_lints/src/lib.rs
+++ b/clippy_lints/src/lib.rs
@@ -541,482 +541,482 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
// begin register lints, do not remove this comment, it’s used in `update_lints`
store.register_lints(&[
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::CLIPPY_LINTS_INTERNAL,
+ utils::internal_lints::CLIPPY_LINTS_INTERNAL,
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::COLLAPSIBLE_SPAN_LINT_CALLS,
+ utils::internal_lints::COLLAPSIBLE_SPAN_LINT_CALLS,
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::COMPILER_LINT_FUNCTIONS,
+ utils::internal_lints::COMPILER_LINT_FUNCTIONS,
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::DEFAULT_LINT,
+ utils::internal_lints::DEFAULT_LINT,
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::IF_CHAIN_STYLE,
+ utils::internal_lints::IF_CHAIN_STYLE,
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::INTERNING_DEFINED_SYMBOL,
+ utils::internal_lints::INTERNING_DEFINED_SYMBOL,
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::INVALID_PATHS,
+ utils::internal_lints::INVALID_PATHS,
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::LINT_WITHOUT_LINT_PASS,
+ utils::internal_lints::LINT_WITHOUT_LINT_PASS,
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::MATCH_TYPE_ON_DIAGNOSTIC_ITEM,
+ utils::internal_lints::MATCH_TYPE_ON_DIAGNOSTIC_ITEM,
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::OUTER_EXPN_EXPN_DATA,
+ utils::internal_lints::OUTER_EXPN_EXPN_DATA,
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::PRODUCE_ICE,
+ utils::internal_lints::PRODUCE_ICE,
#[cfg(feature = "internal-lints")]
- &utils::internal_lints::UNNECESSARY_SYMBOL_STR,
- &absurd_extreme_comparisons::ABSURD_EXTREME_COMPARISONS,
- &approx_const::APPROX_CONSTANT,
- &arithmetic::FLOAT_ARITHMETIC,
- &arithmetic::INTEGER_ARITHMETIC,
- &as_conversions::AS_CONVERSIONS,
- &asm_syntax::INLINE_ASM_X86_ATT_SYNTAX,
- &asm_syntax::INLINE_ASM_X86_INTEL_SYNTAX,
- &assertions_on_constants::ASSERTIONS_ON_CONSTANTS,
- &assign_ops::ASSIGN_OP_PATTERN,
- &assign_ops::MISREFACTORED_ASSIGN_OP,
- &async_yields_async::ASYNC_YIELDS_ASYNC,
- &atomic_ordering::INVALID_ATOMIC_ORDERING,
- &attrs::BLANKET_CLIPPY_RESTRICTION_LINTS,
- &attrs::DEPRECATED_CFG_ATTR,
- &attrs::DEPRECATED_SEMVER,
- &attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
- &attrs::INLINE_ALWAYS,
- &attrs::MISMATCHED_TARGET_OS,
- &attrs::USELESS_ATTRIBUTE,
- &await_holding_invalid::AWAIT_HOLDING_LOCK,
- &await_holding_invalid::AWAIT_HOLDING_REFCELL_REF,
- &bit_mask::BAD_BIT_MASK,
- &bit_mask::INEFFECTIVE_BIT_MASK,
- &bit_mask::VERBOSE_BIT_MASK,
- &blacklisted_name::BLACKLISTED_NAME,
- &blocks_in_if_conditions::BLOCKS_IN_IF_CONDITIONS,
- &booleans::LOGIC_BUG,
- &booleans::NONMINIMAL_BOOL,
- &bytecount::NAIVE_BYTECOUNT,
- &cargo_common_metadata::CARGO_COMMON_METADATA,
- &case_sensitive_file_extension_comparisons::CASE_SENSITIVE_FILE_EXTENSION_COMPARISONS,
- &casts::CAST_LOSSLESS,
- &casts::CAST_POSSIBLE_TRUNCATION,
- &casts::CAST_POSSIBLE_WRAP,
- &casts::CAST_PRECISION_LOSS,
- &casts::CAST_PTR_ALIGNMENT,
- &casts::CAST_REF_TO_MUT,
- &casts::CAST_SIGN_LOSS,
- &casts::CHAR_LIT_AS_U8,
- &casts::FN_TO_NUMERIC_CAST,
- &casts::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
- &casts::PTR_AS_PTR,
- &casts::UNNECESSARY_CAST,
- &checked_conversions::CHECKED_CONVERSIONS,
- &cognitive_complexity::COGNITIVE_COMPLEXITY,
- &collapsible_if::COLLAPSIBLE_ELSE_IF,
- &collapsible_if::COLLAPSIBLE_IF,
- &collapsible_match::COLLAPSIBLE_MATCH,
- &comparison_chain::COMPARISON_CHAIN,
- &copies::BRANCHES_SHARING_CODE,
- &copies::IFS_SAME_COND,
- &copies::IF_SAME_THEN_ELSE,
- &copies::SAME_FUNCTIONS_IN_IF_CONDITION,
- ©_iterator::COPY_ITERATOR,
- &create_dir::CREATE_DIR,
- &dbg_macro::DBG_MACRO,
- &default::DEFAULT_TRAIT_ACCESS,
- &default::FIELD_REASSIGN_WITH_DEFAULT,
- &default_numeric_fallback::DEFAULT_NUMERIC_FALLBACK,
- &dereference::EXPLICIT_DEREF_METHODS,
- &derive::DERIVE_HASH_XOR_EQ,
- &derive::DERIVE_ORD_XOR_PARTIAL_ORD,
- &derive::EXPL_IMPL_CLONE_ON_COPY,
- &derive::UNSAFE_DERIVE_DESERIALIZE,
- &disallowed_method::DISALLOWED_METHOD,
- &doc::DOC_MARKDOWN,
- &doc::MISSING_ERRORS_DOC,
- &doc::MISSING_PANICS_DOC,
- &doc::MISSING_SAFETY_DOC,
- &doc::NEEDLESS_DOCTEST_MAIN,
- &double_comparison::DOUBLE_COMPARISONS,
- &double_parens::DOUBLE_PARENS,
- &drop_forget_ref::DROP_COPY,
- &drop_forget_ref::DROP_REF,
- &drop_forget_ref::FORGET_COPY,
- &drop_forget_ref::FORGET_REF,
- &duration_subsec::DURATION_SUBSEC,
- &else_if_without_else::ELSE_IF_WITHOUT_ELSE,
- &empty_enum::EMPTY_ENUM,
- &entry::MAP_ENTRY,
- &enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
- &enum_variants::ENUM_VARIANT_NAMES,
- &enum_variants::MODULE_INCEPTION,
- &enum_variants::MODULE_NAME_REPETITIONS,
- &enum_variants::PUB_ENUM_VARIANT_NAMES,
- &eq_op::EQ_OP,
- &eq_op::OP_REF,
- &erasing_op::ERASING_OP,
- &escape::BOXED_LOCAL,
- &eta_reduction::REDUNDANT_CLOSURE,
- &eta_reduction::REDUNDANT_CLOSURE_FOR_METHOD_CALLS,
- &eval_order_dependence::DIVERGING_SUB_EXPRESSION,
- &eval_order_dependence::EVAL_ORDER_DEPENDENCE,
- &excessive_bools::FN_PARAMS_EXCESSIVE_BOOLS,
- &excessive_bools::STRUCT_EXCESSIVE_BOOLS,
- &exhaustive_items::EXHAUSTIVE_ENUMS,
- &exhaustive_items::EXHAUSTIVE_STRUCTS,
- &exit::EXIT,
- &explicit_write::EXPLICIT_WRITE,
- &fallible_impl_from::FALLIBLE_IMPL_FROM,
- &float_equality_without_abs::FLOAT_EQUALITY_WITHOUT_ABS,
- &float_literal::EXCESSIVE_PRECISION,
- &float_literal::LOSSY_FLOAT_LITERAL,
- &floating_point_arithmetic::IMPRECISE_FLOPS,
- &floating_point_arithmetic::SUBOPTIMAL_FLOPS,
- &format::USELESS_FORMAT,
- &formatting::POSSIBLE_MISSING_COMMA,
- &formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
- &formatting::SUSPICIOUS_ELSE_FORMATTING,
- &formatting::SUSPICIOUS_UNARY_OP_FORMATTING,
- &from_over_into::FROM_OVER_INTO,
- &from_str_radix_10::FROM_STR_RADIX_10,
- &functions::DOUBLE_MUST_USE,
- &functions::MUST_USE_CANDIDATE,
- &functions::MUST_USE_UNIT,
- &functions::NOT_UNSAFE_PTR_ARG_DEREF,
- &functions::RESULT_UNIT_ERR,
- &functions::TOO_MANY_ARGUMENTS,
- &functions::TOO_MANY_LINES,
- &future_not_send::FUTURE_NOT_SEND,
- &get_last_with_len::GET_LAST_WITH_LEN,
- &identity_op::IDENTITY_OP,
- &if_let_mutex::IF_LET_MUTEX,
- &if_let_some_result::IF_LET_SOME_RESULT,
- &if_not_else::IF_NOT_ELSE,
- &if_then_some_else_none::IF_THEN_SOME_ELSE_NONE,
- &implicit_hasher::IMPLICIT_HASHER,
- &implicit_return::IMPLICIT_RETURN,
- &implicit_saturating_sub::IMPLICIT_SATURATING_SUB,
- &inconsistent_struct_constructor::INCONSISTENT_STRUCT_CONSTRUCTOR,
- &indexing_slicing::INDEXING_SLICING,
- &indexing_slicing::OUT_OF_BOUNDS_INDEXING,
- &infinite_iter::INFINITE_ITER,
- &infinite_iter::MAYBE_INFINITE_ITER,
- &inherent_impl::MULTIPLE_INHERENT_IMPL,
- &inherent_to_string::INHERENT_TO_STRING,
- &inherent_to_string::INHERENT_TO_STRING_SHADOW_DISPLAY,
- &inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
- &int_plus_one::INT_PLUS_ONE,
- &integer_division::INTEGER_DIVISION,
- &invalid_upcast_comparisons::INVALID_UPCAST_COMPARISONS,
- &items_after_statements::ITEMS_AFTER_STATEMENTS,
- &large_const_arrays::LARGE_CONST_ARRAYS,
- &large_enum_variant::LARGE_ENUM_VARIANT,
- &large_stack_arrays::LARGE_STACK_ARRAYS,
- &len_zero::COMPARISON_TO_EMPTY,
- &len_zero::LEN_WITHOUT_IS_EMPTY,
- &len_zero::LEN_ZERO,
- &let_if_seq::USELESS_LET_IF_SEQ,
- &let_underscore::LET_UNDERSCORE_DROP,
- &let_underscore::LET_UNDERSCORE_LOCK,
- &let_underscore::LET_UNDERSCORE_MUST_USE,
- &lifetimes::EXTRA_UNUSED_LIFETIMES,
- &lifetimes::NEEDLESS_LIFETIMES,
- &literal_representation::DECIMAL_LITERAL_REPRESENTATION,
- &literal_representation::INCONSISTENT_DIGIT_GROUPING,
- &literal_representation::LARGE_DIGIT_GROUPS,
- &literal_representation::MISTYPED_LITERAL_SUFFIXES,
- &literal_representation::UNREADABLE_LITERAL,
- &literal_representation::UNUSUAL_BYTE_GROUPINGS,
- &loops::EMPTY_LOOP,
- &loops::EXPLICIT_COUNTER_LOOP,
- &loops::EXPLICIT_INTO_ITER_LOOP,
- &loops::EXPLICIT_ITER_LOOP,
- &loops::FOR_KV_MAP,
- &loops::FOR_LOOPS_OVER_FALLIBLES,
- &loops::ITER_NEXT_LOOP,
- &loops::MANUAL_FLATTEN,
- &loops::MANUAL_MEMCPY,
- &loops::MUT_RANGE_BOUND,
- &loops::NEEDLESS_COLLECT,
- &loops::NEEDLESS_RANGE_LOOP,
- &loops::NEVER_LOOP,
- &loops::SAME_ITEM_PUSH,
- &loops::SINGLE_ELEMENT_LOOP,
- &loops::WHILE_IMMUTABLE_CONDITION,
- &loops::WHILE_LET_LOOP,
- &loops::WHILE_LET_ON_ITERATOR,
- ¯o_use::MACRO_USE_IMPORTS,
- &main_recursion::MAIN_RECURSION,
- &manual_async_fn::MANUAL_ASYNC_FN,
- &manual_map::MANUAL_MAP,
- &manual_non_exhaustive::MANUAL_NON_EXHAUSTIVE,
- &manual_ok_or::MANUAL_OK_OR,
- &manual_strip::MANUAL_STRIP,
- &manual_unwrap_or::MANUAL_UNWRAP_OR,
- &map_clone::MAP_CLONE,
- &map_err_ignore::MAP_ERR_IGNORE,
- &map_identity::MAP_IDENTITY,
- &map_unit_fn::OPTION_MAP_UNIT_FN,
- &map_unit_fn::RESULT_MAP_UNIT_FN,
- &match_on_vec_items::MATCH_ON_VEC_ITEMS,
- &matches::INFALLIBLE_DESTRUCTURING_MATCH,
- &matches::MATCH_AS_REF,
- &matches::MATCH_BOOL,
- &matches::MATCH_LIKE_MATCHES_MACRO,
- &matches::MATCH_OVERLAPPING_ARM,
- &matches::MATCH_REF_PATS,
- &matches::MATCH_SAME_ARMS,
- &matches::MATCH_SINGLE_BINDING,
- &matches::MATCH_WILDCARD_FOR_SINGLE_VARIANTS,
- &matches::MATCH_WILD_ERR_ARM,
- &matches::REDUNDANT_PATTERN_MATCHING,
- &matches::REST_PAT_IN_FULLY_BOUND_STRUCTS,
- &matches::SINGLE_MATCH,
- &matches::SINGLE_MATCH_ELSE,
- &matches::WILDCARD_ENUM_MATCH_ARM,
- &matches::WILDCARD_IN_OR_PATTERNS,
- &mem_discriminant::MEM_DISCRIMINANT_NON_ENUM,
- &mem_forget::MEM_FORGET,
- &mem_replace::MEM_REPLACE_OPTION_WITH_NONE,
- &mem_replace::MEM_REPLACE_WITH_DEFAULT,
- &mem_replace::MEM_REPLACE_WITH_UNINIT,
- &methods::BIND_INSTEAD_OF_MAP,
- &methods::BYTES_NTH,
- &methods::CHARS_LAST_CMP,
- &methods::CHARS_NEXT_CMP,
- &methods::CLONE_DOUBLE_REF,
- &methods::CLONE_ON_COPY,
- &methods::CLONE_ON_REF_PTR,
- &methods::EXPECT_FUN_CALL,
- &methods::EXPECT_USED,
- &methods::FILETYPE_IS_FILE,
- &methods::FILTER_MAP,
- &methods::FILTER_MAP_IDENTITY,
- &methods::FILTER_MAP_NEXT,
- &methods::FILTER_NEXT,
- &methods::FLAT_MAP_IDENTITY,
- &methods::FROM_ITER_INSTEAD_OF_COLLECT,
- &methods::GET_UNWRAP,
- &methods::IMPLICIT_CLONE,
- &methods::INEFFICIENT_TO_STRING,
- &methods::INSPECT_FOR_EACH,
- &methods::INTO_ITER_ON_REF,
- &methods::ITERATOR_STEP_BY_ZERO,
- &methods::ITER_CLONED_COLLECT,
- &methods::ITER_COUNT,
- &methods::ITER_NEXT_SLICE,
- &methods::ITER_NTH,
- &methods::ITER_NTH_ZERO,
- &methods::ITER_SKIP_NEXT,
- &methods::MANUAL_FILTER_MAP,
- &methods::MANUAL_FIND_MAP,
- &methods::MANUAL_SATURATING_ARITHMETIC,
- &methods::MAP_COLLECT_RESULT_UNIT,
- &methods::MAP_FLATTEN,
- &methods::MAP_UNWRAP_OR,
- &methods::NEW_RET_NO_SELF,
- &methods::OK_EXPECT,
- &methods::OPTION_AS_REF_DEREF,
- &methods::OPTION_FILTER_MAP,
- &methods::OPTION_MAP_OR_NONE,
- &methods::OR_FUN_CALL,
- &methods::RESULT_MAP_OR_INTO_OPTION,
- &methods::SEARCH_IS_SOME,
- &methods::SHOULD_IMPLEMENT_TRAIT,
- &methods::SINGLE_CHAR_ADD_STR,
- &methods::SINGLE_CHAR_PATTERN,
- &methods::SKIP_WHILE_NEXT,
- &methods::STRING_EXTEND_CHARS,
- &methods::SUSPICIOUS_MAP,
- &methods::UNINIT_ASSUMED_INIT,
- &methods::UNNECESSARY_FILTER_MAP,
- &methods::UNNECESSARY_FOLD,
- &methods::UNNECESSARY_LAZY_EVALUATIONS,
- &methods::UNWRAP_USED,
- &methods::USELESS_ASREF,
- &methods::WRONG_PUB_SELF_CONVENTION,
- &methods::WRONG_SELF_CONVENTION,
- &methods::ZST_OFFSET,
- &minmax::MIN_MAX,
- &misc::CMP_NAN,
- &misc::CMP_OWNED,
- &misc::FLOAT_CMP,
- &misc::FLOAT_CMP_CONST,
- &misc::MODULO_ONE,
- &misc::SHORT_CIRCUIT_STATEMENT,
- &misc::TOPLEVEL_REF_ARG,
- &misc::USED_UNDERSCORE_BINDING,
- &misc::ZERO_PTR,
- &misc_early::BUILTIN_TYPE_SHADOW,
- &misc_early::DOUBLE_NEG,
- &misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
- &misc_early::MIXED_CASE_HEX_LITERALS,
- &misc_early::REDUNDANT_PATTERN,
- &misc_early::UNNEEDED_FIELD_PATTERN,
- &misc_early::UNNEEDED_WILDCARD_PATTERN,
- &misc_early::UNSEPARATED_LITERAL_SUFFIX,
- &misc_early::ZERO_PREFIXED_LITERAL,
- &missing_const_for_fn::MISSING_CONST_FOR_FN,
- &missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
- &missing_inline::MISSING_INLINE_IN_PUBLIC_ITEMS,
- &modulo_arithmetic::MODULO_ARITHMETIC,
- &multiple_crate_versions::MULTIPLE_CRATE_VERSIONS,
- &mut_key::MUTABLE_KEY_TYPE,
- &mut_mut::MUT_MUT,
- &mut_mutex_lock::MUT_MUTEX_LOCK,
- &mut_reference::UNNECESSARY_MUT_PASSED,
- &mutable_debug_assertion::DEBUG_ASSERT_WITH_MUT_CALL,
- &mutex_atomic::MUTEX_ATOMIC,
- &mutex_atomic::MUTEX_INTEGER,
- &needless_arbitrary_self_type::NEEDLESS_ARBITRARY_SELF_TYPE,
- &needless_bool::BOOL_COMPARISON,
- &needless_bool::NEEDLESS_BOOL,
- &needless_borrow::NEEDLESS_BORROW,
- &needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
- &needless_continue::NEEDLESS_CONTINUE,
- &needless_for_each::NEEDLESS_FOR_EACH,
- &needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
- &needless_question_mark::NEEDLESS_QUESTION_MARK,
- &needless_update::NEEDLESS_UPDATE,
- &neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
- &neg_multiply::NEG_MULTIPLY,
- &new_without_default::NEW_WITHOUT_DEFAULT,
- &no_effect::NO_EFFECT,
- &no_effect::UNNECESSARY_OPERATION,
- &non_copy_const::BORROW_INTERIOR_MUTABLE_CONST,
- &non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST,
- &non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
- &non_expressive_names::MANY_SINGLE_CHAR_NAMES,
- &non_expressive_names::SIMILAR_NAMES,
- &non_octal_unix_permissions::NON_OCTAL_UNIX_PERMISSIONS,
- &open_options::NONSENSICAL_OPEN_OPTIONS,
- &option_env_unwrap::OPTION_ENV_UNWRAP,
- &option_if_let_else::OPTION_IF_LET_ELSE,
- &overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
- &panic_in_result_fn::PANIC_IN_RESULT_FN,
- &panic_unimplemented::PANIC,
- &panic_unimplemented::TODO,
- &panic_unimplemented::UNIMPLEMENTED,
- &panic_unimplemented::UNREACHABLE,
- &partialeq_ne_impl::PARTIALEQ_NE_IMPL,
- &pass_by_ref_or_value::LARGE_TYPES_PASSED_BY_VALUE,
- &pass_by_ref_or_value::TRIVIALLY_COPY_PASS_BY_REF,
- &path_buf_push_overwrite::PATH_BUF_PUSH_OVERWRITE,
- &pattern_type_mismatch::PATTERN_TYPE_MISMATCH,
- &precedence::PRECEDENCE,
- &ptr::CMP_NULL,
- &ptr::MUT_FROM_REF,
- &ptr::PTR_ARG,
- &ptr_eq::PTR_EQ,
- &ptr_offset_with_cast::PTR_OFFSET_WITH_CAST,
- &question_mark::QUESTION_MARK,
- &ranges::MANUAL_RANGE_CONTAINS,
- &ranges::RANGE_MINUS_ONE,
- &ranges::RANGE_PLUS_ONE,
- &ranges::RANGE_ZIP_WITH_LEN,
- &ranges::REVERSED_EMPTY_RANGES,
- &redundant_clone::REDUNDANT_CLONE,
- &redundant_closure_call::REDUNDANT_CLOSURE_CALL,
- &redundant_else::REDUNDANT_ELSE,
- &redundant_field_names::REDUNDANT_FIELD_NAMES,
- &redundant_pub_crate::REDUNDANT_PUB_CRATE,
- &redundant_slicing::REDUNDANT_SLICING,
- &redundant_static_lifetimes::REDUNDANT_STATIC_LIFETIMES,
- &ref_option_ref::REF_OPTION_REF,
- &reference::DEREF_ADDROF,
- &reference::REF_IN_DEREF,
- ®ex::INVALID_REGEX,
- ®ex::TRIVIAL_REGEX,
- &repeat_once::REPEAT_ONCE,
- &returns::LET_AND_RETURN,
- &returns::NEEDLESS_RETURN,
- &self_assignment::SELF_ASSIGNMENT,
- &semicolon_if_nothing_returned::SEMICOLON_IF_NOTHING_RETURNED,
- &serde_api::SERDE_API_MISUSE,
- &shadow::SHADOW_REUSE,
- &shadow::SHADOW_SAME,
- &shadow::SHADOW_UNRELATED,
- &single_component_path_imports::SINGLE_COMPONENT_PATH_IMPORTS,
- &size_of_in_element_count::SIZE_OF_IN_ELEMENT_COUNT,
- &slow_vector_initialization::SLOW_VECTOR_INITIALIZATION,
- &stable_sort_primitive::STABLE_SORT_PRIMITIVE,
- &strings::STRING_ADD,
- &strings::STRING_ADD_ASSIGN,
- &strings::STRING_FROM_UTF8_AS_BYTES,
- &strings::STRING_LIT_AS_BYTES,
- &strings::STRING_TO_STRING,
- &strings::STR_TO_STRING,
- &suspicious_operation_groupings::SUSPICIOUS_OPERATION_GROUPINGS,
- &suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
- &suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
- &swap::ALMOST_SWAPPED,
- &swap::MANUAL_SWAP,
- &tabs_in_doc_comments::TABS_IN_DOC_COMMENTS,
- &temporary_assignment::TEMPORARY_ASSIGNMENT,
- &to_digit_is_some::TO_DIGIT_IS_SOME,
- &to_string_in_display::TO_STRING_IN_DISPLAY,
- &trait_bounds::TRAIT_DUPLICATION_IN_BOUNDS,
- &trait_bounds::TYPE_REPETITION_IN_BOUNDS,
- &transmute::CROSSPOINTER_TRANSMUTE,
- &transmute::TRANSMUTES_EXPRESSIBLE_AS_PTR_CASTS,
- &transmute::TRANSMUTE_BYTES_TO_STR,
- &transmute::TRANSMUTE_FLOAT_TO_INT,
- &transmute::TRANSMUTE_INT_TO_BOOL,
- &transmute::TRANSMUTE_INT_TO_CHAR,
- &transmute::TRANSMUTE_INT_TO_FLOAT,
- &transmute::TRANSMUTE_PTR_TO_PTR,
- &transmute::TRANSMUTE_PTR_TO_REF,
- &transmute::UNSOUND_COLLECTION_TRANSMUTE,
- &transmute::USELESS_TRANSMUTE,
- &transmute::WRONG_TRANSMUTE,
- &transmuting_null::TRANSMUTING_NULL,
- &try_err::TRY_ERR,
- &types::BORROWED_BOX,
- &types::BOX_VEC,
- &types::LINKEDLIST,
- &types::OPTION_OPTION,
- &types::RC_BUFFER,
- &types::REDUNDANT_ALLOCATION,
- &types::TYPE_COMPLEXITY,
- &types::VEC_BOX,
- &undropped_manually_drops::UNDROPPED_MANUALLY_DROPS,
- &unicode::INVISIBLE_CHARACTERS,
- &unicode::NON_ASCII_LITERAL,
- &unicode::UNICODE_NOT_NFC,
- &unit_return_expecting_ord::UNIT_RETURN_EXPECTING_ORD,
- &unit_types::LET_UNIT_VALUE,
- &unit_types::UNIT_ARG,
- &unit_types::UNIT_CMP,
- &unnamed_address::FN_ADDRESS_COMPARISONS,
- &unnamed_address::VTABLE_ADDRESS_COMPARISONS,
- &unnecessary_sort_by::UNNECESSARY_SORT_BY,
- &unnecessary_wraps::UNNECESSARY_WRAPS,
- &unnested_or_patterns::UNNESTED_OR_PATTERNS,
- &unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
- &unused_io_amount::UNUSED_IO_AMOUNT,
- &unused_self::UNUSED_SELF,
- &unused_unit::UNUSED_UNIT,
- &unwrap::PANICKING_UNWRAP,
- &unwrap::UNNECESSARY_UNWRAP,
- &unwrap_in_result::UNWRAP_IN_RESULT,
- &upper_case_acronyms::UPPER_CASE_ACRONYMS,
- &use_self::USE_SELF,
- &useless_conversion::USELESS_CONVERSION,
- &vec::USELESS_VEC,
- &vec_init_then_push::VEC_INIT_THEN_PUSH,
- &vec_resize_to_zero::VEC_RESIZE_TO_ZERO,
- &verbose_file_reads::VERBOSE_FILE_READS,
- &wildcard_dependencies::WILDCARD_DEPENDENCIES,
- &wildcard_imports::ENUM_GLOB_USE,
- &wildcard_imports::WILDCARD_IMPORTS,
- &write::PRINTLN_EMPTY_STRING,
- &write::PRINT_LITERAL,
- &write::PRINT_STDERR,
- &write::PRINT_STDOUT,
- &write::PRINT_WITH_NEWLINE,
- &write::USE_DEBUG,
- &write::WRITELN_EMPTY_STRING,
- &write::WRITE_LITERAL,
- &write::WRITE_WITH_NEWLINE,
- &zero_div_zero::ZERO_DIVIDED_BY_ZERO,
- &zero_sized_map_values::ZERO_SIZED_MAP_VALUES,
+ utils::internal_lints::UNNECESSARY_SYMBOL_STR,
+ absurd_extreme_comparisons::ABSURD_EXTREME_COMPARISONS,
+ approx_const::APPROX_CONSTANT,
+ arithmetic::FLOAT_ARITHMETIC,
+ arithmetic::INTEGER_ARITHMETIC,
+ as_conversions::AS_CONVERSIONS,
+ asm_syntax::INLINE_ASM_X86_ATT_SYNTAX,
+ asm_syntax::INLINE_ASM_X86_INTEL_SYNTAX,
+ assertions_on_constants::ASSERTIONS_ON_CONSTANTS,
+ assign_ops::ASSIGN_OP_PATTERN,
+ assign_ops::MISREFACTORED_ASSIGN_OP,
+ async_yields_async::ASYNC_YIELDS_ASYNC,
+ atomic_ordering::INVALID_ATOMIC_ORDERING,
+ attrs::BLANKET_CLIPPY_RESTRICTION_LINTS,
+ attrs::DEPRECATED_CFG_ATTR,
+ attrs::DEPRECATED_SEMVER,
+ attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
+ attrs::INLINE_ALWAYS,
+ attrs::MISMATCHED_TARGET_OS,
+ attrs::USELESS_ATTRIBUTE,
+ await_holding_invalid::AWAIT_HOLDING_LOCK,
+ await_holding_invalid::AWAIT_HOLDING_REFCELL_REF,
+ bit_mask::BAD_BIT_MASK,
+ bit_mask::INEFFECTIVE_BIT_MASK,
+ bit_mask::VERBOSE_BIT_MASK,
+ blacklisted_name::BLACKLISTED_NAME,
+ blocks_in_if_conditions::BLOCKS_IN_IF_CONDITIONS,
+ booleans::LOGIC_BUG,
+ booleans::NONMINIMAL_BOOL,
+ bytecount::NAIVE_BYTECOUNT,
+ cargo_common_metadata::CARGO_COMMON_METADATA,
+ case_sensitive_file_extension_comparisons::CASE_SENSITIVE_FILE_EXTENSION_COMPARISONS,
+ casts::CAST_LOSSLESS,
+ casts::CAST_POSSIBLE_TRUNCATION,
+ casts::CAST_POSSIBLE_WRAP,
+ casts::CAST_PRECISION_LOSS,
+ casts::CAST_PTR_ALIGNMENT,
+ casts::CAST_REF_TO_MUT,
+ casts::CAST_SIGN_LOSS,
+ casts::CHAR_LIT_AS_U8,
+ casts::FN_TO_NUMERIC_CAST,
+ casts::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
+ casts::PTR_AS_PTR,
+ casts::UNNECESSARY_CAST,
+ checked_conversions::CHECKED_CONVERSIONS,
+ cognitive_complexity::COGNITIVE_COMPLEXITY,
+ collapsible_if::COLLAPSIBLE_ELSE_IF,
+ collapsible_if::COLLAPSIBLE_IF,
+ collapsible_match::COLLAPSIBLE_MATCH,
+ comparison_chain::COMPARISON_CHAIN,
+ copies::BRANCHES_SHARING_CODE,
+ copies::IFS_SAME_COND,
+ copies::IF_SAME_THEN_ELSE,
+ copies::SAME_FUNCTIONS_IN_IF_CONDITION,
+ copy_iterator::COPY_ITERATOR,
+ create_dir::CREATE_DIR,
+ dbg_macro::DBG_MACRO,
+ default::DEFAULT_TRAIT_ACCESS,
+ default::FIELD_REASSIGN_WITH_DEFAULT,
+ default_numeric_fallback::DEFAULT_NUMERIC_FALLBACK,
+ dereference::EXPLICIT_DEREF_METHODS,
+ derive::DERIVE_HASH_XOR_EQ,
+ derive::DERIVE_ORD_XOR_PARTIAL_ORD,
+ derive::EXPL_IMPL_CLONE_ON_COPY,
+ derive::UNSAFE_DERIVE_DESERIALIZE,
+ disallowed_method::DISALLOWED_METHOD,
+ doc::DOC_MARKDOWN,
+ doc::MISSING_ERRORS_DOC,
+ doc::MISSING_PANICS_DOC,
+ doc::MISSING_SAFETY_DOC,
+ doc::NEEDLESS_DOCTEST_MAIN,
+ double_comparison::DOUBLE_COMPARISONS,
+ double_parens::DOUBLE_PARENS,
+ drop_forget_ref::DROP_COPY,
+ drop_forget_ref::DROP_REF,
+ drop_forget_ref::FORGET_COPY,
+ drop_forget_ref::FORGET_REF,
+ duration_subsec::DURATION_SUBSEC,
+ else_if_without_else::ELSE_IF_WITHOUT_ELSE,
+ empty_enum::EMPTY_ENUM,
+ entry::MAP_ENTRY,
+ enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
+ enum_variants::ENUM_VARIANT_NAMES,
+ enum_variants::MODULE_INCEPTION,
+ enum_variants::MODULE_NAME_REPETITIONS,
+ enum_variants::PUB_ENUM_VARIANT_NAMES,
+ eq_op::EQ_OP,
+ eq_op::OP_REF,
+ erasing_op::ERASING_OP,
+ escape::BOXED_LOCAL,
+ eta_reduction::REDUNDANT_CLOSURE,
+ eta_reduction::REDUNDANT_CLOSURE_FOR_METHOD_CALLS,
+ eval_order_dependence::DIVERGING_SUB_EXPRESSION,
+ eval_order_dependence::EVAL_ORDER_DEPENDENCE,
+ excessive_bools::FN_PARAMS_EXCESSIVE_BOOLS,
+ excessive_bools::STRUCT_EXCESSIVE_BOOLS,
+ exhaustive_items::EXHAUSTIVE_ENUMS,
+ exhaustive_items::EXHAUSTIVE_STRUCTS,
+ exit::EXIT,
+ explicit_write::EXPLICIT_WRITE,
+ fallible_impl_from::FALLIBLE_IMPL_FROM,
+ float_equality_without_abs::FLOAT_EQUALITY_WITHOUT_ABS,
+ float_literal::EXCESSIVE_PRECISION,
+ float_literal::LOSSY_FLOAT_LITERAL,
+ floating_point_arithmetic::IMPRECISE_FLOPS,
+ floating_point_arithmetic::SUBOPTIMAL_FLOPS,
+ format::USELESS_FORMAT,
+ formatting::POSSIBLE_MISSING_COMMA,
+ formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
+ formatting::SUSPICIOUS_ELSE_FORMATTING,
+ formatting::SUSPICIOUS_UNARY_OP_FORMATTING,
+ from_over_into::FROM_OVER_INTO,
+ from_str_radix_10::FROM_STR_RADIX_10,
+ functions::DOUBLE_MUST_USE,
+ functions::MUST_USE_CANDIDATE,
+ functions::MUST_USE_UNIT,
+ functions::NOT_UNSAFE_PTR_ARG_DEREF,
+ functions::RESULT_UNIT_ERR,
+ functions::TOO_MANY_ARGUMENTS,
+ functions::TOO_MANY_LINES,
+ future_not_send::FUTURE_NOT_SEND,
+ get_last_with_len::GET_LAST_WITH_LEN,
+ identity_op::IDENTITY_OP,
+ if_let_mutex::IF_LET_MUTEX,
+ if_let_some_result::IF_LET_SOME_RESULT,
+ if_not_else::IF_NOT_ELSE,
+ if_then_some_else_none::IF_THEN_SOME_ELSE_NONE,
+ implicit_hasher::IMPLICIT_HASHER,
+ implicit_return::IMPLICIT_RETURN,
+ implicit_saturating_sub::IMPLICIT_SATURATING_SUB,
+ inconsistent_struct_constructor::INCONSISTENT_STRUCT_CONSTRUCTOR,
+ indexing_slicing::INDEXING_SLICING,
+ indexing_slicing::OUT_OF_BOUNDS_INDEXING,
+ infinite_iter::INFINITE_ITER,
+ infinite_iter::MAYBE_INFINITE_ITER,
+ inherent_impl::MULTIPLE_INHERENT_IMPL,
+ inherent_to_string::INHERENT_TO_STRING,
+ inherent_to_string::INHERENT_TO_STRING_SHADOW_DISPLAY,
+ inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
+ int_plus_one::INT_PLUS_ONE,
+ integer_division::INTEGER_DIVISION,
+ invalid_upcast_comparisons::INVALID_UPCAST_COMPARISONS,
+ items_after_statements::ITEMS_AFTER_STATEMENTS,
+ large_const_arrays::LARGE_CONST_ARRAYS,
+ large_enum_variant::LARGE_ENUM_VARIANT,
+ large_stack_arrays::LARGE_STACK_ARRAYS,
+ len_zero::COMPARISON_TO_EMPTY,
+ len_zero::LEN_WITHOUT_IS_EMPTY,
+ len_zero::LEN_ZERO,
+ let_if_seq::USELESS_LET_IF_SEQ,
+ let_underscore::LET_UNDERSCORE_DROP,
+ let_underscore::LET_UNDERSCORE_LOCK,
+ let_underscore::LET_UNDERSCORE_MUST_USE,
+ lifetimes::EXTRA_UNUSED_LIFETIMES,
+ lifetimes::NEEDLESS_LIFETIMES,
+ literal_representation::DECIMAL_LITERAL_REPRESENTATION,
+ literal_representation::INCONSISTENT_DIGIT_GROUPING,
+ literal_representation::LARGE_DIGIT_GROUPS,
+ literal_representation::MISTYPED_LITERAL_SUFFIXES,
+ literal_representation::UNREADABLE_LITERAL,
+ literal_representation::UNUSUAL_BYTE_GROUPINGS,
+ loops::EMPTY_LOOP,
+ loops::EXPLICIT_COUNTER_LOOP,
+ loops::EXPLICIT_INTO_ITER_LOOP,
+ loops::EXPLICIT_ITER_LOOP,
+ loops::FOR_KV_MAP,
+ loops::FOR_LOOPS_OVER_FALLIBLES,
+ loops::ITER_NEXT_LOOP,
+ loops::MANUAL_FLATTEN,
+ loops::MANUAL_MEMCPY,
+ loops::MUT_RANGE_BOUND,
+ loops::NEEDLESS_COLLECT,
+ loops::NEEDLESS_RANGE_LOOP,
+ loops::NEVER_LOOP,
+ loops::SAME_ITEM_PUSH,
+ loops::SINGLE_ELEMENT_LOOP,
+ loops::WHILE_IMMUTABLE_CONDITION,
+ loops::WHILE_LET_LOOP,
+ loops::WHILE_LET_ON_ITERATOR,
+ macro_use::MACRO_USE_IMPORTS,
+ main_recursion::MAIN_RECURSION,
+ manual_async_fn::MANUAL_ASYNC_FN,
+ manual_map::MANUAL_MAP,
+ manual_non_exhaustive::MANUAL_NON_EXHAUSTIVE,
+ manual_ok_or::MANUAL_OK_OR,
+ manual_strip::MANUAL_STRIP,
+ manual_unwrap_or::MANUAL_UNWRAP_OR,
+ map_clone::MAP_CLONE,
+ map_err_ignore::MAP_ERR_IGNORE,
+ map_identity::MAP_IDENTITY,
+ map_unit_fn::OPTION_MAP_UNIT_FN,
+ map_unit_fn::RESULT_MAP_UNIT_FN,
+ match_on_vec_items::MATCH_ON_VEC_ITEMS,
+ matches::INFALLIBLE_DESTRUCTURING_MATCH,
+ matches::MATCH_AS_REF,
+ matches::MATCH_BOOL,
+ matches::MATCH_LIKE_MATCHES_MACRO,
+ matches::MATCH_OVERLAPPING_ARM,
+ matches::MATCH_REF_PATS,
+ matches::MATCH_SAME_ARMS,
+ matches::MATCH_SINGLE_BINDING,
+ matches::MATCH_WILDCARD_FOR_SINGLE_VARIANTS,
+ matches::MATCH_WILD_ERR_ARM,
+ matches::REDUNDANT_PATTERN_MATCHING,
+ matches::REST_PAT_IN_FULLY_BOUND_STRUCTS,
+ matches::SINGLE_MATCH,
+ matches::SINGLE_MATCH_ELSE,
+ matches::WILDCARD_ENUM_MATCH_ARM,
+ matches::WILDCARD_IN_OR_PATTERNS,
+ mem_discriminant::MEM_DISCRIMINANT_NON_ENUM,
+ mem_forget::MEM_FORGET,
+ mem_replace::MEM_REPLACE_OPTION_WITH_NONE,
+ mem_replace::MEM_REPLACE_WITH_DEFAULT,
+ mem_replace::MEM_REPLACE_WITH_UNINIT,
+ methods::BIND_INSTEAD_OF_MAP,
+ methods::BYTES_NTH,
+ methods::CHARS_LAST_CMP,
+ methods::CHARS_NEXT_CMP,
+ methods::CLONE_DOUBLE_REF,
+ methods::CLONE_ON_COPY,
+ methods::CLONE_ON_REF_PTR,
+ methods::EXPECT_FUN_CALL,
+ methods::EXPECT_USED,
+ methods::FILETYPE_IS_FILE,
+ methods::FILTER_MAP,
+ methods::FILTER_MAP_IDENTITY,
+ methods::FILTER_MAP_NEXT,
+ methods::FILTER_NEXT,
+ methods::FLAT_MAP_IDENTITY,
+ methods::FROM_ITER_INSTEAD_OF_COLLECT,
+ methods::GET_UNWRAP,
+ methods::IMPLICIT_CLONE,
+ methods::INEFFICIENT_TO_STRING,
+ methods::INSPECT_FOR_EACH,
+ methods::INTO_ITER_ON_REF,
+ methods::ITERATOR_STEP_BY_ZERO,
+ methods::ITER_CLONED_COLLECT,
+ methods::ITER_COUNT,
+ methods::ITER_NEXT_SLICE,
+ methods::ITER_NTH,
+ methods::ITER_NTH_ZERO,
+ methods::ITER_SKIP_NEXT,
+ methods::MANUAL_FILTER_MAP,
+ methods::MANUAL_FIND_MAP,
+ methods::MANUAL_SATURATING_ARITHMETIC,
+ methods::MAP_COLLECT_RESULT_UNIT,
+ methods::MAP_FLATTEN,
+ methods::MAP_UNWRAP_OR,
+ methods::NEW_RET_NO_SELF,
+ methods::OK_EXPECT,
+ methods::OPTION_AS_REF_DEREF,
+ methods::OPTION_FILTER_MAP,
+ methods::OPTION_MAP_OR_NONE,
+ methods::OR_FUN_CALL,
+ methods::RESULT_MAP_OR_INTO_OPTION,
+ methods::SEARCH_IS_SOME,
+ methods::SHOULD_IMPLEMENT_TRAIT,
+ methods::SINGLE_CHAR_ADD_STR,
+ methods::SINGLE_CHAR_PATTERN,
+ methods::SKIP_WHILE_NEXT,
+ methods::STRING_EXTEND_CHARS,
+ methods::SUSPICIOUS_MAP,
+ methods::UNINIT_ASSUMED_INIT,
+ methods::UNNECESSARY_FILTER_MAP,
+ methods::UNNECESSARY_FOLD,
+ methods::UNNECESSARY_LAZY_EVALUATIONS,
+ methods::UNWRAP_USED,
+ methods::USELESS_ASREF,
+ methods::WRONG_PUB_SELF_CONVENTION,
+ methods::WRONG_SELF_CONVENTION,
+ methods::ZST_OFFSET,
+ minmax::MIN_MAX,
+ misc::CMP_NAN,
+ misc::CMP_OWNED,
+ misc::FLOAT_CMP,
+ misc::FLOAT_CMP_CONST,
+ misc::MODULO_ONE,
+ misc::SHORT_CIRCUIT_STATEMENT,
+ misc::TOPLEVEL_REF_ARG,
+ misc::USED_UNDERSCORE_BINDING,
+ misc::ZERO_PTR,
+ misc_early::BUILTIN_TYPE_SHADOW,
+ misc_early::DOUBLE_NEG,
+ misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
+ misc_early::MIXED_CASE_HEX_LITERALS,
+ misc_early::REDUNDANT_PATTERN,
+ misc_early::UNNEEDED_FIELD_PATTERN,
+ misc_early::UNNEEDED_WILDCARD_PATTERN,
+ misc_early::UNSEPARATED_LITERAL_SUFFIX,
+ misc_early::ZERO_PREFIXED_LITERAL,
+ missing_const_for_fn::MISSING_CONST_FOR_FN,
+ missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
+ missing_inline::MISSING_INLINE_IN_PUBLIC_ITEMS,
+ modulo_arithmetic::MODULO_ARITHMETIC,
+ multiple_crate_versions::MULTIPLE_CRATE_VERSIONS,
+ mut_key::MUTABLE_KEY_TYPE,
+ mut_mut::MUT_MUT,
+ mut_mutex_lock::MUT_MUTEX_LOCK,
+ mut_reference::UNNECESSARY_MUT_PASSED,
+ mutable_debug_assertion::DEBUG_ASSERT_WITH_MUT_CALL,
+ mutex_atomic::MUTEX_ATOMIC,
+ mutex_atomic::MUTEX_INTEGER,
+ needless_arbitrary_self_type::NEEDLESS_ARBITRARY_SELF_TYPE,
+ needless_bool::BOOL_COMPARISON,
+ needless_bool::NEEDLESS_BOOL,
+ needless_borrow::NEEDLESS_BORROW,
+ needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
+ needless_continue::NEEDLESS_CONTINUE,
+ needless_for_each::NEEDLESS_FOR_EACH,
+ needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
+ needless_question_mark::NEEDLESS_QUESTION_MARK,
+ needless_update::NEEDLESS_UPDATE,
+ neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
+ neg_multiply::NEG_MULTIPLY,
+ new_without_default::NEW_WITHOUT_DEFAULT,
+ no_effect::NO_EFFECT,
+ no_effect::UNNECESSARY_OPERATION,
+ non_copy_const::BORROW_INTERIOR_MUTABLE_CONST,
+ non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST,
+ non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
+ non_expressive_names::MANY_SINGLE_CHAR_NAMES,
+ non_expressive_names::SIMILAR_NAMES,
+ non_octal_unix_permissions::NON_OCTAL_UNIX_PERMISSIONS,
+ open_options::NONSENSICAL_OPEN_OPTIONS,
+ option_env_unwrap::OPTION_ENV_UNWRAP,
+ option_if_let_else::OPTION_IF_LET_ELSE,
+ overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
+ panic_in_result_fn::PANIC_IN_RESULT_FN,
+ panic_unimplemented::PANIC,
+ panic_unimplemented::TODO,
+ panic_unimplemented::UNIMPLEMENTED,
+ panic_unimplemented::UNREACHABLE,
+ partialeq_ne_impl::PARTIALEQ_NE_IMPL,
+ pass_by_ref_or_value::LARGE_TYPES_PASSED_BY_VALUE,
+ pass_by_ref_or_value::TRIVIALLY_COPY_PASS_BY_REF,
+ path_buf_push_overwrite::PATH_BUF_PUSH_OVERWRITE,
+ pattern_type_mismatch::PATTERN_TYPE_MISMATCH,
+ precedence::PRECEDENCE,
+ ptr::CMP_NULL,
+ ptr::MUT_FROM_REF,
+ ptr::PTR_ARG,
+ ptr_eq::PTR_EQ,
+ ptr_offset_with_cast::PTR_OFFSET_WITH_CAST,
+ question_mark::QUESTION_MARK,
+ ranges::MANUAL_RANGE_CONTAINS,
+ ranges::RANGE_MINUS_ONE,
+ ranges::RANGE_PLUS_ONE,
+ ranges::RANGE_ZIP_WITH_LEN,
+ ranges::REVERSED_EMPTY_RANGES,
+ redundant_clone::REDUNDANT_CLONE,
+ redundant_closure_call::REDUNDANT_CLOSURE_CALL,
+ redundant_else::REDUNDANT_ELSE,
+ redundant_field_names::REDUNDANT_FIELD_NAMES,
+ redundant_pub_crate::REDUNDANT_PUB_CRATE,
+ redundant_slicing::REDUNDANT_SLICING,
+ redundant_static_lifetimes::REDUNDANT_STATIC_LIFETIMES,
+ ref_option_ref::REF_OPTION_REF,
+ reference::DEREF_ADDROF,
+ reference::REF_IN_DEREF,
+ regex::INVALID_REGEX,
+ regex::TRIVIAL_REGEX,
+ repeat_once::REPEAT_ONCE,
+ returns::LET_AND_RETURN,
+ returns::NEEDLESS_RETURN,
+ self_assignment::SELF_ASSIGNMENT,
+ semicolon_if_nothing_returned::SEMICOLON_IF_NOTHING_RETURNED,
+ serde_api::SERDE_API_MISUSE,
+ shadow::SHADOW_REUSE,
+ shadow::SHADOW_SAME,
+ shadow::SHADOW_UNRELATED,
+ single_component_path_imports::SINGLE_COMPONENT_PATH_IMPORTS,
+ size_of_in_element_count::SIZE_OF_IN_ELEMENT_COUNT,
+ slow_vector_initialization::SLOW_VECTOR_INITIALIZATION,
+ stable_sort_primitive::STABLE_SORT_PRIMITIVE,
+ strings::STRING_ADD,
+ strings::STRING_ADD_ASSIGN,
+ strings::STRING_FROM_UTF8_AS_BYTES,
+ strings::STRING_LIT_AS_BYTES,
+ strings::STRING_TO_STRING,
+ strings::STR_TO_STRING,
+ suspicious_operation_groupings::SUSPICIOUS_OPERATION_GROUPINGS,
+ suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
+ suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
+ swap::ALMOST_SWAPPED,
+ swap::MANUAL_SWAP,
+ tabs_in_doc_comments::TABS_IN_DOC_COMMENTS,
+ temporary_assignment::TEMPORARY_ASSIGNMENT,
+ to_digit_is_some::TO_DIGIT_IS_SOME,
+ to_string_in_display::TO_STRING_IN_DISPLAY,
+ trait_bounds::TRAIT_DUPLICATION_IN_BOUNDS,
+ trait_bounds::TYPE_REPETITION_IN_BOUNDS,
+ transmute::CROSSPOINTER_TRANSMUTE,
+ transmute::TRANSMUTES_EXPRESSIBLE_AS_PTR_CASTS,
+ transmute::TRANSMUTE_BYTES_TO_STR,
+ transmute::TRANSMUTE_FLOAT_TO_INT,
+ transmute::TRANSMUTE_INT_TO_BOOL,
+ transmute::TRANSMUTE_INT_TO_CHAR,
+ transmute::TRANSMUTE_INT_TO_FLOAT,
+ transmute::TRANSMUTE_PTR_TO_PTR,
+ transmute::TRANSMUTE_PTR_TO_REF,
+ transmute::UNSOUND_COLLECTION_TRANSMUTE,
+ transmute::USELESS_TRANSMUTE,
+ transmute::WRONG_TRANSMUTE,
+ transmuting_null::TRANSMUTING_NULL,
+ try_err::TRY_ERR,
+ types::BORROWED_BOX,
+ types::BOX_VEC,
+ types::LINKEDLIST,
+ types::OPTION_OPTION,
+ types::RC_BUFFER,
+ types::REDUNDANT_ALLOCATION,
+ types::TYPE_COMPLEXITY,
+ types::VEC_BOX,
+ undropped_manually_drops::UNDROPPED_MANUALLY_DROPS,
+ unicode::INVISIBLE_CHARACTERS,
+ unicode::NON_ASCII_LITERAL,
+ unicode::UNICODE_NOT_NFC,
+ unit_return_expecting_ord::UNIT_RETURN_EXPECTING_ORD,
+ unit_types::LET_UNIT_VALUE,
+ unit_types::UNIT_ARG,
+ unit_types::UNIT_CMP,
+ unnamed_address::FN_ADDRESS_COMPARISONS,
+ unnamed_address::VTABLE_ADDRESS_COMPARISONS,
+ unnecessary_sort_by::UNNECESSARY_SORT_BY,
+ unnecessary_wraps::UNNECESSARY_WRAPS,
+ unnested_or_patterns::UNNESTED_OR_PATTERNS,
+ unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
+ unused_io_amount::UNUSED_IO_AMOUNT,
+ unused_self::UNUSED_SELF,
+ unused_unit::UNUSED_UNIT,
+ unwrap::PANICKING_UNWRAP,
+ unwrap::UNNECESSARY_UNWRAP,
+ unwrap_in_result::UNWRAP_IN_RESULT,
+ upper_case_acronyms::UPPER_CASE_ACRONYMS,
+ use_self::USE_SELF,
+ useless_conversion::USELESS_CONVERSION,
+ vec::USELESS_VEC,
+ vec_init_then_push::VEC_INIT_THEN_PUSH,
+ vec_resize_to_zero::VEC_RESIZE_TO_ZERO,
+ verbose_file_reads::VERBOSE_FILE_READS,
+ wildcard_dependencies::WILDCARD_DEPENDENCIES,
+ wildcard_imports::ENUM_GLOB_USE,
+ wildcard_imports::WILDCARD_IMPORTS,
+ write::PRINTLN_EMPTY_STRING,
+ write::PRINT_LITERAL,
+ write::PRINT_STDERR,
+ write::PRINT_STDOUT,
+ write::PRINT_WITH_NEWLINE,
+ write::USE_DEBUG,
+ write::WRITELN_EMPTY_STRING,
+ write::WRITE_LITERAL,
+ write::WRITE_WITH_NEWLINE,
+ zero_div_zero::ZERO_DIVIDED_BY_ZERO,
+ zero_sized_map_values::ZERO_SIZED_MAP_VALUES,
]);
// end register lints, do not remove this comment, it’s used in `update_lints`
@@ -1295,792 +1295,792 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
store.register_late_pass(move || box if_then_some_else_none::IfThenSomeElseNone::new(msrv));
store.register_group(true, "clippy::restriction", Some("clippy_restriction"), vec![
- LintId::of(&arithmetic::FLOAT_ARITHMETIC),
- LintId::of(&arithmetic::INTEGER_ARITHMETIC),
- LintId::of(&as_conversions::AS_CONVERSIONS),
- LintId::of(&asm_syntax::INLINE_ASM_X86_ATT_SYNTAX),
- LintId::of(&asm_syntax::INLINE_ASM_X86_INTEL_SYNTAX),
- LintId::of(&create_dir::CREATE_DIR),
- LintId::of(&dbg_macro::DBG_MACRO),
- LintId::of(&default_numeric_fallback::DEFAULT_NUMERIC_FALLBACK),
- LintId::of(&else_if_without_else::ELSE_IF_WITHOUT_ELSE),
- LintId::of(&exhaustive_items::EXHAUSTIVE_ENUMS),
- LintId::of(&exhaustive_items::EXHAUSTIVE_STRUCTS),
- LintId::of(&exit::EXIT),
- LintId::of(&float_literal::LOSSY_FLOAT_LITERAL),
- LintId::of(&if_then_some_else_none::IF_THEN_SOME_ELSE_NONE),
- LintId::of(&implicit_return::IMPLICIT_RETURN),
- LintId::of(&indexing_slicing::INDEXING_SLICING),
- LintId::of(&inherent_impl::MULTIPLE_INHERENT_IMPL),
- LintId::of(&integer_division::INTEGER_DIVISION),
- LintId::of(&let_underscore::LET_UNDERSCORE_MUST_USE),
- LintId::of(&literal_representation::DECIMAL_LITERAL_REPRESENTATION),
- LintId::of(&map_err_ignore::MAP_ERR_IGNORE),
- LintId::of(&matches::REST_PAT_IN_FULLY_BOUND_STRUCTS),
- LintId::of(&matches::WILDCARD_ENUM_MATCH_ARM),
- LintId::of(&mem_forget::MEM_FORGET),
- LintId::of(&methods::CLONE_ON_REF_PTR),
- LintId::of(&methods::EXPECT_USED),
- LintId::of(&methods::FILETYPE_IS_FILE),
- LintId::of(&methods::GET_UNWRAP),
- LintId::of(&methods::UNWRAP_USED),
- LintId::of(&methods::WRONG_PUB_SELF_CONVENTION),
- LintId::of(&misc::FLOAT_CMP_CONST),
- LintId::of(&misc_early::UNNEEDED_FIELD_PATTERN),
- LintId::of(&missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS),
- LintId::of(&missing_inline::MISSING_INLINE_IN_PUBLIC_ITEMS),
- LintId::of(&modulo_arithmetic::MODULO_ARITHMETIC),
- LintId::of(&panic_in_result_fn::PANIC_IN_RESULT_FN),
- LintId::of(&panic_unimplemented::PANIC),
- LintId::of(&panic_unimplemented::TODO),
- LintId::of(&panic_unimplemented::UNIMPLEMENTED),
- LintId::of(&panic_unimplemented::UNREACHABLE),
- LintId::of(&pattern_type_mismatch::PATTERN_TYPE_MISMATCH),
- LintId::of(&semicolon_if_nothing_returned::SEMICOLON_IF_NOTHING_RETURNED),
- LintId::of(&shadow::SHADOW_REUSE),
- LintId::of(&shadow::SHADOW_SAME),
- LintId::of(&strings::STRING_ADD),
- LintId::of(&strings::STRING_TO_STRING),
- LintId::of(&strings::STR_TO_STRING),
- LintId::of(&types::RC_BUFFER),
- LintId::of(&unwrap_in_result::UNWRAP_IN_RESULT),
- LintId::of(&verbose_file_reads::VERBOSE_FILE_READS),
- LintId::of(&write::PRINT_STDERR),
- LintId::of(&write::PRINT_STDOUT),
- LintId::of(&write::USE_DEBUG),
+ LintId::of(arithmetic::FLOAT_ARITHMETIC),
+ LintId::of(arithmetic::INTEGER_ARITHMETIC),
+ LintId::of(as_conversions::AS_CONVERSIONS),
+ LintId::of(asm_syntax::INLINE_ASM_X86_ATT_SYNTAX),
+ LintId::of(asm_syntax::INLINE_ASM_X86_INTEL_SYNTAX),
+ LintId::of(create_dir::CREATE_DIR),
+ LintId::of(dbg_macro::DBG_MACRO),
+ LintId::of(default_numeric_fallback::DEFAULT_NUMERIC_FALLBACK),
+ LintId::of(else_if_without_else::ELSE_IF_WITHOUT_ELSE),
+ LintId::of(exhaustive_items::EXHAUSTIVE_ENUMS),
+ LintId::of(exhaustive_items::EXHAUSTIVE_STRUCTS),
+ LintId::of(exit::EXIT),
+ LintId::of(float_literal::LOSSY_FLOAT_LITERAL),
+ LintId::of(if_then_some_else_none::IF_THEN_SOME_ELSE_NONE),
+ LintId::of(implicit_return::IMPLICIT_RETURN),
+ LintId::of(indexing_slicing::INDEXING_SLICING),
+ LintId::of(inherent_impl::MULTIPLE_INHERENT_IMPL),
+ LintId::of(integer_division::INTEGER_DIVISION),
+ LintId::of(let_underscore::LET_UNDERSCORE_MUST_USE),
+ LintId::of(literal_representation::DECIMAL_LITERAL_REPRESENTATION),
+ LintId::of(map_err_ignore::MAP_ERR_IGNORE),
+ LintId::of(matches::REST_PAT_IN_FULLY_BOUND_STRUCTS),
+ LintId::of(matches::WILDCARD_ENUM_MATCH_ARM),
+ LintId::of(mem_forget::MEM_FORGET),
+ LintId::of(methods::CLONE_ON_REF_PTR),
+ LintId::of(methods::EXPECT_USED),
+ LintId::of(methods::FILETYPE_IS_FILE),
+ LintId::of(methods::GET_UNWRAP),
+ LintId::of(methods::UNWRAP_USED),
+ LintId::of(methods::WRONG_PUB_SELF_CONVENTION),
+ LintId::of(misc::FLOAT_CMP_CONST),
+ LintId::of(misc_early::UNNEEDED_FIELD_PATTERN),
+ LintId::of(missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS),
+ LintId::of(missing_inline::MISSING_INLINE_IN_PUBLIC_ITEMS),
+ LintId::of(modulo_arithmetic::MODULO_ARITHMETIC),
+ LintId::of(panic_in_result_fn::PANIC_IN_RESULT_FN),
+ LintId::of(panic_unimplemented::PANIC),
+ LintId::of(panic_unimplemented::TODO),
+ LintId::of(panic_unimplemented::UNIMPLEMENTED),
+ LintId::of(panic_unimplemented::UNREACHABLE),
+ LintId::of(pattern_type_mismatch::PATTERN_TYPE_MISMATCH),
+ LintId::of(semicolon_if_nothing_returned::SEMICOLON_IF_NOTHING_RETURNED),
+ LintId::of(shadow::SHADOW_REUSE),
+ LintId::of(shadow::SHADOW_SAME),
+ LintId::of(strings::STRING_ADD),
+ LintId::of(strings::STRING_TO_STRING),
+ LintId::of(strings::STR_TO_STRING),
+ LintId::of(types::RC_BUFFER),
+ LintId::of(unwrap_in_result::UNWRAP_IN_RESULT),
+ LintId::of(verbose_file_reads::VERBOSE_FILE_READS),
+ LintId::of(write::PRINT_STDERR),
+ LintId::of(write::PRINT_STDOUT),
+ LintId::of(write::USE_DEBUG),
]);
store.register_group(true, "clippy::pedantic", Some("clippy_pedantic"), vec![
- LintId::of(&attrs::INLINE_ALWAYS),
- LintId::of(&await_holding_invalid::AWAIT_HOLDING_LOCK),
- LintId::of(&await_holding_invalid::AWAIT_HOLDING_REFCELL_REF),
- LintId::of(&bit_mask::VERBOSE_BIT_MASK),
- LintId::of(&bytecount::NAIVE_BYTECOUNT),
- LintId::of(&case_sensitive_file_extension_comparisons::CASE_SENSITIVE_FILE_EXTENSION_COMPARISONS),
- LintId::of(&casts::CAST_LOSSLESS),
- LintId::of(&casts::CAST_POSSIBLE_TRUNCATION),
- LintId::of(&casts::CAST_POSSIBLE_WRAP),
- LintId::of(&casts::CAST_PRECISION_LOSS),
- LintId::of(&casts::CAST_PTR_ALIGNMENT),
- LintId::of(&casts::CAST_SIGN_LOSS),
- LintId::of(&casts::PTR_AS_PTR),
- LintId::of(&checked_conversions::CHECKED_CONVERSIONS),
- LintId::of(&copies::SAME_FUNCTIONS_IN_IF_CONDITION),
- LintId::of(©_iterator::COPY_ITERATOR),
- LintId::of(&default::DEFAULT_TRAIT_ACCESS),
- LintId::of(&dereference::EXPLICIT_DEREF_METHODS),
- LintId::of(&derive::EXPL_IMPL_CLONE_ON_COPY),
- LintId::of(&derive::UNSAFE_DERIVE_DESERIALIZE),
- LintId::of(&doc::DOC_MARKDOWN),
- LintId::of(&doc::MISSING_ERRORS_DOC),
- LintId::of(&doc::MISSING_PANICS_DOC),
- LintId::of(&empty_enum::EMPTY_ENUM),
- LintId::of(&enum_variants::MODULE_NAME_REPETITIONS),
- LintId::of(&enum_variants::PUB_ENUM_VARIANT_NAMES),
- LintId::of(&eta_reduction::REDUNDANT_CLOSURE_FOR_METHOD_CALLS),
- LintId::of(&excessive_bools::FN_PARAMS_EXCESSIVE_BOOLS),
- LintId::of(&excessive_bools::STRUCT_EXCESSIVE_BOOLS),
- LintId::of(&functions::MUST_USE_CANDIDATE),
- LintId::of(&functions::TOO_MANY_LINES),
- LintId::of(&if_not_else::IF_NOT_ELSE),
- LintId::of(&implicit_hasher::IMPLICIT_HASHER),
- LintId::of(&implicit_saturating_sub::IMPLICIT_SATURATING_SUB),
- LintId::of(&infinite_iter::MAYBE_INFINITE_ITER),
- LintId::of(&invalid_upcast_comparisons::INVALID_UPCAST_COMPARISONS),
- LintId::of(&items_after_statements::ITEMS_AFTER_STATEMENTS),
- LintId::of(&large_stack_arrays::LARGE_STACK_ARRAYS),
- LintId::of(&let_underscore::LET_UNDERSCORE_DROP),
- LintId::of(&literal_representation::LARGE_DIGIT_GROUPS),
- LintId::of(&literal_representation::UNREADABLE_LITERAL),
- LintId::of(&loops::EXPLICIT_INTO_ITER_LOOP),
- LintId::of(&loops::EXPLICIT_ITER_LOOP),
- LintId::of(¯o_use::MACRO_USE_IMPORTS),
- LintId::of(&manual_ok_or::MANUAL_OK_OR),
- LintId::of(&match_on_vec_items::MATCH_ON_VEC_ITEMS),
- LintId::of(&matches::MATCH_BOOL),
- LintId::of(&matches::MATCH_SAME_ARMS),
- LintId::of(&matches::MATCH_WILDCARD_FOR_SINGLE_VARIANTS),
- LintId::of(&matches::MATCH_WILD_ERR_ARM),
- LintId::of(&matches::SINGLE_MATCH_ELSE),
- LintId::of(&methods::FILTER_MAP),
- LintId::of(&methods::FILTER_MAP_NEXT),
- LintId::of(&methods::IMPLICIT_CLONE),
- LintId::of(&methods::INEFFICIENT_TO_STRING),
- LintId::of(&methods::MAP_FLATTEN),
- LintId::of(&methods::MAP_UNWRAP_OR),
- LintId::of(&misc::USED_UNDERSCORE_BINDING),
- LintId::of(&misc_early::UNSEPARATED_LITERAL_SUFFIX),
- LintId::of(&mut_mut::MUT_MUT),
- LintId::of(&needless_continue::NEEDLESS_CONTINUE),
- LintId::of(&needless_for_each::NEEDLESS_FOR_EACH),
- LintId::of(&needless_pass_by_value::NEEDLESS_PASS_BY_VALUE),
- LintId::of(&non_expressive_names::SIMILAR_NAMES),
- LintId::of(&option_if_let_else::OPTION_IF_LET_ELSE),
- LintId::of(&pass_by_ref_or_value::LARGE_TYPES_PASSED_BY_VALUE),
- LintId::of(&pass_by_ref_or_value::TRIVIALLY_COPY_PASS_BY_REF),
- LintId::of(&ranges::RANGE_MINUS_ONE),
- LintId::of(&ranges::RANGE_PLUS_ONE),
- LintId::of(&redundant_else::REDUNDANT_ELSE),
- LintId::of(&ref_option_ref::REF_OPTION_REF),
- LintId::of(&shadow::SHADOW_UNRELATED),
- LintId::of(&strings::STRING_ADD_ASSIGN),
- LintId::of(&trait_bounds::TRAIT_DUPLICATION_IN_BOUNDS),
- LintId::of(&trait_bounds::TYPE_REPETITION_IN_BOUNDS),
- LintId::of(&types::LINKEDLIST),
- LintId::of(&types::OPTION_OPTION),
- LintId::of(&unicode::NON_ASCII_LITERAL),
- LintId::of(&unicode::UNICODE_NOT_NFC),
- LintId::of(&unit_types::LET_UNIT_VALUE),
- LintId::of(&unnecessary_wraps::UNNECESSARY_WRAPS),
- LintId::of(&unnested_or_patterns::UNNESTED_OR_PATTERNS),
- LintId::of(&unused_self::UNUSED_SELF),
- LintId::of(&wildcard_imports::ENUM_GLOB_USE),
- LintId::of(&wildcard_imports::WILDCARD_IMPORTS),
- LintId::of(&zero_sized_map_values::ZERO_SIZED_MAP_VALUES),
+ LintId::of(attrs::INLINE_ALWAYS),
+ LintId::of(await_holding_invalid::AWAIT_HOLDING_LOCK),
+ LintId::of(await_holding_invalid::AWAIT_HOLDING_REFCELL_REF),
+ LintId::of(bit_mask::VERBOSE_BIT_MASK),
+ LintId::of(bytecount::NAIVE_BYTECOUNT),
+ LintId::of(case_sensitive_file_extension_comparisons::CASE_SENSITIVE_FILE_EXTENSION_COMPARISONS),
+ LintId::of(casts::CAST_LOSSLESS),
+ LintId::of(casts::CAST_POSSIBLE_TRUNCATION),
+ LintId::of(casts::CAST_POSSIBLE_WRAP),
+ LintId::of(casts::CAST_PRECISION_LOSS),
+ LintId::of(casts::CAST_PTR_ALIGNMENT),
+ LintId::of(casts::CAST_SIGN_LOSS),
+ LintId::of(casts::PTR_AS_PTR),
+ LintId::of(checked_conversions::CHECKED_CONVERSIONS),
+ LintId::of(copies::SAME_FUNCTIONS_IN_IF_CONDITION),
+ LintId::of(copy_iterator::COPY_ITERATOR),
+ LintId::of(default::DEFAULT_TRAIT_ACCESS),
+ LintId::of(dereference::EXPLICIT_DEREF_METHODS),
+ LintId::of(derive::EXPL_IMPL_CLONE_ON_COPY),
+ LintId::of(derive::UNSAFE_DERIVE_DESERIALIZE),
+ LintId::of(doc::DOC_MARKDOWN),
+ LintId::of(doc::MISSING_ERRORS_DOC),
+ LintId::of(doc::MISSING_PANICS_DOC),
+ LintId::of(empty_enum::EMPTY_ENUM),
+ LintId::of(enum_variants::MODULE_NAME_REPETITIONS),
+ LintId::of(enum_variants::PUB_ENUM_VARIANT_NAMES),
+ LintId::of(eta_reduction::REDUNDANT_CLOSURE_FOR_METHOD_CALLS),
+ LintId::of(excessive_bools::FN_PARAMS_EXCESSIVE_BOOLS),
+ LintId::of(excessive_bools::STRUCT_EXCESSIVE_BOOLS),
+ LintId::of(functions::MUST_USE_CANDIDATE),
+ LintId::of(functions::TOO_MANY_LINES),
+ LintId::of(if_not_else::IF_NOT_ELSE),
+ LintId::of(implicit_hasher::IMPLICIT_HASHER),
+ LintId::of(implicit_saturating_sub::IMPLICIT_SATURATING_SUB),
+ LintId::of(infinite_iter::MAYBE_INFINITE_ITER),
+ LintId::of(invalid_upcast_comparisons::INVALID_UPCAST_COMPARISONS),
+ LintId::of(items_after_statements::ITEMS_AFTER_STATEMENTS),
+ LintId::of(large_stack_arrays::LARGE_STACK_ARRAYS),
+ LintId::of(let_underscore::LET_UNDERSCORE_DROP),
+ LintId::of(literal_representation::LARGE_DIGIT_GROUPS),
+ LintId::of(literal_representation::UNREADABLE_LITERAL),
+ LintId::of(loops::EXPLICIT_INTO_ITER_LOOP),
+ LintId::of(loops::EXPLICIT_ITER_LOOP),
+ LintId::of(macro_use::MACRO_USE_IMPORTS),
+ LintId::of(manual_ok_or::MANUAL_OK_OR),
+ LintId::of(match_on_vec_items::MATCH_ON_VEC_ITEMS),
+ LintId::of(matches::MATCH_BOOL),
+ LintId::of(matches::MATCH_SAME_ARMS),
+ LintId::of(matches::MATCH_WILDCARD_FOR_SINGLE_VARIANTS),
+ LintId::of(matches::MATCH_WILD_ERR_ARM),
+ LintId::of(matches::SINGLE_MATCH_ELSE),
+ LintId::of(methods::FILTER_MAP),
+ LintId::of(methods::FILTER_MAP_NEXT),
+ LintId::of(methods::IMPLICIT_CLONE),
+ LintId::of(methods::INEFFICIENT_TO_STRING),
+ LintId::of(methods::MAP_FLATTEN),
+ LintId::of(methods::MAP_UNWRAP_OR),
+ LintId::of(misc::USED_UNDERSCORE_BINDING),
+ LintId::of(misc_early::UNSEPARATED_LITERAL_SUFFIX),
+ LintId::of(mut_mut::MUT_MUT),
+ LintId::of(needless_continue::NEEDLESS_CONTINUE),
+ LintId::of(needless_for_each::NEEDLESS_FOR_EACH),
+ LintId::of(needless_pass_by_value::NEEDLESS_PASS_BY_VALUE),
+ LintId::of(non_expressive_names::SIMILAR_NAMES),
+ LintId::of(option_if_let_else::OPTION_IF_LET_ELSE),
+ LintId::of(pass_by_ref_or_value::LARGE_TYPES_PASSED_BY_VALUE),
+ LintId::of(pass_by_ref_or_value::TRIVIALLY_COPY_PASS_BY_REF),
+ LintId::of(ranges::RANGE_MINUS_ONE),
+ LintId::of(ranges::RANGE_PLUS_ONE),
+ LintId::of(redundant_else::REDUNDANT_ELSE),
+ LintId::of(ref_option_ref::REF_OPTION_REF),
+ LintId::of(shadow::SHADOW_UNRELATED),
+ LintId::of(strings::STRING_ADD_ASSIGN),
+ LintId::of(trait_bounds::TRAIT_DUPLICATION_IN_BOUNDS),
+ LintId::of(trait_bounds::TYPE_REPETITION_IN_BOUNDS),
+ LintId::of(types::LINKEDLIST),
+ LintId::of(types::OPTION_OPTION),
+ LintId::of(unicode::NON_ASCII_LITERAL),
+ LintId::of(unicode::UNICODE_NOT_NFC),
+ LintId::of(unit_types::LET_UNIT_VALUE),
+ LintId::of(unnecessary_wraps::UNNECESSARY_WRAPS),
+ LintId::of(unnested_or_patterns::UNNESTED_OR_PATTERNS),
+ LintId::of(unused_self::UNUSED_SELF),
+ LintId::of(wildcard_imports::ENUM_GLOB_USE),
+ LintId::of(wildcard_imports::WILDCARD_IMPORTS),
+ LintId::of(zero_sized_map_values::ZERO_SIZED_MAP_VALUES),
]);
#[cfg(feature = "internal-lints")]
store.register_group(true, "clippy::internal", Some("clippy_internal"), vec![
- LintId::of(&utils::internal_lints::CLIPPY_LINTS_INTERNAL),
- LintId::of(&utils::internal_lints::COLLAPSIBLE_SPAN_LINT_CALLS),
- LintId::of(&utils::internal_lints::COMPILER_LINT_FUNCTIONS),
- LintId::of(&utils::internal_lints::DEFAULT_LINT),
- LintId::of(&utils::internal_lints::IF_CHAIN_STYLE),
- LintId::of(&utils::internal_lints::INTERNING_DEFINED_SYMBOL),
- LintId::of(&utils::internal_lints::INVALID_PATHS),
- LintId::of(&utils::internal_lints::LINT_WITHOUT_LINT_PASS),
- LintId::of(&utils::internal_lints::MATCH_TYPE_ON_DIAGNOSTIC_ITEM),
- LintId::of(&utils::internal_lints::OUTER_EXPN_EXPN_DATA),
- LintId::of(&utils::internal_lints::PRODUCE_ICE),
- LintId::of(&utils::internal_lints::UNNECESSARY_SYMBOL_STR),
+ LintId::of(utils::internal_lints::CLIPPY_LINTS_INTERNAL),
+ LintId::of(utils::internal_lints::COLLAPSIBLE_SPAN_LINT_CALLS),
+ LintId::of(utils::internal_lints::COMPILER_LINT_FUNCTIONS),
+ LintId::of(utils::internal_lints::DEFAULT_LINT),
+ LintId::of(utils::internal_lints::IF_CHAIN_STYLE),
+ LintId::of(utils::internal_lints::INTERNING_DEFINED_SYMBOL),
+ LintId::of(utils::internal_lints::INVALID_PATHS),
+ LintId::of(utils::internal_lints::LINT_WITHOUT_LINT_PASS),
+ LintId::of(utils::internal_lints::MATCH_TYPE_ON_DIAGNOSTIC_ITEM),
+ LintId::of(utils::internal_lints::OUTER_EXPN_EXPN_DATA),
+ LintId::of(utils::internal_lints::PRODUCE_ICE),
+ LintId::of(utils::internal_lints::UNNECESSARY_SYMBOL_STR),
]);
store.register_group(true, "clippy::all", Some("clippy"), vec![
- LintId::of(&absurd_extreme_comparisons::ABSURD_EXTREME_COMPARISONS),
- LintId::of(&approx_const::APPROX_CONSTANT),
- LintId::of(&assertions_on_constants::ASSERTIONS_ON_CONSTANTS),
- LintId::of(&assign_ops::ASSIGN_OP_PATTERN),
- LintId::of(&assign_ops::MISREFACTORED_ASSIGN_OP),
- LintId::of(&async_yields_async::ASYNC_YIELDS_ASYNC),
- LintId::of(&atomic_ordering::INVALID_ATOMIC_ORDERING),
- LintId::of(&attrs::BLANKET_CLIPPY_RESTRICTION_LINTS),
- LintId::of(&attrs::DEPRECATED_CFG_ATTR),
- LintId::of(&attrs::DEPRECATED_SEMVER),
- LintId::of(&attrs::MISMATCHED_TARGET_OS),
- LintId::of(&attrs::USELESS_ATTRIBUTE),
- LintId::of(&bit_mask::BAD_BIT_MASK),
- LintId::of(&bit_mask::INEFFECTIVE_BIT_MASK),
- LintId::of(&blacklisted_name::BLACKLISTED_NAME),
- LintId::of(&blocks_in_if_conditions::BLOCKS_IN_IF_CONDITIONS),
- LintId::of(&booleans::LOGIC_BUG),
- LintId::of(&booleans::NONMINIMAL_BOOL),
- LintId::of(&casts::CAST_REF_TO_MUT),
- LintId::of(&casts::CHAR_LIT_AS_U8),
- LintId::of(&casts::FN_TO_NUMERIC_CAST),
- LintId::of(&casts::FN_TO_NUMERIC_CAST_WITH_TRUNCATION),
- LintId::of(&casts::UNNECESSARY_CAST),
- LintId::of(&collapsible_if::COLLAPSIBLE_ELSE_IF),
- LintId::of(&collapsible_if::COLLAPSIBLE_IF),
- LintId::of(&collapsible_match::COLLAPSIBLE_MATCH),
- LintId::of(&comparison_chain::COMPARISON_CHAIN),
- LintId::of(&copies::BRANCHES_SHARING_CODE),
- LintId::of(&copies::IFS_SAME_COND),
- LintId::of(&copies::IF_SAME_THEN_ELSE),
- LintId::of(&default::FIELD_REASSIGN_WITH_DEFAULT),
- LintId::of(&derive::DERIVE_HASH_XOR_EQ),
- LintId::of(&derive::DERIVE_ORD_XOR_PARTIAL_ORD),
- LintId::of(&doc::MISSING_SAFETY_DOC),
- LintId::of(&doc::NEEDLESS_DOCTEST_MAIN),
- LintId::of(&double_comparison::DOUBLE_COMPARISONS),
- LintId::of(&double_parens::DOUBLE_PARENS),
- LintId::of(&drop_forget_ref::DROP_COPY),
- LintId::of(&drop_forget_ref::DROP_REF),
- LintId::of(&drop_forget_ref::FORGET_COPY),
- LintId::of(&drop_forget_ref::FORGET_REF),
- LintId::of(&duration_subsec::DURATION_SUBSEC),
- LintId::of(&entry::MAP_ENTRY),
- LintId::of(&enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT),
- LintId::of(&enum_variants::ENUM_VARIANT_NAMES),
- LintId::of(&enum_variants::MODULE_INCEPTION),
- LintId::of(&eq_op::EQ_OP),
- LintId::of(&eq_op::OP_REF),
- LintId::of(&erasing_op::ERASING_OP),
- LintId::of(&escape::BOXED_LOCAL),
- LintId::of(&eta_reduction::REDUNDANT_CLOSURE),
- LintId::of(&eval_order_dependence::DIVERGING_SUB_EXPRESSION),
- LintId::of(&eval_order_dependence::EVAL_ORDER_DEPENDENCE),
- LintId::of(&explicit_write::EXPLICIT_WRITE),
- LintId::of(&float_equality_without_abs::FLOAT_EQUALITY_WITHOUT_ABS),
- LintId::of(&float_literal::EXCESSIVE_PRECISION),
- LintId::of(&format::USELESS_FORMAT),
- LintId::of(&formatting::POSSIBLE_MISSING_COMMA),
- LintId::of(&formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING),
- LintId::of(&formatting::SUSPICIOUS_ELSE_FORMATTING),
- LintId::of(&formatting::SUSPICIOUS_UNARY_OP_FORMATTING),
- LintId::of(&from_over_into::FROM_OVER_INTO),
- LintId::of(&from_str_radix_10::FROM_STR_RADIX_10),
- LintId::of(&functions::DOUBLE_MUST_USE),
- LintId::of(&functions::MUST_USE_UNIT),
- LintId::of(&functions::NOT_UNSAFE_PTR_ARG_DEREF),
- LintId::of(&functions::RESULT_UNIT_ERR),
- LintId::of(&functions::TOO_MANY_ARGUMENTS),
- LintId::of(&get_last_with_len::GET_LAST_WITH_LEN),
- LintId::of(&identity_op::IDENTITY_OP),
- LintId::of(&if_let_mutex::IF_LET_MUTEX),
- LintId::of(&if_let_some_result::IF_LET_SOME_RESULT),
- LintId::of(&inconsistent_struct_constructor::INCONSISTENT_STRUCT_CONSTRUCTOR),
- LintId::of(&indexing_slicing::OUT_OF_BOUNDS_INDEXING),
- LintId::of(&infinite_iter::INFINITE_ITER),
- LintId::of(&inherent_to_string::INHERENT_TO_STRING),
- LintId::of(&inherent_to_string::INHERENT_TO_STRING_SHADOW_DISPLAY),
- LintId::of(&inline_fn_without_body::INLINE_FN_WITHOUT_BODY),
- LintId::of(&int_plus_one::INT_PLUS_ONE),
- LintId::of(&large_const_arrays::LARGE_CONST_ARRAYS),
- LintId::of(&large_enum_variant::LARGE_ENUM_VARIANT),
- LintId::of(&len_zero::COMPARISON_TO_EMPTY),
- LintId::of(&len_zero::LEN_WITHOUT_IS_EMPTY),
- LintId::of(&len_zero::LEN_ZERO),
- LintId::of(&let_underscore::LET_UNDERSCORE_LOCK),
- LintId::of(&lifetimes::EXTRA_UNUSED_LIFETIMES),
- LintId::of(&lifetimes::NEEDLESS_LIFETIMES),
- LintId::of(&literal_representation::INCONSISTENT_DIGIT_GROUPING),
- LintId::of(&literal_representation::MISTYPED_LITERAL_SUFFIXES),
- LintId::of(&literal_representation::UNUSUAL_BYTE_GROUPINGS),
- LintId::of(&loops::EMPTY_LOOP),
- LintId::of(&loops::EXPLICIT_COUNTER_LOOP),
- LintId::of(&loops::FOR_KV_MAP),
- LintId::of(&loops::FOR_LOOPS_OVER_FALLIBLES),
- LintId::of(&loops::ITER_NEXT_LOOP),
- LintId::of(&loops::MANUAL_FLATTEN),
- LintId::of(&loops::MANUAL_MEMCPY),
- LintId::of(&loops::MUT_RANGE_BOUND),
- LintId::of(&loops::NEEDLESS_COLLECT),
- LintId::of(&loops::NEEDLESS_RANGE_LOOP),
- LintId::of(&loops::NEVER_LOOP),
- LintId::of(&loops::SAME_ITEM_PUSH),
- LintId::of(&loops::SINGLE_ELEMENT_LOOP),
- LintId::of(&loops::WHILE_IMMUTABLE_CONDITION),
- LintId::of(&loops::WHILE_LET_LOOP),
- LintId::of(&loops::WHILE_LET_ON_ITERATOR),
- LintId::of(&main_recursion::MAIN_RECURSION),
- LintId::of(&manual_async_fn::MANUAL_ASYNC_FN),
- LintId::of(&manual_map::MANUAL_MAP),
- LintId::of(&manual_non_exhaustive::MANUAL_NON_EXHAUSTIVE),
- LintId::of(&manual_strip::MANUAL_STRIP),
- LintId::of(&manual_unwrap_or::MANUAL_UNWRAP_OR),
- LintId::of(&map_clone::MAP_CLONE),
- LintId::of(&map_identity::MAP_IDENTITY),
- LintId::of(&map_unit_fn::OPTION_MAP_UNIT_FN),
- LintId::of(&map_unit_fn::RESULT_MAP_UNIT_FN),
- LintId::of(&matches::INFALLIBLE_DESTRUCTURING_MATCH),
- LintId::of(&matches::MATCH_AS_REF),
- LintId::of(&matches::MATCH_LIKE_MATCHES_MACRO),
- LintId::of(&matches::MATCH_OVERLAPPING_ARM),
- LintId::of(&matches::MATCH_REF_PATS),
- LintId::of(&matches::MATCH_SINGLE_BINDING),
- LintId::of(&matches::REDUNDANT_PATTERN_MATCHING),
- LintId::of(&matches::SINGLE_MATCH),
- LintId::of(&matches::WILDCARD_IN_OR_PATTERNS),
- LintId::of(&mem_discriminant::MEM_DISCRIMINANT_NON_ENUM),
- LintId::of(&mem_replace::MEM_REPLACE_OPTION_WITH_NONE),
- LintId::of(&mem_replace::MEM_REPLACE_WITH_DEFAULT),
- LintId::of(&mem_replace::MEM_REPLACE_WITH_UNINIT),
- LintId::of(&methods::BIND_INSTEAD_OF_MAP),
- LintId::of(&methods::BYTES_NTH),
- LintId::of(&methods::CHARS_LAST_CMP),
- LintId::of(&methods::CHARS_NEXT_CMP),
- LintId::of(&methods::CLONE_DOUBLE_REF),
- LintId::of(&methods::CLONE_ON_COPY),
- LintId::of(&methods::EXPECT_FUN_CALL),
- LintId::of(&methods::FILTER_MAP_IDENTITY),
- LintId::of(&methods::FILTER_NEXT),
- LintId::of(&methods::FLAT_MAP_IDENTITY),
- LintId::of(&methods::FROM_ITER_INSTEAD_OF_COLLECT),
- LintId::of(&methods::INSPECT_FOR_EACH),
- LintId::of(&methods::INTO_ITER_ON_REF),
- LintId::of(&methods::ITERATOR_STEP_BY_ZERO),
- LintId::of(&methods::ITER_CLONED_COLLECT),
- LintId::of(&methods::ITER_COUNT),
- LintId::of(&methods::ITER_NEXT_SLICE),
- LintId::of(&methods::ITER_NTH),
- LintId::of(&methods::ITER_NTH_ZERO),
- LintId::of(&methods::ITER_SKIP_NEXT),
- LintId::of(&methods::MANUAL_FILTER_MAP),
- LintId::of(&methods::MANUAL_FIND_MAP),
- LintId::of(&methods::MANUAL_SATURATING_ARITHMETIC),
- LintId::of(&methods::MAP_COLLECT_RESULT_UNIT),
- LintId::of(&methods::NEW_RET_NO_SELF),
- LintId::of(&methods::OK_EXPECT),
- LintId::of(&methods::OPTION_AS_REF_DEREF),
- LintId::of(&methods::OPTION_FILTER_MAP),
- LintId::of(&methods::OPTION_MAP_OR_NONE),
- LintId::of(&methods::OR_FUN_CALL),
- LintId::of(&methods::RESULT_MAP_OR_INTO_OPTION),
- LintId::of(&methods::SEARCH_IS_SOME),
- LintId::of(&methods::SHOULD_IMPLEMENT_TRAIT),
- LintId::of(&methods::SINGLE_CHAR_ADD_STR),
- LintId::of(&methods::SINGLE_CHAR_PATTERN),
- LintId::of(&methods::SKIP_WHILE_NEXT),
- LintId::of(&methods::STRING_EXTEND_CHARS),
- LintId::of(&methods::SUSPICIOUS_MAP),
- LintId::of(&methods::UNINIT_ASSUMED_INIT),
- LintId::of(&methods::UNNECESSARY_FILTER_MAP),
- LintId::of(&methods::UNNECESSARY_FOLD),
- LintId::of(&methods::UNNECESSARY_LAZY_EVALUATIONS),
- LintId::of(&methods::USELESS_ASREF),
- LintId::of(&methods::WRONG_SELF_CONVENTION),
- LintId::of(&methods::ZST_OFFSET),
- LintId::of(&minmax::MIN_MAX),
- LintId::of(&misc::CMP_NAN),
- LintId::of(&misc::CMP_OWNED),
- LintId::of(&misc::FLOAT_CMP),
- LintId::of(&misc::MODULO_ONE),
- LintId::of(&misc::SHORT_CIRCUIT_STATEMENT),
- LintId::of(&misc::TOPLEVEL_REF_ARG),
- LintId::of(&misc::ZERO_PTR),
- LintId::of(&misc_early::BUILTIN_TYPE_SHADOW),
- LintId::of(&misc_early::DOUBLE_NEG),
- LintId::of(&misc_early::DUPLICATE_UNDERSCORE_ARGUMENT),
- LintId::of(&misc_early::MIXED_CASE_HEX_LITERALS),
- LintId::of(&misc_early::REDUNDANT_PATTERN),
- LintId::of(&misc_early::UNNEEDED_WILDCARD_PATTERN),
- LintId::of(&misc_early::ZERO_PREFIXED_LITERAL),
- LintId::of(&mut_key::MUTABLE_KEY_TYPE),
- LintId::of(&mut_mutex_lock::MUT_MUTEX_LOCK),
- LintId::of(&mut_reference::UNNECESSARY_MUT_PASSED),
- LintId::of(&mutex_atomic::MUTEX_ATOMIC),
- LintId::of(&needless_arbitrary_self_type::NEEDLESS_ARBITRARY_SELF_TYPE),
- LintId::of(&needless_bool::BOOL_COMPARISON),
- LintId::of(&needless_bool::NEEDLESS_BOOL),
- LintId::of(&needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE),
- LintId::of(&needless_question_mark::NEEDLESS_QUESTION_MARK),
- LintId::of(&needless_update::NEEDLESS_UPDATE),
- LintId::of(&neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD),
- LintId::of(&neg_multiply::NEG_MULTIPLY),
- LintId::of(&new_without_default::NEW_WITHOUT_DEFAULT),
- LintId::of(&no_effect::NO_EFFECT),
- LintId::of(&no_effect::UNNECESSARY_OPERATION),
- LintId::of(&non_copy_const::BORROW_INTERIOR_MUTABLE_CONST),
- LintId::of(&non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST),
- LintId::of(&non_expressive_names::JUST_UNDERSCORES_AND_DIGITS),
- LintId::of(&non_expressive_names::MANY_SINGLE_CHAR_NAMES),
- LintId::of(&non_octal_unix_permissions::NON_OCTAL_UNIX_PERMISSIONS),
- LintId::of(&open_options::NONSENSICAL_OPEN_OPTIONS),
- LintId::of(&option_env_unwrap::OPTION_ENV_UNWRAP),
- LintId::of(&overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL),
- LintId::of(&partialeq_ne_impl::PARTIALEQ_NE_IMPL),
- LintId::of(&precedence::PRECEDENCE),
- LintId::of(&ptr::CMP_NULL),
- LintId::of(&ptr::MUT_FROM_REF),
- LintId::of(&ptr::PTR_ARG),
- LintId::of(&ptr_eq::PTR_EQ),
- LintId::of(&ptr_offset_with_cast::PTR_OFFSET_WITH_CAST),
- LintId::of(&question_mark::QUESTION_MARK),
- LintId::of(&ranges::MANUAL_RANGE_CONTAINS),
- LintId::of(&ranges::RANGE_ZIP_WITH_LEN),
- LintId::of(&ranges::REVERSED_EMPTY_RANGES),
- LintId::of(&redundant_clone::REDUNDANT_CLONE),
- LintId::of(&redundant_closure_call::REDUNDANT_CLOSURE_CALL),
- LintId::of(&redundant_field_names::REDUNDANT_FIELD_NAMES),
- LintId::of(&redundant_slicing::REDUNDANT_SLICING),
- LintId::of(&redundant_static_lifetimes::REDUNDANT_STATIC_LIFETIMES),
- LintId::of(&reference::DEREF_ADDROF),
- LintId::of(&reference::REF_IN_DEREF),
- LintId::of(®ex::INVALID_REGEX),
- LintId::of(&repeat_once::REPEAT_ONCE),
- LintId::of(&returns::LET_AND_RETURN),
- LintId::of(&returns::NEEDLESS_RETURN),
- LintId::of(&self_assignment::SELF_ASSIGNMENT),
- LintId::of(&serde_api::SERDE_API_MISUSE),
- LintId::of(&single_component_path_imports::SINGLE_COMPONENT_PATH_IMPORTS),
- LintId::of(&size_of_in_element_count::SIZE_OF_IN_ELEMENT_COUNT),
- LintId::of(&slow_vector_initialization::SLOW_VECTOR_INITIALIZATION),
- LintId::of(&stable_sort_primitive::STABLE_SORT_PRIMITIVE),
- LintId::of(&strings::STRING_FROM_UTF8_AS_BYTES),
- LintId::of(&suspicious_operation_groupings::SUSPICIOUS_OPERATION_GROUPINGS),
- LintId::of(&suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL),
- LintId::of(&suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL),
- LintId::of(&swap::ALMOST_SWAPPED),
- LintId::of(&swap::MANUAL_SWAP),
- LintId::of(&tabs_in_doc_comments::TABS_IN_DOC_COMMENTS),
- LintId::of(&temporary_assignment::TEMPORARY_ASSIGNMENT),
- LintId::of(&to_digit_is_some::TO_DIGIT_IS_SOME),
- LintId::of(&to_string_in_display::TO_STRING_IN_DISPLAY),
- LintId::of(&transmute::CROSSPOINTER_TRANSMUTE),
- LintId::of(&transmute::TRANSMUTES_EXPRESSIBLE_AS_PTR_CASTS),
- LintId::of(&transmute::TRANSMUTE_BYTES_TO_STR),
- LintId::of(&transmute::TRANSMUTE_FLOAT_TO_INT),
- LintId::of(&transmute::TRANSMUTE_INT_TO_BOOL),
- LintId::of(&transmute::TRANSMUTE_INT_TO_CHAR),
- LintId::of(&transmute::TRANSMUTE_INT_TO_FLOAT),
- LintId::of(&transmute::TRANSMUTE_PTR_TO_PTR),
- LintId::of(&transmute::TRANSMUTE_PTR_TO_REF),
- LintId::of(&transmute::UNSOUND_COLLECTION_TRANSMUTE),
- LintId::of(&transmute::WRONG_TRANSMUTE),
- LintId::of(&transmuting_null::TRANSMUTING_NULL),
- LintId::of(&try_err::TRY_ERR),
- LintId::of(&types::BORROWED_BOX),
- LintId::of(&types::BOX_VEC),
- LintId::of(&types::REDUNDANT_ALLOCATION),
- LintId::of(&types::TYPE_COMPLEXITY),
- LintId::of(&types::VEC_BOX),
- LintId::of(&undropped_manually_drops::UNDROPPED_MANUALLY_DROPS),
- LintId::of(&unicode::INVISIBLE_CHARACTERS),
- LintId::of(&unit_return_expecting_ord::UNIT_RETURN_EXPECTING_ORD),
- LintId::of(&unit_types::UNIT_ARG),
- LintId::of(&unit_types::UNIT_CMP),
- LintId::of(&unnamed_address::FN_ADDRESS_COMPARISONS),
- LintId::of(&unnamed_address::VTABLE_ADDRESS_COMPARISONS),
- LintId::of(&unnecessary_sort_by::UNNECESSARY_SORT_BY),
- LintId::of(&unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME),
- LintId::of(&unused_io_amount::UNUSED_IO_AMOUNT),
- LintId::of(&unused_unit::UNUSED_UNIT),
- LintId::of(&unwrap::PANICKING_UNWRAP),
- LintId::of(&unwrap::UNNECESSARY_UNWRAP),
- LintId::of(&upper_case_acronyms::UPPER_CASE_ACRONYMS),
- LintId::of(&useless_conversion::USELESS_CONVERSION),
- LintId::of(&vec::USELESS_VEC),
- LintId::of(&vec_init_then_push::VEC_INIT_THEN_PUSH),
- LintId::of(&vec_resize_to_zero::VEC_RESIZE_TO_ZERO),
- LintId::of(&write::PRINTLN_EMPTY_STRING),
- LintId::of(&write::PRINT_LITERAL),
- LintId::of(&write::PRINT_WITH_NEWLINE),
- LintId::of(&write::WRITELN_EMPTY_STRING),
- LintId::of(&write::WRITE_LITERAL),
- LintId::of(&write::WRITE_WITH_NEWLINE),
- LintId::of(&zero_div_zero::ZERO_DIVIDED_BY_ZERO),
+ LintId::of(absurd_extreme_comparisons::ABSURD_EXTREME_COMPARISONS),
+ LintId::of(approx_const::APPROX_CONSTANT),
+ LintId::of(assertions_on_constants::ASSERTIONS_ON_CONSTANTS),
+ LintId::of(assign_ops::ASSIGN_OP_PATTERN),
+ LintId::of(assign_ops::MISREFACTORED_ASSIGN_OP),
+ LintId::of(async_yields_async::ASYNC_YIELDS_ASYNC),
+ LintId::of(atomic_ordering::INVALID_ATOMIC_ORDERING),
+ LintId::of(attrs::BLANKET_CLIPPY_RESTRICTION_LINTS),
+ LintId::of(attrs::DEPRECATED_CFG_ATTR),
+ LintId::of(attrs::DEPRECATED_SEMVER),
+ LintId::of(attrs::MISMATCHED_TARGET_OS),
+ LintId::of(attrs::USELESS_ATTRIBUTE),
+ LintId::of(bit_mask::BAD_BIT_MASK),
+ LintId::of(bit_mask::INEFFECTIVE_BIT_MASK),
+ LintId::of(blacklisted_name::BLACKLISTED_NAME),
+ LintId::of(blocks_in_if_conditions::BLOCKS_IN_IF_CONDITIONS),
+ LintId::of(booleans::LOGIC_BUG),
+ LintId::of(booleans::NONMINIMAL_BOOL),
+ LintId::of(casts::CAST_REF_TO_MUT),
+ LintId::of(casts::CHAR_LIT_AS_U8),
+ LintId::of(casts::FN_TO_NUMERIC_CAST),
+ LintId::of(casts::FN_TO_NUMERIC_CAST_WITH_TRUNCATION),
+ LintId::of(casts::UNNECESSARY_CAST),
+ LintId::of(collapsible_if::COLLAPSIBLE_ELSE_IF),
+ LintId::of(collapsible_if::COLLAPSIBLE_IF),
+ LintId::of(collapsible_match::COLLAPSIBLE_MATCH),
+ LintId::of(comparison_chain::COMPARISON_CHAIN),
+ LintId::of(copies::BRANCHES_SHARING_CODE),
+ LintId::of(copies::IFS_SAME_COND),
+ LintId::of(copies::IF_SAME_THEN_ELSE),
+ LintId::of(default::FIELD_REASSIGN_WITH_DEFAULT),
+ LintId::of(derive::DERIVE_HASH_XOR_EQ),
+ LintId::of(derive::DERIVE_ORD_XOR_PARTIAL_ORD),
+ LintId::of(doc::MISSING_SAFETY_DOC),
+ LintId::of(doc::NEEDLESS_DOCTEST_MAIN),
+ LintId::of(double_comparison::DOUBLE_COMPARISONS),
+ LintId::of(double_parens::DOUBLE_PARENS),
+ LintId::of(drop_forget_ref::DROP_COPY),
+ LintId::of(drop_forget_ref::DROP_REF),
+ LintId::of(drop_forget_ref::FORGET_COPY),
+ LintId::of(drop_forget_ref::FORGET_REF),
+ LintId::of(duration_subsec::DURATION_SUBSEC),
+ LintId::of(entry::MAP_ENTRY),
+ LintId::of(enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT),
+ LintId::of(enum_variants::ENUM_VARIANT_NAMES),
+ LintId::of(enum_variants::MODULE_INCEPTION),
+ LintId::of(eq_op::EQ_OP),
+ LintId::of(eq_op::OP_REF),
+ LintId::of(erasing_op::ERASING_OP),
+ LintId::of(escape::BOXED_LOCAL),
+ LintId::of(eta_reduction::REDUNDANT_CLOSURE),
+ LintId::of(eval_order_dependence::DIVERGING_SUB_EXPRESSION),
+ LintId::of(eval_order_dependence::EVAL_ORDER_DEPENDENCE),
+ LintId::of(explicit_write::EXPLICIT_WRITE),
+ LintId::of(float_equality_without_abs::FLOAT_EQUALITY_WITHOUT_ABS),
+ LintId::of(float_literal::EXCESSIVE_PRECISION),
+ LintId::of(format::USELESS_FORMAT),
+ LintId::of(formatting::POSSIBLE_MISSING_COMMA),
+ LintId::of(formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING),
+ LintId::of(formatting::SUSPICIOUS_ELSE_FORMATTING),
+ LintId::of(formatting::SUSPICIOUS_UNARY_OP_FORMATTING),
+ LintId::of(from_over_into::FROM_OVER_INTO),
+ LintId::of(from_str_radix_10::FROM_STR_RADIX_10),
+ LintId::of(functions::DOUBLE_MUST_USE),
+ LintId::of(functions::MUST_USE_UNIT),
+ LintId::of(functions::NOT_UNSAFE_PTR_ARG_DEREF),
+ LintId::of(functions::RESULT_UNIT_ERR),
+ LintId::of(functions::TOO_MANY_ARGUMENTS),
+ LintId::of(get_last_with_len::GET_LAST_WITH_LEN),
+ LintId::of(identity_op::IDENTITY_OP),
+ LintId::of(if_let_mutex::IF_LET_MUTEX),
+ LintId::of(if_let_some_result::IF_LET_SOME_RESULT),
+ LintId::of(inconsistent_struct_constructor::INCONSISTENT_STRUCT_CONSTRUCTOR),
+ LintId::of(indexing_slicing::OUT_OF_BOUNDS_INDEXING),
+ LintId::of(infinite_iter::INFINITE_ITER),
+ LintId::of(inherent_to_string::INHERENT_TO_STRING),
+ LintId::of(inherent_to_string::INHERENT_TO_STRING_SHADOW_DISPLAY),
+ LintId::of(inline_fn_without_body::INLINE_FN_WITHOUT_BODY),
+ LintId::of(int_plus_one::INT_PLUS_ONE),
+ LintId::of(large_const_arrays::LARGE_CONST_ARRAYS),
+ LintId::of(large_enum_variant::LARGE_ENUM_VARIANT),
+ LintId::of(len_zero::COMPARISON_TO_EMPTY),
+ LintId::of(len_zero::LEN_WITHOUT_IS_EMPTY),
+ LintId::of(len_zero::LEN_ZERO),
+ LintId::of(let_underscore::LET_UNDERSCORE_LOCK),
+ LintId::of(lifetimes::EXTRA_UNUSED_LIFETIMES),
+ LintId::of(lifetimes::NEEDLESS_LIFETIMES),
+ LintId::of(literal_representation::INCONSISTENT_DIGIT_GROUPING),
+ LintId::of(literal_representation::MISTYPED_LITERAL_SUFFIXES),
+ LintId::of(literal_representation::UNUSUAL_BYTE_GROUPINGS),
+ LintId::of(loops::EMPTY_LOOP),
+ LintId::of(loops::EXPLICIT_COUNTER_LOOP),
+ LintId::of(loops::FOR_KV_MAP),
+ LintId::of(loops::FOR_LOOPS_OVER_FALLIBLES),
+ LintId::of(loops::ITER_NEXT_LOOP),
+ LintId::of(loops::MANUAL_FLATTEN),
+ LintId::of(loops::MANUAL_MEMCPY),
+ LintId::of(loops::MUT_RANGE_BOUND),
+ LintId::of(loops::NEEDLESS_COLLECT),
+ LintId::of(loops::NEEDLESS_RANGE_LOOP),
+ LintId::of(loops::NEVER_LOOP),
+ LintId::of(loops::SAME_ITEM_PUSH),
+ LintId::of(loops::SINGLE_ELEMENT_LOOP),
+ LintId::of(loops::WHILE_IMMUTABLE_CONDITION),
+ LintId::of(loops::WHILE_LET_LOOP),
+ LintId::of(loops::WHILE_LET_ON_ITERATOR),
+ LintId::of(main_recursion::MAIN_RECURSION),
+ LintId::of(manual_async_fn::MANUAL_ASYNC_FN),
+ LintId::of(manual_map::MANUAL_MAP),
+ LintId::of(manual_non_exhaustive::MANUAL_NON_EXHAUSTIVE),
+ LintId::of(manual_strip::MANUAL_STRIP),
+ LintId::of(manual_unwrap_or::MANUAL_UNWRAP_OR),
+ LintId::of(map_clone::MAP_CLONE),
+ LintId::of(map_identity::MAP_IDENTITY),
+ LintId::of(map_unit_fn::OPTION_MAP_UNIT_FN),
+ LintId::of(map_unit_fn::RESULT_MAP_UNIT_FN),
+ LintId::of(matches::INFALLIBLE_DESTRUCTURING_MATCH),
+ LintId::of(matches::MATCH_AS_REF),
+ LintId::of(matches::MATCH_LIKE_MATCHES_MACRO),
+ LintId::of(matches::MATCH_OVERLAPPING_ARM),
+ LintId::of(matches::MATCH_REF_PATS),
+ LintId::of(matches::MATCH_SINGLE_BINDING),
+ LintId::of(matches::REDUNDANT_PATTERN_MATCHING),
+ LintId::of(matches::SINGLE_MATCH),
+ LintId::of(matches::WILDCARD_IN_OR_PATTERNS),
+ LintId::of(mem_discriminant::MEM_DISCRIMINANT_NON_ENUM),
+ LintId::of(mem_replace::MEM_REPLACE_OPTION_WITH_NONE),
+ LintId::of(mem_replace::MEM_REPLACE_WITH_DEFAULT),
+ LintId::of(mem_replace::MEM_REPLACE_WITH_UNINIT),
+ LintId::of(methods::BIND_INSTEAD_OF_MAP),
+ LintId::of(methods::BYTES_NTH),
+ LintId::of(methods::CHARS_LAST_CMP),
+ LintId::of(methods::CHARS_NEXT_CMP),
+ LintId::of(methods::CLONE_DOUBLE_REF),
+ LintId::of(methods::CLONE_ON_COPY),
+ LintId::of(methods::EXPECT_FUN_CALL),
+ LintId::of(methods::FILTER_MAP_IDENTITY),
+ LintId::of(methods::FILTER_NEXT),
+ LintId::of(methods::FLAT_MAP_IDENTITY),
+ LintId::of(methods::FROM_ITER_INSTEAD_OF_COLLECT),
+ LintId::of(methods::INSPECT_FOR_EACH),
+ LintId::of(methods::INTO_ITER_ON_REF),
+ LintId::of(methods::ITERATOR_STEP_BY_ZERO),
+ LintId::of(methods::ITER_CLONED_COLLECT),
+ LintId::of(methods::ITER_COUNT),
+ LintId::of(methods::ITER_NEXT_SLICE),
+ LintId::of(methods::ITER_NTH),
+ LintId::of(methods::ITER_NTH_ZERO),
+ LintId::of(methods::ITER_SKIP_NEXT),
+ LintId::of(methods::MANUAL_FILTER_MAP),
+ LintId::of(methods::MANUAL_FIND_MAP),
+ LintId::of(methods::MANUAL_SATURATING_ARITHMETIC),
+ LintId::of(methods::MAP_COLLECT_RESULT_UNIT),
+ LintId::of(methods::NEW_RET_NO_SELF),
+ LintId::of(methods::OK_EXPECT),
+ LintId::of(methods::OPTION_AS_REF_DEREF),
+ LintId::of(methods::OPTION_FILTER_MAP),
+ LintId::of(methods::OPTION_MAP_OR_NONE),
+ LintId::of(methods::OR_FUN_CALL),
+ LintId::of(methods::RESULT_MAP_OR_INTO_OPTION),
+ LintId::of(methods::SEARCH_IS_SOME),
+ LintId::of(methods::SHOULD_IMPLEMENT_TRAIT),
+ LintId::of(methods::SINGLE_CHAR_ADD_STR),
+ LintId::of(methods::SINGLE_CHAR_PATTERN),
+ LintId::of(methods::SKIP_WHILE_NEXT),
+ LintId::of(methods::STRING_EXTEND_CHARS),
+ LintId::of(methods::SUSPICIOUS_MAP),
+ LintId::of(methods::UNINIT_ASSUMED_INIT),
+ LintId::of(methods::UNNECESSARY_FILTER_MAP),
+ LintId::of(methods::UNNECESSARY_FOLD),
+ LintId::of(methods::UNNECESSARY_LAZY_EVALUATIONS),
+ LintId::of(methods::USELESS_ASREF),
+ LintId::of(methods::WRONG_SELF_CONVENTION),
+ LintId::of(methods::ZST_OFFSET),
+ LintId::of(minmax::MIN_MAX),
+ LintId::of(misc::CMP_NAN),
+ LintId::of(misc::CMP_OWNED),
+ LintId::of(misc::FLOAT_CMP),
+ LintId::of(misc::MODULO_ONE),
+ LintId::of(misc::SHORT_CIRCUIT_STATEMENT),
+ LintId::of(misc::TOPLEVEL_REF_ARG),
+ LintId::of(misc::ZERO_PTR),
+ LintId::of(misc_early::BUILTIN_TYPE_SHADOW),
+ LintId::of(misc_early::DOUBLE_NEG),
+ LintId::of(misc_early::DUPLICATE_UNDERSCORE_ARGUMENT),
+ LintId::of(misc_early::MIXED_CASE_HEX_LITERALS),
+ LintId::of(misc_early::REDUNDANT_PATTERN),
+ LintId::of(misc_early::UNNEEDED_WILDCARD_PATTERN),
+ LintId::of(misc_early::ZERO_PREFIXED_LITERAL),
+ LintId::of(mut_key::MUTABLE_KEY_TYPE),
+ LintId::of(mut_mutex_lock::MUT_MUTEX_LOCK),
+ LintId::of(mut_reference::UNNECESSARY_MUT_PASSED),
+ LintId::of(mutex_atomic::MUTEX_ATOMIC),
+ LintId::of(needless_arbitrary_self_type::NEEDLESS_ARBITRARY_SELF_TYPE),
+ LintId::of(needless_bool::BOOL_COMPARISON),
+ LintId::of(needless_bool::NEEDLESS_BOOL),
+ LintId::of(needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE),
+ LintId::of(needless_question_mark::NEEDLESS_QUESTION_MARK),
+ LintId::of(needless_update::NEEDLESS_UPDATE),
+ LintId::of(neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD),
+ LintId::of(neg_multiply::NEG_MULTIPLY),
+ LintId::of(new_without_default::NEW_WITHOUT_DEFAULT),
+ LintId::of(no_effect::NO_EFFECT),
+ LintId::of(no_effect::UNNECESSARY_OPERATION),
+ LintId::of(non_copy_const::BORROW_INTERIOR_MUTABLE_CONST),
+ LintId::of(non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST),
+ LintId::of(non_expressive_names::JUST_UNDERSCORES_AND_DIGITS),
+ LintId::of(non_expressive_names::MANY_SINGLE_CHAR_NAMES),
+ LintId::of(non_octal_unix_permissions::NON_OCTAL_UNIX_PERMISSIONS),
+ LintId::of(open_options::NONSENSICAL_OPEN_OPTIONS),
+ LintId::of(option_env_unwrap::OPTION_ENV_UNWRAP),
+ LintId::of(overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL),
+ LintId::of(partialeq_ne_impl::PARTIALEQ_NE_IMPL),
+ LintId::of(precedence::PRECEDENCE),
+ LintId::of(ptr::CMP_NULL),
+ LintId::of(ptr::MUT_FROM_REF),
+ LintId::of(ptr::PTR_ARG),
+ LintId::of(ptr_eq::PTR_EQ),
+ LintId::of(ptr_offset_with_cast::PTR_OFFSET_WITH_CAST),
+ LintId::of(question_mark::QUESTION_MARK),
+ LintId::of(ranges::MANUAL_RANGE_CONTAINS),
+ LintId::of(ranges::RANGE_ZIP_WITH_LEN),
+ LintId::of(ranges::REVERSED_EMPTY_RANGES),
+ LintId::of(redundant_clone::REDUNDANT_CLONE),
+ LintId::of(redundant_closure_call::REDUNDANT_CLOSURE_CALL),
+ LintId::of(redundant_field_names::REDUNDANT_FIELD_NAMES),
+ LintId::of(redundant_slicing::REDUNDANT_SLICING),
+ LintId::of(redundant_static_lifetimes::REDUNDANT_STATIC_LIFETIMES),
+ LintId::of(reference::DEREF_ADDROF),
+ LintId::of(reference::REF_IN_DEREF),
+ LintId::of(regex::INVALID_REGEX),
+ LintId::of(repeat_once::REPEAT_ONCE),
+ LintId::of(returns::LET_AND_RETURN),
+ LintId::of(returns::NEEDLESS_RETURN),
+ LintId::of(self_assignment::SELF_ASSIGNMENT),
+ LintId::of(serde_api::SERDE_API_MISUSE),
+ LintId::of(single_component_path_imports::SINGLE_COMPONENT_PATH_IMPORTS),
+ LintId::of(size_of_in_element_count::SIZE_OF_IN_ELEMENT_COUNT),
+ LintId::of(slow_vector_initialization::SLOW_VECTOR_INITIALIZATION),
+ LintId::of(stable_sort_primitive::STABLE_SORT_PRIMITIVE),
+ LintId::of(strings::STRING_FROM_UTF8_AS_BYTES),
+ LintId::of(suspicious_operation_groupings::SUSPICIOUS_OPERATION_GROUPINGS),
+ LintId::of(suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL),
+ LintId::of(suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL),
+ LintId::of(swap::ALMOST_SWAPPED),
+ LintId::of(swap::MANUAL_SWAP),
+ LintId::of(tabs_in_doc_comments::TABS_IN_DOC_COMMENTS),
+ LintId::of(temporary_assignment::TEMPORARY_ASSIGNMENT),
+ LintId::of(to_digit_is_some::TO_DIGIT_IS_SOME),
+ LintId::of(to_string_in_display::TO_STRING_IN_DISPLAY),
+ LintId::of(transmute::CROSSPOINTER_TRANSMUTE),
+ LintId::of(transmute::TRANSMUTES_EXPRESSIBLE_AS_PTR_CASTS),
+ LintId::of(transmute::TRANSMUTE_BYTES_TO_STR),
+ LintId::of(transmute::TRANSMUTE_FLOAT_TO_INT),
+ LintId::of(transmute::TRANSMUTE_INT_TO_BOOL),
+ LintId::of(transmute::TRANSMUTE_INT_TO_CHAR),
+ LintId::of(transmute::TRANSMUTE_INT_TO_FLOAT),
+ LintId::of(transmute::TRANSMUTE_PTR_TO_PTR),
+ LintId::of(transmute::TRANSMUTE_PTR_TO_REF),
+ LintId::of(transmute::UNSOUND_COLLECTION_TRANSMUTE),
+ LintId::of(transmute::WRONG_TRANSMUTE),
+ LintId::of(transmuting_null::TRANSMUTING_NULL),
+ LintId::of(try_err::TRY_ERR),
+ LintId::of(types::BORROWED_BOX),
+ LintId::of(types::BOX_VEC),
+ LintId::of(types::REDUNDANT_ALLOCATION),
+ LintId::of(types::TYPE_COMPLEXITY),
+ LintId::of(types::VEC_BOX),
+ LintId::of(undropped_manually_drops::UNDROPPED_MANUALLY_DROPS),
+ LintId::of(unicode::INVISIBLE_CHARACTERS),
+ LintId::of(unit_return_expecting_ord::UNIT_RETURN_EXPECTING_ORD),
+ LintId::of(unit_types::UNIT_ARG),
+ LintId::of(unit_types::UNIT_CMP),
+ LintId::of(unnamed_address::FN_ADDRESS_COMPARISONS),
+ LintId::of(unnamed_address::VTABLE_ADDRESS_COMPARISONS),
+ LintId::of(unnecessary_sort_by::UNNECESSARY_SORT_BY),
+ LintId::of(unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME),
+ LintId::of(unused_io_amount::UNUSED_IO_AMOUNT),
+ LintId::of(unused_unit::UNUSED_UNIT),
+ LintId::of(unwrap::PANICKING_UNWRAP),
+ LintId::of(unwrap::UNNECESSARY_UNWRAP),
+ LintId::of(upper_case_acronyms::UPPER_CASE_ACRONYMS),
+ LintId::of(useless_conversion::USELESS_CONVERSION),
+ LintId::of(vec::USELESS_VEC),
+ LintId::of(vec_init_then_push::VEC_INIT_THEN_PUSH),
+ LintId::of(vec_resize_to_zero::VEC_RESIZE_TO_ZERO),
+ LintId::of(write::PRINTLN_EMPTY_STRING),
+ LintId::of(write::PRINT_LITERAL),
+ LintId::of(write::PRINT_WITH_NEWLINE),
+ LintId::of(write::WRITELN_EMPTY_STRING),
+ LintId::of(write::WRITE_LITERAL),
+ LintId::of(write::WRITE_WITH_NEWLINE),
+ LintId::of(zero_div_zero::ZERO_DIVIDED_BY_ZERO),
]);
store.register_group(true, "clippy::style", Some("clippy_style"), vec![
- LintId::of(&assertions_on_constants::ASSERTIONS_ON_CONSTANTS),
- LintId::of(&assign_ops::ASSIGN_OP_PATTERN),
- LintId::of(&attrs::BLANKET_CLIPPY_RESTRICTION_LINTS),
- LintId::of(&blacklisted_name::BLACKLISTED_NAME),
- LintId::of(&blocks_in_if_conditions::BLOCKS_IN_IF_CONDITIONS),
- LintId::of(&casts::FN_TO_NUMERIC_CAST),
- LintId::of(&casts::FN_TO_NUMERIC_CAST_WITH_TRUNCATION),
- LintId::of(&collapsible_if::COLLAPSIBLE_ELSE_IF),
- LintId::of(&collapsible_if::COLLAPSIBLE_IF),
- LintId::of(&collapsible_match::COLLAPSIBLE_MATCH),
- LintId::of(&comparison_chain::COMPARISON_CHAIN),
- LintId::of(&default::FIELD_REASSIGN_WITH_DEFAULT),
- LintId::of(&doc::MISSING_SAFETY_DOC),
- LintId::of(&doc::NEEDLESS_DOCTEST_MAIN),
- LintId::of(&enum_variants::ENUM_VARIANT_NAMES),
- LintId::of(&enum_variants::MODULE_INCEPTION),
- LintId::of(&eq_op::OP_REF),
- LintId::of(&eta_reduction::REDUNDANT_CLOSURE),
- LintId::of(&float_literal::EXCESSIVE_PRECISION),
- LintId::of(&formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING),
- LintId::of(&formatting::SUSPICIOUS_ELSE_FORMATTING),
- LintId::of(&formatting::SUSPICIOUS_UNARY_OP_FORMATTING),
- LintId::of(&from_over_into::FROM_OVER_INTO),
- LintId::of(&from_str_radix_10::FROM_STR_RADIX_10),
- LintId::of(&functions::DOUBLE_MUST_USE),
- LintId::of(&functions::MUST_USE_UNIT),
- LintId::of(&functions::RESULT_UNIT_ERR),
- LintId::of(&if_let_some_result::IF_LET_SOME_RESULT),
- LintId::of(&inconsistent_struct_constructor::INCONSISTENT_STRUCT_CONSTRUCTOR),
- LintId::of(&inherent_to_string::INHERENT_TO_STRING),
- LintId::of(&len_zero::COMPARISON_TO_EMPTY),
- LintId::of(&len_zero::LEN_WITHOUT_IS_EMPTY),
- LintId::of(&len_zero::LEN_ZERO),
- LintId::of(&literal_representation::INCONSISTENT_DIGIT_GROUPING),
- LintId::of(&literal_representation::UNUSUAL_BYTE_GROUPINGS),
- LintId::of(&loops::EMPTY_LOOP),
- LintId::of(&loops::FOR_KV_MAP),
- LintId::of(&loops::NEEDLESS_RANGE_LOOP),
- LintId::of(&loops::SAME_ITEM_PUSH),
- LintId::of(&loops::WHILE_LET_ON_ITERATOR),
- LintId::of(&main_recursion::MAIN_RECURSION),
- LintId::of(&manual_async_fn::MANUAL_ASYNC_FN),
- LintId::of(&manual_map::MANUAL_MAP),
- LintId::of(&manual_non_exhaustive::MANUAL_NON_EXHAUSTIVE),
- LintId::of(&map_clone::MAP_CLONE),
- LintId::of(&matches::INFALLIBLE_DESTRUCTURING_MATCH),
- LintId::of(&matches::MATCH_LIKE_MATCHES_MACRO),
- LintId::of(&matches::MATCH_OVERLAPPING_ARM),
- LintId::of(&matches::MATCH_REF_PATS),
- LintId::of(&matches::REDUNDANT_PATTERN_MATCHING),
- LintId::of(&matches::SINGLE_MATCH),
- LintId::of(&mem_replace::MEM_REPLACE_OPTION_WITH_NONE),
- LintId::of(&mem_replace::MEM_REPLACE_WITH_DEFAULT),
- LintId::of(&methods::BYTES_NTH),
- LintId::of(&methods::CHARS_LAST_CMP),
- LintId::of(&methods::CHARS_NEXT_CMP),
- LintId::of(&methods::FROM_ITER_INSTEAD_OF_COLLECT),
- LintId::of(&methods::INTO_ITER_ON_REF),
- LintId::of(&methods::ITER_CLONED_COLLECT),
- LintId::of(&methods::ITER_NEXT_SLICE),
- LintId::of(&methods::ITER_NTH_ZERO),
- LintId::of(&methods::ITER_SKIP_NEXT),
- LintId::of(&methods::MANUAL_SATURATING_ARITHMETIC),
- LintId::of(&methods::MAP_COLLECT_RESULT_UNIT),
- LintId::of(&methods::NEW_RET_NO_SELF),
- LintId::of(&methods::OK_EXPECT),
- LintId::of(&methods::OPTION_MAP_OR_NONE),
- LintId::of(&methods::RESULT_MAP_OR_INTO_OPTION),
- LintId::of(&methods::SHOULD_IMPLEMENT_TRAIT),
- LintId::of(&methods::SINGLE_CHAR_ADD_STR),
- LintId::of(&methods::STRING_EXTEND_CHARS),
- LintId::of(&methods::UNNECESSARY_FOLD),
- LintId::of(&methods::UNNECESSARY_LAZY_EVALUATIONS),
- LintId::of(&methods::WRONG_SELF_CONVENTION),
- LintId::of(&misc::TOPLEVEL_REF_ARG),
- LintId::of(&misc::ZERO_PTR),
- LintId::of(&misc_early::BUILTIN_TYPE_SHADOW),
- LintId::of(&misc_early::DOUBLE_NEG),
- LintId::of(&misc_early::DUPLICATE_UNDERSCORE_ARGUMENT),
- LintId::of(&misc_early::MIXED_CASE_HEX_LITERALS),
- LintId::of(&misc_early::REDUNDANT_PATTERN),
- LintId::of(&mut_mutex_lock::MUT_MUTEX_LOCK),
- LintId::of(&mut_reference::UNNECESSARY_MUT_PASSED),
- LintId::of(&neg_multiply::NEG_MULTIPLY),
- LintId::of(&new_without_default::NEW_WITHOUT_DEFAULT),
- LintId::of(&non_copy_const::BORROW_INTERIOR_MUTABLE_CONST),
- LintId::of(&non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST),
- LintId::of(&non_expressive_names::JUST_UNDERSCORES_AND_DIGITS),
- LintId::of(&non_expressive_names::MANY_SINGLE_CHAR_NAMES),
- LintId::of(&ptr::CMP_NULL),
- LintId::of(&ptr::PTR_ARG),
- LintId::of(&ptr_eq::PTR_EQ),
- LintId::of(&question_mark::QUESTION_MARK),
- LintId::of(&ranges::MANUAL_RANGE_CONTAINS),
- LintId::of(&redundant_field_names::REDUNDANT_FIELD_NAMES),
- LintId::of(&redundant_static_lifetimes::REDUNDANT_STATIC_LIFETIMES),
- LintId::of(&returns::LET_AND_RETURN),
- LintId::of(&returns::NEEDLESS_RETURN),
- LintId::of(&single_component_path_imports::SINGLE_COMPONENT_PATH_IMPORTS),
- LintId::of(&suspicious_operation_groupings::SUSPICIOUS_OPERATION_GROUPINGS),
- LintId::of(&tabs_in_doc_comments::TABS_IN_DOC_COMMENTS),
- LintId::of(&to_digit_is_some::TO_DIGIT_IS_SOME),
- LintId::of(&try_err::TRY_ERR),
- LintId::of(&unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME),
- LintId::of(&unused_unit::UNUSED_UNIT),
- LintId::of(&upper_case_acronyms::UPPER_CASE_ACRONYMS),
- LintId::of(&write::PRINTLN_EMPTY_STRING),
- LintId::of(&write::PRINT_LITERAL),
- LintId::of(&write::PRINT_WITH_NEWLINE),
- LintId::of(&write::WRITELN_EMPTY_STRING),
- LintId::of(&write::WRITE_LITERAL),
- LintId::of(&write::WRITE_WITH_NEWLINE),
+ LintId::of(assertions_on_constants::ASSERTIONS_ON_CONSTANTS),
+ LintId::of(assign_ops::ASSIGN_OP_PATTERN),
+ LintId::of(attrs::BLANKET_CLIPPY_RESTRICTION_LINTS),
+ LintId::of(blacklisted_name::BLACKLISTED_NAME),
+ LintId::of(blocks_in_if_conditions::BLOCKS_IN_IF_CONDITIONS),
+ LintId::of(casts::FN_TO_NUMERIC_CAST),
+ LintId::of(casts::FN_TO_NUMERIC_CAST_WITH_TRUNCATION),
+ LintId::of(collapsible_if::COLLAPSIBLE_ELSE_IF),
+ LintId::of(collapsible_if::COLLAPSIBLE_IF),
+ LintId::of(collapsible_match::COLLAPSIBLE_MATCH),
+ LintId::of(comparison_chain::COMPARISON_CHAIN),
+ LintId::of(default::FIELD_REASSIGN_WITH_DEFAULT),
+ LintId::of(doc::MISSING_SAFETY_DOC),
+ LintId::of(doc::NEEDLESS_DOCTEST_MAIN),
+ LintId::of(enum_variants::ENUM_VARIANT_NAMES),
+ LintId::of(enum_variants::MODULE_INCEPTION),
+ LintId::of(eq_op::OP_REF),
+ LintId::of(eta_reduction::REDUNDANT_CLOSURE),
+ LintId::of(float_literal::EXCESSIVE_PRECISION),
+ LintId::of(formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING),
+ LintId::of(formatting::SUSPICIOUS_ELSE_FORMATTING),
+ LintId::of(formatting::SUSPICIOUS_UNARY_OP_FORMATTING),
+ LintId::of(from_over_into::FROM_OVER_INTO),
+ LintId::of(from_str_radix_10::FROM_STR_RADIX_10),
+ LintId::of(functions::DOUBLE_MUST_USE),
+ LintId::of(functions::MUST_USE_UNIT),
+ LintId::of(functions::RESULT_UNIT_ERR),
+ LintId::of(if_let_some_result::IF_LET_SOME_RESULT),
+ LintId::of(inconsistent_struct_constructor::INCONSISTENT_STRUCT_CONSTRUCTOR),
+ LintId::of(inherent_to_string::INHERENT_TO_STRING),
+ LintId::of(len_zero::COMPARISON_TO_EMPTY),
+ LintId::of(len_zero::LEN_WITHOUT_IS_EMPTY),
+ LintId::of(len_zero::LEN_ZERO),
+ LintId::of(literal_representation::INCONSISTENT_DIGIT_GROUPING),
+ LintId::of(literal_representation::UNUSUAL_BYTE_GROUPINGS),
+ LintId::of(loops::EMPTY_LOOP),
+ LintId::of(loops::FOR_KV_MAP),
+ LintId::of(loops::NEEDLESS_RANGE_LOOP),
+ LintId::of(loops::SAME_ITEM_PUSH),
+ LintId::of(loops::WHILE_LET_ON_ITERATOR),
+ LintId::of(main_recursion::MAIN_RECURSION),
+ LintId::of(manual_async_fn::MANUAL_ASYNC_FN),
+ LintId::of(manual_map::MANUAL_MAP),
+ LintId::of(manual_non_exhaustive::MANUAL_NON_EXHAUSTIVE),
+ LintId::of(map_clone::MAP_CLONE),
+ LintId::of(matches::INFALLIBLE_DESTRUCTURING_MATCH),
+ LintId::of(matches::MATCH_LIKE_MATCHES_MACRO),
+ LintId::of(matches::MATCH_OVERLAPPING_ARM),
+ LintId::of(matches::MATCH_REF_PATS),
+ LintId::of(matches::REDUNDANT_PATTERN_MATCHING),
+ LintId::of(matches::SINGLE_MATCH),
+ LintId::of(mem_replace::MEM_REPLACE_OPTION_WITH_NONE),
+ LintId::of(mem_replace::MEM_REPLACE_WITH_DEFAULT),
+ LintId::of(methods::BYTES_NTH),
+ LintId::of(methods::CHARS_LAST_CMP),
+ LintId::of(methods::CHARS_NEXT_CMP),
+ LintId::of(methods::FROM_ITER_INSTEAD_OF_COLLECT),
+ LintId::of(methods::INTO_ITER_ON_REF),
+ LintId::of(methods::ITER_CLONED_COLLECT),
+ LintId::of(methods::ITER_NEXT_SLICE),
+ LintId::of(methods::ITER_NTH_ZERO),
+ LintId::of(methods::ITER_SKIP_NEXT),
+ LintId::of(methods::MANUAL_SATURATING_ARITHMETIC),
+ LintId::of(methods::MAP_COLLECT_RESULT_UNIT),
+ LintId::of(methods::NEW_RET_NO_SELF),
+ LintId::of(methods::OK_EXPECT),
+ LintId::of(methods::OPTION_MAP_OR_NONE),
+ LintId::of(methods::RESULT_MAP_OR_INTO_OPTION),
+ LintId::of(methods::SHOULD_IMPLEMENT_TRAIT),
+ LintId::of(methods::SINGLE_CHAR_ADD_STR),
+ LintId::of(methods::STRING_EXTEND_CHARS),
+ LintId::of(methods::UNNECESSARY_FOLD),
+ LintId::of(methods::UNNECESSARY_LAZY_EVALUATIONS),
+ LintId::of(methods::WRONG_SELF_CONVENTION),
+ LintId::of(misc::TOPLEVEL_REF_ARG),
+ LintId::of(misc::ZERO_PTR),
+ LintId::of(misc_early::BUILTIN_TYPE_SHADOW),
+ LintId::of(misc_early::DOUBLE_NEG),
+ LintId::of(misc_early::DUPLICATE_UNDERSCORE_ARGUMENT),
+ LintId::of(misc_early::MIXED_CASE_HEX_LITERALS),
+ LintId::of(misc_early::REDUNDANT_PATTERN),
+ LintId::of(mut_mutex_lock::MUT_MUTEX_LOCK),
+ LintId::of(mut_reference::UNNECESSARY_MUT_PASSED),
+ LintId::of(neg_multiply::NEG_MULTIPLY),
+ LintId::of(new_without_default::NEW_WITHOUT_DEFAULT),
+ LintId::of(non_copy_const::BORROW_INTERIOR_MUTABLE_CONST),
+ LintId::of(non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST),
+ LintId::of(non_expressive_names::JUST_UNDERSCORES_AND_DIGITS),
+ LintId::of(non_expressive_names::MANY_SINGLE_CHAR_NAMES),
+ LintId::of(ptr::CMP_NULL),
+ LintId::of(ptr::PTR_ARG),
+ LintId::of(ptr_eq::PTR_EQ),
+ LintId::of(question_mark::QUESTION_MARK),
+ LintId::of(ranges::MANUAL_RANGE_CONTAINS),
+ LintId::of(redundant_field_names::REDUNDANT_FIELD_NAMES),
+ LintId::of(redundant_static_lifetimes::REDUNDANT_STATIC_LIFETIMES),
+ LintId::of(returns::LET_AND_RETURN),
+ LintId::of(returns::NEEDLESS_RETURN),
+ LintId::of(single_component_path_imports::SINGLE_COMPONENT_PATH_IMPORTS),
+ LintId::of(suspicious_operation_groupings::SUSPICIOUS_OPERATION_GROUPINGS),
+ LintId::of(tabs_in_doc_comments::TABS_IN_DOC_COMMENTS),
+ LintId::of(to_digit_is_some::TO_DIGIT_IS_SOME),
+ LintId::of(try_err::TRY_ERR),
+ LintId::of(unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME),
+ LintId::of(unused_unit::UNUSED_UNIT),
+ LintId::of(upper_case_acronyms::UPPER_CASE_ACRONYMS),
+ LintId::of(write::PRINTLN_EMPTY_STRING),
+ LintId::of(write::PRINT_LITERAL),
+ LintId::of(write::PRINT_WITH_NEWLINE),
+ LintId::of(write::WRITELN_EMPTY_STRING),
+ LintId::of(write::WRITE_LITERAL),
+ LintId::of(write::WRITE_WITH_NEWLINE),
]);
store.register_group(true, "clippy::complexity", Some("clippy_complexity"), vec![
- LintId::of(&assign_ops::MISREFACTORED_ASSIGN_OP),
- LintId::of(&attrs::DEPRECATED_CFG_ATTR),
- LintId::of(&booleans::NONMINIMAL_BOOL),
- LintId::of(&casts::CHAR_LIT_AS_U8),
- LintId::of(&casts::UNNECESSARY_CAST),
- LintId::of(&copies::BRANCHES_SHARING_CODE),
- LintId::of(&double_comparison::DOUBLE_COMPARISONS),
- LintId::of(&double_parens::DOUBLE_PARENS),
- LintId::of(&duration_subsec::DURATION_SUBSEC),
- LintId::of(&eval_order_dependence::DIVERGING_SUB_EXPRESSION),
- LintId::of(&eval_order_dependence::EVAL_ORDER_DEPENDENCE),
- LintId::of(&explicit_write::EXPLICIT_WRITE),
- LintId::of(&format::USELESS_FORMAT),
- LintId::of(&functions::TOO_MANY_ARGUMENTS),
- LintId::of(&get_last_with_len::GET_LAST_WITH_LEN),
- LintId::of(&identity_op::IDENTITY_OP),
- LintId::of(&int_plus_one::INT_PLUS_ONE),
- LintId::of(&lifetimes::EXTRA_UNUSED_LIFETIMES),
- LintId::of(&lifetimes::NEEDLESS_LIFETIMES),
- LintId::of(&loops::EXPLICIT_COUNTER_LOOP),
- LintId::of(&loops::MANUAL_FLATTEN),
- LintId::of(&loops::MUT_RANGE_BOUND),
- LintId::of(&loops::SINGLE_ELEMENT_LOOP),
- LintId::of(&loops::WHILE_LET_LOOP),
- LintId::of(&manual_strip::MANUAL_STRIP),
- LintId::of(&manual_unwrap_or::MANUAL_UNWRAP_OR),
- LintId::of(&map_identity::MAP_IDENTITY),
- LintId::of(&map_unit_fn::OPTION_MAP_UNIT_FN),
- LintId::of(&map_unit_fn::RESULT_MAP_UNIT_FN),
- LintId::of(&matches::MATCH_AS_REF),
- LintId::of(&matches::MATCH_SINGLE_BINDING),
- LintId::of(&matches::WILDCARD_IN_OR_PATTERNS),
- LintId::of(&methods::BIND_INSTEAD_OF_MAP),
- LintId::of(&methods::CLONE_ON_COPY),
- LintId::of(&methods::FILTER_MAP_IDENTITY),
- LintId::of(&methods::FILTER_NEXT),
- LintId::of(&methods::FLAT_MAP_IDENTITY),
- LintId::of(&methods::INSPECT_FOR_EACH),
- LintId::of(&methods::ITER_COUNT),
- LintId::of(&methods::MANUAL_FILTER_MAP),
- LintId::of(&methods::MANUAL_FIND_MAP),
- LintId::of(&methods::OPTION_AS_REF_DEREF),
- LintId::of(&methods::OPTION_FILTER_MAP),
- LintId::of(&methods::SEARCH_IS_SOME),
- LintId::of(&methods::SKIP_WHILE_NEXT),
- LintId::of(&methods::SUSPICIOUS_MAP),
- LintId::of(&methods::UNNECESSARY_FILTER_MAP),
- LintId::of(&methods::USELESS_ASREF),
- LintId::of(&misc::SHORT_CIRCUIT_STATEMENT),
- LintId::of(&misc_early::UNNEEDED_WILDCARD_PATTERN),
- LintId::of(&misc_early::ZERO_PREFIXED_LITERAL),
- LintId::of(&needless_arbitrary_self_type::NEEDLESS_ARBITRARY_SELF_TYPE),
- LintId::of(&needless_bool::BOOL_COMPARISON),
- LintId::of(&needless_bool::NEEDLESS_BOOL),
- LintId::of(&needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE),
- LintId::of(&needless_question_mark::NEEDLESS_QUESTION_MARK),
- LintId::of(&needless_update::NEEDLESS_UPDATE),
- LintId::of(&neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD),
- LintId::of(&no_effect::NO_EFFECT),
- LintId::of(&no_effect::UNNECESSARY_OPERATION),
- LintId::of(&overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL),
- LintId::of(&partialeq_ne_impl::PARTIALEQ_NE_IMPL),
- LintId::of(&precedence::PRECEDENCE),
- LintId::of(&ptr_offset_with_cast::PTR_OFFSET_WITH_CAST),
- LintId::of(&ranges::RANGE_ZIP_WITH_LEN),
- LintId::of(&redundant_closure_call::REDUNDANT_CLOSURE_CALL),
- LintId::of(&redundant_slicing::REDUNDANT_SLICING),
- LintId::of(&reference::DEREF_ADDROF),
- LintId::of(&reference::REF_IN_DEREF),
- LintId::of(&repeat_once::REPEAT_ONCE),
- LintId::of(&strings::STRING_FROM_UTF8_AS_BYTES),
- LintId::of(&swap::MANUAL_SWAP),
- LintId::of(&temporary_assignment::TEMPORARY_ASSIGNMENT),
- LintId::of(&transmute::CROSSPOINTER_TRANSMUTE),
- LintId::of(&transmute::TRANSMUTES_EXPRESSIBLE_AS_PTR_CASTS),
- LintId::of(&transmute::TRANSMUTE_BYTES_TO_STR),
- LintId::of(&transmute::TRANSMUTE_FLOAT_TO_INT),
- LintId::of(&transmute::TRANSMUTE_INT_TO_BOOL),
- LintId::of(&transmute::TRANSMUTE_INT_TO_CHAR),
- LintId::of(&transmute::TRANSMUTE_INT_TO_FLOAT),
- LintId::of(&transmute::TRANSMUTE_PTR_TO_PTR),
- LintId::of(&transmute::TRANSMUTE_PTR_TO_REF),
- LintId::of(&types::BORROWED_BOX),
- LintId::of(&types::TYPE_COMPLEXITY),
- LintId::of(&types::VEC_BOX),
- LintId::of(&unit_types::UNIT_ARG),
- LintId::of(&unnecessary_sort_by::UNNECESSARY_SORT_BY),
- LintId::of(&unwrap::UNNECESSARY_UNWRAP),
- LintId::of(&useless_conversion::USELESS_CONVERSION),
- LintId::of(&zero_div_zero::ZERO_DIVIDED_BY_ZERO),
+ LintId::of(assign_ops::MISREFACTORED_ASSIGN_OP),
+ LintId::of(attrs::DEPRECATED_CFG_ATTR),
+ LintId::of(booleans::NONMINIMAL_BOOL),
+ LintId::of(casts::CHAR_LIT_AS_U8),
+ LintId::of(casts::UNNECESSARY_CAST),
+ LintId::of(copies::BRANCHES_SHARING_CODE),
+ LintId::of(double_comparison::DOUBLE_COMPARISONS),
+ LintId::of(double_parens::DOUBLE_PARENS),
+ LintId::of(duration_subsec::DURATION_SUBSEC),
+ LintId::of(eval_order_dependence::DIVERGING_SUB_EXPRESSION),
+ LintId::of(eval_order_dependence::EVAL_ORDER_DEPENDENCE),
+ LintId::of(explicit_write::EXPLICIT_WRITE),
+ LintId::of(format::USELESS_FORMAT),
+ LintId::of(functions::TOO_MANY_ARGUMENTS),
+ LintId::of(get_last_with_len::GET_LAST_WITH_LEN),
+ LintId::of(identity_op::IDENTITY_OP),
+ LintId::of(int_plus_one::INT_PLUS_ONE),
+ LintId::of(lifetimes::EXTRA_UNUSED_LIFETIMES),
+ LintId::of(lifetimes::NEEDLESS_LIFETIMES),
+ LintId::of(loops::EXPLICIT_COUNTER_LOOP),
+ LintId::of(loops::MANUAL_FLATTEN),
+ LintId::of(loops::MUT_RANGE_BOUND),
+ LintId::of(loops::SINGLE_ELEMENT_LOOP),
+ LintId::of(loops::WHILE_LET_LOOP),
+ LintId::of(manual_strip::MANUAL_STRIP),
+ LintId::of(manual_unwrap_or::MANUAL_UNWRAP_OR),
+ LintId::of(map_identity::MAP_IDENTITY),
+ LintId::of(map_unit_fn::OPTION_MAP_UNIT_FN),
+ LintId::of(map_unit_fn::RESULT_MAP_UNIT_FN),
+ LintId::of(matches::MATCH_AS_REF),
+ LintId::of(matches::MATCH_SINGLE_BINDING),
+ LintId::of(matches::WILDCARD_IN_OR_PATTERNS),
+ LintId::of(methods::BIND_INSTEAD_OF_MAP),
+ LintId::of(methods::CLONE_ON_COPY),
+ LintId::of(methods::FILTER_MAP_IDENTITY),
+ LintId::of(methods::FILTER_NEXT),
+ LintId::of(methods::FLAT_MAP_IDENTITY),
+ LintId::of(methods::INSPECT_FOR_EACH),
+ LintId::of(methods::ITER_COUNT),
+ LintId::of(methods::MANUAL_FILTER_MAP),
+ LintId::of(methods::MANUAL_FIND_MAP),
+ LintId::of(methods::OPTION_AS_REF_DEREF),
+ LintId::of(methods::OPTION_FILTER_MAP),
+ LintId::of(methods::SEARCH_IS_SOME),
+ LintId::of(methods::SKIP_WHILE_NEXT),
+ LintId::of(methods::SUSPICIOUS_MAP),
+ LintId::of(methods::UNNECESSARY_FILTER_MAP),
+ LintId::of(methods::USELESS_ASREF),
+ LintId::of(misc::SHORT_CIRCUIT_STATEMENT),
+ LintId::of(misc_early::UNNEEDED_WILDCARD_PATTERN),
+ LintId::of(misc_early::ZERO_PREFIXED_LITERAL),
+ LintId::of(needless_arbitrary_self_type::NEEDLESS_ARBITRARY_SELF_TYPE),
+ LintId::of(needless_bool::BOOL_COMPARISON),
+ LintId::of(needless_bool::NEEDLESS_BOOL),
+ LintId::of(needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE),
+ LintId::of(needless_question_mark::NEEDLESS_QUESTION_MARK),
+ LintId::of(needless_update::NEEDLESS_UPDATE),
+ LintId::of(neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD),
+ LintId::of(no_effect::NO_EFFECT),
+ LintId::of(no_effect::UNNECESSARY_OPERATION),
+ LintId::of(overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL),
+ LintId::of(partialeq_ne_impl::PARTIALEQ_NE_IMPL),
+ LintId::of(precedence::PRECEDENCE),
+ LintId::of(ptr_offset_with_cast::PTR_OFFSET_WITH_CAST),
+ LintId::of(ranges::RANGE_ZIP_WITH_LEN),
+ LintId::of(redundant_closure_call::REDUNDANT_CLOSURE_CALL),
+ LintId::of(redundant_slicing::REDUNDANT_SLICING),
+ LintId::of(reference::DEREF_ADDROF),
+ LintId::of(reference::REF_IN_DEREF),
+ LintId::of(repeat_once::REPEAT_ONCE),
+ LintId::of(strings::STRING_FROM_UTF8_AS_BYTES),
+ LintId::of(swap::MANUAL_SWAP),
+ LintId::of(temporary_assignment::TEMPORARY_ASSIGNMENT),
+ LintId::of(transmute::CROSSPOINTER_TRANSMUTE),
+ LintId::of(transmute::TRANSMUTES_EXPRESSIBLE_AS_PTR_CASTS),
+ LintId::of(transmute::TRANSMUTE_BYTES_TO_STR),
+ LintId::of(transmute::TRANSMUTE_FLOAT_TO_INT),
+ LintId::of(transmute::TRANSMUTE_INT_TO_BOOL),
+ LintId::of(transmute::TRANSMUTE_INT_TO_CHAR),
+ LintId::of(transmute::TRANSMUTE_INT_TO_FLOAT),
+ LintId::of(transmute::TRANSMUTE_PTR_TO_PTR),
+ LintId::of(transmute::TRANSMUTE_PTR_TO_REF),
+ LintId::of(types::BORROWED_BOX),
+ LintId::of(types::TYPE_COMPLEXITY),
+ LintId::of(types::VEC_BOX),
+ LintId::of(unit_types::UNIT_ARG),
+ LintId::of(unnecessary_sort_by::UNNECESSARY_SORT_BY),
+ LintId::of(unwrap::UNNECESSARY_UNWRAP),
+ LintId::of(useless_conversion::USELESS_CONVERSION),
+ LintId::of(zero_div_zero::ZERO_DIVIDED_BY_ZERO),
]);
store.register_group(true, "clippy::correctness", Some("clippy_correctness"), vec![
- LintId::of(&absurd_extreme_comparisons::ABSURD_EXTREME_COMPARISONS),
- LintId::of(&approx_const::APPROX_CONSTANT),
- LintId::of(&async_yields_async::ASYNC_YIELDS_ASYNC),
- LintId::of(&atomic_ordering::INVALID_ATOMIC_ORDERING),
- LintId::of(&attrs::DEPRECATED_SEMVER),
- LintId::of(&attrs::MISMATCHED_TARGET_OS),
- LintId::of(&attrs::USELESS_ATTRIBUTE),
- LintId::of(&bit_mask::BAD_BIT_MASK),
- LintId::of(&bit_mask::INEFFECTIVE_BIT_MASK),
- LintId::of(&booleans::LOGIC_BUG),
- LintId::of(&casts::CAST_REF_TO_MUT),
- LintId::of(&copies::IFS_SAME_COND),
- LintId::of(&copies::IF_SAME_THEN_ELSE),
- LintId::of(&derive::DERIVE_HASH_XOR_EQ),
- LintId::of(&derive::DERIVE_ORD_XOR_PARTIAL_ORD),
- LintId::of(&drop_forget_ref::DROP_COPY),
- LintId::of(&drop_forget_ref::DROP_REF),
- LintId::of(&drop_forget_ref::FORGET_COPY),
- LintId::of(&drop_forget_ref::FORGET_REF),
- LintId::of(&enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT),
- LintId::of(&eq_op::EQ_OP),
- LintId::of(&erasing_op::ERASING_OP),
- LintId::of(&float_equality_without_abs::FLOAT_EQUALITY_WITHOUT_ABS),
- LintId::of(&formatting::POSSIBLE_MISSING_COMMA),
- LintId::of(&functions::NOT_UNSAFE_PTR_ARG_DEREF),
- LintId::of(&if_let_mutex::IF_LET_MUTEX),
- LintId::of(&indexing_slicing::OUT_OF_BOUNDS_INDEXING),
- LintId::of(&infinite_iter::INFINITE_ITER),
- LintId::of(&inherent_to_string::INHERENT_TO_STRING_SHADOW_DISPLAY),
- LintId::of(&inline_fn_without_body::INLINE_FN_WITHOUT_BODY),
- LintId::of(&let_underscore::LET_UNDERSCORE_LOCK),
- LintId::of(&literal_representation::MISTYPED_LITERAL_SUFFIXES),
- LintId::of(&loops::FOR_LOOPS_OVER_FALLIBLES),
- LintId::of(&loops::ITER_NEXT_LOOP),
- LintId::of(&loops::NEVER_LOOP),
- LintId::of(&loops::WHILE_IMMUTABLE_CONDITION),
- LintId::of(&mem_discriminant::MEM_DISCRIMINANT_NON_ENUM),
- LintId::of(&mem_replace::MEM_REPLACE_WITH_UNINIT),
- LintId::of(&methods::CLONE_DOUBLE_REF),
- LintId::of(&methods::ITERATOR_STEP_BY_ZERO),
- LintId::of(&methods::UNINIT_ASSUMED_INIT),
- LintId::of(&methods::ZST_OFFSET),
- LintId::of(&minmax::MIN_MAX),
- LintId::of(&misc::CMP_NAN),
- LintId::of(&misc::FLOAT_CMP),
- LintId::of(&misc::MODULO_ONE),
- LintId::of(&mut_key::MUTABLE_KEY_TYPE),
- LintId::of(&non_octal_unix_permissions::NON_OCTAL_UNIX_PERMISSIONS),
- LintId::of(&open_options::NONSENSICAL_OPEN_OPTIONS),
- LintId::of(&option_env_unwrap::OPTION_ENV_UNWRAP),
- LintId::of(&ptr::MUT_FROM_REF),
- LintId::of(&ranges::REVERSED_EMPTY_RANGES),
- LintId::of(®ex::INVALID_REGEX),
- LintId::of(&self_assignment::SELF_ASSIGNMENT),
- LintId::of(&serde_api::SERDE_API_MISUSE),
- LintId::of(&size_of_in_element_count::SIZE_OF_IN_ELEMENT_COUNT),
- LintId::of(&suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL),
- LintId::of(&suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL),
- LintId::of(&swap::ALMOST_SWAPPED),
- LintId::of(&to_string_in_display::TO_STRING_IN_DISPLAY),
- LintId::of(&transmute::UNSOUND_COLLECTION_TRANSMUTE),
- LintId::of(&transmute::WRONG_TRANSMUTE),
- LintId::of(&transmuting_null::TRANSMUTING_NULL),
- LintId::of(&undropped_manually_drops::UNDROPPED_MANUALLY_DROPS),
- LintId::of(&unicode::INVISIBLE_CHARACTERS),
- LintId::of(&unit_return_expecting_ord::UNIT_RETURN_EXPECTING_ORD),
- LintId::of(&unit_types::UNIT_CMP),
- LintId::of(&unnamed_address::FN_ADDRESS_COMPARISONS),
- LintId::of(&unnamed_address::VTABLE_ADDRESS_COMPARISONS),
- LintId::of(&unused_io_amount::UNUSED_IO_AMOUNT),
- LintId::of(&unwrap::PANICKING_UNWRAP),
- LintId::of(&vec_resize_to_zero::VEC_RESIZE_TO_ZERO),
+ LintId::of(absurd_extreme_comparisons::ABSURD_EXTREME_COMPARISONS),
+ LintId::of(approx_const::APPROX_CONSTANT),
+ LintId::of(async_yields_async::ASYNC_YIELDS_ASYNC),
+ LintId::of(atomic_ordering::INVALID_ATOMIC_ORDERING),
+ LintId::of(attrs::DEPRECATED_SEMVER),
+ LintId::of(attrs::MISMATCHED_TARGET_OS),
+ LintId::of(attrs::USELESS_ATTRIBUTE),
+ LintId::of(bit_mask::BAD_BIT_MASK),
+ LintId::of(bit_mask::INEFFECTIVE_BIT_MASK),
+ LintId::of(booleans::LOGIC_BUG),
+ LintId::of(casts::CAST_REF_TO_MUT),
+ LintId::of(copies::IFS_SAME_COND),
+ LintId::of(copies::IF_SAME_THEN_ELSE),
+ LintId::of(derive::DERIVE_HASH_XOR_EQ),
+ LintId::of(derive::DERIVE_ORD_XOR_PARTIAL_ORD),
+ LintId::of(drop_forget_ref::DROP_COPY),
+ LintId::of(drop_forget_ref::DROP_REF),
+ LintId::of(drop_forget_ref::FORGET_COPY),
+ LintId::of(drop_forget_ref::FORGET_REF),
+ LintId::of(enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT),
+ LintId::of(eq_op::EQ_OP),
+ LintId::of(erasing_op::ERASING_OP),
+ LintId::of(float_equality_without_abs::FLOAT_EQUALITY_WITHOUT_ABS),
+ LintId::of(formatting::POSSIBLE_MISSING_COMMA),
+ LintId::of(functions::NOT_UNSAFE_PTR_ARG_DEREF),
+ LintId::of(if_let_mutex::IF_LET_MUTEX),
+ LintId::of(indexing_slicing::OUT_OF_BOUNDS_INDEXING),
+ LintId::of(infinite_iter::INFINITE_ITER),
+ LintId::of(inherent_to_string::INHERENT_TO_STRING_SHADOW_DISPLAY),
+ LintId::of(inline_fn_without_body::INLINE_FN_WITHOUT_BODY),
+ LintId::of(let_underscore::LET_UNDERSCORE_LOCK),
+ LintId::of(literal_representation::MISTYPED_LITERAL_SUFFIXES),
+ LintId::of(loops::FOR_LOOPS_OVER_FALLIBLES),
+ LintId::of(loops::ITER_NEXT_LOOP),
+ LintId::of(loops::NEVER_LOOP),
+ LintId::of(loops::WHILE_IMMUTABLE_CONDITION),
+ LintId::of(mem_discriminant::MEM_DISCRIMINANT_NON_ENUM),
+ LintId::of(mem_replace::MEM_REPLACE_WITH_UNINIT),
+ LintId::of(methods::CLONE_DOUBLE_REF),
+ LintId::of(methods::ITERATOR_STEP_BY_ZERO),
+ LintId::of(methods::UNINIT_ASSUMED_INIT),
+ LintId::of(methods::ZST_OFFSET),
+ LintId::of(minmax::MIN_MAX),
+ LintId::of(misc::CMP_NAN),
+ LintId::of(misc::FLOAT_CMP),
+ LintId::of(misc::MODULO_ONE),
+ LintId::of(mut_key::MUTABLE_KEY_TYPE),
+ LintId::of(non_octal_unix_permissions::NON_OCTAL_UNIX_PERMISSIONS),
+ LintId::of(open_options::NONSENSICAL_OPEN_OPTIONS),
+ LintId::of(option_env_unwrap::OPTION_ENV_UNWRAP),
+ LintId::of(ptr::MUT_FROM_REF),
+ LintId::of(ranges::REVERSED_EMPTY_RANGES),
+ LintId::of(regex::INVALID_REGEX),
+ LintId::of(self_assignment::SELF_ASSIGNMENT),
+ LintId::of(serde_api::SERDE_API_MISUSE),
+ LintId::of(size_of_in_element_count::SIZE_OF_IN_ELEMENT_COUNT),
+ LintId::of(suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL),
+ LintId::of(suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL),
+ LintId::of(swap::ALMOST_SWAPPED),
+ LintId::of(to_string_in_display::TO_STRING_IN_DISPLAY),
+ LintId::of(transmute::UNSOUND_COLLECTION_TRANSMUTE),
+ LintId::of(transmute::WRONG_TRANSMUTE),
+ LintId::of(transmuting_null::TRANSMUTING_NULL),
+ LintId::of(undropped_manually_drops::UNDROPPED_MANUALLY_DROPS),
+ LintId::of(unicode::INVISIBLE_CHARACTERS),
+ LintId::of(unit_return_expecting_ord::UNIT_RETURN_EXPECTING_ORD),
+ LintId::of(unit_types::UNIT_CMP),
+ LintId::of(unnamed_address::FN_ADDRESS_COMPARISONS),
+ LintId::of(unnamed_address::VTABLE_ADDRESS_COMPARISONS),
+ LintId::of(unused_io_amount::UNUSED_IO_AMOUNT),
+ LintId::of(unwrap::PANICKING_UNWRAP),
+ LintId::of(vec_resize_to_zero::VEC_RESIZE_TO_ZERO),
]);
store.register_group(true, "clippy::perf", Some("clippy_perf"), vec![
- LintId::of(&entry::MAP_ENTRY),
- LintId::of(&escape::BOXED_LOCAL),
- LintId::of(&large_const_arrays::LARGE_CONST_ARRAYS),
- LintId::of(&large_enum_variant::LARGE_ENUM_VARIANT),
- LintId::of(&loops::MANUAL_MEMCPY),
- LintId::of(&loops::NEEDLESS_COLLECT),
- LintId::of(&methods::EXPECT_FUN_CALL),
- LintId::of(&methods::ITER_NTH),
- LintId::of(&methods::OR_FUN_CALL),
- LintId::of(&methods::SINGLE_CHAR_PATTERN),
- LintId::of(&misc::CMP_OWNED),
- LintId::of(&mutex_atomic::MUTEX_ATOMIC),
- LintId::of(&redundant_clone::REDUNDANT_CLONE),
- LintId::of(&slow_vector_initialization::SLOW_VECTOR_INITIALIZATION),
- LintId::of(&stable_sort_primitive::STABLE_SORT_PRIMITIVE),
- LintId::of(&types::BOX_VEC),
- LintId::of(&types::REDUNDANT_ALLOCATION),
- LintId::of(&vec::USELESS_VEC),
- LintId::of(&vec_init_then_push::VEC_INIT_THEN_PUSH),
+ LintId::of(entry::MAP_ENTRY),
+ LintId::of(escape::BOXED_LOCAL),
+ LintId::of(large_const_arrays::LARGE_CONST_ARRAYS),
+ LintId::of(large_enum_variant::LARGE_ENUM_VARIANT),
+ LintId::of(loops::MANUAL_MEMCPY),
+ LintId::of(loops::NEEDLESS_COLLECT),
+ LintId::of(methods::EXPECT_FUN_CALL),
+ LintId::of(methods::ITER_NTH),
+ LintId::of(methods::OR_FUN_CALL),
+ LintId::of(methods::SINGLE_CHAR_PATTERN),
+ LintId::of(misc::CMP_OWNED),
+ LintId::of(mutex_atomic::MUTEX_ATOMIC),
+ LintId::of(redundant_clone::REDUNDANT_CLONE),
+ LintId::of(slow_vector_initialization::SLOW_VECTOR_INITIALIZATION),
+ LintId::of(stable_sort_primitive::STABLE_SORT_PRIMITIVE),
+ LintId::of(types::BOX_VEC),
+ LintId::of(types::REDUNDANT_ALLOCATION),
+ LintId::of(vec::USELESS_VEC),
+ LintId::of(vec_init_then_push::VEC_INIT_THEN_PUSH),
]);
store.register_group(true, "clippy::cargo", Some("clippy_cargo"), vec![
- LintId::of(&cargo_common_metadata::CARGO_COMMON_METADATA),
- LintId::of(&multiple_crate_versions::MULTIPLE_CRATE_VERSIONS),
- LintId::of(&wildcard_dependencies::WILDCARD_DEPENDENCIES),
+ LintId::of(cargo_common_metadata::CARGO_COMMON_METADATA),
+ LintId::of(multiple_crate_versions::MULTIPLE_CRATE_VERSIONS),
+ LintId::of(wildcard_dependencies::WILDCARD_DEPENDENCIES),
]);
store.register_group(true, "clippy::nursery", Some("clippy_nursery"), vec![
- LintId::of(&attrs::EMPTY_LINE_AFTER_OUTER_ATTR),
- LintId::of(&cognitive_complexity::COGNITIVE_COMPLEXITY),
- LintId::of(&disallowed_method::DISALLOWED_METHOD),
- LintId::of(&fallible_impl_from::FALLIBLE_IMPL_FROM),
- LintId::of(&floating_point_arithmetic::IMPRECISE_FLOPS),
- LintId::of(&floating_point_arithmetic::SUBOPTIMAL_FLOPS),
- LintId::of(&future_not_send::FUTURE_NOT_SEND),
- LintId::of(&let_if_seq::USELESS_LET_IF_SEQ),
- LintId::of(&missing_const_for_fn::MISSING_CONST_FOR_FN),
- LintId::of(&mutable_debug_assertion::DEBUG_ASSERT_WITH_MUT_CALL),
- LintId::of(&mutex_atomic::MUTEX_INTEGER),
- LintId::of(&needless_borrow::NEEDLESS_BORROW),
- LintId::of(&path_buf_push_overwrite::PATH_BUF_PUSH_OVERWRITE),
- LintId::of(&redundant_pub_crate::REDUNDANT_PUB_CRATE),
- LintId::of(®ex::TRIVIAL_REGEX),
- LintId::of(&strings::STRING_LIT_AS_BYTES),
- LintId::of(&transmute::USELESS_TRANSMUTE),
- LintId::of(&use_self::USE_SELF),
+ LintId::of(attrs::EMPTY_LINE_AFTER_OUTER_ATTR),
+ LintId::of(cognitive_complexity::COGNITIVE_COMPLEXITY),
+ LintId::of(disallowed_method::DISALLOWED_METHOD),
+ LintId::of(fallible_impl_from::FALLIBLE_IMPL_FROM),
+ LintId::of(floating_point_arithmetic::IMPRECISE_FLOPS),
+ LintId::of(floating_point_arithmetic::SUBOPTIMAL_FLOPS),
+ LintId::of(future_not_send::FUTURE_NOT_SEND),
+ LintId::of(let_if_seq::USELESS_LET_IF_SEQ),
+ LintId::of(missing_const_for_fn::MISSING_CONST_FOR_FN),
+ LintId::of(mutable_debug_assertion::DEBUG_ASSERT_WITH_MUT_CALL),
+ LintId::of(mutex_atomic::MUTEX_INTEGER),
+ LintId::of(needless_borrow::NEEDLESS_BORROW),
+ LintId::of(path_buf_push_overwrite::PATH_BUF_PUSH_OVERWRITE),
+ LintId::of(redundant_pub_crate::REDUNDANT_PUB_CRATE),
+ LintId::of(regex::TRIVIAL_REGEX),
+ LintId::of(strings::STRING_LIT_AS_BYTES),
+ LintId::of(transmute::USELESS_TRANSMUTE),
+ LintId::of(use_self::USE_SELF),
]);
}
diff --git a/clippy_lints/src/lifetimes.rs b/clippy_lints/src/lifetimes.rs
index e3b3fa21cabb..116ad0728379 100644
--- a/clippy_lints/src/lifetimes.rs
+++ b/clippy_lints/src/lifetimes.rs
@@ -81,7 +81,7 @@ declare_lint_pass!(Lifetimes => [NEEDLESS_LIFETIMES, EXTRA_UNUSED_LIFETIMES]);
impl<'tcx> LateLintPass<'tcx> for Lifetimes {
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'_>) {
if let ItemKind::Fn(ref sig, ref generics, id) = item.kind {
- check_fn_inner(cx, &sig.decl, Some(id), generics, item.span, true);
+ check_fn_inner(cx, sig.decl, Some(id), generics, item.span, true);
}
}
@@ -90,7 +90,7 @@ impl<'tcx> LateLintPass<'tcx> for Lifetimes {
let report_extra_lifetimes = trait_ref_of_method(cx, item.hir_id()).is_none();
check_fn_inner(
cx,
- &sig.decl,
+ sig.decl,
Some(id),
&item.generics,
item.span,
@@ -105,7 +105,7 @@ impl<'tcx> LateLintPass<'tcx> for Lifetimes {
TraitFn::Required(_) => None,
TraitFn::Provided(id) => Some(id),
};
- check_fn_inner(cx, &sig.decl, body, &item.generics, item.span, true);
+ check_fn_inner(cx, sig.decl, body, &item.generics, item.span, true);
}
}
}
@@ -149,7 +149,7 @@ fn check_fn_inner<'tcx>(
.last()
.expect("a path must have at least one segment")
.args;
- if let Some(ref params) = *params {
+ if let Some(params) = *params {
let lifetimes = params.args.iter().filter_map(|arg| match arg {
GenericArg::Lifetime(lt) => Some(lt),
_ => None,
@@ -163,7 +163,7 @@ fn check_fn_inner<'tcx>(
}
}
}
- if could_use_elision(cx, decl, body, &generics.params) {
+ if could_use_elision(cx, decl, body, generics.params) {
span_lint(
cx,
NEEDLESS_LIFETIMES,
@@ -201,7 +201,7 @@ fn could_use_elision<'tcx>(
input_visitor.visit_ty(arg);
}
// extract lifetimes in output type
- if let Return(ref ty) = func.output {
+ if let Return(ty) = func.output {
output_visitor.visit_ty(ty);
}
for lt in named_generics {
@@ -416,12 +416,12 @@ fn has_where_lifetimes<'tcx>(cx: &LateContext<'tcx>, where_clause: &'tcx WhereCl
// a predicate like F: Trait or F: for<'a> Trait<'a>
let mut visitor = RefVisitor::new(cx);
// walk the type F, it may not contain LT refs
- walk_ty(&mut visitor, &pred.bounded_ty);
+ walk_ty(&mut visitor, pred.bounded_ty);
if !visitor.all_lts().is_empty() {
return true;
}
// if the bounds define new lifetimes, they are fine to occur
- let allowed_lts = allowed_lts_from(&pred.bound_generic_params);
+ let allowed_lts = allowed_lts_from(pred.bound_generic_params);
// now walk the bounds
for bound in pred.bounds.iter() {
walk_param_bound(&mut visitor, bound);
@@ -433,8 +433,8 @@ fn has_where_lifetimes<'tcx>(cx: &LateContext<'tcx>, where_clause: &'tcx WhereCl
},
WherePredicate::EqPredicate(ref pred) => {
let mut visitor = RefVisitor::new(cx);
- walk_ty(&mut visitor, &pred.lhs_ty);
- walk_ty(&mut visitor, &pred.rhs_ty);
+ walk_ty(&mut visitor, pred.lhs_ty);
+ walk_ty(&mut visitor, pred.rhs_ty);
if !visitor.lts.is_empty() {
return true;
}
diff --git a/clippy_lints/src/literal_representation.rs b/clippy_lints/src/literal_representation.rs
index 7fd55151226b..1d63af25803d 100644
--- a/clippy_lints/src/literal_representation.rs
+++ b/clippy_lints/src/literal_representation.rs
@@ -248,7 +248,7 @@ impl LiteralDigitGrouping {
fn check_lit(self, cx: &EarlyContext<'_>, lit: &Lit) {
if_chain! {
if let Some(src) = snippet_opt(cx, lit.span);
- if let Some(mut num_lit) = NumericLiteral::from_lit(&src, &lit);
+ if let Some(mut num_lit) = NumericLiteral::from_lit(&src, lit);
then {
if !Self::check_for_mistyped_suffix(cx, lit.span, &mut num_lit) {
return;
@@ -438,7 +438,7 @@ impl DecimalLiteralRepresentation {
if_chain! {
if let LitKind::Int(val, _) = lit.kind;
if let Some(src) = snippet_opt(cx, lit.span);
- if let Some(num_lit) = NumericLiteral::from_lit(&src, &lit);
+ if let Some(num_lit) = NumericLiteral::from_lit(&src, lit);
if num_lit.radix == Radix::Decimal;
if val >= u128::from(self.threshold);
then {
diff --git a/clippy_lints/src/loops/explicit_counter_loop.rs b/clippy_lints/src/loops/explicit_counter_loop.rs
index f14dbb1d6421..98e60f7ed85c 100644
--- a/clippy_lints/src/loops/explicit_counter_loop.rs
+++ b/clippy_lints/src/loops/explicit_counter_loop.rs
@@ -26,7 +26,7 @@ pub(super) fn check<'tcx>(
// For each candidate, check the parent block to see if
// it's initialized to zero at the start of the loop.
- if let Some(block) = get_enclosing_block(&cx, expr.hir_id) {
+ if let Some(block) = get_enclosing_block(cx, expr.hir_id) {
for id in increment_visitor.into_results() {
let mut initialize_visitor = InitializeVisitor::new(cx, expr, id);
walk_block(&mut initialize_visitor, block);
diff --git a/clippy_lints/src/loops/for_kv_map.rs b/clippy_lints/src/loops/for_kv_map.rs
index 8f18f54119bd..666b8c58728c 100644
--- a/clippy_lints/src/loops/for_kv_map.rs
+++ b/clippy_lints/src/loops/for_kv_map.rs
@@ -19,7 +19,7 @@ pub(super) fn check<'tcx>(
) {
let pat_span = pat.span;
- if let PatKind::Tuple(ref pat, _) = pat.kind {
+ if let PatKind::Tuple(pat, _) = pat.kind {
if pat.len() == 2 {
let arg_span = arg.span;
let (new_pat_span, kind, ty, mutbl) = match *cx.typeck_results().expr_ty(arg).kind() {
@@ -35,7 +35,7 @@ pub(super) fn check<'tcx>(
Mutability::Mut => "_mut",
};
let arg = match arg.kind {
- ExprKind::AddrOf(BorrowKind::Ref, _, ref expr) => &**expr,
+ ExprKind::AddrOf(BorrowKind::Ref, _, expr) => expr,
_ => arg,
};
diff --git a/clippy_lints/src/loops/manual_flatten.rs b/clippy_lints/src/loops/manual_flatten.rs
index 574ad8c0f29d..94743cfcf465 100644
--- a/clippy_lints/src/loops/manual_flatten.rs
+++ b/clippy_lints/src/loops/manual_flatten.rs
@@ -18,7 +18,7 @@ pub(super) fn check<'tcx>(
body: &'tcx Expr<'_>,
span: Span,
) {
- if let ExprKind::Block(ref block, _) = body.kind {
+ if let ExprKind::Block(block, _) = body.kind {
// Ensure the `if let` statement is the only expression or statement in the for-loop
let inner_expr = if block.stmts.len() == 1 && block.expr.is_none() {
let match_stmt = &block.stmts[0];
@@ -36,7 +36,7 @@ pub(super) fn check<'tcx>(
if_chain! {
if let Some(inner_expr) = inner_expr;
if let ExprKind::Match(
- ref match_expr, ref match_arms, MatchSource::IfLetDesugar{ contains_else_clause: false }
+ match_expr, match_arms, MatchSource::IfLetDesugar{ contains_else_clause: false }
) = inner_expr.kind;
// Ensure match_expr in `if let` statement is the same as the pat from the for-loop
if let PatKind::Binding(_, pat_hir_id, _, _) = pat.kind;
diff --git a/clippy_lints/src/loops/manual_memcpy.rs b/clippy_lints/src/loops/manual_memcpy.rs
index 3c5abb7a3c42..47005aba3889 100644
--- a/clippy_lints/src/loops/manual_memcpy.rs
+++ b/clippy_lints/src/loops/manual_memcpy.rs
@@ -63,8 +63,8 @@ pub(super) fn check<'tcx>(
if let ExprKind::Index(base_right, idx_right) = rhs.kind;
if is_slice_like(cx, cx.typeck_results().expr_ty(base_left));
if is_slice_like(cx, cx.typeck_results().expr_ty(base_right));
- if let Some((start_left, offset_left)) = get_details_from_idx(cx, &idx_left, &starts);
- if let Some((start_right, offset_right)) = get_details_from_idx(cx, &idx_right, &starts);
+ if let Some((start_left, offset_left)) = get_details_from_idx(cx, idx_left, &starts);
+ if let Some((start_right, offset_right)) = get_details_from_idx(cx, idx_right, &starts);
// Source and destination must be different
if path_to_local(base_left) != path_to_local(base_right);
@@ -168,8 +168,8 @@ fn build_manual_memcpy_suggestion<'tcx>(
},
};
- let (dst_offset, dst_limit) = print_offset_and_limit(&dst);
- let (src_offset, src_limit) = print_offset_and_limit(&src);
+ let (dst_offset, dst_limit) = print_offset_and_limit(dst);
+ let (src_offset, src_limit) = print_offset_and_limit(src);
let dst_base_str = snippet(cx, dst.base.span, "???");
let src_base_str = snippet(cx, src.base.span, "???");
@@ -435,7 +435,7 @@ fn get_loop_counters<'a, 'tcx>(
// For each candidate, check the parent block to see if
// it's initialized to zero at the start of the loop.
- get_enclosing_block(&cx, expr.hir_id).and_then(|block| {
+ get_enclosing_block(cx, expr.hir_id).and_then(|block| {
increment_visitor
.into_results()
.filter_map(move |var_id| {
diff --git a/clippy_lints/src/loops/mod.rs b/clippy_lints/src/loops/mod.rs
index 202914919987..28acefd51fef 100644
--- a/clippy_lints/src/loops/mod.rs
+++ b/clippy_lints/src/loops/mod.rs
@@ -562,7 +562,7 @@ impl<'tcx> LateLintPass<'tcx> for Loops {
// check for `loop { if let {} else break }` that could be `while let`
// (also matches an explicit "match" instead of "if let")
// (even if the "match" or "if let" is used for declaration)
- if let ExprKind::Loop(ref block, _, LoopSource::Loop, _) = expr.kind {
+ if let ExprKind::Loop(block, _, LoopSource::Loop, _) = expr.kind {
// also check for empty `loop {}` statements, skipping those in #[panic_handler]
empty_loop::check(cx, expr, block);
while_let_loop::check(cx, expr, block);
@@ -570,7 +570,7 @@ impl<'tcx> LateLintPass<'tcx> for Loops {
while_let_on_iterator::check(cx, expr);
- if let Some((cond, body)) = higher::while_loop(&expr) {
+ if let Some((cond, body)) = higher::while_loop(expr) {
while_immutable_condition::check(cx, cond, body);
}
@@ -602,7 +602,7 @@ fn check_for_loop<'tcx>(
fn check_for_loop_arg(cx: &LateContext<'_>, pat: &Pat<'_>, arg: &Expr<'_>, expr: &Expr<'_>) {
let mut next_loop_linted = false; // whether or not ITER_NEXT_LOOP lint was used
- if let ExprKind::MethodCall(ref method, _, ref args, _) = arg.kind {
+ if let ExprKind::MethodCall(method, _, args, _) = arg.kind {
// just the receiver, no arguments
if args.len() == 1 {
let method_name = &*method.ident.as_str();
diff --git a/clippy_lints/src/loops/needless_collect.rs b/clippy_lints/src/loops/needless_collect.rs
index e0c5caf51362..4d73aef76e87 100644
--- a/clippy_lints/src/loops/needless_collect.rs
+++ b/clippy_lints/src/loops/needless_collect.rs
@@ -21,10 +21,10 @@ pub(super) fn check<'tcx>(expr: &'tcx Expr<'_>, cx: &LateContext<'tcx>) {
}
fn check_needless_collect_direct_usage<'tcx>(expr: &'tcx Expr<'_>, cx: &LateContext<'tcx>) {
if_chain! {
- if let ExprKind::MethodCall(ref method, _, ref args, _) = expr.kind;
- if let ExprKind::MethodCall(ref chain_method, method0_span, _, _) = args[0].kind;
+ if let ExprKind::MethodCall(method, _, args, _) = expr.kind;
+ if let ExprKind::MethodCall(chain_method, method0_span, _, _) = args[0].kind;
if chain_method.ident.name == sym!(collect) && is_trait_method(cx, &args[0], sym::Iterator);
- if let Some(ref generic_args) = chain_method.args;
+ if let Some(generic_args) = chain_method.args;
if let Some(GenericArg::Type(ref ty)) = generic_args.args.get(0);
let ty = cx.typeck_results().node_type(ty.hir_id);
if is_type_diagnostic_item(cx, ty, sym::vec_type)
@@ -58,16 +58,16 @@ fn check_needless_collect_direct_usage<'tcx>(expr: &'tcx Expr<'_>, cx: &LateCont
}
fn check_needless_collect_indirect_usage<'tcx>(expr: &'tcx Expr<'_>, cx: &LateContext<'tcx>) {
- if let ExprKind::Block(ref block, _) = expr.kind {
- for ref stmt in block.stmts {
+ if let ExprKind::Block(block, _) = expr.kind {
+ for stmt in block.stmts {
if_chain! {
if let StmtKind::Local(
Local { pat: Pat { hir_id: pat_id, kind: PatKind::Binding(_, _, ident, .. ), .. },
- init: Some(ref init_expr), .. }
+ init: Some(init_expr), .. }
) = stmt.kind;
- if let ExprKind::MethodCall(ref method_name, collect_span, &[ref iter_source], ..) = init_expr.kind;
- if method_name.ident.name == sym!(collect) && is_trait_method(cx, &init_expr, sym::Iterator);
- if let Some(ref generic_args) = method_name.args;
+ if let ExprKind::MethodCall(method_name, collect_span, &[ref iter_source], ..) = init_expr.kind;
+ if method_name.ident.name == sym!(collect) && is_trait_method(cx, init_expr, sym::Iterator);
+ if let Some(generic_args) = method_name.args;
if let Some(GenericArg::Type(ref ty)) = generic_args.args.get(0);
if let ty = cx.typeck_results().node_type(ty.hir_id);
if is_type_diagnostic_item(cx, ty, sym::vec_type) ||
@@ -165,8 +165,8 @@ impl<'tcx> Visitor<'tcx> for IterFunctionVisitor {
fn visit_expr(&mut self, expr: &'tcx Expr<'tcx>) {
// Check function calls on our collection
if_chain! {
- if let ExprKind::MethodCall(method_name, _, ref args, _) = &expr.kind;
- if let Some(Expr { kind: ExprKind::Path(QPath::Resolved(_, ref path)), .. }) = args.get(0);
+ if let ExprKind::MethodCall(method_name, _, args, _) = &expr.kind;
+ if let Some(Expr { kind: ExprKind::Path(QPath::Resolved(_, path)), .. }) = args.get(0);
if let &[name] = &path.segments;
if name.ident == self.target;
then {
@@ -193,7 +193,7 @@ impl<'tcx> Visitor<'tcx> for IterFunctionVisitor {
}
// Check if the collection is used for anything else
if_chain! {
- if let Expr { kind: ExprKind::Path(QPath::Resolved(_, ref path)), .. } = expr;
+ if let Expr { kind: ExprKind::Path(QPath::Resolved(_, path)), .. } = expr;
if let &[name] = &path.segments;
if name.ident == self.target;
then {
diff --git a/clippy_lints/src/loops/needless_range_loop.rs b/clippy_lints/src/loops/needless_range_loop.rs
index 60afa449a455..56141fb38376 100644
--- a/clippy_lints/src/loops/needless_range_loop.rs
+++ b/clippy_lints/src/loops/needless_range_loop.rs
@@ -96,7 +96,7 @@ pub(super) fn check<'tcx>(
let take = if let Some(end) = *end {
let mut take_expr = end;
- if let ExprKind::Binary(ref op, ref left, ref right) = end.kind {
+ if let ExprKind::Binary(ref op, left, right) = end.kind {
if let BinOpKind::Add = op.node {
let start_equal_left = SpanlessEq::new(cx).eq_expr(start, left);
let start_equal_right = SpanlessEq::new(cx).eq_expr(start, right);
@@ -190,10 +190,10 @@ pub(super) fn check<'tcx>(
fn is_len_call(expr: &Expr<'_>, var: Symbol) -> bool {
if_chain! {
- if let ExprKind::MethodCall(ref method, _, ref len_args, _) = expr.kind;
+ if let ExprKind::MethodCall(method, _, len_args, _) = expr.kind;
if len_args.len() == 1;
if method.ident.name == sym!(len);
- if let ExprKind::Path(QPath::Resolved(_, ref path)) = len_args[0].kind;
+ if let ExprKind::Path(QPath::Resolved(_, path)) = len_args[0].kind;
if path.segments.len() == 1;
if path.segments[0].ident.name == var;
then {
@@ -254,7 +254,7 @@ impl<'a, 'tcx> VarVisitor<'a, 'tcx> {
if_chain! {
// the indexed container is referenced by a name
if let ExprKind::Path(ref seqpath) = seqexpr.kind;
- if let QPath::Resolved(None, ref seqvar) = *seqpath;
+ if let QPath::Resolved(None, seqvar) = *seqpath;
if seqvar.segments.len() == 1;
let index_used_directly = path_to_local_id(idx, self.var);
let indexed_indirectly = {
@@ -310,7 +310,7 @@ impl<'a, 'tcx> Visitor<'tcx> for VarVisitor<'a, 'tcx> {
fn visit_expr(&mut self, expr: &'tcx Expr<'_>) {
if_chain! {
// a range index op
- if let ExprKind::MethodCall(ref meth, _, ref args, _) = expr.kind;
+ if let ExprKind::MethodCall(meth, _, args, _) = expr.kind;
if (meth.ident.name == sym::index && match_trait_method(self.cx, expr, &paths::INDEX))
|| (meth.ident.name == sym::index_mut && match_trait_method(self.cx, expr, &paths::INDEX_MUT));
if !self.check(&args[1], &args[0], expr);
@@ -319,7 +319,7 @@ impl<'a, 'tcx> Visitor<'tcx> for VarVisitor<'a, 'tcx> {
if_chain! {
// an index op
- if let ExprKind::Index(ref seqexpr, ref idx) = expr.kind;
+ if let ExprKind::Index(seqexpr, idx) = expr.kind;
if !self.check(idx, seqexpr, expr);
then { return }
}
@@ -340,19 +340,19 @@ impl<'a, 'tcx> Visitor<'tcx> for VarVisitor<'a, 'tcx> {
let old = self.prefer_mutable;
match expr.kind {
- ExprKind::AssignOp(_, ref lhs, ref rhs) | ExprKind::Assign(ref lhs, ref rhs, _) => {
+ ExprKind::AssignOp(_, lhs, rhs) | ExprKind::Assign(lhs, rhs, _) => {
self.prefer_mutable = true;
self.visit_expr(lhs);
self.prefer_mutable = false;
self.visit_expr(rhs);
},
- ExprKind::AddrOf(BorrowKind::Ref, mutbl, ref expr) => {
+ ExprKind::AddrOf(BorrowKind::Ref, mutbl, expr) => {
if mutbl == Mutability::Mut {
self.prefer_mutable = true;
}
self.visit_expr(expr);
},
- ExprKind::Call(ref f, args) => {
+ ExprKind::Call(f, args) => {
self.visit_expr(f);
for expr in args {
let ty = self.cx.typeck_results().expr_ty_adjusted(expr);
diff --git a/clippy_lints/src/loops/never_loop.rs b/clippy_lints/src/loops/never_loop.rs
index f63a3761a0d1..e2cb4638018a 100644
--- a/clippy_lints/src/loops/never_loop.rs
+++ b/clippy_lints/src/loops/never_loop.rs
@@ -5,7 +5,7 @@ use rustc_lint::LateContext;
use std::iter::{once, Iterator};
pub(super) fn check(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::Loop(ref block, _, _, _) = expr.kind {
+ if let ExprKind::Loop(block, _, _, _) = expr.kind {
match never_loop_block(block, expr.hir_id) {
NeverLoopResult::AlwaysBreak => span_lint(cx, NEVER_LOOP, expr.span, "this loop never actually loops"),
NeverLoopResult::MayContinueMainLoop | NeverLoopResult::Otherwise => (),
@@ -76,36 +76,36 @@ fn never_loop_expr_seq<'a, T: Iterator<Item = &'a Expr<'a>>>(es: &mut T, main_lo
fn stmt_to_expr<'tcx>(stmt: &Stmt<'tcx>) -> Option<&'tcx Expr<'tcx>> {
match stmt.kind {
- StmtKind::Semi(ref e, ..) | StmtKind::Expr(ref e, ..) => Some(e),
- StmtKind::Local(ref local) => local.init.as_deref(),
+ StmtKind::Semi(e, ..) | StmtKind::Expr(e, ..) => Some(e),
+ StmtKind::Local(local) => local.init.as_deref(),
StmtKind::Item(..) => None,
}
}
fn never_loop_expr(expr: &Expr<'_>, main_loop_id: HirId) -> NeverLoopResult {
match expr.kind {
- ExprKind::Box(ref e)
- | ExprKind::Unary(_, ref e)
- | ExprKind::Cast(ref e, _)
- | ExprKind::Type(ref e, _)
- | ExprKind::Field(ref e, _)
- | ExprKind::AddrOf(_, _, ref e)
- | ExprKind::Struct(_, _, Some(ref e))
- | ExprKind::Repeat(ref e, _)
- | ExprKind::DropTemps(ref e) => never_loop_expr(e, main_loop_id),
- ExprKind::Array(ref es) | ExprKind::MethodCall(_, _, ref es, _) | ExprKind::Tup(ref es) => {
+ ExprKind::Box(e)
+ | ExprKind::Unary(_, e)
+ | ExprKind::Cast(e, _)
+ | ExprKind::Type(e, _)
+ | ExprKind::Field(e, _)
+ | ExprKind::AddrOf(_, _, e)
+ | ExprKind::Struct(_, _, Some(e))
+ | ExprKind::Repeat(e, _)
+ | ExprKind::DropTemps(e) => never_loop_expr(e, main_loop_id),
+ ExprKind::Array(es) | ExprKind::MethodCall(_, _, es, _) | ExprKind::Tup(es) => {
never_loop_expr_all(&mut es.iter(), main_loop_id)
},
- ExprKind::Call(ref e, ref es) => never_loop_expr_all(&mut once(&**e).chain(es.iter()), main_loop_id),
- ExprKind::Binary(_, ref e1, ref e2)
- | ExprKind::Assign(ref e1, ref e2, _)
- | ExprKind::AssignOp(_, ref e1, ref e2)
- | ExprKind::Index(ref e1, ref e2) => never_loop_expr_all(&mut [&**e1, &**e2].iter().cloned(), main_loop_id),
- ExprKind::Loop(ref b, _, _, _) => {
+ ExprKind::Call(e, es) => never_loop_expr_all(&mut once(e).chain(es.iter()), main_loop_id),
+ ExprKind::Binary(_, e1, e2)
+ | ExprKind::Assign(e1, e2, _)
+ | ExprKind::AssignOp(_, e1, e2)
+ | ExprKind::Index(e1, e2) => never_loop_expr_all(&mut [e1, e2].iter().cloned(), main_loop_id),
+ ExprKind::Loop(b, _, _, _) => {
// Break can come from the inner loop so remove them.
absorb_break(&never_loop_block(b, main_loop_id))
},
- ExprKind::If(ref e, ref e2, ref e3) => {
+ ExprKind::If(e, e2, ref e3) => {
let e1 = never_loop_expr(e, main_loop_id);
let e2 = never_loop_expr(e2, main_loop_id);
let e3 = e3
@@ -113,7 +113,7 @@ fn never_loop_expr(expr: &Expr<'_>, main_loop_id: HirId) -> NeverLoopResult {
.map_or(NeverLoopResult::Otherwise, |e| never_loop_expr(e, main_loop_id));
combine_seq(e1, combine_branches(e2, e3))
},
- ExprKind::Match(ref e, ref arms, _) => {
+ ExprKind::Match(e, arms, _) => {
let e = never_loop_expr(e, main_loop_id);
if arms.is_empty() {
e
@@ -122,7 +122,7 @@ fn never_loop_expr(expr: &Expr<'_>, main_loop_id: HirId) -> NeverLoopResult {
combine_seq(e, arms)
}
},
- ExprKind::Block(ref b, _) => never_loop_block(b, main_loop_id),
+ ExprKind::Block(b, _) => never_loop_block(b, main_loop_id),
ExprKind::Continue(d) => {
let id = d
.target_id
@@ -136,7 +136,7 @@ fn never_loop_expr(expr: &Expr<'_>, main_loop_id: HirId) -> NeverLoopResult {
ExprKind::Break(_, ref e) | ExprKind::Ret(ref e) => e.as_ref().map_or(NeverLoopResult::AlwaysBreak, |e| {
combine_seq(never_loop_expr(e, main_loop_id), NeverLoopResult::AlwaysBreak)
}),
- ExprKind::InlineAsm(ref asm) => asm
+ ExprKind::InlineAsm(asm) => asm
.operands
.iter()
.map(|(o, _)| match o {
diff --git a/clippy_lints/src/loops/same_item_push.rs b/clippy_lints/src/loops/same_item_push.rs
index b3d784474c82..cb2c83e90294 100644
--- a/clippy_lints/src/loops/same_item_push.rs
+++ b/clippy_lints/src/loops/same_item_push.rs
@@ -161,7 +161,7 @@ impl<'a, 'tcx> Visitor<'tcx> for SameItemPushVisitor<'a, 'tcx> {
if vec_push_option.is_none() {
// Current statement is not a push so visit inside
match &s.kind {
- StmtKind::Expr(expr) | StmtKind::Semi(expr) => self.visit_expr(&expr),
+ StmtKind::Expr(expr) | StmtKind::Semi(expr) => self.visit_expr(expr),
_ => {},
}
} else {
diff --git a/clippy_lints/src/loops/single_element_loop.rs b/clippy_lints/src/loops/single_element_loop.rs
index 8451c1c6130d..fc067e81bcaf 100644
--- a/clippy_lints/src/loops/single_element_loop.rs
+++ b/clippy_lints/src/loops/single_element_loop.rs
@@ -15,12 +15,12 @@ pub(super) fn check<'tcx>(
expr: &'tcx Expr<'_>,
) {
if_chain! {
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref arg_expr) = arg.kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, arg_expr) = arg.kind;
if let PatKind::Binding(.., target, _) = pat.kind;
if let ExprKind::Array([arg_expression]) = arg_expr.kind;
if let ExprKind::Path(ref list_item) = arg_expression.kind;
if let Some(list_item_name) = single_segment_path(list_item).map(|ps| ps.ident.name);
- if let ExprKind::Block(ref block, _) = body.kind;
+ if let ExprKind::Block(block, _) = body.kind;
if !block.stmts.is_empty();
then {
diff --git a/clippy_lints/src/loops/utils.rs b/clippy_lints/src/loops/utils.rs
index fc287d512491..4db6644b9d70 100644
--- a/clippy_lints/src/loops/utils.rs
+++ b/clippy_lints/src/loops/utils.rs
@@ -65,7 +65,7 @@ impl<'a, 'tcx> Visitor<'tcx> for IncrementVisitor<'a, 'tcx> {
}
match parent.kind {
- ExprKind::AssignOp(op, ref lhs, ref rhs) => {
+ ExprKind::AssignOp(op, lhs, rhs) => {
if lhs.hir_id == expr.hir_id {
*state = if op.node == BinOpKind::Add
&& is_integer_const(self.cx, rhs, 1)
@@ -79,7 +79,7 @@ impl<'a, 'tcx> Visitor<'tcx> for IncrementVisitor<'a, 'tcx> {
};
}
},
- ExprKind::Assign(ref lhs, _, _) if lhs.hir_id == expr.hir_id => {
+ ExprKind::Assign(lhs, _, _) if lhs.hir_id == expr.hir_id => {
*state = IncrementVisitorVarState::DontWarn
},
ExprKind::AddrOf(BorrowKind::Ref, mutability, _) if mutability == Mutability::Mut => {
@@ -153,7 +153,7 @@ impl<'a, 'tcx> Visitor<'tcx> for InitializeVisitor<'a, 'tcx> {
fn visit_stmt(&mut self, stmt: &'tcx Stmt<'_>) {
// Look for declarations of the variable
if_chain! {
- if let StmtKind::Local(ref local) = stmt.kind;
+ if let StmtKind::Local(local) = stmt.kind;
if local.pat.hir_id == self.var_id;
if let PatKind::Binding(.., ident, _) = local.pat.kind;
then {
@@ -191,10 +191,10 @@ impl<'a, 'tcx> Visitor<'tcx> for InitializeVisitor<'a, 'tcx> {
if let Some(parent) = get_parent_expr(self.cx, expr) {
match parent.kind {
- ExprKind::AssignOp(_, ref lhs, _) if lhs.hir_id == expr.hir_id => {
+ ExprKind::AssignOp(_, lhs, _) if lhs.hir_id == expr.hir_id => {
self.state = InitializeVisitorState::DontWarn;
},
- ExprKind::Assign(ref lhs, ref rhs, _) if lhs.hir_id == expr.hir_id => {
+ ExprKind::Assign(lhs, rhs, _) if lhs.hir_id == expr.hir_id => {
self.state = if_chain! {
if self.depth == 0;
if let InitializeVisitorState::Declared(name)
@@ -273,7 +273,7 @@ impl<'tcx> Visitor<'tcx> for LoopNestVisitor {
return;
}
match expr.kind {
- ExprKind::Assign(ref path, _, _) | ExprKind::AssignOp(_, ref path, _) => {
+ ExprKind::Assign(path, _, _) | ExprKind::AssignOp(_, path, _) => {
if path_to_local_id(path, self.iterator) {
self.nesting = RuledOut;
}
@@ -327,7 +327,7 @@ pub(super) fn make_iterator_snippet(cx: &LateContext<'_>, arg: &Expr<'_>, applic
// (&mut x).into_iter() ==> x.iter_mut()
match &arg.kind {
ExprKind::AddrOf(BorrowKind::Ref, mutability, arg_inner)
- if has_iter_method(cx, cx.typeck_results().expr_ty(&arg_inner)).is_some() =>
+ if has_iter_method(cx, cx.typeck_results().expr_ty(arg_inner)).is_some() =>
{
let meth_name = match mutability {
Mutability::Mut => "iter_mut",
@@ -335,7 +335,7 @@ pub(super) fn make_iterator_snippet(cx: &LateContext<'_>, arg: &Expr<'_>, applic
};
format!(
"{}.{}()",
- sugg::Sugg::hir_with_applicability(cx, &arg_inner, "_", applic_ref).maybe_par(),
+ sugg::Sugg::hir_with_applicability(cx, arg_inner, "_", applic_ref).maybe_par(),
meth_name,
)
}
diff --git a/clippy_lints/src/loops/while_let_loop.rs b/clippy_lints/src/loops/while_let_loop.rs
index ffe8c0c5494b..9c1720798529 100644
--- a/clippy_lints/src/loops/while_let_loop.rs
+++ b/clippy_lints/src/loops/while_let_loop.rs
@@ -11,14 +11,14 @@ pub(super) fn check(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, loop_block: &'
let inner_stmt_expr = extract_expr_from_first_stmt(loop_block);
// or extract the first expression (if any) from the block
if let Some(inner) = inner_stmt_expr.or_else(|| extract_first_expr(loop_block)) {
- if let ExprKind::Match(ref matchexpr, ref arms, ref source) = inner.kind {
+ if let ExprKind::Match(matchexpr, arms, ref source) = inner.kind {
// ensure "if let" compatible match structure
match *source {
MatchSource::Normal | MatchSource::IfLetDesugar { .. } => {
if arms.len() == 2
&& arms[0].guard.is_none()
&& arms[1].guard.is_none()
- && is_simple_break_expr(&arms[1].body)
+ && is_simple_break_expr(arms[1].body)
{
if in_external_macro(cx.sess(), expr.span) {
return;
@@ -57,7 +57,7 @@ fn extract_expr_from_first_stmt<'tcx>(block: &Block<'tcx>) -> Option<&'tcx Expr<
if block.stmts.is_empty() {
return None;
}
- if let StmtKind::Local(ref local) = block.stmts[0].kind {
+ if let StmtKind::Local(local) = block.stmts[0].kind {
local.init //.map(|expr| expr)
} else {
None
@@ -67,9 +67,9 @@ fn extract_expr_from_first_stmt<'tcx>(block: &Block<'tcx>) -> Option<&'tcx Expr<
/// If a block begins with an expression (with or without semicolon), return it.
fn extract_first_expr<'tcx>(block: &Block<'tcx>) -> Option<&'tcx Expr<'tcx>> {
match block.expr {
- Some(ref expr) if block.stmts.is_empty() => Some(expr),
+ Some(expr) if block.stmts.is_empty() => Some(expr),
None if !block.stmts.is_empty() => match block.stmts[0].kind {
- StmtKind::Expr(ref expr) | StmtKind::Semi(ref expr) => Some(expr),
+ StmtKind::Expr(expr) | StmtKind::Semi(expr) => Some(expr),
StmtKind::Local(..) | StmtKind::Item(..) => None,
},
_ => None,
@@ -82,7 +82,7 @@ fn extract_first_expr<'tcx>(block: &Block<'tcx>) -> Option<&'tcx Expr<'tcx>> {
fn is_simple_break_expr(expr: &Expr<'_>) -> bool {
match expr.kind {
ExprKind::Break(dest, ref passed_expr) if dest.label.is_none() && passed_expr.is_none() => true,
- ExprKind::Block(ref b, _) => extract_first_expr(b).map_or(false, |subexpr| is_simple_break_expr(subexpr)),
+ ExprKind::Block(b, _) => extract_first_expr(b).map_or(false, |subexpr| is_simple_break_expr(subexpr)),
_ => false,
}
}
diff --git a/clippy_lints/src/loops/while_let_on_iterator.rs b/clippy_lints/src/loops/while_let_on_iterator.rs
index 57fc6250a9ae..82715d9bafac 100644
--- a/clippy_lints/src/loops/while_let_on_iterator.rs
+++ b/clippy_lints/src/loops/while_let_on_iterator.rs
@@ -16,12 +16,10 @@ use rustc_middle::hir::map::Map;
use rustc_span::symbol::sym;
pub(super) fn check(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::Match(ref match_expr, ref arms, MatchSource::WhileLetDesugar) = expr.kind {
+ if let ExprKind::Match(match_expr, arms, MatchSource::WhileLetDesugar) = expr.kind {
let pat = &arms[0].pat.kind;
- if let (
- &PatKind::TupleStruct(ref qpath, ref pat_args, _),
- &ExprKind::MethodCall(ref method_path, _, ref method_args, _),
- ) = (pat, &match_expr.kind)
+ if let (&PatKind::TupleStruct(ref qpath, pat_args, _), &ExprKind::MethodCall(method_path, _, method_args, _)) =
+ (pat, &match_expr.kind)
{
let iter_expr = &method_args[0];
@@ -40,8 +38,8 @@ pub(super) fn check(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
&& is_trait_method(cx, match_expr, sym::Iterator)
&& lhs_constructor.ident.name == sym::Some
&& (pat_args.is_empty()
- || !is_refutable(cx, &pat_args[0])
- && !is_used_inside(cx, iter_expr, &arms[0].body)
+ || !is_refutable(cx, pat_args[0])
+ && !is_used_inside(cx, iter_expr, arms[0].body)
&& !is_iterator_used_after_while_let(cx, iter_expr)
&& !is_nested(cx, expr, &method_args[0]))
{
diff --git a/clippy_lints/src/manual_strip.rs b/clippy_lints/src/manual_strip.rs
index 9da37efddac9..dfa464ddb81a 100644
--- a/clippy_lints/src/manual_strip.rs
+++ b/clippy_lints/src/manual_strip.rs
@@ -91,7 +91,7 @@ impl<'tcx> LateLintPass<'tcx> for ManualStrip {
} else {
return;
};
- let target_res = cx.qpath_res(&target_path, target_arg.hir_id);
+ let target_res = cx.qpath_res(target_path, target_arg.hir_id);
if target_res == Res::Err {
return;
};
@@ -174,7 +174,7 @@ fn eq_pattern_length<'tcx>(cx: &LateContext<'tcx>, pattern: &Expr<'_>, expr: &'t
// Tests if `expr` is a `&str`.
fn is_ref_str(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
- match cx.typeck_results().expr_ty_adjusted(&expr).kind() {
+ match cx.typeck_results().expr_ty_adjusted(expr).kind() {
ty::Ref(_, ty, _) => ty.is_str(),
_ => false,
}
diff --git a/clippy_lints/src/map_clone.rs b/clippy_lints/src/map_clone.rs
index 9f1ab1f695d8..99c35ae3bbf4 100644
--- a/clippy_lints/src/map_clone.rs
+++ b/clippy_lints/src/map_clone.rs
@@ -52,7 +52,7 @@ impl<'tcx> LateLintPass<'tcx> for MapClone {
}
if_chain! {
- if let hir::ExprKind::MethodCall(ref method, _, ref args, _) = e.kind;
+ if let hir::ExprKind::MethodCall(method, _, args, _) = e.kind;
if args.len() == 2;
if method.ident.name == sym::map;
let ty = cx.typeck_results().expr_ty(&args[0]);
@@ -62,7 +62,7 @@ impl<'tcx> LateLintPass<'tcx> for MapClone {
let closure_body = cx.tcx.hir().body(body_id);
let closure_expr = remove_blocks(&closure_body.value);
match closure_body.params[0].pat.kind {
- hir::PatKind::Ref(ref inner, hir::Mutability::Not) => if let hir::PatKind::Binding(
+ hir::PatKind::Ref(inner, hir::Mutability::Not) => if let hir::PatKind::Binding(
hir::BindingAnnotation::Unannotated, .., name, None
) = inner.kind {
if ident_eq(name, closure_expr) {
@@ -71,14 +71,14 @@ impl<'tcx> LateLintPass<'tcx> for MapClone {
},
hir::PatKind::Binding(hir::BindingAnnotation::Unannotated, .., name, None) => {
match closure_expr.kind {
- hir::ExprKind::Unary(hir::UnOp::Deref, ref inner) => {
+ hir::ExprKind::Unary(hir::UnOp::Deref, inner) => {
if ident_eq(name, inner) {
if let ty::Ref(.., Mutability::Not) = cx.typeck_results().expr_ty(inner).kind() {
lint(cx, e.span, args[0].span, true);
}
}
},
- hir::ExprKind::MethodCall(ref method, _, [obj], _) => if_chain! {
+ hir::ExprKind::MethodCall(method, _, [obj], _) => if_chain! {
if ident_eq(name, obj) && method.ident.name == sym::clone;
if let Some(fn_id) = cx.typeck_results().type_dependent_def_id(closure_expr.hir_id);
if let Some(trait_id) = cx.tcx.trait_of_item(fn_id);
@@ -109,7 +109,7 @@ impl<'tcx> LateLintPass<'tcx> for MapClone {
}
fn ident_eq(name: Ident, path: &hir::Expr<'_>) -> bool {
- if let hir::ExprKind::Path(hir::QPath::Resolved(None, ref path)) = path.kind {
+ if let hir::ExprKind::Path(hir::QPath::Resolved(None, path)) = path.kind {
path.segments.len() == 1 && path.segments[0].ident == name
} else {
false
diff --git a/clippy_lints/src/map_err_ignore.rs b/clippy_lints/src/map_err_ignore.rs
index a6a63961be57..425a9734e5fe 100644
--- a/clippy_lints/src/map_err_ignore.rs
+++ b/clippy_lints/src/map_err_ignore.rs
@@ -112,7 +112,7 @@ impl<'tcx> LateLintPass<'tcx> for MapErrIgnore {
}
// check if this is a method call (e.g. x.foo())
- if let ExprKind::MethodCall(ref method, _t_span, ref args, _) = e.kind {
+ if let ExprKind::MethodCall(method, _t_span, args, _) = e.kind {
// only work if the method name is `map_err` and there are only 2 arguments (e.g. x.map_err(|_|[1]
// Enum::Variant[2]))
if method.ident.as_str() == "map_err" && args.len() == 2 {
diff --git a/clippy_lints/src/map_identity.rs b/clippy_lints/src/map_identity.rs
index 75191e1f9ee8..e7719e7663d6 100644
--- a/clippy_lints/src/map_identity.rs
+++ b/clippy_lints/src/map_identity.rs
@@ -61,7 +61,7 @@ impl<'tcx> LateLintPass<'tcx> for MapIdentity {
/// map(). Otherwise, returns None.
fn get_map_argument<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<&'a [Expr<'a>]> {
if_chain! {
- if let ExprKind::MethodCall(ref method, _, ref args, _) = expr.kind;
+ if let ExprKind::MethodCall(method, _, args, _) = expr.kind;
if args.len() == 2 && method.ident.name == sym::map;
let caller_ty = cx.typeck_results().expr_ty(&args[0]);
if is_trait_method(cx, expr, sym::Iterator)
@@ -80,7 +80,7 @@ fn get_map_argument<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<&'a
fn is_expr_identity_function(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
match expr.kind {
ExprKind::Closure(_, _, body_id, _, _) => is_body_identity_function(cx, cx.tcx.hir().body(body_id)),
- ExprKind::Path(QPath::Resolved(_, ref path)) => match_path(path, &paths::STD_CONVERT_IDENTITY),
+ ExprKind::Path(QPath::Resolved(_, path)) => match_path(path, &paths::STD_CONVERT_IDENTITY),
_ => false,
}
}
@@ -99,12 +99,12 @@ fn is_body_identity_function(cx: &LateContext<'_>, func: &Body<'_>) -> bool {
match body.kind {
ExprKind::Path(QPath::Resolved(None, _)) => match_expr_param(cx, body, params[0].pat),
- ExprKind::Ret(Some(ref ret_val)) => match_expr_param(cx, ret_val, params[0].pat),
- ExprKind::Block(ref block, _) => {
+ ExprKind::Ret(Some(ret_val)) => match_expr_param(cx, ret_val, params[0].pat),
+ ExprKind::Block(block, _) => {
if_chain! {
if block.stmts.len() == 1;
- if let StmtKind::Semi(ref expr) | StmtKind::Expr(ref expr) = block.stmts[0].kind;
- if let ExprKind::Ret(Some(ref ret_val)) = expr.kind;
+ if let StmtKind::Semi(expr) | StmtKind::Expr(expr) = block.stmts[0].kind;
+ if let ExprKind::Ret(Some(ret_val)) = expr.kind;
then {
match_expr_param(cx, ret_val, params[0].pat)
} else {
diff --git a/clippy_lints/src/map_unit_fn.rs b/clippy_lints/src/map_unit_fn.rs
index 5cc16244a0da..57cd907e77e8 100644
--- a/clippy_lints/src/map_unit_fn.rs
+++ b/clippy_lints/src/map_unit_fn.rs
@@ -133,7 +133,7 @@ fn reduce_unit_expression<'a>(cx: &LateContext<'_>, expr: &'a hir::Expr<'_>) ->
// Calls can't be reduced any more
Some(expr.span)
},
- hir::ExprKind::Block(ref block, _) => {
+ hir::ExprKind::Block(block, _) => {
match (block.stmts, block.expr.as_ref()) {
(&[], Some(inner_expr)) => {
// If block only contains an expression,
@@ -144,8 +144,8 @@ fn reduce_unit_expression<'a>(cx: &LateContext<'_>, expr: &'a hir::Expr<'_>) ->
// If block only contains statements,
// reduce `{ X; }` to `X` or `X;`
match inner_stmt.kind {
- hir::StmtKind::Local(ref local) => Some(local.span),
- hir::StmtKind::Expr(ref e) => Some(e.span),
+ hir::StmtKind::Local(local) => Some(local.span),
+ hir::StmtKind::Expr(e) => Some(e.span),
hir::StmtKind::Semi(..) => Some(inner_stmt.span),
hir::StmtKind::Item(..) => None,
}
@@ -169,12 +169,12 @@ fn unit_closure<'tcx>(
expr: &hir::Expr<'_>,
) -> Option<(&'tcx hir::Param<'tcx>, &'tcx hir::Expr<'tcx>)> {
if_chain! {
- if let hir::ExprKind::Closure(_, ref decl, inner_expr_id, _, _) = expr.kind;
+ if let hir::ExprKind::Closure(_, decl, inner_expr_id, _, _) = expr.kind;
let body = cx.tcx.hir().body(inner_expr_id);
let body_expr = &body.value;
if decl.inputs.len() == 1;
if is_unit_expression(cx, body_expr);
- if let Some(binding) = iter_input_pats(&decl, body).next();
+ if let Some(binding) = iter_input_pats(decl, body).next();
then {
return Some((binding, body_expr));
}
@@ -267,7 +267,7 @@ impl<'tcx> LateLintPass<'tcx> for MapUnit {
return;
}
- if let hir::StmtKind::Semi(ref expr) = stmt.kind {
+ if let hir::StmtKind::Semi(expr) = stmt.kind {
if let Some(arglists) = method_chain_args(expr, &["map"]) {
lint_map_unit_fn(cx, stmt, expr, arglists[0]);
}
diff --git a/clippy_lints/src/match_on_vec_items.rs b/clippy_lints/src/match_on_vec_items.rs
index ccaa5e98c83a..ca6fb0831fe2 100644
--- a/clippy_lints/src/match_on_vec_items.rs
+++ b/clippy_lints/src/match_on_vec_items.rs
@@ -51,7 +51,7 @@ impl<'tcx> LateLintPass<'tcx> for MatchOnVecItems {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) {
if_chain! {
if !in_external_macro(cx.sess(), expr.span);
- if let ExprKind::Match(ref match_expr, _, MatchSource::Normal) = expr.kind;
+ if let ExprKind::Match(match_expr, _, MatchSource::Normal) = expr.kind;
if let Some(idx_expr) = is_vec_indexing(cx, match_expr);
if let ExprKind::Index(vec, idx) = idx_expr.kind;
@@ -78,7 +78,7 @@ impl<'tcx> LateLintPass<'tcx> for MatchOnVecItems {
fn is_vec_indexing<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) -> Option<&'tcx Expr<'tcx>> {
if_chain! {
- if let ExprKind::Index(ref array, ref index) = expr.kind;
+ if let ExprKind::Index(array, index) = expr.kind;
if is_vector(cx, array);
if !is_full_range(cx, index);
diff --git a/clippy_lints/src/matches.rs b/clippy_lints/src/matches.rs
index c68ae00be015..a892e24482b9 100644
--- a/clippy_lints/src/matches.rs
+++ b/clippy_lints/src/matches.rs
@@ -589,7 +589,7 @@ impl<'tcx> LateLintPass<'tcx> for Matches {
lint_match_arms(cx, expr);
}
- if let ExprKind::Match(ref ex, ref arms, MatchSource::Normal) = expr.kind {
+ if let ExprKind::Match(ex, arms, MatchSource::Normal) = expr.kind {
check_single_match(cx, ex, arms, expr);
check_match_bool(cx, ex, arms, expr);
check_overlapping_arms(cx, ex, arms);
@@ -604,7 +604,7 @@ impl<'tcx> LateLintPass<'tcx> for Matches {
check_match_single_binding(cx, ex, arms, expr);
}
}
- if let ExprKind::Match(ref ex, ref arms, _) = expr.kind {
+ if let ExprKind::Match(ex, arms, _) = expr.kind {
check_match_ref_pats(cx, ex, arms, expr);
}
}
@@ -613,14 +613,14 @@ impl<'tcx> LateLintPass<'tcx> for Matches {
if_chain! {
if !in_external_macro(cx.sess(), local.span);
if !in_macro(local.span);
- if let Some(ref expr) = local.init;
- if let ExprKind::Match(ref target, ref arms, MatchSource::Normal) = expr.kind;
+ if let Some(expr) = local.init;
+ if let ExprKind::Match(target, arms, MatchSource::Normal) = expr.kind;
if arms.len() == 1 && arms[0].guard.is_none();
if let PatKind::TupleStruct(
- QPath::Resolved(None, ref variant_name), ref args, _) = arms[0].pat.kind;
+ QPath::Resolved(None, variant_name), args, _) = arms[0].pat.kind;
if args.len() == 1;
- if let PatKind::Binding(_, arg, ..) = strip_pat_refs(&args[0]).kind;
- let body = remove_blocks(&arms[0].body);
+ if let PatKind::Binding(_, arg, ..) = strip_pat_refs(args[0]).kind;
+ let body = remove_blocks(arms[0].body);
if path_to_local_id(body, arg);
then {
@@ -649,7 +649,7 @@ impl<'tcx> LateLintPass<'tcx> for Matches {
if_chain! {
if !in_external_macro(cx.sess(), pat.span);
if !in_macro(pat.span);
- if let PatKind::Struct(QPath::Resolved(_, ref path), fields, true) = pat.kind;
+ if let PatKind::Struct(QPath::Resolved(_, path), fields, true) = pat.kind;
if let Some(def_id) = path.res.opt_def_id();
let ty = cx.tcx.type_of(def_id);
if let ty::Adt(def, _) = ty.kind();
@@ -761,7 +761,7 @@ fn report_single_match_single_pattern(
// PartialEq for different reference counts may not exist.
"&".repeat(ref_count_diff),
snippet(cx, arms[0].pat.span, ".."),
- expr_block(cx, &arms[0].body, None, "..", Some(expr.span)),
+ expr_block(cx, arms[0].body, None, "..", Some(expr.span)),
els_str,
);
(msg, sugg)
@@ -771,7 +771,7 @@ fn report_single_match_single_pattern(
"if let {} = {} {}{}",
snippet(cx, arms[0].pat.span, ".."),
snippet(cx, ex.span, ".."),
- expr_block(cx, &arms[0].body, None, "..", Some(expr.span)),
+ expr_block(cx, arms[0].body, None, "..", Some(expr.span)),
els_str,
);
(msg, sugg)
@@ -809,7 +809,7 @@ fn check_single_match_opt_like(
];
let path = match arms[1].pat.kind {
- PatKind::TupleStruct(ref path, ref inner, _) => {
+ PatKind::TupleStruct(ref path, inner, _) => {
// Contains any non wildcard patterns (e.g., `Err(err)`)?
if !inner.iter().all(is_wild) {
return;
@@ -841,7 +841,7 @@ fn check_match_bool(cx: &LateContext<'_>, ex: &Expr<'_>, arms: &[Arm<'_>], expr:
move |diag| {
if arms.len() == 2 {
// no guards
- let exprs = if let PatKind::Lit(ref arm_bool) = arms[0].pat.kind {
+ let exprs = if let PatKind::Lit(arm_bool) = arms[0].pat.kind {
if let ExprKind::Lit(ref lit) = arm_bool.kind {
match lit.node {
LitKind::Bool(true) => Some((&*arms[0].body, &*arms[1].body)),
@@ -917,7 +917,7 @@ fn check_wild_err_arm<'tcx>(cx: &LateContext<'tcx>, ex: &Expr<'tcx>, arms: &[Arm
let ex_ty = cx.typeck_results().expr_ty(ex).peel_refs();
if is_type_diagnostic_item(cx, ex_ty, sym::result_type) {
for arm in arms {
- if let PatKind::TupleStruct(ref path, ref inner, _) = arm.pat.kind {
+ if let PatKind::TupleStruct(ref path, inner, _) = arm.pat.kind {
let path_str = rustc_hir_pretty::to_string(rustc_hir_pretty::NO_ANN, |s| s.print_qpath(path, false));
if path_str == "Err" {
let mut matching_wild = inner.iter().any(is_wild);
@@ -937,7 +937,7 @@ fn check_wild_err_arm<'tcx>(cx: &LateContext<'tcx>, ex: &Expr<'tcx>, arms: &[Arm
}
if_chain! {
if matching_wild;
- if let ExprKind::Block(ref block, _) = arm.body.kind;
+ if let ExprKind::Block(block, _) = arm.body.kind;
if is_panic_block(block);
then {
// `Err(_)` or `Err(_e)` arm with `panic!` found
@@ -1143,9 +1143,7 @@ fn check_wild_enum_match(cx: &LateContext<'_>, ex: &Expr<'_>, arms: &[Arm<'_>])
// If the block contains only a `panic!` macro (as expression or statement)
fn is_panic_block(block: &Block<'_>) -> bool {
match (&block.expr, block.stmts.len(), block.stmts.first()) {
- (&Some(ref exp), 0, _) => {
- is_expn_of(exp.span, "panic").is_some() && is_expn_of(exp.span, "unreachable").is_none()
- },
+ (&Some(exp), 0, _) => is_expn_of(exp.span, "panic").is_some() && is_expn_of(exp.span, "unreachable").is_none(),
(&None, 1, Some(stmt)) => {
is_expn_of(stmt.span, "panic").is_some() && is_expn_of(stmt.span, "unreachable").is_none()
},
@@ -1156,7 +1154,7 @@ fn is_panic_block(block: &Block<'_>) -> bool {
fn check_match_ref_pats(cx: &LateContext<'_>, ex: &Expr<'_>, arms: &[Arm<'_>], expr: &Expr<'_>) {
if has_only_ref_pats(arms) {
let mut suggs = Vec::with_capacity(arms.len() + 1);
- let (title, msg) = if let ExprKind::AddrOf(BorrowKind::Ref, Mutability::Not, ref inner) = ex.kind {
+ let (title, msg) = if let ExprKind::AddrOf(BorrowKind::Ref, Mutability::Not, inner) = ex.kind {
let span = ex.span.source_callsite();
suggs.push((span, Sugg::hir_with_macro_callsite(cx, inner, "..").to_string()));
(
@@ -1173,7 +1171,7 @@ fn check_match_ref_pats(cx: &LateContext<'_>, ex: &Expr<'_>, arms: &[Arm<'_>], e
};
suggs.extend(arms.iter().filter_map(|a| {
- if let PatKind::Ref(ref refp, _) = a.pat.kind {
+ if let PatKind::Ref(refp, _) = a.pat.kind {
Some((a.pat.span, snippet(cx, refp.span, "..").to_string()))
} else {
None
@@ -1242,7 +1240,7 @@ fn check_match_as_ref(cx: &LateContext<'_>, ex: &Expr<'_>, arms: &[Arm<'_>], exp
fn check_wild_in_or_pats(cx: &LateContext<'_>, arms: &[Arm<'_>]) {
for arm in arms {
- if let PatKind::Or(ref fields) = arm.pat.kind {
+ if let PatKind::Or(fields) = arm.pat.kind {
// look for multiple fields in this arm that contains at least one Wild pattern
if fields.len() > 1 && fields.iter().any(is_wild) {
span_lint_and_help(
@@ -1308,7 +1306,7 @@ fn find_matches_sugg(cx: &LateContext<'_>, ex: &Expr<'_>, arms: &[Arm<'_>], expr
// strip potential borrows (#6503), but only if the type is a reference
let mut ex_new = ex;
if let ExprKind::AddrOf(BorrowKind::Ref, .., ex_inner) = ex.kind {
- if let ty::Ref(..) = cx.typeck_results().expr_ty(&ex_inner).kind() {
+ if let ty::Ref(..) = cx.typeck_results().expr_ty(ex_inner).kind() {
ex_new = ex_inner;
}
};
@@ -1385,7 +1383,7 @@ fn check_match_single_binding<'a>(cx: &LateContext<'a>, ex: &Expr<'a>, arms: &[A
let matched_vars = ex.span;
let bind_names = arms[0].pat.span;
- let match_body = remove_blocks(&arms[0].body);
+ let match_body = remove_blocks(arms[0].body);
let mut snippet_body = if match_body.span.from_expansion() {
Sugg::hir_with_macro_callsite(cx, match_body, "..").to_string()
} else {
@@ -1396,13 +1394,13 @@ fn check_match_single_binding<'a>(cx: &LateContext<'a>, ex: &Expr<'a>, arms: &[A
match match_body.kind {
ExprKind::Block(block, _) => {
// macro + expr_ty(body) == ()
- if block.span.from_expansion() && cx.typeck_results().expr_ty(&match_body).is_unit() {
+ if block.span.from_expansion() && cx.typeck_results().expr_ty(match_body).is_unit() {
snippet_body.push(';');
}
},
_ => {
// expr_ty(body) == ()
- if cx.typeck_results().expr_ty(&match_body).is_unit() {
+ if cx.typeck_results().expr_ty(match_body).is_unit() {
snippet_body.push(';');
}
},
@@ -1502,10 +1500,7 @@ fn opt_parent_let<'a>(cx: &LateContext<'a>, ex: &Expr<'a>) -> Option<&'a Local<'
fn all_ranges<'tcx>(cx: &LateContext<'tcx>, arms: &'tcx [Arm<'_>], ty: Ty<'tcx>) -> Vec<SpannedRange<Constant>> {
arms.iter()
.flat_map(|arm| {
- if let Arm {
- ref pat, guard: None, ..
- } = *arm
- {
+ if let Arm { pat, guard: None, .. } = *arm {
if let PatKind::Range(ref lhs, ref rhs, range_end) = pat.kind {
let lhs = match lhs {
Some(lhs) => constant(cx, cx.typeck_results(), lhs)?.0,
@@ -1525,7 +1520,7 @@ fn all_ranges<'tcx>(cx: &LateContext<'tcx>, arms: &'tcx [Arm<'_>], ty: Ty<'tcx>)
});
}
- if let PatKind::Lit(ref value) = pat.kind {
+ if let PatKind::Lit(value) = pat.kind {
let value = constant(cx, cx.typeck_results(), value)?.0;
return Some(SpannedRange {
span: pat.span,
@@ -1572,8 +1567,8 @@ fn type_ranges(ranges: &[SpannedRange<Constant>]) -> TypedRanges {
fn is_unit_expr(expr: &Expr<'_>) -> bool {
match expr.kind {
- ExprKind::Tup(ref v) if v.is_empty() => true,
- ExprKind::Block(ref b, _) if b.stmts.is_empty() && b.expr.is_none() => true,
+ ExprKind::Tup(v) if v.is_empty() => true,
+ ExprKind::Block(b, _) if b.stmts.is_empty() && b.expr.is_none() => true,
_ => false,
}
}
@@ -1586,14 +1581,14 @@ fn is_none_arm(arm: &Arm<'_>) -> bool {
// Checks if arm has the form `Some(ref v) => Some(v)` (checks for `ref` and `ref mut`)
fn is_ref_some_arm(arm: &Arm<'_>) -> Option<BindingAnnotation> {
if_chain! {
- if let PatKind::TupleStruct(ref path, ref pats, _) = arm.pat.kind;
+ if let PatKind::TupleStruct(ref path, pats, _) = arm.pat.kind;
if pats.len() == 1 && match_qpath(path, &paths::OPTION_SOME);
if let PatKind::Binding(rb, .., ident, _) = pats[0].kind;
if rb == BindingAnnotation::Ref || rb == BindingAnnotation::RefMut;
- if let ExprKind::Call(ref e, ref args) = remove_blocks(&arm.body).kind;
+ if let ExprKind::Call(e, args) = remove_blocks(arm.body).kind;
if let ExprKind::Path(ref some_path) = e.kind;
if match_qpath(some_path, &paths::OPTION_SOME) && args.len() == 1;
- if let ExprKind::Path(QPath::Resolved(_, ref path2)) = args[0].kind;
+ if let ExprKind::Path(QPath::Resolved(_, path2)) = args[0].kind;
if path2.segments.len() == 1 && ident.name == path2.segments[0].ident.name;
then {
return Some(rb)
@@ -1685,7 +1680,7 @@ where
(&Kind::End(a, _), &Kind::Start(b, _)) if a != Bound::Included(b) => (),
_ => {
// skip if the range `a` is completely included into the range `b`
- if let Ordering::Equal | Ordering::Less = a.cmp(&b) {
+ if let Ordering::Equal | Ordering::Less = a.cmp(b) {
let kind_a = Kind::End(a.range().node.1, a.range());
let kind_b = Kind::End(b.range().node.1, b.range());
if let Ordering::Equal | Ordering::Greater = kind_a.cmp(&kind_b) {
@@ -1737,7 +1732,7 @@ mod redundant_pattern_match {
kind = &inner.kind;
}
let good_method = match kind {
- PatKind::TupleStruct(ref path, ref patterns, _) if patterns.len() == 1 => {
+ PatKind::TupleStruct(ref path, patterns, _) if patterns.len() == 1 => {
if let PatKind::Wild = patterns[0].kind {
if match_qpath(path, &paths::RESULT_OK) {
"is_ok()"
@@ -1818,8 +1813,8 @@ mod redundant_pattern_match {
let found_good_method = match node_pair {
(
- PatKind::TupleStruct(ref path_left, ref patterns_left, _),
- PatKind::TupleStruct(ref path_right, ref patterns_right, _),
+ PatKind::TupleStruct(ref path_left, patterns_left, _),
+ PatKind::TupleStruct(ref path_right, patterns_right, _),
) if patterns_left.len() == 1 && patterns_right.len() == 1 => {
if let (PatKind::Wild, PatKind::Wild) = (&patterns_left[0].kind, &patterns_right[0].kind) {
find_good_method_for_match(
@@ -1846,8 +1841,8 @@ mod redundant_pattern_match {
None
}
},
- (PatKind::TupleStruct(ref path_left, ref patterns, _), PatKind::Path(ref path_right))
- | (PatKind::Path(ref path_left), PatKind::TupleStruct(ref path_right, ref patterns, _))
+ (PatKind::TupleStruct(ref path_left, patterns, _), PatKind::Path(ref path_right))
+ | (PatKind::Path(ref path_left), PatKind::TupleStruct(ref path_right, patterns, _))
if patterns.len() == 1 =>
{
if let PatKind::Wild = patterns[0].kind {
@@ -1969,10 +1964,10 @@ fn test_overlapping() {
/// Implementation of `MATCH_SAME_ARMS`.
fn lint_match_arms<'tcx>(cx: &LateContext<'tcx>, expr: &Expr<'_>) {
- if let ExprKind::Match(_, ref arms, MatchSource::Normal) = expr.kind {
+ if let ExprKind::Match(_, arms, MatchSource::Normal) = expr.kind {
let hash = |&(_, arm): &(usize, &Arm<'_>)| -> u64 {
let mut h = SpanlessHash::new(cx);
- h.hash_expr(&arm.body);
+ h.hash_expr(arm.body);
h.finish()
};
@@ -2008,7 +2003,7 @@ fn lint_match_arms<'tcx>(cx: &LateContext<'tcx>, expr: &Expr<'_>) {
(min_index..=max_index).all(|index| arms[index].guard.is_none())
&& SpanlessEq::new(cx)
.expr_fallback(eq_fallback)
- .eq_expr(&lhs.body, &rhs.body)
+ .eq_expr(lhs.body, rhs.body)
// these checks could be removed to allow unused bindings
&& bindings_eq(lhs.pat, local_map.keys().copied().collect())
&& bindings_eq(rhs.pat, local_map.values().copied().collect())
diff --git a/clippy_lints/src/mem_discriminant.rs b/clippy_lints/src/mem_discriminant.rs
index 7895ba9f1e07..a735c616f6e4 100644
--- a/clippy_lints/src/mem_discriminant.rs
+++ b/clippy_lints/src/mem_discriminant.rs
@@ -34,7 +34,7 @@ declare_lint_pass!(MemDiscriminant => [MEM_DISCRIMINANT_NON_ENUM]);
impl<'tcx> LateLintPass<'tcx> for MemDiscriminant {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
if_chain! {
- if let ExprKind::Call(ref func, ref func_args) = expr.kind;
+ if let ExprKind::Call(func, func_args) = expr.kind;
// is `mem::discriminant`
if let ExprKind::Path(ref func_qpath) = func.kind;
if let Some(def_id) = cx.qpath_res(func_qpath, func.hir_id).opt_def_id();
@@ -59,7 +59,7 @@ impl<'tcx> LateLintPass<'tcx> for MemDiscriminant {
let mut derefs_needed = ptr_depth;
let mut cur_expr = param;
while derefs_needed > 0 {
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref inner_expr) = cur_expr.kind {
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, inner_expr) = cur_expr.kind {
derefs_needed -= 1;
cur_expr = inner_expr;
} else {
diff --git a/clippy_lints/src/mem_forget.rs b/clippy_lints/src/mem_forget.rs
index c13802e39539..a28cb5f32fe8 100644
--- a/clippy_lints/src/mem_forget.rs
+++ b/clippy_lints/src/mem_forget.rs
@@ -28,7 +28,7 @@ declare_lint_pass!(MemForget => [MEM_FORGET]);
impl<'tcx> LateLintPass<'tcx> for MemForget {
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
- if let ExprKind::Call(ref path_expr, ref args) = e.kind {
+ if let ExprKind::Call(path_expr, args) = e.kind {
if let ExprKind::Path(ref qpath) = path_expr.kind {
if let Some(def_id) = cx.qpath_res(qpath, path_expr.hir_id).opt_def_id() {
if match_def_path(cx, def_id, &paths::MEM_FORGET) {
diff --git a/clippy_lints/src/mem_replace.rs b/clippy_lints/src/mem_replace.rs
index 0418c616efa8..e1d351aee454 100644
--- a/clippy_lints/src/mem_replace.rs
+++ b/clippy_lints/src/mem_replace.rs
@@ -109,14 +109,14 @@ fn check_replace_option_with_none(cx: &LateContext<'_>, src: &Expr<'_>, dest: &E
// argument's type. All that's left is to get
// replacee's path.
let replaced_path = match dest.kind {
- ExprKind::AddrOf(BorrowKind::Ref, Mutability::Mut, ref replaced) => {
- if let ExprKind::Path(QPath::Resolved(None, ref replaced_path)) = replaced.kind {
+ ExprKind::AddrOf(BorrowKind::Ref, Mutability::Mut, replaced) => {
+ if let ExprKind::Path(QPath::Resolved(None, replaced_path)) = replaced.kind {
replaced_path
} else {
return;
}
},
- ExprKind::Path(QPath::Resolved(None, ref replaced_path)) => replaced_path,
+ ExprKind::Path(QPath::Resolved(None, replaced_path)) => replaced_path,
_ => return,
};
@@ -161,7 +161,7 @@ fn check_replace_with_uninit(cx: &LateContext<'_>, src: &Expr<'_>, dest: &Expr<'
}
if_chain! {
- if let ExprKind::Call(ref repl_func, ref repl_args) = src.kind;
+ if let ExprKind::Call(repl_func, repl_args) = src.kind;
if repl_args.is_empty();
if let ExprKind::Path(ref repl_func_qpath) = repl_func.kind;
if let Some(repl_def_id) = cx.qpath_res(repl_func_qpath, repl_func.hir_id).opt_def_id();
@@ -214,7 +214,7 @@ fn is_default_equivalent_ctor(cx: &LateContext<'_>, def_id: DefId, path: &QPath<
.iter()
.any(|symbol| is_diagnostic_assoc_item(cx, def_id, *symbol))
{
- if let QPath::TypeRelative(_, ref method) = path {
+ if let QPath::TypeRelative(_, method) = path {
if method.ident.name == sym::new {
return true;
}
@@ -226,7 +226,7 @@ fn is_default_equivalent_ctor(cx: &LateContext<'_>, def_id: DefId, path: &QPath<
fn check_replace_with_default(cx: &LateContext<'_>, src: &Expr<'_>, dest: &Expr<'_>, expr_span: Span) {
if_chain! {
- if let ExprKind::Call(ref repl_func, _) = src.kind;
+ if let ExprKind::Call(repl_func, _) = src.kind;
if !in_external_macro(cx.tcx.sess, expr_span);
if let ExprKind::Path(ref repl_func_qpath) = repl_func.kind;
if let Some(repl_def_id) = cx.qpath_res(repl_func_qpath, repl_func.hir_id).opt_def_id();
@@ -273,11 +273,11 @@ impl<'tcx> LateLintPass<'tcx> for MemReplace {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
if_chain! {
// Check that `expr` is a call to `mem::replace()`
- if let ExprKind::Call(ref func, ref func_args) = expr.kind;
+ if let ExprKind::Call(func, func_args) = expr.kind;
if let ExprKind::Path(ref func_qpath) = func.kind;
if let Some(def_id) = cx.qpath_res(func_qpath, func.hir_id).opt_def_id();
if match_def_path(cx, def_id, &paths::MEM_REPLACE);
- if let [dest, src] = &**func_args;
+ if let [dest, src] = func_args;
then {
check_replace_option_with_none(cx, src, dest, expr.span);
check_replace_with_uninit(cx, src, dest, expr.span);
diff --git a/clippy_lints/src/methods/bind_instead_of_map.rs b/clippy_lints/src/methods/bind_instead_of_map.rs
index 46d4c6746481..287bff886bfb 100644
--- a/clippy_lints/src/methods/bind_instead_of_map.rs
+++ b/clippy_lints/src/methods/bind_instead_of_map.rs
@@ -71,7 +71,7 @@ pub(crate) trait BindInsteadOfMap {
closure_args_span: Span,
) -> bool {
if_chain! {
- if let hir::ExprKind::Call(ref some_expr, [inner_expr]) = closure_expr.kind;
+ if let hir::ExprKind::Call(some_expr, [inner_expr]) = closure_expr.kind;
if let hir::ExprKind::Path(QPath::Resolved(_, path)) = some_expr.kind;
if Self::is_variant(cx, path.res);
if !contains_return(inner_expr);
@@ -107,7 +107,7 @@ pub(crate) trait BindInsteadOfMap {
let can_sugg: bool = find_all_ret_expressions(cx, closure_expr, |ret_expr| {
if_chain! {
if !in_macro(ret_expr.span);
- if let hir::ExprKind::Call(ref func_path, [arg]) = ret_expr.kind;
+ if let hir::ExprKind::Call(func_path, [arg]) = ret_expr.kind;
if let hir::ExprKind::Path(QPath::Resolved(_, path)) = func_path.kind;
if Self::is_variant(cx, path.res);
if !contains_return(arg);
diff --git a/clippy_lints/src/methods/chars_cmp.rs b/clippy_lints/src/methods/chars_cmp.rs
index c668fe52781d..514c41187655 100644
--- a/clippy_lints/src/methods/chars_cmp.rs
+++ b/clippy_lints/src/methods/chars_cmp.rs
@@ -19,7 +19,7 @@ pub(super) fn check(
) -> bool {
if_chain! {
if let Some(args) = method_chain_args(info.chain, chain_methods);
- if let hir::ExprKind::Call(ref fun, ref arg_char) = info.other.kind;
+ if let hir::ExprKind::Call(fun, arg_char) = info.other.kind;
if arg_char.len() == 1;
if let hir::ExprKind::Path(ref qpath) = fun.kind;
if let Some(segment) = single_segment_path(qpath);
diff --git a/clippy_lints/src/methods/expect_fun_call.rs b/clippy_lints/src/methods/expect_fun_call.rs
index e7bffa66b3fc..03cb41697d50 100644
--- a/clippy_lints/src/methods/expect_fun_call.rs
+++ b/clippy_lints/src/methods/expect_fun_call.rs
@@ -100,9 +100,9 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, method_span: Spa
applicability: &mut Applicability,
) -> Vec<String> {
if_chain! {
- if let hir::ExprKind::AddrOf(hir::BorrowKind::Ref, _, ref format_arg) = a.kind;
- if let hir::ExprKind::Match(ref format_arg_expr, _, _) = format_arg.kind;
- if let hir::ExprKind::Tup(ref format_arg_expr_tup) = format_arg_expr.kind;
+ if let hir::ExprKind::AddrOf(hir::BorrowKind::Ref, _, format_arg) = a.kind;
+ if let hir::ExprKind::Match(format_arg_expr, _, _) = format_arg.kind;
+ if let hir::ExprKind::Tup(format_arg_expr_tup) = format_arg_expr.kind;
then {
format_arg_expr_tup
@@ -155,7 +155,7 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, method_span: Spa
if block.stmts.len() == 1;
if let hir::StmtKind::Local(local) = &block.stmts[0].kind;
if let Some(arg_root) = &local.init;
- if let hir::ExprKind::Call(ref inner_fun, ref inner_args) = arg_root.kind;
+ if let hir::ExprKind::Call(inner_fun, inner_args) = arg_root.kind;
if is_expn_of(inner_fun.span, "format").is_some() && inner_args.len() == 1;
if let hir::ExprKind::Call(_, format_args) = &inner_args[0].kind;
then {
diff --git a/clippy_lints/src/methods/filter_map.rs b/clippy_lints/src/methods/filter_map.rs
index 45d1ed953b4e..35fae450eeb9 100644
--- a/clippy_lints/src/methods/filter_map.rs
+++ b/clippy_lints/src/methods/filter_map.rs
@@ -19,7 +19,7 @@ use super::OPTION_FILTER_MAP;
fn is_method<'tcx>(cx: &LateContext<'tcx>, expr: &hir::Expr<'_>, method_name: Symbol) -> bool {
match &expr.kind {
- hir::ExprKind::Path(QPath::TypeRelative(_, ref mname)) => mname.ident.name == method_name,
+ hir::ExprKind::Path(QPath::TypeRelative(_, mname)) => mname.ident.name == method_name,
hir::ExprKind::Path(QPath::Resolved(_, segments)) => {
segments.segments.last().unwrap().ident.name == method_name
},
@@ -28,7 +28,7 @@ fn is_method<'tcx>(cx: &LateContext<'tcx>, expr: &hir::Expr<'_>, method_name: Sy
let closure_expr = remove_blocks(&body.value);
let arg_id = body.params[0].pat.hir_id;
match closure_expr.kind {
- hir::ExprKind::MethodCall(hir::PathSegment { ident, .. }, _, ref args, _) => {
+ hir::ExprKind::MethodCall(hir::PathSegment { ident, .. }, _, args, _) => {
if_chain! {
if ident.name == method_name;
if let hir::ExprKind::Path(path) = &args[0].kind;
@@ -61,7 +61,7 @@ fn lint_filter_some_map_unwrap(
methods_span: Span,
) {
let iterator = is_trait_method(cx, expr, sym::Iterator);
- let option = is_type_diagnostic_item(cx, cx.typeck_results().expr_ty(&filter_recv), sym::option_type);
+ let option = is_type_diagnostic_item(cx, cx.typeck_results().expr_ty(filter_recv), sym::option_type);
if (iterator || option) && is_option_filter_map(cx, filter_arg, map_arg) {
let msg = "`filter` for `Some` followed by `unwrap`";
let help = "consider using `flatten` instead";
diff --git a/clippy_lints/src/methods/flat_map_identity.rs b/clippy_lints/src/methods/flat_map_identity.rs
index 664885a2f0e7..dd613d0cd638 100644
--- a/clippy_lints/src/methods/flat_map_identity.rs
+++ b/clippy_lints/src/methods/flat_map_identity.rs
@@ -35,7 +35,7 @@ pub(super) fn check<'tcx>(
let body = cx.tcx.hir().body(*body_id);
if let hir::PatKind::Binding(_, _, binding_ident, _) = body.params[0].pat.kind;
- if let hir::ExprKind::Path(hir::QPath::Resolved(_, ref path)) = body.value.kind;
+ if let hir::ExprKind::Path(hir::QPath::Resolved(_, path)) = body.value.kind;
if path.segments.len() == 1;
if path.segments[0].ident.name == binding_ident.name;
diff --git a/clippy_lints/src/methods/implicit_clone.rs b/clippy_lints/src/methods/implicit_clone.rs
index 04461ad5c3a6..1211e2f2bf7c 100644
--- a/clippy_lints/src/methods/implicit_clone.rs
+++ b/clippy_lints/src/methods/implicit_clone.rs
@@ -13,7 +13,7 @@ use clippy_utils::is_diagnostic_assoc_item;
pub fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, trait_diagnostic: Symbol) {
if_chain! {
if let ExprKind::MethodCall(method_path, _, [arg], _) = &expr.kind;
- let return_type = cx.typeck_results().expr_ty(&expr);
+ let return_type = cx.typeck_results().expr_ty(expr);
let input_type = cx.typeck_results().expr_ty(arg).peel_refs();
if let Some(expr_def_id) = cx.typeck_results().type_dependent_def_id(expr.hir_id);
if let Some(ty_name) = input_type.ty_adt_def().map(|adt_def| cx.tcx.item_name(adt_def.did));
diff --git a/clippy_lints/src/methods/iter_next_slice.rs b/clippy_lints/src/methods/iter_next_slice.rs
index dab0a43a0968..a49851de38e1 100644
--- a/clippy_lints/src/methods/iter_next_slice.rs
+++ b/clippy_lints/src/methods/iter_next_slice.rs
@@ -27,7 +27,7 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx hir::Expr<'_>, cal
if derefs_to_slice(cx, caller_expr, cx.typeck_results().expr_ty(caller_expr)).is_some() {
// caller is a Slice
if_chain! {
- if let hir::ExprKind::Index(ref caller_var, ref index_expr) = &caller_expr.kind;
+ if let hir::ExprKind::Index(caller_var, index_expr) = &caller_expr.kind;
if let Some(higher::Range { start: Some(start_expr), end: None, limits: ast::RangeLimits::HalfOpen })
= higher::range(index_expr);
if let hir::ExprKind::Lit(ref start_lit) = &start_expr.kind;
diff --git a/clippy_lints/src/methods/mod.rs b/clippy_lints/src/methods/mod.rs
index fa6323b56e1d..b1ade5addd6a 100644
--- a/clippy_lints/src/methods/mod.rs
+++ b/clippy_lints/src/methods/mod.rs
@@ -1740,10 +1740,10 @@ impl<'tcx> LateLintPass<'tcx> for Methods {
check_methods(cx, expr, self.msrv.as_ref());
match expr.kind {
- hir::ExprKind::Call(ref func, ref args) => {
+ hir::ExprKind::Call(func, args) => {
from_iter_instead_of_collect::check(cx, expr, args, &func.kind);
},
- hir::ExprKind::MethodCall(ref method_call, ref method_span, ref args, _) => {
+ hir::ExprKind::MethodCall(method_call, ref method_span, args, _) => {
or_fun_call::check(cx, expr, *method_span, &method_call.ident.as_str(), args);
expect_fun_call::check(cx, expr, *method_span, &method_call.ident.as_str(), args);
clone_on_copy::check(cx, expr, method_call.ident.name, args);
@@ -1753,9 +1753,7 @@ impl<'tcx> LateLintPass<'tcx> for Methods {
into_iter_on_ref::check(cx, expr, *method_span, method_call.ident.name, args);
single_char_pattern::check(cx, expr, method_call.ident.name, args);
},
- hir::ExprKind::Binary(op, ref lhs, ref rhs)
- if op.node == hir::BinOpKind::Eq || op.node == hir::BinOpKind::Ne =>
- {
+ hir::ExprKind::Binary(op, lhs, rhs) if op.node == hir::BinOpKind::Eq || op.node == hir::BinOpKind::Ne => {
let mut info = BinaryExprInfo {
expr,
chain: lhs,
@@ -1763,7 +1761,7 @@ impl<'tcx> LateLintPass<'tcx> for Methods {
eq: op.node == hir::BinOpKind::Eq,
};
lint_binary_expr_with_method_call(cx, &mut info);
- }
+ },
_ => (),
}
}
@@ -1781,7 +1779,7 @@ impl<'tcx> LateLintPass<'tcx> for Methods {
let implements_trait = matches!(item.kind, hir::ItemKind::Impl(hir::Impl { of_trait: Some(_), .. }));
if_chain! {
if let hir::ImplItemKind::Fn(ref sig, id) = impl_item.kind;
- if let Some(first_arg) = iter_input_pats(&sig.decl, cx.tcx.hir().body(id)).next();
+ if let Some(first_arg) = iter_input_pats(sig.decl, cx.tcx.hir().body(id)).next();
let method_sig = cx.tcx.fn_sig(impl_item.def_id);
let method_sig = cx.tcx.erase_late_bound_regions(method_sig);
@@ -1801,7 +1799,7 @@ impl<'tcx> LateLintPass<'tcx> for Methods {
method_config.output_type.matches(&sig.decl.output) &&
method_config.self_kind.matches(cx, self_ty, first_arg_ty) &&
fn_header_equals(method_config.fn_header, sig.header) &&
- method_config.lifetime_param_cond(&impl_item)
+ method_config.lifetime_param_cond(impl_item)
{
span_lint_and_help(
cx,
@@ -2272,10 +2270,10 @@ impl OutType {
let is_unit = |ty: &hir::Ty<'_>| matches!(ty.kind, hir::TyKind::Tup(&[]));
match (self, ty) {
(Self::Unit, &hir::FnRetTy::DefaultReturn(_)) => true,
- (Self::Unit, &hir::FnRetTy::Return(ref ty)) if is_unit(ty) => true,
- (Self::Bool, &hir::FnRetTy::Return(ref ty)) if is_bool(ty) => true,
- (Self::Any, &hir::FnRetTy::Return(ref ty)) if !is_unit(ty) => true,
- (Self::Ref, &hir::FnRetTy::Return(ref ty)) => matches!(ty.kind, hir::TyKind::Rptr(_, _)),
+ (Self::Unit, &hir::FnRetTy::Return(ty)) if is_unit(ty) => true,
+ (Self::Bool, &hir::FnRetTy::Return(ty)) if is_bool(ty) => true,
+ (Self::Any, &hir::FnRetTy::Return(ty)) if !is_unit(ty) => true,
+ (Self::Ref, &hir::FnRetTy::Return(ty)) => matches!(ty.kind, hir::TyKind::Rptr(_, _)),
_ => false,
}
}
diff --git a/clippy_lints/src/methods/option_as_ref_deref.rs b/clippy_lints/src/methods/option_as_ref_deref.rs
index 1367a0c21d8e..7e9c8fa829de 100644
--- a/clippy_lints/src/methods/option_as_ref_deref.rs
+++ b/clippy_lints/src/methods/option_as_ref_deref.rs
@@ -77,10 +77,10 @@ pub(super) fn check<'tcx>(
}
}
},
- hir::ExprKind::AddrOf(hir::BorrowKind::Ref, m, ref inner) if same_mutability(m) => {
+ hir::ExprKind::AddrOf(hir::BorrowKind::Ref, m, inner) if same_mutability(m) => {
if_chain! {
- if let hir::ExprKind::Unary(hir::UnOp::Deref, ref inner1) = inner.kind;
- if let hir::ExprKind::Unary(hir::UnOp::Deref, ref inner2) = inner1.kind;
+ if let hir::ExprKind::Unary(hir::UnOp::Deref, inner1) = inner.kind;
+ if let hir::ExprKind::Unary(hir::UnOp::Deref, inner2) = inner1.kind;
then {
path_to_local_id(inner2, closure_body.params[0].pat.hir_id)
} else {
diff --git a/clippy_lints/src/methods/or_fun_call.rs b/clippy_lints/src/methods/or_fun_call.rs
index 89dedc5f0d80..df89da5d3e00 100644
--- a/clippy_lints/src/methods/or_fun_call.rs
+++ b/clippy_lints/src/methods/or_fun_call.rs
@@ -86,7 +86,7 @@ pub(super) fn check<'tcx>(
(&paths::RESULT, true, &["or", "unwrap_or"], "else"),
];
- if let hir::ExprKind::MethodCall(ref path, _, ref args, _) = &arg.kind {
+ if let hir::ExprKind::MethodCall(path, _, args, _) = &arg.kind {
if path.ident.as_str() == "len" {
let ty = cx.typeck_results().expr_ty(&args[0]).peel_refs();
@@ -105,7 +105,7 @@ pub(super) fn check<'tcx>(
if KNOW_TYPES.iter().any(|k| k.2.contains(&name));
if is_lazyness_candidate(cx, arg);
- if !contains_return(&arg);
+ if !contains_return(arg);
let self_ty = cx.typeck_results().expr_ty(self_expr);
@@ -158,7 +158,7 @@ pub(super) fn check<'tcx>(
if args.len() == 2 {
match args[1].kind {
- hir::ExprKind::Call(ref fun, ref or_args) => {
+ hir::ExprKind::Call(fun, or_args) => {
let or_has_args = !or_args.is_empty();
if !check_unwrap_or_default(cx, name, fun, &args[0], &args[1], or_has_args, expr.span) {
let fun_span = if or_has_args { None } else { Some(fun.span) };
diff --git a/clippy_lints/src/methods/search_is_some.rs b/clippy_lints/src/methods/search_is_some.rs
index 8a94d7f41558..ecec6fc3bb7f 100644
--- a/clippy_lints/src/methods/search_is_some.rs
+++ b/clippy_lints/src/methods/search_is_some.rs
@@ -45,7 +45,7 @@ pub(super) fn check<'tcx>(
then {
if let hir::PatKind::Ref(..) = closure_arg.pat.kind {
Some(search_snippet.replacen('&', "", 1))
- } else if let PatKind::Binding(_, _, ident, _) = strip_pat_refs(&closure_arg.pat).kind {
+ } else if let PatKind::Binding(_, _, ident, _) = strip_pat_refs(closure_arg.pat).kind {
let name = &*ident.name.as_str();
Some(search_snippet.replace(&format!("*{}", name), name))
} else {
@@ -108,8 +108,8 @@ pub(super) fn check<'tcx>(
}
};
if_chain! {
- if is_string_or_str_slice(&search_recv);
- if is_string_or_str_slice(&search_arg);
+ if is_string_or_str_slice(search_recv);
+ if is_string_or_str_slice(search_arg);
then {
let msg = format!("called `{}()` after calling `find()` on a string", option_check_method);
match option_check_method {
diff --git a/clippy_lints/src/methods/uninit_assumed_init.rs b/clippy_lints/src/methods/uninit_assumed_init.rs
index 3cc1912b15ae..0ae65c0c01db 100644
--- a/clippy_lints/src/methods/uninit_assumed_init.rs
+++ b/clippy_lints/src/methods/uninit_assumed_init.rs
@@ -10,7 +10,7 @@ use super::UNINIT_ASSUMED_INIT;
/// lint for `MaybeUninit::uninit().assume_init()` (we already have the latter)
pub(super) fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, recv: &hir::Expr<'_>) {
if_chain! {
- if let hir::ExprKind::Call(ref callee, ref args) = recv.kind;
+ if let hir::ExprKind::Call(callee, args) = recv.kind;
if args.is_empty();
if let hir::ExprKind::Path(ref path) = callee.kind;
if match_qpath(path, &paths::MEM_MAYBEUNINIT_UNINIT);
@@ -28,9 +28,9 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, recv: &hir::Expr
fn is_maybe_uninit_ty_valid(cx: &LateContext<'_>, ty: Ty<'_>) -> bool {
match ty.kind() {
- ty::Array(ref component, _) => is_maybe_uninit_ty_valid(cx, component),
- ty::Tuple(ref types) => types.types().all(|ty| is_maybe_uninit_ty_valid(cx, ty)),
- ty::Adt(ref adt, _) => match_def_path(cx, adt.did, &paths::MEM_MAYBEUNINIT),
+ ty::Array(component, _) => is_maybe_uninit_ty_valid(cx, component),
+ ty::Tuple(types) => types.types().all(|ty| is_maybe_uninit_ty_valid(cx, ty)),
+ ty::Adt(adt, _) => match_def_path(cx, adt.did, &paths::MEM_MAYBEUNINIT),
_ => false,
}
}
diff --git a/clippy_lints/src/methods/unnecessary_filter_map.rs b/clippy_lints/src/methods/unnecessary_filter_map.rs
index 8e637e123933..0f28bfdf09e8 100644
--- a/clippy_lints/src/methods/unnecessary_filter_map.rs
+++ b/clippy_lints/src/methods/unnecessary_filter_map.rs
@@ -20,9 +20,9 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, arg: &hir::Expr<
let mutates_arg =
mutated_variables(&body.value, cx).map_or(true, |used_mutably| used_mutably.contains(&arg_id));
- let (mut found_mapping, mut found_filtering) = check_expression(&cx, arg_id, &body.value);
+ let (mut found_mapping, mut found_filtering) = check_expression(cx, arg_id, &body.value);
- let mut return_visitor = ReturnVisitor::new(&cx, arg_id);
+ let mut return_visitor = ReturnVisitor::new(cx, arg_id);
return_visitor.visit_expr(&body.value);
found_mapping |= return_visitor.found_mapping;
found_filtering |= return_visitor.found_filtering;
@@ -52,7 +52,7 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, arg: &hir::Expr<
// returns (found_mapping, found_filtering)
fn check_expression<'tcx>(cx: &LateContext<'tcx>, arg_id: hir::HirId, expr: &'tcx hir::Expr<'_>) -> (bool, bool) {
match &expr.kind {
- hir::ExprKind::Call(ref func, ref args) => {
+ hir::ExprKind::Call(func, args) => {
if let hir::ExprKind::Path(ref path) = func.kind {
if match_qpath(path, &paths::OPTION_SOME) {
if path_to_local_id(&args[0], arg_id) {
@@ -65,22 +65,22 @@ fn check_expression<'tcx>(cx: &LateContext<'tcx>, arg_id: hir::HirId, expr: &'tc
}
(true, true)
},
- hir::ExprKind::Block(ref block, _) => block
+ hir::ExprKind::Block(block, _) => block
.expr
.as_ref()
- .map_or((false, false), |expr| check_expression(cx, arg_id, &expr)),
+ .map_or((false, false), |expr| check_expression(cx, arg_id, expr)),
hir::ExprKind::Match(_, arms, _) => {
let mut found_mapping = false;
let mut found_filtering = false;
for arm in *arms {
- let (m, f) = check_expression(cx, arg_id, &arm.body);
+ let (m, f) = check_expression(cx, arg_id, arm.body);
found_mapping |= m;
found_filtering |= f;
}
(found_mapping, found_filtering)
},
// There must be an else_arm or there will be a type error
- hir::ExprKind::If(_, ref if_arm, Some(ref else_arm)) => {
+ hir::ExprKind::If(_, if_arm, Some(else_arm)) => {
let if_check = check_expression(cx, arg_id, if_arm);
let else_check = check_expression(cx, arg_id, else_arm);
(if_check.0 | else_check.0, if_check.1 | else_check.1)
diff --git a/clippy_lints/src/methods/unnecessary_fold.rs b/clippy_lints/src/methods/unnecessary_fold.rs
index 7c16470348fd..75517c48a21c 100644
--- a/clippy_lints/src/methods/unnecessary_fold.rs
+++ b/clippy_lints/src/methods/unnecessary_fold.rs
@@ -34,13 +34,13 @@ pub(super) fn check(
let closure_expr = remove_blocks(&closure_body.value);
// Check if the closure body is of the form `acc <op> some_expr(x)`
- if let hir::ExprKind::Binary(ref bin_op, ref left_expr, ref right_expr) = closure_expr.kind;
+ if let hir::ExprKind::Binary(ref bin_op, left_expr, right_expr) = closure_expr.kind;
if bin_op.node == op;
// Extract the names of the two arguments to the closure
if let [param_a, param_b] = closure_body.params;
- if let PatKind::Binding(_, first_arg_id, ..) = strip_pat_refs(¶m_a.pat).kind;
- if let PatKind::Binding(_, second_arg_id, second_arg_ident, _) = strip_pat_refs(¶m_b.pat).kind;
+ if let PatKind::Binding(_, first_arg_id, ..) = strip_pat_refs(param_a.pat).kind;
+ if let PatKind::Binding(_, second_arg_id, second_arg_ident, _) = strip_pat_refs(param_b.pat).kind;
if path_to_local_id(left_expr, first_arg_id);
if replacement_has_args || path_to_local_id(right_expr, second_arg_id);
diff --git a/clippy_lints/src/methods/utils.rs b/clippy_lints/src/methods/utils.rs
index ac6b55396da7..f6bf37e08b96 100644
--- a/clippy_lints/src/methods/utils.rs
+++ b/clippy_lints/src/methods/utils.rs
@@ -26,7 +26,7 @@ pub(super) fn derefs_to_slice<'tcx>(
}
}
- if let hir::ExprKind::MethodCall(ref path, _, ref args, _) = expr.kind {
+ if let hir::ExprKind::MethodCall(path, _, args, _) = expr.kind {
if path.ident.name == sym::iter && may_slice(cx, cx.typeck_results().expr_ty(&args[0])) {
Some(&args[0])
} else {
diff --git a/clippy_lints/src/methods/zst_offset.rs b/clippy_lints/src/methods/zst_offset.rs
index 0489d0f6fcfc..866cf616679c 100644
--- a/clippy_lints/src/methods/zst_offset.rs
+++ b/clippy_lints/src/methods/zst_offset.rs
@@ -8,7 +8,7 @@ use super::ZST_OFFSET;
pub(super) fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, recv: &hir::Expr<'_>) {
if_chain! {
- if let ty::RawPtr(ty::TypeAndMut { ref ty, .. }) = cx.typeck_results().expr_ty(recv).kind();
+ if let ty::RawPtr(ty::TypeAndMut { ty, .. }) = cx.typeck_results().expr_ty(recv).kind();
if let Ok(layout) = cx.tcx.layout_of(cx.param_env.and(ty));
if layout.is_zst();
then {
diff --git a/clippy_lints/src/minmax.rs b/clippy_lints/src/minmax.rs
index 776f4c7b7413..45948f4d926b 100644
--- a/clippy_lints/src/minmax.rs
+++ b/clippy_lints/src/minmax.rs
@@ -67,7 +67,7 @@ enum MinMax {
fn min_max<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<(MinMax, Constant, &'a Expr<'a>)> {
match expr.kind {
- ExprKind::Call(ref path, ref args) => {
+ ExprKind::Call(path, args) => {
if let ExprKind::Path(ref qpath) = path.kind {
cx.typeck_results()
.qpath_res(qpath, path.hir_id)
@@ -85,7 +85,7 @@ fn min_max<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<(MinMax, Cons
None
}
},
- ExprKind::MethodCall(ref path, _, ref args, _) => {
+ ExprKind::MethodCall(path, _, args, _) => {
if_chain! {
if let [obj, _] = args;
if cx.typeck_results().expr_ty(obj).is_floating_point() || match_trait_method(cx, expr, &paths::ORD);
diff --git a/clippy_lints/src/misc.rs b/clippy_lints/src/misc.rs
index c23643cb2f5b..afced5a5ce58 100644
--- a/clippy_lints/src/misc.rs
+++ b/clippy_lints/src/misc.rs
@@ -304,9 +304,9 @@ impl<'tcx> LateLintPass<'tcx> for MiscLints {
fn check_stmt(&mut self, cx: &LateContext<'tcx>, stmt: &'tcx Stmt<'_>) {
if_chain! {
if !in_external_macro(cx.tcx.sess, stmt.span);
- if let StmtKind::Local(ref local) = stmt.kind;
+ if let StmtKind::Local(local) = stmt.kind;
if let PatKind::Binding(an, .., name, None) = local.pat.kind;
- if let Some(ref init) = local.init;
+ if let Some(init) = local.init;
if !higher::is_from_for_desugar(local);
if an == BindingAnnotation::Ref || an == BindingAnnotation::RefMut;
then {
@@ -322,7 +322,7 @@ impl<'tcx> LateLintPass<'tcx> for MiscLints {
} else {
("", sugg_init.addr())
};
- let tyopt = if let Some(ref ty) = local.ty {
+ let tyopt = if let Some(ty) = local.ty {
format!(": &{mutopt}{ty}", mutopt=mutopt, ty=snippet(cx, ty.span, ".."))
} else {
String::new()
@@ -350,8 +350,8 @@ impl<'tcx> LateLintPass<'tcx> for MiscLints {
}
};
if_chain! {
- if let StmtKind::Semi(ref expr) = stmt.kind;
- if let ExprKind::Binary(ref binop, ref a, ref b) = expr.kind;
+ if let StmtKind::Semi(expr) = stmt.kind;
+ if let ExprKind::Binary(ref binop, a, b) = expr.kind;
if binop.node == BinOpKind::And || binop.node == BinOpKind::Or;
if let Some(sugg) = Sugg::hir_opt(cx, a);
then {
@@ -378,11 +378,11 @@ impl<'tcx> LateLintPass<'tcx> for MiscLints {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
match expr.kind {
- ExprKind::Cast(ref e, ref ty) => {
+ ExprKind::Cast(e, ty) => {
check_cast(cx, expr.span, e, ty);
return;
},
- ExprKind::Binary(ref cmp, ref left, ref right) => {
+ ExprKind::Binary(ref cmp, left, right) => {
check_binary(cx, expr, cmp, left, right);
return;
},
@@ -501,12 +501,12 @@ fn is_allowed<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) -> bool {
// Return true if `expr` is the result of `signum()` invoked on a float value.
fn is_signum(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
// The negation of a signum is still a signum
- if let ExprKind::Unary(UnOp::Neg, ref child_expr) = expr.kind {
- return is_signum(cx, &child_expr);
+ if let ExprKind::Unary(UnOp::Neg, child_expr) = expr.kind {
+ return is_signum(cx, child_expr);
}
if_chain! {
- if let ExprKind::MethodCall(ref method_name, _, ref expressions, _) = expr.kind;
+ if let ExprKind::MethodCall(method_name, _, expressions, _) = expr.kind;
if sym!(signum) == method_name.ident.name;
// Check that the receiver of the signum() is a float (expressions[0] is the receiver of
// the method call)
@@ -552,7 +552,7 @@ fn check_to_owned(cx: &LateContext<'_>, expr: &Expr<'_>, other: &Expr<'_>, left:
}
let (arg_ty, snip) = match expr.kind {
- ExprKind::MethodCall(.., ref args, _) if args.len() == 1 => {
+ ExprKind::MethodCall(.., args, _) if args.len() == 1 => {
if_chain!(
if let Some(expr_def_id) = cx.typeck_results().type_dependent_def_id(expr.hir_id);
if is_diagnostic_assoc_item(cx, expr_def_id, sym::ToString)
@@ -564,7 +564,7 @@ fn check_to_owned(cx: &LateContext<'_>, expr: &Expr<'_>, other: &Expr<'_>, left:
}
)
},
- ExprKind::Call(ref path, ref v) if v.len() == 1 => {
+ ExprKind::Call(path, v) if v.len() == 1 => {
if let ExprKind::Path(ref path) = path.kind {
if match_qpath(path, &["String", "from_str"]) || match_qpath(path, &["String", "from"]) {
(cx.typeck_results().expr_ty(&v[0]), snippet(cx, v[0].span, ".."))
@@ -649,7 +649,7 @@ fn check_to_owned(cx: &LateContext<'_>, expr: &Expr<'_>, other: &Expr<'_>, left:
/// of what it means for an expression to be "used".
fn is_used(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
get_parent_expr(cx, expr).map_or(true, |parent| match parent.kind {
- ExprKind::Assign(_, ref rhs, _) | ExprKind::AssignOp(_, _, ref rhs) => SpanlessEq::new(cx).eq_expr(rhs, expr),
+ ExprKind::Assign(_, rhs, _) | ExprKind::AssignOp(_, _, rhs) => SpanlessEq::new(cx).eq_expr(rhs, expr),
_ => is_used(cx, parent),
})
}
diff --git a/clippy_lints/src/missing_const_for_fn.rs b/clippy_lints/src/missing_const_for_fn.rs
index 23554669d977..0dc02431ad53 100644
--- a/clippy_lints/src/missing_const_for_fn.rs
+++ b/clippy_lints/src/missing_const_for_fn.rs
@@ -138,7 +138,7 @@ impl<'tcx> LateLintPass<'tcx> for MissingConstForFn {
let mir = cx.tcx.optimized_mir(def_id);
- if let Err((span, err)) = is_min_const_fn(cx.tcx, &mir) {
+ if let Err((span, err)) = is_min_const_fn(cx.tcx, mir) {
if rustc_mir::const_eval::is_min_const_fn(cx.tcx, def_id.to_def_id()) {
cx.tcx.sess.span_err(span, &err);
}
diff --git a/clippy_lints/src/missing_inline.rs b/clippy_lints/src/missing_inline.rs
index dd4488f3f026..041fe64a1a97 100644
--- a/clippy_lints/src/missing_inline.rs
+++ b/clippy_lints/src/missing_inline.rs
@@ -96,7 +96,7 @@ impl<'tcx> LateLintPass<'tcx> for MissingInline {
let attrs = cx.tcx.hir().attrs(it.hir_id());
check_missing_inline_attrs(cx, attrs, it.span, desc);
},
- hir::ItemKind::Trait(ref _is_auto, ref _unsafe, ref _generics, ref _bounds, trait_items) => {
+ hir::ItemKind::Trait(ref _is_auto, ref _unsafe, ref _generics, _bounds, trait_items) => {
// note: we need to check if the trait is exported so we can't use
// `LateLintPass::check_trait_item` here.
for tit in trait_items {
diff --git a/clippy_lints/src/mut_key.rs b/clippy_lints/src/mut_key.rs
index 41bd07bcf1ea..ed7b9cd62dcb 100644
--- a/clippy_lints/src/mut_key.rs
+++ b/clippy_lints/src/mut_key.rs
@@ -58,21 +58,21 @@ declare_lint_pass!(MutableKeyType => [ MUTABLE_KEY_TYPE ]);
impl<'tcx> LateLintPass<'tcx> for MutableKeyType {
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::Item<'tcx>) {
if let hir::ItemKind::Fn(ref sig, ..) = item.kind {
- check_sig(cx, item.hir_id(), &sig.decl);
+ check_sig(cx, item.hir_id(), sig.decl);
}
}
fn check_impl_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::ImplItem<'tcx>) {
if let hir::ImplItemKind::Fn(ref sig, ..) = item.kind {
if trait_ref_of_method(cx, item.hir_id()).is_none() {
- check_sig(cx, item.hir_id(), &sig.decl);
+ check_sig(cx, item.hir_id(), sig.decl);
}
}
}
fn check_trait_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::TraitItem<'tcx>) {
if let hir::TraitItemKind::Fn(ref sig, ..) = item.kind {
- check_sig(cx, item.hir_id(), &sig.decl);
+ check_sig(cx, item.hir_id(), sig.decl);
}
}
diff --git a/clippy_lints/src/mut_mut.rs b/clippy_lints/src/mut_mut.rs
index ef33e41a5fa9..4b9c51d0c16c 100644
--- a/clippy_lints/src/mut_mut.rs
+++ b/clippy_lints/src/mut_mut.rs
@@ -62,7 +62,7 @@ impl<'a, 'tcx> intravisit::Visitor<'tcx> for MutVisitor<'a, 'tcx> {
// Let's ignore the generated code.
intravisit::walk_expr(self, arg);
intravisit::walk_expr(self, body);
- } else if let hir::ExprKind::AddrOf(hir::BorrowKind::Ref, hir::Mutability::Mut, ref e) = expr.kind {
+ } else if let hir::ExprKind::AddrOf(hir::BorrowKind::Ref, hir::Mutability::Mut, e) = expr.kind {
if let hir::ExprKind::AddrOf(hir::BorrowKind::Ref, hir::Mutability::Mut, _) = e.kind {
span_lint(
self.cx,
@@ -85,7 +85,7 @@ impl<'a, 'tcx> intravisit::Visitor<'tcx> for MutVisitor<'a, 'tcx> {
if let hir::TyKind::Rptr(
_,
hir::MutTy {
- ty: ref pty,
+ ty: pty,
mutbl: hir::Mutability::Mut,
},
) = ty.kind
diff --git a/clippy_lints/src/mut_reference.rs b/clippy_lints/src/mut_reference.rs
index 0c09ddb80733..b85cc4b95482 100644
--- a/clippy_lints/src/mut_reference.rs
+++ b/clippy_lints/src/mut_reference.rs
@@ -32,7 +32,7 @@ declare_lint_pass!(UnnecessaryMutPassed => [UNNECESSARY_MUT_PASSED]);
impl<'tcx> LateLintPass<'tcx> for UnnecessaryMutPassed {
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
match e.kind {
- ExprKind::Call(ref fn_expr, ref arguments) => {
+ ExprKind::Call(fn_expr, arguments) => {
if let ExprKind::Path(ref path) = fn_expr.kind {
check_arguments(
cx,
@@ -43,7 +43,7 @@ impl<'tcx> LateLintPass<'tcx> for UnnecessaryMutPassed {
);
}
},
- ExprKind::MethodCall(ref path, _, ref arguments, _) => {
+ ExprKind::MethodCall(path, _, arguments, _) => {
let def_id = cx.typeck_results().type_dependent_def_id(e.hir_id).unwrap();
let substs = cx.typeck_results().node_substs(e.hir_id);
let method_type = cx.tcx.type_of(def_id).subst(cx.tcx, substs);
diff --git a/clippy_lints/src/needless_bool.rs b/clippy_lints/src/needless_bool.rs
index db7b3423ad9d..96a58d1410f2 100644
--- a/clippy_lints/src/needless_bool.rs
+++ b/clippy_lints/src/needless_bool.rs
@@ -71,7 +71,7 @@ declare_lint_pass!(NeedlessBool => [NEEDLESS_BOOL]);
impl<'tcx> LateLintPass<'tcx> for NeedlessBool {
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
use self::Expression::{Bool, RetBool};
- if let ExprKind::If(ref pred, ref then_block, Some(ref else_expr)) = e.kind {
+ if let ExprKind::If(pred, then_block, Some(else_expr)) = e.kind {
let reduce = |ret, not| {
let mut applicability = Applicability::MachineApplicable;
let snip = Sugg::hir_with_applicability(cx, pred, "<predicate>", &mut applicability);
@@ -81,7 +81,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessBool {
snip = snip.make_return();
}
- if parent_node_is_if_expr(&e, &cx) {
+ if parent_node_is_if_expr(e, cx) {
snip = snip.blockify()
}
@@ -95,7 +95,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessBool {
applicability,
);
};
- if let ExprKind::Block(ref then_block, _) = then_block.kind {
+ if let ExprKind::Block(then_block, _) = then_block.kind {
match (fetch_bool_block(then_block), fetch_bool_expr(else_expr)) {
(RetBool(true), RetBool(true)) | (Bool(true), Bool(true)) => {
span_lint(
@@ -225,7 +225,7 @@ fn check_comparison<'a, 'tcx>(
) {
use self::Expression::{Bool, Other};
- if let ExprKind::Binary(op, ref left_side, ref right_side) = e.kind {
+ if let ExprKind::Binary(op, left_side, right_side) = e.kind {
let (l_ty, r_ty) = (
cx.typeck_results().expr_ty(left_side),
cx.typeck_results().expr_ty(right_side),
@@ -237,7 +237,7 @@ fn check_comparison<'a, 'tcx>(
let mut applicability = Applicability::MachineApplicable;
if let BinOpKind::Eq = op.node {
- let expression_info = one_side_is_unary_not(&left_side, &right_side);
+ let expression_info = one_side_is_unary_not(left_side, right_side);
if expression_info.one_side_is_unary_not {
span_lint_and_sugg(
cx,
@@ -324,9 +324,9 @@ fn fetch_bool_block(block: &Block<'_>) -> Expression {
match (&*block.stmts, block.expr.as_ref()) {
(&[], Some(e)) => fetch_bool_expr(&**e),
(&[ref e], None) => {
- if let StmtKind::Semi(ref e) = e.kind {
+ if let StmtKind::Semi(e) = e.kind {
if let ExprKind::Ret(_) = e.kind {
- fetch_bool_expr(&**e)
+ fetch_bool_expr(e)
} else {
Expression::Other
}
@@ -340,7 +340,7 @@ fn fetch_bool_block(block: &Block<'_>) -> Expression {
fn fetch_bool_expr(expr: &Expr<'_>) -> Expression {
match expr.kind {
- ExprKind::Block(ref block, _) => fetch_bool_block(block),
+ ExprKind::Block(block, _) => fetch_bool_block(block),
ExprKind::Lit(ref lit_ptr) => {
if let LitKind::Bool(value) = lit_ptr.node {
Expression::Bool(value)
@@ -348,7 +348,7 @@ fn fetch_bool_expr(expr: &Expr<'_>) -> Expression {
Expression::Other
}
},
- ExprKind::Ret(Some(ref expr)) => match fetch_bool_expr(expr) {
+ ExprKind::Ret(Some(expr)) => match fetch_bool_expr(expr) {
Expression::Bool(value) => Expression::RetBool(value),
_ => Expression::Other,
},
diff --git a/clippy_lints/src/needless_borrow.rs b/clippy_lints/src/needless_borrow.rs
index 79d84da2dfc0..eef3c16730b1 100644
--- a/clippy_lints/src/needless_borrow.rs
+++ b/clippy_lints/src/needless_borrow.rs
@@ -48,7 +48,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessBorrow {
if e.span.from_expansion() || self.derived_item.is_some() {
return;
}
- if let ExprKind::AddrOf(BorrowKind::Ref, Mutability::Not, ref inner) = e.kind {
+ if let ExprKind::AddrOf(BorrowKind::Ref, Mutability::Not, inner) = e.kind {
if let ty::Ref(_, ty, _) = cx.typeck_results().expr_ty(inner).kind() {
for adj3 in cx.typeck_results().expr_adjustments(e).windows(3) {
if let [Adjustment {
diff --git a/clippy_lints/src/needless_borrowed_ref.rs b/clippy_lints/src/needless_borrowed_ref.rs
index 7fbffe04a3f5..0e976b130ebf 100644
--- a/clippy_lints/src/needless_borrowed_ref.rs
+++ b/clippy_lints/src/needless_borrowed_ref.rs
@@ -51,7 +51,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessBorrowedRef {
if_chain! {
// Only lint immutable refs, because `&mut ref T` may be useful.
- if let PatKind::Ref(ref sub_pat, Mutability::Not) = pat.kind;
+ if let PatKind::Ref(sub_pat, Mutability::Not) = pat.kind;
// Check sub_pat got a `ref` keyword (excluding `ref mut`).
if let PatKind::Binding(BindingAnnotation::Ref, .., spanned_name, _) = sub_pat.kind;
diff --git a/clippy_lints/src/needless_for_each.rs b/clippy_lints/src/needless_for_each.rs
index 2ea871990f14..079b6642d583 100644
--- a/clippy_lints/src/needless_for_each.rs
+++ b/clippy_lints/src/needless_for_each.rs
@@ -70,7 +70,7 @@ impl LateLintPass<'_> for NeedlessForEach {
ExprKind::Array(..) | ExprKind::Call(..) | ExprKind::Path(..)
);
// Checks the type of the `iter` method receiver is NOT a user defined type.
- if has_iter_method(cx, cx.typeck_results().expr_ty(&iter_recv)).is_some();
+ if has_iter_method(cx, cx.typeck_results().expr_ty(iter_recv)).is_some();
// Skip the lint if the body is not block because this is simpler than `for` loop.
// e.g. `v.iter().for_each(f)` is simpler and clearer than using `for` loop.
if let ExprKind::Closure(_, _, body_id, ..) = for_each_arg.kind;
diff --git a/clippy_lints/src/needless_pass_by_value.rs b/clippy_lints/src/needless_pass_by_value.rs
index 7370ba399224..780e22412934 100644
--- a/clippy_lints/src/needless_pass_by_value.rs
+++ b/clippy_lints/src/needless_pass_by_value.rs
@@ -208,7 +208,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessPassByValue {
if is_type_diagnostic_item(cx, ty, sym::vec_type);
if let Some(clone_spans) =
get_spans(cx, Some(body.id()), idx, &[("clone", ".to_owned()")]);
- if let TyKind::Path(QPath::Resolved(_, ref path)) = input.kind;
+ if let TyKind::Path(QPath::Resolved(_, path)) = input.kind;
if let Some(elem_ty) = path.segments.iter()
.find(|seg| seg.ident.name == sym::Vec)
.and_then(|ps| ps.args.as_ref())
diff --git a/clippy_lints/src/needless_update.rs b/clippy_lints/src/needless_update.rs
index e93de8a252a3..8f325404deb4 100644
--- a/clippy_lints/src/needless_update.rs
+++ b/clippy_lints/src/needless_update.rs
@@ -49,7 +49,7 @@ declare_lint_pass!(NeedlessUpdate => [NEEDLESS_UPDATE]);
impl<'tcx> LateLintPass<'tcx> for NeedlessUpdate {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::Struct(_, ref fields, Some(ref base)) = expr.kind {
+ if let ExprKind::Struct(_, fields, Some(base)) = expr.kind {
let ty = cx.typeck_results().expr_ty(expr);
if let ty::Adt(def, _) = ty.kind() {
if fields.len() == def.non_enum_variant().fields.len()
diff --git a/clippy_lints/src/neg_cmp_op_on_partial_ord.rs b/clippy_lints/src/neg_cmp_op_on_partial_ord.rs
index 4b935c7b906a..0704173a0117 100644
--- a/clippy_lints/src/neg_cmp_op_on_partial_ord.rs
+++ b/clippy_lints/src/neg_cmp_op_on_partial_ord.rs
@@ -51,8 +51,8 @@ impl<'tcx> LateLintPass<'tcx> for NoNegCompOpForPartialOrd {
if_chain! {
if !in_external_macro(cx.sess(), expr.span);
- if let ExprKind::Unary(UnOp::Not, ref inner) = expr.kind;
- if let ExprKind::Binary(ref op, ref left, _) = inner.kind;
+ if let ExprKind::Unary(UnOp::Not, inner) = expr.kind;
+ if let ExprKind::Binary(ref op, left, _) = inner.kind;
if let BinOpKind::Le | BinOpKind::Ge | BinOpKind::Lt | BinOpKind::Gt = op.node;
then {
diff --git a/clippy_lints/src/neg_multiply.rs b/clippy_lints/src/neg_multiply.rs
index 7b00879251f7..34fd012572f4 100644
--- a/clippy_lints/src/neg_multiply.rs
+++ b/clippy_lints/src/neg_multiply.rs
@@ -28,12 +28,12 @@ declare_lint_pass!(NegMultiply => [NEG_MULTIPLY]);
#[allow(clippy::match_same_arms)]
impl<'tcx> LateLintPass<'tcx> for NegMultiply {
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
- if let ExprKind::Binary(ref op, ref left, ref right) = e.kind {
+ if let ExprKind::Binary(ref op, left, right) = e.kind {
if BinOpKind::Mul == op.node {
match (&left.kind, &right.kind) {
(&ExprKind::Unary(..), &ExprKind::Unary(..)) => {},
- (&ExprKind::Unary(UnOp::Neg, ref lit), _) => check_mul(cx, e.span, lit, right),
- (_, &ExprKind::Unary(UnOp::Neg, ref lit)) => check_mul(cx, e.span, lit, left),
+ (&ExprKind::Unary(UnOp::Neg, lit), _) => check_mul(cx, e.span, lit, right),
+ (_, &ExprKind::Unary(UnOp::Neg, lit)) => check_mul(cx, e.span, lit, left),
_ => {},
}
}
diff --git a/clippy_lints/src/no_effect.rs b/clippy_lints/src/no_effect.rs
index 83953a16bc8d..cfcaf5094716 100644
--- a/clippy_lints/src/no_effect.rs
+++ b/clippy_lints/src/no_effect.rs
@@ -51,23 +51,21 @@ fn has_no_effect(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
match expr.kind {
ExprKind::Lit(..) | ExprKind::Closure(..) => true,
ExprKind::Path(..) => !has_drop(cx, cx.typeck_results().expr_ty(expr)),
- ExprKind::Index(ref a, ref b) | ExprKind::Binary(_, ref a, ref b) => {
- has_no_effect(cx, a) && has_no_effect(cx, b)
- },
- ExprKind::Array(ref v) | ExprKind::Tup(ref v) => v.iter().all(|val| has_no_effect(cx, val)),
- ExprKind::Repeat(ref inner, _)
- | ExprKind::Cast(ref inner, _)
- | ExprKind::Type(ref inner, _)
- | ExprKind::Unary(_, ref inner)
- | ExprKind::Field(ref inner, _)
- | ExprKind::AddrOf(_, _, ref inner)
- | ExprKind::Box(ref inner) => has_no_effect(cx, inner),
- ExprKind::Struct(_, ref fields, ref base) => {
+ ExprKind::Index(a, b) | ExprKind::Binary(_, a, b) => has_no_effect(cx, a) && has_no_effect(cx, b),
+ ExprKind::Array(v) | ExprKind::Tup(v) => v.iter().all(|val| has_no_effect(cx, val)),
+ ExprKind::Repeat(inner, _)
+ | ExprKind::Cast(inner, _)
+ | ExprKind::Type(inner, _)
+ | ExprKind::Unary(_, inner)
+ | ExprKind::Field(inner, _)
+ | ExprKind::AddrOf(_, _, inner)
+ | ExprKind::Box(inner) => has_no_effect(cx, inner),
+ ExprKind::Struct(_, fields, ref base) => {
!has_drop(cx, cx.typeck_results().expr_ty(expr))
- && fields.iter().all(|field| has_no_effect(cx, &field.expr))
+ && fields.iter().all(|field| has_no_effect(cx, field.expr))
&& base.as_ref().map_or(true, |base| has_no_effect(cx, base))
},
- ExprKind::Call(ref callee, ref args) => {
+ ExprKind::Call(callee, args) => {
if let ExprKind::Path(ref qpath) = callee.kind {
let res = cx.qpath_res(qpath, callee.hir_id);
match res {
@@ -81,7 +79,7 @@ fn has_no_effect(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
false
}
},
- ExprKind::Block(ref block, _) => {
+ ExprKind::Block(block, _) => {
block.stmts.is_empty() && block.expr.as_ref().map_or(false, |expr| has_no_effect(cx, expr))
},
_ => false,
@@ -92,7 +90,7 @@ declare_lint_pass!(NoEffect => [NO_EFFECT, UNNECESSARY_OPERATION]);
impl<'tcx> LateLintPass<'tcx> for NoEffect {
fn check_stmt(&mut self, cx: &LateContext<'tcx>, stmt: &'tcx Stmt<'_>) {
- if let StmtKind::Semi(ref expr) = stmt.kind {
+ if let StmtKind::Semi(expr) = stmt.kind {
if has_no_effect(cx, expr) {
span_lint(cx, NO_EFFECT, stmt.span, "statement with no effect");
} else if let Some(reduced) = reduce_expression(cx, expr) {
@@ -127,26 +125,26 @@ fn reduce_expression<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<Vec
return None;
}
match expr.kind {
- ExprKind::Index(ref a, ref b) => Some(vec![&**a, &**b]),
- ExprKind::Binary(ref binop, ref a, ref b) if binop.node != BinOpKind::And && binop.node != BinOpKind::Or => {
- Some(vec![&**a, &**b])
+ ExprKind::Index(a, b) => Some(vec![a, b]),
+ ExprKind::Binary(ref binop, a, b) if binop.node != BinOpKind::And && binop.node != BinOpKind::Or => {
+ Some(vec![a, b])
},
- ExprKind::Array(ref v) | ExprKind::Tup(ref v) => Some(v.iter().collect()),
- ExprKind::Repeat(ref inner, _)
- | ExprKind::Cast(ref inner, _)
- | ExprKind::Type(ref inner, _)
- | ExprKind::Unary(_, ref inner)
- | ExprKind::Field(ref inner, _)
- | ExprKind::AddrOf(_, _, ref inner)
- | ExprKind::Box(ref inner) => reduce_expression(cx, inner).or_else(|| Some(vec![inner])),
- ExprKind::Struct(_, ref fields, ref base) => {
+ ExprKind::Array(v) | ExprKind::Tup(v) => Some(v.iter().collect()),
+ ExprKind::Repeat(inner, _)
+ | ExprKind::Cast(inner, _)
+ | ExprKind::Type(inner, _)
+ | ExprKind::Unary(_, inner)
+ | ExprKind::Field(inner, _)
+ | ExprKind::AddrOf(_, _, inner)
+ | ExprKind::Box(inner) => reduce_expression(cx, inner).or_else(|| Some(vec![inner])),
+ ExprKind::Struct(_, fields, ref base) => {
if has_drop(cx, cx.typeck_results().expr_ty(expr)) {
None
} else {
Some(fields.iter().map(|f| &f.expr).chain(base).map(Deref::deref).collect())
}
},
- ExprKind::Call(ref callee, ref args) => {
+ ExprKind::Call(callee, args) => {
if let ExprKind::Path(ref qpath) = callee.kind {
let res = cx.qpath_res(qpath, callee.hir_id);
match res {
@@ -161,7 +159,7 @@ fn reduce_expression<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<Vec
None
}
},
- ExprKind::Block(ref block, _) => {
+ ExprKind::Block(block, _) => {
if block.stmts.is_empty() {
block.expr.as_ref().and_then(|e| {
match block.rules {
diff --git a/clippy_lints/src/non_octal_unix_permissions.rs b/clippy_lints/src/non_octal_unix_permissions.rs
index 6d45e7bc6cf6..a83daea97bf6 100644
--- a/clippy_lints/src/non_octal_unix_permissions.rs
+++ b/clippy_lints/src/non_octal_unix_permissions.rs
@@ -44,7 +44,7 @@ impl LateLintPass<'_> for NonOctalUnixPermissions {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) {
match &expr.kind {
ExprKind::MethodCall(path, _, [func, param], _) => {
- let obj_ty = cx.typeck_results().expr_ty(&func).peel_refs();
+ let obj_ty = cx.typeck_results().expr_ty(func).peel_refs();
if_chain! {
if (path.ident.name == sym!(mode)
@@ -65,7 +65,7 @@ impl LateLintPass<'_> for NonOctalUnixPermissions {
}
}
},
- ExprKind::Call(ref func, [param]) => {
+ ExprKind::Call(func, [param]) => {
if_chain! {
if let ExprKind::Path(ref path) = func.kind;
if let Some(def_id) = cx.qpath_res(path, func.hir_id).opt_def_id();
diff --git a/clippy_lints/src/open_options.rs b/clippy_lints/src/open_options.rs
index c61dff4b8e04..9efe45336bfc 100644
--- a/clippy_lints/src/open_options.rs
+++ b/clippy_lints/src/open_options.rs
@@ -31,7 +31,7 @@ declare_lint_pass!(OpenOptions => [NONSENSICAL_OPEN_OPTIONS]);
impl<'tcx> LateLintPass<'tcx> for OpenOptions {
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
- if let ExprKind::MethodCall(ref path, _, ref arguments, _) = e.kind {
+ if let ExprKind::MethodCall(path, _, arguments, _) = e.kind {
let obj_ty = cx.typeck_results().expr_ty(&arguments[0]).peel_refs();
if path.ident.name == sym!(open) && match_type(cx, obj_ty, &paths::OPEN_OPTIONS) {
let mut options = Vec::new();
@@ -59,7 +59,7 @@ enum OpenOption {
}
fn get_open_options(cx: &LateContext<'_>, argument: &Expr<'_>, options: &mut Vec<(OpenOption, Argument)>) {
- if let ExprKind::MethodCall(ref path, _, ref arguments, _) = argument.kind {
+ if let ExprKind::MethodCall(path, _, arguments, _) = argument.kind {
let obj_ty = cx.typeck_results().expr_ty(&arguments[0]).peel_refs();
// Only proceed if this is a call on some object of type std::fs::OpenOptions
diff --git a/clippy_lints/src/option_if_let_else.rs b/clippy_lints/src/option_if_let_else.rs
index a76a4a33f1f3..1b9120ae45f5 100644
--- a/clippy_lints/src/option_if_let_else.rs
+++ b/clippy_lints/src/option_if_let_else.rs
@@ -66,9 +66,9 @@ declare_lint_pass!(OptionIfLetElse => [OPTION_IF_LET_ELSE]);
/// Returns true iff the given expression is the result of calling `Result::ok`
fn is_result_ok(cx: &LateContext<'_>, expr: &'_ Expr<'_>) -> bool {
- if let ExprKind::MethodCall(ref path, _, &[ref receiver], _) = &expr.kind {
+ if let ExprKind::MethodCall(path, _, &[ref receiver], _) = &expr.kind {
path.ident.name.as_str() == "ok"
- && is_type_diagnostic_item(cx, &cx.typeck_results().expr_ty(&receiver), sym::result_type)
+ && is_type_diagnostic_item(cx, cx.typeck_results().expr_ty(receiver), sym::result_type)
} else {
false
}
@@ -97,9 +97,9 @@ fn extract_body_from_arm<'a>(arm: &'a Arm<'a>) -> Option<&'a Expr<'a>> {
) = &arm.body.kind
{
if let [] = statements {
- Some(&expr)
+ Some(expr)
} else {
- Some(&arm.body)
+ Some(arm.body)
}
} else {
None
diff --git a/clippy_lints/src/overflow_check_conditional.rs b/clippy_lints/src/overflow_check_conditional.rs
index cf667c6e8053..e222782c2cc8 100644
--- a/clippy_lints/src/overflow_check_conditional.rs
+++ b/clippy_lints/src/overflow_check_conditional.rs
@@ -31,11 +31,11 @@ impl<'tcx> LateLintPass<'tcx> for OverflowCheckConditional {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
let eq = |l, r| SpanlessEq::new(cx).eq_path_segment(l, r);
if_chain! {
- if let ExprKind::Binary(ref op, ref first, ref second) = expr.kind;
- if let ExprKind::Binary(ref op2, ref ident1, ref ident2) = first.kind;
- if let ExprKind::Path(QPath::Resolved(_, ref path1)) = ident1.kind;
- if let ExprKind::Path(QPath::Resolved(_, ref path2)) = ident2.kind;
- if let ExprKind::Path(QPath::Resolved(_, ref path3)) = second.kind;
+ if let ExprKind::Binary(ref op, first, second) = expr.kind;
+ if let ExprKind::Binary(ref op2, ident1, ident2) = first.kind;
+ if let ExprKind::Path(QPath::Resolved(_, path1)) = ident1.kind;
+ if let ExprKind::Path(QPath::Resolved(_, path2)) = ident2.kind;
+ if let ExprKind::Path(QPath::Resolved(_, path3)) = second.kind;
if eq(&path1.segments[0], &path3.segments[0]) || eq(&path2.segments[0], &path3.segments[0]);
if cx.typeck_results().expr_ty(ident1).is_integral();
if cx.typeck_results().expr_ty(ident2).is_integral();
@@ -56,11 +56,11 @@ impl<'tcx> LateLintPass<'tcx> for OverflowCheckConditional {
}
if_chain! {
- if let ExprKind::Binary(ref op, ref first, ref second) = expr.kind;
- if let ExprKind::Binary(ref op2, ref ident1, ref ident2) = second.kind;
- if let ExprKind::Path(QPath::Resolved(_, ref path1)) = ident1.kind;
- if let ExprKind::Path(QPath::Resolved(_, ref path2)) = ident2.kind;
- if let ExprKind::Path(QPath::Resolved(_, ref path3)) = first.kind;
+ if let ExprKind::Binary(ref op, first, second) = expr.kind;
+ if let ExprKind::Binary(ref op2, ident1, ident2) = second.kind;
+ if let ExprKind::Path(QPath::Resolved(_, path1)) = ident1.kind;
+ if let ExprKind::Path(QPath::Resolved(_, path2)) = ident2.kind;
+ if let ExprKind::Path(QPath::Resolved(_, path3)) = first.kind;
if eq(&path1.segments[0], &path3.segments[0]) || eq(&path2.segments[0], &path3.segments[0]);
if cx.typeck_results().expr_ty(ident1).is_integral();
if cx.typeck_results().expr_ty(ident2).is_integral();
diff --git a/clippy_lints/src/pass_by_ref_or_value.rs b/clippy_lints/src/pass_by_ref_or_value.rs
index 9a5b1c3b9442..c86a847b2ee1 100644
--- a/clippy_lints/src/pass_by_ref_or_value.rs
+++ b/clippy_lints/src/pass_by_ref_or_value.rs
@@ -141,11 +141,11 @@ impl<'tcx> PassByRefOrValue {
};
if_chain! {
- if !output_lts.contains(&input_lt);
+ if !output_lts.contains(input_lt);
if is_copy(cx, ty);
if let Some(size) = cx.layout_of(ty).ok().map(|l| l.size.bytes());
if size <= self.ref_min_size;
- if let hir::TyKind::Rptr(_, MutTy { ty: ref decl_ty, .. }) = input.kind;
+ if let hir::TyKind::Rptr(_, MutTy { ty: decl_ty, .. }) = input.kind;
then {
let value_type = if is_self_ty(decl_ty) {
"self".into()
diff --git a/clippy_lints/src/path_buf_push_overwrite.rs b/clippy_lints/src/path_buf_push_overwrite.rs
index 95ffae28d8c2..002459263810 100644
--- a/clippy_lints/src/path_buf_push_overwrite.rs
+++ b/clippy_lints/src/path_buf_push_overwrite.rs
@@ -45,7 +45,7 @@ declare_lint_pass!(PathBufPushOverwrite => [PATH_BUF_PUSH_OVERWRITE]);
impl<'tcx> LateLintPass<'tcx> for PathBufPushOverwrite {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
if_chain! {
- if let ExprKind::MethodCall(ref path, _, ref args, _) = expr.kind;
+ if let ExprKind::MethodCall(path, _, args, _) = expr.kind;
if path.ident.name == sym!(push);
if args.len() == 2;
if is_type_diagnostic_item(cx, cx.typeck_results().expr_ty(&args[0]).peel_refs(), sym::PathBuf);
diff --git a/clippy_lints/src/pattern_type_mismatch.rs b/clippy_lints/src/pattern_type_mismatch.rs
index 4550b367da4b..8c198cecd6a7 100644
--- a/clippy_lints/src/pattern_type_mismatch.rs
+++ b/clippy_lints/src/pattern_type_mismatch.rs
@@ -86,7 +86,7 @@ declare_lint_pass!(PatternTypeMismatch => [PATTERN_TYPE_MISMATCH]);
impl<'tcx> LateLintPass<'tcx> for PatternTypeMismatch {
fn check_stmt(&mut self, cx: &LateContext<'tcx>, stmt: &'tcx Stmt<'_>) {
- if let StmtKind::Local(ref local) = stmt.kind {
+ if let StmtKind::Local(local) = stmt.kind {
if let Some(init) = &local.init {
if let Some(init_ty) = cx.typeck_results().node_type_opt(init.hir_id) {
let pat = &local.pat;
@@ -104,7 +104,7 @@ impl<'tcx> LateLintPass<'tcx> for PatternTypeMismatch {
}
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::Match(ref expr, arms, source) = expr.kind {
+ if let ExprKind::Match(expr, arms, source) = expr.kind {
match source {
MatchSource::Normal | MatchSource::IfLetDesugar { .. } | MatchSource::WhileLetDesugar => {
if let Some(expr_ty) = cx.typeck_results().node_type_opt(expr.hir_id) {
@@ -135,7 +135,7 @@ impl<'tcx> LateLintPass<'tcx> for PatternTypeMismatch {
) {
if let Some(fn_sig) = cx.typeck_results().liberated_fn_sigs().get(hir_id) {
for (param, ty) in body.params.iter().zip(fn_sig.inputs().iter()) {
- apply_lint(cx, ¶m.pat, ty, DerefPossible::Impossible);
+ apply_lint(cx, param.pat, ty, DerefPossible::Impossible);
}
}
}
@@ -187,7 +187,7 @@ fn find_first_mismatch<'tcx>(
ty: Ty<'tcx>,
level: Level,
) -> Option<(Span, Mutability, Level)> {
- if let PatKind::Ref(ref sub_pat, _) = pat.kind {
+ if let PatKind::Ref(sub_pat, _) = pat.kind {
if let TyKind::Ref(_, sub_ty, _) = ty.kind() {
return find_first_mismatch(cx, sub_pat, sub_ty, Level::Lower);
}
@@ -199,8 +199,8 @@ fn find_first_mismatch<'tcx>(
}
}
- if let PatKind::Struct(ref qpath, ref field_pats, _) = pat.kind {
- if let TyKind::Adt(ref adt_def, ref substs_ref) = ty.kind() {
+ if let PatKind::Struct(ref qpath, field_pats, _) = pat.kind {
+ if let TyKind::Adt(adt_def, substs_ref) = ty.kind() {
if let Some(variant) = get_variant(adt_def, qpath) {
let field_defs = &variant.fields;
return find_first_mismatch_in_struct(cx, field_pats, field_defs, substs_ref);
@@ -208,8 +208,8 @@ fn find_first_mismatch<'tcx>(
}
}
- if let PatKind::TupleStruct(ref qpath, ref pats, _) = pat.kind {
- if let TyKind::Adt(ref adt_def, ref substs_ref) = ty.kind() {
+ if let PatKind::TupleStruct(ref qpath, pats, _) = pat.kind {
+ if let TyKind::Adt(adt_def, substs_ref) = ty.kind() {
if let Some(variant) = get_variant(adt_def, qpath) {
let field_defs = &variant.fields;
let ty_iter = field_defs.iter().map(|field_def| field_def.ty(cx.tcx, substs_ref));
@@ -218,7 +218,7 @@ fn find_first_mismatch<'tcx>(
}
}
- if let PatKind::Tuple(ref pats, _) = pat.kind {
+ if let PatKind::Tuple(pats, _) = pat.kind {
if let TyKind::Tuple(..) = ty.kind() {
return find_first_mismatch_in_tuple(cx, pats, ty.tuple_fields());
}
diff --git a/clippy_lints/src/ptr.rs b/clippy_lints/src/ptr.rs
index 6e530d0ffb03..09fcdb5faf84 100644
--- a/clippy_lints/src/ptr.rs
+++ b/clippy_lints/src/ptr.rs
@@ -124,7 +124,7 @@ declare_lint_pass!(Ptr => [PTR_ARG, CMP_NULL, MUT_FROM_REF]);
impl<'tcx> LateLintPass<'tcx> for Ptr {
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'_>) {
if let ItemKind::Fn(ref sig, _, body_id) = item.kind {
- check_fn(cx, &sig.decl, item.hir_id(), Some(body_id));
+ check_fn(cx, sig.decl, item.hir_id(), Some(body_id));
}
}
@@ -136,7 +136,7 @@ impl<'tcx> LateLintPass<'tcx> for Ptr {
return; // ignore trait impls
}
}
- check_fn(cx, &sig.decl, item.hir_id(), Some(body_id));
+ check_fn(cx, sig.decl, item.hir_id(), Some(body_id));
}
}
@@ -147,12 +147,12 @@ impl<'tcx> LateLintPass<'tcx> for Ptr {
} else {
None
};
- check_fn(cx, &sig.decl, item.hir_id(), body_id);
+ check_fn(cx, sig.decl, item.hir_id(), body_id);
}
}
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let ExprKind::Binary(ref op, ref l, ref r) = expr.kind {
+ if let ExprKind::Binary(ref op, l, r) = expr.kind {
if (op.node == BinOpKind::Eq || op.node == BinOpKind::Ne) && (is_null_path(l) || is_null_path(r)) {
span_lint(
cx,
@@ -262,10 +262,10 @@ fn check_fn(cx: &LateContext<'_>, decl: &FnDecl<'_>, fn_id: HirId, opt_body_id:
}
} else if match_type(cx, ty, &paths::COW) {
if_chain! {
- if let TyKind::Rptr(_, MutTy { ref ty, ..} ) = arg.kind;
- if let TyKind::Path(QPath::Resolved(None, ref pp)) = ty.kind;
+ if let TyKind::Rptr(_, MutTy { ty, ..} ) = arg.kind;
+ if let TyKind::Path(QPath::Resolved(None, pp)) = ty.kind;
if let [ref bx] = *pp.segments;
- if let Some(ref params) = bx.args;
+ if let Some(params) = bx.args;
if !params.parenthesized;
if let Some(inner) = params.args.iter().find_map(|arg| match arg {
GenericArg::Type(ty) => Some(ty),
@@ -289,7 +289,7 @@ fn check_fn(cx: &LateContext<'_>, decl: &FnDecl<'_>, fn_id: HirId, opt_body_id:
}
}
- if let FnRetTy::Return(ref ty) = decl.output {
+ if let FnRetTy::Return(ty) = decl.output {
if let Some((out, Mutability::Mut, _)) = get_rptr_lm(ty) {
let mut immutables = vec![];
for (_, ref mutbl, ref argspan) in decl
@@ -322,8 +322,8 @@ fn check_fn(cx: &LateContext<'_>, decl: &FnDecl<'_>, fn_id: HirId, opt_body_id:
fn get_only_generic_arg_snippet(cx: &LateContext<'_>, arg: &Ty<'_>) -> Option<String> {
if_chain! {
- if let TyKind::Path(QPath::Resolved(_, ref path)) = walk_ptrs_hir_ty(arg).kind;
- if let Some(&PathSegment{args: Some(ref parameters), ..}) = path.segments.last();
+ if let TyKind::Path(QPath::Resolved(_, path)) = walk_ptrs_hir_ty(arg).kind;
+ if let Some(&PathSegment{args: Some(parameters), ..}) = path.segments.last();
let types: Vec<_> = parameters.args.iter().filter_map(|arg| match arg {
GenericArg::Type(ty) => Some(ty),
_ => None,
@@ -346,7 +346,7 @@ fn get_rptr_lm<'tcx>(ty: &'tcx Ty<'tcx>) -> Option<(&'tcx Lifetime, Mutability,
}
fn is_null_path(expr: &Expr<'_>) -> bool {
- if let ExprKind::Call(ref pathexp, ref args) = expr.kind {
+ if let ExprKind::Call(pathexp, args) = expr.kind {
if args.is_empty() {
if let ExprKind::Path(ref path) = pathexp.kind {
return match_qpath(path, &paths::PTR_NULL) || match_qpath(path, &paths::PTR_NULL_MUT);
diff --git a/clippy_lints/src/ptr_eq.rs b/clippy_lints/src/ptr_eq.rs
index 5796c59c8b3f..77cfa3f6b176 100644
--- a/clippy_lints/src/ptr_eq.rs
+++ b/clippy_lints/src/ptr_eq.rs
@@ -46,11 +46,11 @@ impl LateLintPass<'_> for PtrEq {
return;
}
- if let ExprKind::Binary(ref op, ref left, ref right) = expr.kind {
+ if let ExprKind::Binary(ref op, left, right) = expr.kind {
if BinOpKind::Eq == op.node {
let (left, right) = match (expr_as_cast_to_usize(cx, left), expr_as_cast_to_usize(cx, right)) {
(Some(lhs), Some(rhs)) => (lhs, rhs),
- _ => (&**left, &**right),
+ _ => (left, right),
};
if_chain! {
@@ -79,7 +79,7 @@ impl LateLintPass<'_> for PtrEq {
// E.g., `foo as *const _ as usize` returns `foo as *const _`.
fn expr_as_cast_to_usize<'tcx>(cx: &LateContext<'tcx>, cast_expr: &'tcx Expr<'_>) -> Option<&'tcx Expr<'tcx>> {
if cx.typeck_results().expr_ty(cast_expr) == cx.tcx.types.usize {
- if let ExprKind::Cast(ref expr, _) = cast_expr.kind {
+ if let ExprKind::Cast(expr, _) = cast_expr.kind {
return Some(expr);
}
}
@@ -90,7 +90,7 @@ fn expr_as_cast_to_usize<'tcx>(cx: &LateContext<'tcx>, cast_expr: &'tcx Expr<'_>
// E.g., `foo as *const _` returns `foo`.
fn expr_as_cast_to_raw_pointer<'tcx>(cx: &LateContext<'tcx>, cast_expr: &'tcx Expr<'_>) -> Option<&'tcx Expr<'tcx>> {
if cx.typeck_results().expr_ty(cast_expr).is_unsafe_ptr() {
- if let ExprKind::Cast(ref expr, _) = cast_expr.kind {
+ if let ExprKind::Cast(expr, _) = cast_expr.kind {
return Some(expr);
}
}
diff --git a/clippy_lints/src/ptr_offset_with_cast.rs b/clippy_lints/src/ptr_offset_with_cast.rs
index c04b42552569..afb198f49559 100644
--- a/clippy_lints/src/ptr_offset_with_cast.rs
+++ b/clippy_lints/src/ptr_offset_with_cast.rs
@@ -78,8 +78,8 @@ impl<'tcx> LateLintPass<'tcx> for PtrOffsetWithCast {
// If the given expression is a cast from a usize, return the lhs of the cast
fn expr_as_cast_from_usize<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) -> Option<&'tcx Expr<'tcx>> {
- if let ExprKind::Cast(ref cast_lhs_expr, _) = expr.kind {
- if is_expr_ty_usize(cx, &cast_lhs_expr) {
+ if let ExprKind::Cast(cast_lhs_expr, _) = expr.kind {
+ if is_expr_ty_usize(cx, cast_lhs_expr) {
return Some(cast_lhs_expr);
}
}
@@ -92,7 +92,7 @@ fn expr_as_ptr_offset_call<'tcx>(
cx: &LateContext<'tcx>,
expr: &'tcx Expr<'_>,
) -> Option<(&'tcx Expr<'tcx>, &'tcx Expr<'tcx>, Method)> {
- if let ExprKind::MethodCall(ref path_segment, _, ref args, _) = expr.kind {
+ if let ExprKind::MethodCall(path_segment, _, args, _) = expr.kind {
if is_expr_ty_raw_ptr(cx, &args[0]) {
if path_segment.ident.name == sym::offset {
return Some((&args[0], &args[1], Method::Offset));
diff --git a/clippy_lints/src/question_mark.rs b/clippy_lints/src/question_mark.rs
index 2054255a7c9d..6d720f43851a 100644
--- a/clippy_lints/src/question_mark.rs
+++ b/clippy_lints/src/question_mark.rs
@@ -148,14 +148,14 @@ impl QuestionMark {
fn expression_returns_none(cx: &LateContext<'_>, expression: &Expr<'_>) -> bool {
match expression.kind {
- ExprKind::Block(ref block, _) => {
+ ExprKind::Block(block, _) => {
if let Some(return_expression) = Self::return_expression(block) {
- return Self::expression_returns_none(cx, &return_expression);
+ return Self::expression_returns_none(cx, return_expression);
}
false
},
- ExprKind::Ret(Some(ref expr)) => Self::expression_returns_none(cx, expr),
+ ExprKind::Ret(Some(expr)) => Self::expression_returns_none(cx, expr),
ExprKind::Path(ref qp) => {
if let Res::Def(DefKind::Ctor(def::CtorOf::Variant, def::CtorKind::Const), def_id) =
cx.qpath_res(qp, expression.hir_id)
@@ -174,7 +174,7 @@ impl QuestionMark {
if_chain! {
if block.stmts.len() == 1;
if let Some(expr) = block.stmts.iter().last();
- if let StmtKind::Semi(ref expr) = expr.kind;
+ if let StmtKind::Semi(expr) = expr.kind;
if let ExprKind::Ret(Some(ret_expr)) = expr.kind;
then {
diff --git a/clippy_lints/src/ranges.rs b/clippy_lints/src/ranges.rs
index 79692abb6acf..1c3c125e5791 100644
--- a/clippy_lints/src/ranges.rs
+++ b/clippy_lints/src/ranges.rs
@@ -183,10 +183,10 @@ impl_lint_pass!(Ranges => [
impl<'tcx> LateLintPass<'tcx> for Ranges {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
match expr.kind {
- ExprKind::MethodCall(ref path, _, ref args, _) => {
+ ExprKind::MethodCall(path, _, args, _) => {
check_range_zip_with_len(cx, path, args, expr.span);
},
- ExprKind::Binary(ref op, ref l, ref r) => {
+ ExprKind::Binary(ref op, l, r) => {
if meets_msrv(self.msrv.as_ref(), &MANUAL_RANGE_CONTAINS_MSRV) {
check_possible_range_contains(cx, op.node, l, r, expr);
}
@@ -287,7 +287,7 @@ fn check_possible_range_contains(cx: &LateContext<'_>, op: BinOpKind, l: &Expr<'
}
fn check_range_bounds(cx: &LateContext<'_>, ex: &Expr<'_>) -> Option<(Constant, Ident, Span, Span, Ordering, bool)> {
- if let ExprKind::Binary(ref op, ref l, ref r) = ex.kind {
+ if let ExprKind::Binary(ref op, l, r) = ex.kind {
let (inclusive, ordering) = match op.node {
BinOpKind::Gt => (false, Ordering::Greater),
BinOpKind::Ge => (true, Ordering::Greater),
@@ -324,18 +324,18 @@ fn check_range_zip_with_len(cx: &LateContext<'_>, path: &PathSegment<'_>, args:
if path.ident.as_str() == "zip";
if let [iter, zip_arg] = args;
// `.iter()` call
- if let ExprKind::MethodCall(ref iter_path, _, ref iter_args, _) = iter.kind;
+ if let ExprKind::MethodCall(iter_path, _, iter_args, _) = iter.kind;
if iter_path.ident.name == sym::iter;
// range expression in `.zip()` call: `0..x.len()`
if let Some(higher::Range { start: Some(start), end: Some(end), .. }) = higher::range(zip_arg);
if is_integer_const(cx, start, 0);
// `.len()` call
- if let ExprKind::MethodCall(ref len_path, _, ref len_args, _) = end.kind;
+ if let ExprKind::MethodCall(len_path, _, len_args, _) = end.kind;
if len_path.ident.name == sym!(len) && len_args.len() == 1;
// `.iter()` and `.len()` called on same `Path`
- if let ExprKind::Path(QPath::Resolved(_, ref iter_path)) = iter_args[0].kind;
- if let ExprKind::Path(QPath::Resolved(_, ref len_path)) = len_args[0].kind;
- if SpanlessEq::new(cx).eq_path_segments(&iter_path.segments, &len_path.segments);
+ if let ExprKind::Path(QPath::Resolved(_, iter_path)) = iter_args[0].kind;
+ if let ExprKind::Path(QPath::Resolved(_, len_path)) = len_args[0].kind;
+ if SpanlessEq::new(cx).eq_path_segments(iter_path.segments, len_path.segments);
then {
span_lint(cx,
RANGE_ZIP_WITH_LEN,
@@ -508,8 +508,8 @@ fn y_plus_one<'t>(cx: &LateContext<'_>, expr: &'t Expr<'_>) -> Option<&'t Expr<'
Spanned {
node: BinOpKind::Add, ..
},
- ref lhs,
- ref rhs,
+ lhs,
+ rhs,
) => {
if is_integer_const(cx, lhs, 1) {
Some(rhs)
@@ -529,8 +529,8 @@ fn y_minus_one<'t>(cx: &LateContext<'_>, expr: &'t Expr<'_>) -> Option<&'t Expr<
Spanned {
node: BinOpKind::Sub, ..
},
- ref lhs,
- ref rhs,
+ lhs,
+ rhs,
) if is_integer_const(cx, rhs, 1) => Some(lhs),
_ => None,
}
diff --git a/clippy_lints/src/redundant_clone.rs b/clippy_lints/src/redundant_clone.rs
index 9656ee64c818..19650c41b840 100644
--- a/clippy_lints/src/redundant_clone.rs
+++ b/clippy_lints/src/redundant_clone.rs
@@ -94,7 +94,7 @@ impl<'tcx> LateLintPass<'tcx> for RedundantClone {
.into_results_cursor(mir);
let mut possible_borrower = {
let mut vis = PossibleBorrowerVisitor::new(cx, mir);
- vis.visit_body(&mir);
+ vis.visit_body(mir);
vis.into_map(cx, maybe_storage_live_result)
};
@@ -126,7 +126,7 @@ impl<'tcx> LateLintPass<'tcx> for RedundantClone {
continue;
}
- if let ty::Adt(ref def, _) = arg_ty.kind() {
+ if let ty::Adt(def, _) = arg_ty.kind() {
if match_def_path(cx, def.did, &paths::MEM_MANUALLY_DROP) {
continue;
}
@@ -206,7 +206,7 @@ impl<'tcx> LateLintPass<'tcx> for RedundantClone {
clone_consumed_or_mutated: true,
}
} else {
- let clone_usage = visit_clone_usage(local, ret_local, &mir, bb);
+ let clone_usage = visit_clone_usage(local, ret_local, mir, bb);
if clone_usage.cloned_used && clone_usage.clone_consumed_or_mutated {
// cloned value is used, and the clone is modified or moved
continue;
@@ -426,7 +426,7 @@ fn visit_clone_usage(cloned: mir::Local, clone: mir::Local, mir: &mir::Body<'_>,
// TODO: Actually check for mutation of non-temporaries.
clone_consumed_or_mutated: mir.local_kind(clone) != mir::LocalKind::Temp,
};
- traversal::ReversePostorder::new(&mir, bb)
+ traversal::ReversePostorder::new(mir, bb)
.skip(1)
.fold(init, |usage, (tbb, tdata)| {
// Short-circuit
@@ -588,7 +588,7 @@ impl<'a, 'tcx> mir::visit::Visitor<'tcx> for PossibleBorrowerVisitor<'a, 'tcx> {
// If the call returns something with lifetimes,
// let's conservatively assume the returned value contains lifetime of all the arguments.
// For example, given `let y: Foo<'a> = foo(x)`, `y` is considered to be a possible borrower of `x`.
- if ContainsRegion.visit_ty(&self.body.local_decls[*dest].ty).is_continue() {
+ if ContainsRegion.visit_ty(self.body.local_decls[*dest].ty).is_continue() {
return;
}
diff --git a/clippy_lints/src/redundant_closure_call.rs b/clippy_lints/src/redundant_closure_call.rs
index 5429d3896101..92921bedf4df 100644
--- a/clippy_lints/src/redundant_closure_call.rs
+++ b/clippy_lints/src/redundant_closure_call.rs
@@ -111,8 +111,8 @@ impl<'tcx> LateLintPass<'tcx> for RedundantClosureCall {
fn visit_expr(&mut self, expr: &'tcx hir::Expr<'tcx>) {
if_chain! {
- if let hir::ExprKind::Call(ref closure, _) = expr.kind;
- if let hir::ExprKind::Path(hir::QPath::Resolved(_, ref path)) = closure.kind;
+ if let hir::ExprKind::Call(closure, _) = expr.kind;
+ if let hir::ExprKind::Path(hir::QPath::Resolved(_, path)) = closure.kind;
if self.path.segments[0].ident == path.segments[0].ident;
if self.path.res == path.res;
then {
@@ -133,14 +133,14 @@ impl<'tcx> LateLintPass<'tcx> for RedundantClosureCall {
for w in block.stmts.windows(2) {
if_chain! {
- if let hir::StmtKind::Local(ref local) = w[0].kind;
- if let Option::Some(ref t) = local.init;
+ if let hir::StmtKind::Local(local) = w[0].kind;
+ if let Option::Some(t) = local.init;
if let hir::ExprKind::Closure(..) = t.kind;
if let hir::PatKind::Binding(_, _, ident, _) = local.pat.kind;
- if let hir::StmtKind::Semi(ref second) = w[1].kind;
- if let hir::ExprKind::Assign(_, ref call, _) = second.kind;
- if let hir::ExprKind::Call(ref closure, _) = call.kind;
- if let hir::ExprKind::Path(hir::QPath::Resolved(_, ref path)) = closure.kind;
+ if let hir::StmtKind::Semi(second) = w[1].kind;
+ if let hir::ExprKind::Assign(_, call, _) = second.kind;
+ if let hir::ExprKind::Call(closure, _) = call.kind;
+ if let hir::ExprKind::Path(hir::QPath::Resolved(_, path)) = closure.kind;
if ident == path.segments[0].ident;
if count_closure_usage(cx, block, path) == 1;
then {
diff --git a/clippy_lints/src/ref_option_ref.rs b/clippy_lints/src/ref_option_ref.rs
index 0922cfa494e6..0cf4e0ce7fe2 100644
--- a/clippy_lints/src/ref_option_ref.rs
+++ b/clippy_lints/src/ref_option_ref.rs
@@ -44,7 +44,7 @@ impl<'tcx> LateLintPass<'tcx> for RefOptionRef {
if let Some(def_id) = res.opt_def_id();
if cx.tcx.is_diagnostic_item(sym::option_type, def_id);
- if let Some(ref params) = last_path_segment(qpath).args ;
+ if let Some(params) = last_path_segment(qpath).args ;
if !params.parenthesized;
if let Some(inner_ty) = params.args.iter().find_map(|arg| match arg {
GenericArg::Type(inner_ty) => Some(inner_ty),
diff --git a/clippy_lints/src/regex.rs b/clippy_lints/src/regex.rs
index 1cc332de894e..4b5306de58ec 100644
--- a/clippy_lints/src/regex.rs
+++ b/clippy_lints/src/regex.rs
@@ -60,7 +60,7 @@ impl_lint_pass!(Regex => [INVALID_REGEX, TRIVIAL_REGEX]);
impl<'tcx> LateLintPass<'tcx> for Regex {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
if_chain! {
- if let ExprKind::Call(ref fun, ref args) = expr.kind;
+ if let ExprKind::Call(fun, args) = expr.kind;
if let ExprKind::Path(ref qpath) = fun.kind;
if args.len() == 1;
if let Some(def_id) = cx.qpath_res(qpath, fun.hir_id).opt_def_id();
@@ -134,7 +134,7 @@ fn is_trivial_regex(s: ®ex_syntax::hir::Hir) -> Option<&'static str> {
fn check_set<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, utf8: bool) {
if_chain! {
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref expr) = expr.kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, expr) = expr.kind;
if let ExprKind::Array(exprs) = expr.kind;
then {
for expr in exprs {
diff --git a/clippy_lints/src/repeat_once.rs b/clippy_lints/src/repeat_once.rs
index 63e5ec69e66d..560a5e7c9200 100644
--- a/clippy_lints/src/repeat_once.rs
+++ b/clippy_lints/src/repeat_once.rs
@@ -45,10 +45,10 @@ impl<'tcx> LateLintPass<'tcx> for RepeatOnce {
if_chain! {
if let ExprKind::MethodCall(path, _, [receiver, count], _) = &expr.kind;
if path.ident.name == sym!(repeat);
- if let Some(Constant::Int(1)) = constant_context(cx, cx.typeck_results()).expr(&count);
+ if let Some(Constant::Int(1)) = constant_context(cx, cx.typeck_results()).expr(count);
if !in_macro(receiver.span);
then {
- let ty = cx.typeck_results().expr_ty(&receiver).peel_refs();
+ let ty = cx.typeck_results().expr_ty(receiver).peel_refs();
if ty.is_str() {
span_lint_and_sugg(
cx,
diff --git a/clippy_lints/src/returns.rs b/clippy_lints/src/returns.rs
index 8995ae431ada..af772cf4a145 100644
--- a/clippy_lints/src/returns.rs
+++ b/clippy_lints/src/returns.rs
@@ -102,7 +102,7 @@ impl<'tcx> LateLintPass<'tcx> for Return {
err.span_label(local.span, "unnecessary `let` binding");
if let Some(mut snippet) = snippet_opt(cx, initexpr.span) {
- if !cx.typeck_results().expr_adjustments(&retexpr).is_empty() {
+ if !cx.typeck_results().expr_adjustments(retexpr).is_empty() {
snippet.push_str(" as _");
}
err.multipart_suggestion(
@@ -143,7 +143,7 @@ impl<'tcx> LateLintPass<'tcx> for Return {
check_final_expr(cx, &body.value, Some(body.value.span), replacement)
},
FnKind::ItemFn(..) | FnKind::Method(..) => {
- if let ExprKind::Block(ref block, _) = body.value.kind {
+ if let ExprKind::Block(block, _) = body.value.kind {
check_block_return(cx, block);
}
},
@@ -160,7 +160,7 @@ fn check_block_return<'tcx>(cx: &LateContext<'tcx>, block: &Block<'tcx>) {
check_final_expr(cx, expr, Some(expr.span), RetReplacement::Empty);
} else if let Some(stmt) = block.stmts.iter().last() {
match stmt.kind {
- StmtKind::Expr(ref expr) | StmtKind::Semi(ref expr) => {
+ StmtKind::Expr(expr) | StmtKind::Semi(expr) => {
check_final_expr(cx, expr, Some(stmt.span), RetReplacement::Empty);
},
_ => (),
@@ -192,11 +192,11 @@ fn check_final_expr<'tcx>(
}
},
// a whole block? check it!
- ExprKind::Block(ref block, _) => {
+ ExprKind::Block(block, _) => {
check_block_return(cx, block);
},
ExprKind::If(_, then, else_clause_opt) => {
- if let ExprKind::Block(ref ifblock, _) = then.kind {
+ if let ExprKind::Block(ifblock, _) = then.kind {
check_block_return(cx, ifblock);
}
if let Some(else_clause) = else_clause_opt {
@@ -207,16 +207,16 @@ fn check_final_expr<'tcx>(
// an if/if let expr, check both exprs
// note, if without else is going to be a type checking error anyways
// (except for unit type functions) so we don't match it
- ExprKind::Match(_, ref arms, source) => match source {
+ ExprKind::Match(_, arms, source) => match source {
MatchSource::Normal => {
for arm in arms.iter() {
- check_final_expr(cx, &arm.body, Some(arm.body.span), RetReplacement::Block);
+ check_final_expr(cx, arm.body, Some(arm.body.span), RetReplacement::Block);
}
},
MatchSource::IfLetDesugar {
contains_else_clause: true,
} => {
- if let ExprKind::Block(ref ifblock, _) = arms[0].body.kind {
+ if let ExprKind::Block(ifblock, _) = arms[0].body.kind {
check_block_return(cx, ifblock);
}
check_final_expr(cx, arms[1].body, None, RetReplacement::Empty);
diff --git a/clippy_lints/src/semicolon_if_nothing_returned.rs b/clippy_lints/src/semicolon_if_nothing_returned.rs
index f61af15fbed0..553987a426b5 100644
--- a/clippy_lints/src/semicolon_if_nothing_returned.rs
+++ b/clippy_lints/src/semicolon_if_nothing_returned.rs
@@ -51,7 +51,7 @@ impl LateLintPass<'_> for SemicolonIfNothingReturned {
return;
}
- let sugg = sugg::Sugg::hir_with_macro_callsite(cx, &expr, "..");
+ let sugg = sugg::Sugg::hir_with_macro_callsite(cx, expr, "..");
let suggestion = format!("{0};", sugg);
span_lint_and_sugg(
cx,
diff --git a/clippy_lints/src/shadow.rs b/clippy_lints/src/shadow.rs
index 612d2fd84cb6..d6101bd5e36a 100644
--- a/clippy_lints/src/shadow.rs
+++ b/clippy_lints/src/shadow.rs
@@ -130,12 +130,12 @@ fn check_block<'tcx>(cx: &LateContext<'tcx>, block: &'tcx Block<'_>, bindings: &
let len = bindings.len();
for stmt in block.stmts {
match stmt.kind {
- StmtKind::Local(ref local) => check_local(cx, local, bindings),
- StmtKind::Expr(ref e) | StmtKind::Semi(ref e) => check_expr(cx, e, bindings),
+ StmtKind::Local(local) => check_local(cx, local, bindings),
+ StmtKind::Expr(e) | StmtKind::Semi(e) => check_expr(cx, e, bindings),
StmtKind::Item(..) => {},
}
}
- if let Some(ref o) = block.expr {
+ if let Some(o) = block.expr {
check_expr(cx, o, bindings);
}
bindings.truncate(len);
@@ -149,16 +149,16 @@ fn check_local<'tcx>(cx: &LateContext<'tcx>, local: &'tcx Local<'_>, bindings: &
return;
}
let Local {
- ref pat,
+ pat,
ref ty,
ref init,
span,
..
} = *local;
- if let Some(ref t) = *ty {
+ if let Some(t) = *ty {
check_ty(cx, t, bindings)
}
- if let Some(ref o) = *init {
+ if let Some(o) = *init {
check_expr(cx, o, bindings);
check_pat(cx, pat, Some(o), span, bindings);
} else {
@@ -196,34 +196,34 @@ fn check_pat<'tcx>(
bindings.push((name, ident.span));
}
}
- if let Some(ref p) = *inner {
+ if let Some(p) = *inner {
check_pat(cx, p, init, span, bindings);
}
},
PatKind::Struct(_, pfields, _) => {
if let Some(init_struct) = init {
- if let ExprKind::Struct(_, ref efields, _) = init_struct.kind {
+ if let ExprKind::Struct(_, efields, _) = init_struct.kind {
for field in pfields {
let name = field.ident.name;
let efield = efields
.iter()
.find_map(|f| if f.ident.name == name { Some(&*f.expr) } else { None });
- check_pat(cx, &field.pat, efield, span, bindings);
+ check_pat(cx, field.pat, efield, span, bindings);
}
} else {
for field in pfields {
- check_pat(cx, &field.pat, init, span, bindings);
+ check_pat(cx, field.pat, init, span, bindings);
}
}
} else {
for field in pfields {
- check_pat(cx, &field.pat, None, span, bindings);
+ check_pat(cx, field.pat, None, span, bindings);
}
}
},
PatKind::Tuple(inner, _) => {
if let Some(init_tup) = init {
- if let ExprKind::Tup(ref tup) = init_tup.kind {
+ if let ExprKind::Tup(tup) = init_tup.kind {
for (i, p) in inner.iter().enumerate() {
check_pat(cx, p, Some(&tup[i]), p.span, bindings);
}
@@ -238,10 +238,10 @@ fn check_pat<'tcx>(
}
}
},
- PatKind::Box(ref inner) => {
+ PatKind::Box(inner) => {
if let Some(initp) = init {
- if let ExprKind::Box(ref inner_init) = initp.kind {
- check_pat(cx, inner, Some(&**inner_init), span, bindings);
+ if let ExprKind::Box(inner_init) = initp.kind {
+ check_pat(cx, inner, Some(inner_init), span, bindings);
} else {
check_pat(cx, inner, init, span, bindings);
}
@@ -249,7 +249,7 @@ fn check_pat<'tcx>(
check_pat(cx, inner, init, span, bindings);
}
},
- PatKind::Ref(ref inner, _) => check_pat(cx, inner, init, span, bindings),
+ PatKind::Ref(inner, _) => check_pat(cx, inner, init, span, bindings),
// PatVec(Vec<P<Pat>>, Option<P<Pat>>, Vec<P<Pat>>),
_ => (),
}
@@ -323,11 +323,10 @@ fn check_expr<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, bindings: &mut
return;
}
match expr.kind {
- ExprKind::Unary(_, ref e)
- | ExprKind::Field(ref e, _)
- | ExprKind::AddrOf(_, _, ref e)
- | ExprKind::Box(ref e) => check_expr(cx, e, bindings),
- ExprKind::Block(ref block, _) | ExprKind::Loop(ref block, ..) => check_block(cx, block, bindings),
+ ExprKind::Unary(_, e) | ExprKind::Field(e, _) | ExprKind::AddrOf(_, _, e) | ExprKind::Box(e) => {
+ check_expr(cx, e, bindings)
+ },
+ ExprKind::Block(block, _) | ExprKind::Loop(block, ..) => check_block(cx, block, bindings),
// ExprKind::Call
// ExprKind::MethodCall
ExprKind::Array(v) | ExprKind::Tup(v) => {
@@ -335,18 +334,18 @@ fn check_expr<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, bindings: &mut
check_expr(cx, e, bindings)
}
},
- ExprKind::If(ref cond, ref then, ref otherwise) => {
+ ExprKind::If(cond, then, ref otherwise) => {
check_expr(cx, cond, bindings);
- check_expr(cx, &**then, bindings);
- if let Some(ref o) = *otherwise {
+ check_expr(cx, then, bindings);
+ if let Some(o) = *otherwise {
check_expr(cx, o, bindings);
}
},
- ExprKind::Match(ref init, arms, _) => {
+ ExprKind::Match(init, arms, _) => {
check_expr(cx, init, bindings);
let len = bindings.len();
for arm in arms {
- check_pat(cx, &arm.pat, Some(&**init), arm.pat.span, bindings);
+ check_pat(cx, arm.pat, Some(init), arm.pat.span, bindings);
// This is ugly, but needed to get the right type
if let Some(ref guard) = arm.guard {
match guard {
@@ -357,7 +356,7 @@ fn check_expr<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, bindings: &mut
},
}
}
- check_expr(cx, &arm.body, bindings);
+ check_expr(cx, arm.body, bindings);
bindings.truncate(len);
}
},
@@ -367,14 +366,12 @@ fn check_expr<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, bindings: &mut
fn check_ty<'tcx>(cx: &LateContext<'tcx>, ty: &'tcx Ty<'_>, bindings: &mut Vec<(Symbol, Span)>) {
match ty.kind {
- TyKind::Slice(ref sty) => check_ty(cx, sty, bindings),
- TyKind::Array(ref fty, ref anon_const) => {
+ TyKind::Slice(sty) => check_ty(cx, sty, bindings),
+ TyKind::Array(fty, ref anon_const) => {
check_ty(cx, fty, bindings);
check_expr(cx, &cx.tcx.hir().body(anon_const.body).value, bindings);
},
- TyKind::Ptr(MutTy { ty: ref mty, .. }) | TyKind::Rptr(_, MutTy { ty: ref mty, .. }) => {
- check_ty(cx, mty, bindings)
- },
+ TyKind::Ptr(MutTy { ty: mty, .. }) | TyKind::Rptr(_, MutTy { ty: mty, .. }) => check_ty(cx, mty, bindings),
TyKind::Tup(tup) => {
for t in tup {
check_ty(cx, t, bindings)
@@ -387,12 +384,12 @@ fn check_ty<'tcx>(cx: &LateContext<'tcx>, ty: &'tcx Ty<'_>, bindings: &mut Vec<(
fn is_self_shadow(name: Symbol, expr: &Expr<'_>) -> bool {
match expr.kind {
- ExprKind::Box(ref inner) | ExprKind::AddrOf(_, _, ref inner) => is_self_shadow(name, inner),
- ExprKind::Block(ref block, _) => {
+ ExprKind::Box(inner) | ExprKind::AddrOf(_, _, inner) => is_self_shadow(name, inner),
+ ExprKind::Block(block, _) => {
block.stmts.is_empty() && block.expr.as_ref().map_or(false, |e| is_self_shadow(name, e))
},
- ExprKind::Unary(op, ref inner) => (UnOp::Deref == op) && is_self_shadow(name, inner),
- ExprKind::Path(QPath::Resolved(_, ref path)) => path_eq_name(name, path),
+ ExprKind::Unary(op, inner) => (UnOp::Deref == op) && is_self_shadow(name, inner),
+ ExprKind::Path(QPath::Resolved(_, path)) => path_eq_name(name, path),
_ => false,
}
}
diff --git a/clippy_lints/src/slow_vector_initialization.rs b/clippy_lints/src/slow_vector_initialization.rs
index d55a83f16136..8cf89ae456ee 100644
--- a/clippy_lints/src/slow_vector_initialization.rs
+++ b/clippy_lints/src/slow_vector_initialization.rs
@@ -70,14 +70,14 @@ impl<'tcx> LateLintPass<'tcx> for SlowVectorInit {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
// Matches initialization on reassignements. For example: `vec = Vec::with_capacity(100)`
if_chain! {
- if let ExprKind::Assign(ref left, ref right, _) = expr.kind;
+ if let ExprKind::Assign(left, right, _) = expr.kind;
// Extract variable name
- if let ExprKind::Path(QPath::Resolved(_, ref path)) = left.kind;
+ if let ExprKind::Path(QPath::Resolved(_, path)) = left.kind;
if let Some(variable_name) = path.segments.get(0);
// Extract len argument
- if let Some(ref len_arg) = Self::is_vec_with_capacity(right);
+ if let Some(len_arg) = Self::is_vec_with_capacity(right);
then {
let vi = VecAllocation {
@@ -94,10 +94,10 @@ impl<'tcx> LateLintPass<'tcx> for SlowVectorInit {
fn check_stmt(&mut self, cx: &LateContext<'tcx>, stmt: &'tcx Stmt<'_>) {
// Matches statements which initializes vectors. For example: `let mut vec = Vec::with_capacity(10)`
if_chain! {
- if let StmtKind::Local(ref local) = stmt.kind;
+ if let StmtKind::Local(local) = stmt.kind;
if let PatKind::Binding(BindingAnnotation::Mutable, .., variable_name, None) = local.pat.kind;
- if let Some(ref init) = local.init;
- if let Some(ref len_arg) = Self::is_vec_with_capacity(init);
+ if let Some(init) = local.init;
+ if let Some(len_arg) = Self::is_vec_with_capacity(init);
then {
let vi = VecAllocation {
@@ -117,7 +117,7 @@ impl SlowVectorInit {
/// of the first argument of `with_capacity` call if it matches or `None` if it does not.
fn is_vec_with_capacity<'tcx>(expr: &Expr<'tcx>) -> Option<&'tcx Expr<'tcx>> {
if_chain! {
- if let ExprKind::Call(ref func, ref args) = expr.kind;
+ if let ExprKind::Call(func, args) = expr.kind;
if let ExprKind::Path(ref path) = func.kind;
if match_qpath(path, &["Vec", "with_capacity"]);
if args.len() == 1;
@@ -208,11 +208,11 @@ impl<'a, 'tcx> VectorInitializationVisitor<'a, 'tcx> {
fn search_slow_extend_filling(&mut self, expr: &'tcx Expr<'_>) {
if_chain! {
if self.initialization_found;
- if let ExprKind::MethodCall(ref path, _, ref args, _) = expr.kind;
+ if let ExprKind::MethodCall(path, _, args, _) = expr.kind;
if let ExprKind::Path(ref qpath_subj) = args[0].kind;
- if match_qpath(&qpath_subj, &[&*self.vec_alloc.variable_name.as_str()]);
+ if match_qpath(qpath_subj, &[&*self.vec_alloc.variable_name.as_str()]);
if path.ident.name == sym!(extend);
- if let Some(ref extend_arg) = args.get(1);
+ if let Some(extend_arg) = args.get(1);
if self.is_repeat_take(extend_arg);
then {
@@ -225,11 +225,11 @@ impl<'a, 'tcx> VectorInitializationVisitor<'a, 'tcx> {
fn search_slow_resize_filling(&mut self, expr: &'tcx Expr<'_>) {
if_chain! {
if self.initialization_found;
- if let ExprKind::MethodCall(ref path, _, ref args, _) = expr.kind;
+ if let ExprKind::MethodCall(path, _, args, _) = expr.kind;
if let ExprKind::Path(ref qpath_subj) = args[0].kind;
- if match_qpath(&qpath_subj, &[&*self.vec_alloc.variable_name.as_str()]);
+ if match_qpath(qpath_subj, &[&*self.vec_alloc.variable_name.as_str()]);
if path.ident.name == sym!(resize);
- if let (Some(ref len_arg), Some(fill_arg)) = (args.get(1), args.get(2));
+ if let (Some(len_arg), Some(fill_arg)) = (args.get(1), args.get(2));
// Check that is filled with 0
if let ExprKind::Lit(ref lit) = fill_arg.kind;
@@ -247,15 +247,15 @@ impl<'a, 'tcx> VectorInitializationVisitor<'a, 'tcx> {
/// Returns `true` if give expression is `repeat(0).take(...)`
fn is_repeat_take(&self, expr: &Expr<'_>) -> bool {
if_chain! {
- if let ExprKind::MethodCall(ref take_path, _, ref take_args, _) = expr.kind;
+ if let ExprKind::MethodCall(take_path, _, take_args, _) = expr.kind;
if take_path.ident.name == sym!(take);
// Check that take is applied to `repeat(0)`
- if let Some(ref repeat_expr) = take_args.get(0);
+ if let Some(repeat_expr) = take_args.get(0);
if Self::is_repeat_zero(repeat_expr);
// Check that len expression is equals to `with_capacity` expression
- if let Some(ref len_arg) = take_args.get(1);
+ if let Some(len_arg) = take_args.get(1);
if SpanlessEq::new(self.cx).eq_expr(len_arg, self.vec_alloc.len_expr);
then {
@@ -269,10 +269,10 @@ impl<'a, 'tcx> VectorInitializationVisitor<'a, 'tcx> {
/// Returns `true` if given expression is `repeat(0)`
fn is_repeat_zero(expr: &Expr<'_>) -> bool {
if_chain! {
- if let ExprKind::Call(ref fn_expr, ref repeat_args) = expr.kind;
+ if let ExprKind::Call(fn_expr, repeat_args) = expr.kind;
if let ExprKind::Path(ref qpath_repeat) = fn_expr.kind;
- if match_qpath(&qpath_repeat, &["repeat"]);
- if let Some(ref repeat_arg) = repeat_args.get(0);
+ if match_qpath(qpath_repeat, &["repeat"]);
+ if let Some(repeat_arg) = repeat_args.get(0);
if let ExprKind::Lit(ref lit) = repeat_arg.kind;
if let LitKind::Int(0, _) = lit.node;
@@ -291,7 +291,7 @@ impl<'a, 'tcx> Visitor<'tcx> for VectorInitializationVisitor<'a, 'tcx> {
fn visit_stmt(&mut self, stmt: &'tcx Stmt<'_>) {
if self.initialization_found {
match stmt.kind {
- StmtKind::Expr(ref expr) | StmtKind::Semi(ref expr) => {
+ StmtKind::Expr(expr) | StmtKind::Semi(expr) => {
self.search_slow_extend_filling(expr);
self.search_slow_resize_filling(expr);
},
@@ -306,7 +306,7 @@ impl<'a, 'tcx> Visitor<'tcx> for VectorInitializationVisitor<'a, 'tcx> {
fn visit_block(&mut self, block: &'tcx Block<'_>) {
if self.initialization_found {
- if let Some(ref s) = block.stmts.get(0) {
+ if let Some(s) = block.stmts.get(0) {
self.visit_stmt(s)
}
diff --git a/clippy_lints/src/strings.rs b/clippy_lints/src/strings.rs
index 99ca7ef77a5c..9d91b53e1bbc 100644
--- a/clippy_lints/src/strings.rs
+++ b/clippy_lints/src/strings.rs
@@ -119,7 +119,7 @@ impl<'tcx> LateLintPass<'tcx> for StringAdd {
Spanned {
node: BinOpKind::Add, ..
},
- ref left,
+ left,
_,
) = e.kind
{
@@ -127,7 +127,7 @@ impl<'tcx> LateLintPass<'tcx> for StringAdd {
if !is_allowed(cx, STRING_ADD_ASSIGN, e.hir_id) {
let parent = get_parent_expr(cx, e);
if let Some(p) = parent {
- if let ExprKind::Assign(ref target, _, _) = p.kind {
+ if let ExprKind::Assign(target, _, _) = p.kind {
// avoid duplicate matches
if SpanlessEq::new(cx).eq_expr(target, left) {
return;
@@ -142,7 +142,7 @@ impl<'tcx> LateLintPass<'tcx> for StringAdd {
"you added something to a string. Consider using `String::push_str()` instead",
);
}
- } else if let ExprKind::Assign(ref target, ref src, _) = e.kind {
+ } else if let ExprKind::Assign(target, src, _) = e.kind {
if is_string(cx, target) && is_add(cx, src, target) {
span_lint(
cx,
@@ -166,10 +166,10 @@ fn is_add(cx: &LateContext<'_>, src: &Expr<'_>, target: &Expr<'_>) -> bool {
Spanned {
node: BinOpKind::Add, ..
},
- ref left,
+ left,
_,
) => SpanlessEq::new(cx).eq_expr(target, left),
- ExprKind::Block(ref block, _) => {
+ ExprKind::Block(block, _) => {
block.stmts.is_empty() && block.expr.as_ref().map_or(false, |expr| is_add(cx, expr, target))
},
_ => false,
@@ -210,8 +210,8 @@ impl<'tcx> LateLintPass<'tcx> for StringLitAsBytes {
if let Some(args) = match_function_call(cx, e, &paths::STR_FROM_UTF8);
// Find string::as_bytes
- if let ExprKind::AddrOf(BorrowKind::Ref, _, ref args) = args[0].kind;
- if let ExprKind::Index(ref left, ref right) = args.kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, _, args) = args[0].kind;
+ if let ExprKind::Index(left, right) = args.kind;
let (method_names, expressions, _) = method_calls(left, 1);
if method_names.len() == 1;
if expressions.len() == 1;
diff --git a/clippy_lints/src/suspicious_operation_groupings.rs b/clippy_lints/src/suspicious_operation_groupings.rs
index 46f423204a21..cb2237e53126 100644
--- a/clippy_lints/src/suspicious_operation_groupings.rs
+++ b/clippy_lints/src/suspicious_operation_groupings.rs
@@ -225,7 +225,7 @@ fn attempt_to_emit_no_difference_lint(
emit_suggestion(
cx,
binop.span,
- replace_left_sugg(cx, &binop, &sugg, &mut applicability),
+ replace_left_sugg(cx, binop, &sugg, &mut applicability),
applicability,
);
return;
@@ -247,7 +247,7 @@ fn attempt_to_emit_no_difference_lint(
emit_suggestion(
cx,
binop.span,
- replace_right_sugg(cx, &binop, &sugg, &mut applicability),
+ replace_right_sugg(cx, binop, &sugg, &mut applicability),
applicability,
);
return;
@@ -276,8 +276,8 @@ fn ident_swap_sugg(
location: IdentLocation,
applicability: &mut Applicability,
) -> Option<String> {
- let left_ident = get_ident(&binop.left, location)?;
- let right_ident = get_ident(&binop.right, location)?;
+ let left_ident = get_ident(binop.left, location)?;
+ let right_ident = get_ident(binop.right, location)?;
let sugg = match (
paired_identifiers.contains(&left_ident),
@@ -293,8 +293,7 @@ fn ident_swap_sugg(
// ends up duplicating a clause, the `logic_bug` lint
// should catch it.
- let right_suggestion =
- suggestion_with_swapped_ident(cx, &binop.right, location, left_ident, applicability)?;
+ let right_suggestion = suggestion_with_swapped_ident(cx, binop.right, location, left_ident, applicability)?;
replace_right_sugg(cx, binop, &right_suggestion, applicability)
},
@@ -302,15 +301,14 @@ fn ident_swap_sugg(
// We haven't seen a pair involving the left one, so
// it's probably what is wanted.
- let right_suggestion =
- suggestion_with_swapped_ident(cx, &binop.right, location, left_ident, applicability)?;
+ let right_suggestion = suggestion_with_swapped_ident(cx, binop.right, location, left_ident, applicability)?;
replace_right_sugg(cx, binop, &right_suggestion, applicability)
},
(true, false) => {
// We haven't seen a pair involving the right one, so
// it's probably what is wanted.
- let left_suggestion = suggestion_with_swapped_ident(cx, &binop.left, location, right_ident, applicability)?;
+ let left_suggestion = suggestion_with_swapped_ident(cx, binop.left, location, right_ident, applicability)?;
replace_left_sugg(cx, binop, &left_suggestion, applicability)
},
diff --git a/clippy_lints/src/swap.rs b/clippy_lints/src/swap.rs
index 14519eaa962e..19967e2c9701 100644
--- a/clippy_lints/src/swap.rs
+++ b/clippy_lints/src/swap.rs
@@ -78,26 +78,26 @@ fn check_manual_swap(cx: &LateContext<'_>, block: &Block<'_>) {
for w in block.stmts.windows(3) {
if_chain! {
// let t = foo();
- if let StmtKind::Local(ref tmp) = w[0].kind;
- if let Some(ref tmp_init) = tmp.init;
+ if let StmtKind::Local(tmp) = w[0].kind;
+ if let Some(tmp_init) = tmp.init;
if let PatKind::Binding(.., ident, None) = tmp.pat.kind;
// foo() = bar();
- if let StmtKind::Semi(ref first) = w[1].kind;
- if let ExprKind::Assign(ref lhs1, ref rhs1, _) = first.kind;
+ if let StmtKind::Semi(first) = w[1].kind;
+ if let ExprKind::Assign(lhs1, rhs1, _) = first.kind;
// bar() = t;
- if let StmtKind::Semi(ref second) = w[2].kind;
- if let ExprKind::Assign(ref lhs2, ref rhs2, _) = second.kind;
- if let ExprKind::Path(QPath::Resolved(None, ref rhs2)) = rhs2.kind;
+ if let StmtKind::Semi(second) = w[2].kind;
+ if let ExprKind::Assign(lhs2, rhs2, _) = second.kind;
+ if let ExprKind::Path(QPath::Resolved(None, rhs2)) = rhs2.kind;
if rhs2.segments.len() == 1;
if ident.name == rhs2.segments[0].ident.name;
if eq_expr_value(cx, tmp_init, lhs1);
if eq_expr_value(cx, rhs1, lhs2);
then {
- if let ExprKind::Field(ref lhs1, _) = lhs1.kind {
- if let ExprKind::Field(ref lhs2, _) = lhs2.kind {
+ if let ExprKind::Field(lhs1, _) = lhs1.kind {
+ if let ExprKind::Field(lhs2, _) = lhs2.kind {
if lhs1.hir_id.owner == lhs2.hir_id.owner {
return;
}
@@ -192,8 +192,8 @@ enum Slice<'a> {
/// Checks if both expressions are index operations into "slice-like" types.
fn check_for_slice<'a>(cx: &LateContext<'_>, lhs1: &'a Expr<'_>, lhs2: &'a Expr<'_>) -> Slice<'a> {
- if let ExprKind::Index(ref lhs1, ref idx1) = lhs1.kind {
- if let ExprKind::Index(ref lhs2, ref idx2) = lhs2.kind {
+ if let ExprKind::Index(lhs1, idx1) = lhs1.kind {
+ if let ExprKind::Index(lhs2, idx2) = lhs2.kind {
if eq_expr_value(cx, lhs1, lhs2) {
let ty = cx.typeck_results().expr_ty(lhs1).peel_refs();
@@ -217,11 +217,11 @@ fn check_for_slice<'a>(cx: &LateContext<'_>, lhs1: &'a Expr<'_>, lhs2: &'a Expr<
fn check_suspicious_swap(cx: &LateContext<'_>, block: &Block<'_>) {
for w in block.stmts.windows(2) {
if_chain! {
- if let StmtKind::Semi(ref first) = w[0].kind;
- if let StmtKind::Semi(ref second) = w[1].kind;
+ if let StmtKind::Semi(first) = w[0].kind;
+ if let StmtKind::Semi(second) = w[1].kind;
if !differing_macro_contexts(first.span, second.span);
- if let ExprKind::Assign(ref lhs0, ref rhs0, _) = first.kind;
- if let ExprKind::Assign(ref lhs1, ref rhs1, _) = second.kind;
+ if let ExprKind::Assign(lhs0, rhs0, _) = first.kind;
+ if let ExprKind::Assign(lhs1, rhs1, _) = second.kind;
if eq_expr_value(cx, lhs0, rhs1);
if eq_expr_value(cx, lhs1, rhs0);
then {
diff --git a/clippy_lints/src/tabs_in_doc_comments.rs b/clippy_lints/src/tabs_in_doc_comments.rs
index 88bd2feaadda..a0492a88f912 100644
--- a/clippy_lints/src/tabs_in_doc_comments.rs
+++ b/clippy_lints/src/tabs_in_doc_comments.rs
@@ -86,7 +86,7 @@ impl TabsInDocComments {
impl EarlyLintPass for TabsInDocComments {
fn check_attribute(&mut self, cx: &EarlyContext<'_>, attribute: &ast::Attribute) {
- Self::warn_if_tabs_in_doc(cx, &attribute);
+ Self::warn_if_tabs_in_doc(cx, attribute);
}
}
diff --git a/clippy_lints/src/to_string_in_display.rs b/clippy_lints/src/to_string_in_display.rs
index 42ec14c31b5b..ae05a8da37bc 100644
--- a/clippy_lints/src/to_string_in_display.rs
+++ b/clippy_lints/src/to_string_in_display.rs
@@ -92,7 +92,7 @@ impl LateLintPass<'_> for ToStringInDisplay {
if_chain! {
if self.in_display_impl;
if let Some(self_hir_id) = self.self_hir_id;
- if let ExprKind::MethodCall(ref path, _, args, _) = expr.kind;
+ if let ExprKind::MethodCall(path, _, args, _) = expr.kind;
if path.ident.name == sym!(to_string);
if let Some(expr_def_id) = cx.typeck_results().type_dependent_def_id(expr.hir_id);
if is_diagnostic_assoc_item(cx, expr_def_id, sym::ToString);
diff --git a/clippy_lints/src/trait_bounds.rs b/clippy_lints/src/trait_bounds.rs
index 3ff27c3bcf49..b0589b0512ef 100644
--- a/clippy_lints/src/trait_bounds.rs
+++ b/clippy_lints/src/trait_bounds.rs
@@ -107,7 +107,7 @@ impl TraitBounds {
if let WherePredicate::BoundPredicate(ref p) = bound;
if p.bounds.len() as u64 <= self.max_trait_bounds;
if !in_macro(p.span);
- let h = hash(&p.bounded_ty);
+ let h = hash(p.bounded_ty);
if let Some(ref v) = map.insert(h, p.bounds.iter().collect::<Vec<_>>());
then {
@@ -170,7 +170,7 @@ fn check_trait_bound_duplication(cx: &LateContext<'_>, gen: &'_ Generics<'_>) {
if_chain! {
if let WherePredicate::BoundPredicate(ref bound_predicate) = predicate;
if !in_macro(bound_predicate.span);
- if let TyKind::Path(QPath::Resolved(_, Path { ref segments, .. })) = bound_predicate.bounded_ty.kind;
+ if let TyKind::Path(QPath::Resolved(_, Path { segments, .. })) = bound_predicate.bounded_ty.kind;
if let Some(segment) = segments.first();
if let Some(trait_resolutions_direct) = map.get(&segment.ident);
then {
diff --git a/clippy_lints/src/transmute/mod.rs b/clippy_lints/src/transmute/mod.rs
index 47d58bd30db5..86ac916df6cb 100644
--- a/clippy_lints/src/transmute/mod.rs
+++ b/clippy_lints/src/transmute/mod.rs
@@ -325,7 +325,7 @@ impl<'tcx> LateLintPass<'tcx> for Transmute {
#[allow(clippy::similar_names, clippy::too_many_lines)]
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
if_chain! {
- if let ExprKind::Call(ref path_expr, ref args) = e.kind;
+ if let ExprKind::Call(path_expr, args) = e.kind;
if let ExprKind::Path(ref qpath) = path_expr.kind;
if let Some(def_id) = cx.qpath_res(qpath, path_expr.hir_id).opt_def_id();
if match_def_path(cx, def_id, &paths::TRANSMUTE);
diff --git a/clippy_lints/src/transmute/transmute_float_to_int.rs b/clippy_lints/src/transmute/transmute_float_to_int.rs
index 1a6124e9ddb7..3aa3c393ba57 100644
--- a/clippy_lints/src/transmute/transmute_float_to_int.rs
+++ b/clippy_lints/src/transmute/transmute_float_to_int.rs
@@ -30,7 +30,7 @@ pub(super) fn check<'tcx>(
let mut arg = sugg::Sugg::hir(cx, expr, "..");
if let ExprKind::Unary(UnOp::Neg, inner_expr) = &expr.kind {
- expr = &inner_expr;
+ expr = inner_expr;
}
if_chain! {
diff --git a/clippy_lints/src/transmute/utils.rs b/clippy_lints/src/transmute/utils.rs
index c6d0d63b0b54..f359b606e454 100644
--- a/clippy_lints/src/transmute/utils.rs
+++ b/clippy_lints/src/transmute/utils.rs
@@ -16,7 +16,7 @@ use rustc_typeck::check::{cast::CastCheck, FnCtxt, Inherited};
pub(super) fn get_type_snippet(cx: &LateContext<'_>, path: &QPath<'_>, to_ref_ty: Ty<'_>) -> String {
let seg = last_path_segment(path);
if_chain! {
- if let Some(ref params) = seg.args;
+ if let Some(params) = seg.args;
if !params.parenthesized;
if let Some(to_ty) = params.args.iter().filter_map(|arg| match arg {
GenericArg::Type(ty) => Some(ty),
diff --git a/clippy_lints/src/transmuting_null.rs b/clippy_lints/src/transmuting_null.rs
index d42cdde110e7..0be05d3e0cf3 100644
--- a/clippy_lints/src/transmuting_null.rs
+++ b/clippy_lints/src/transmuting_null.rs
@@ -37,7 +37,7 @@ impl<'tcx> LateLintPass<'tcx> for TransmutingNull {
}
if_chain! {
- if let ExprKind::Call(ref func, ref args) = expr.kind;
+ if let ExprKind::Call(func, args) = expr.kind;
if let ExprKind::Path(ref path) = func.kind;
if match_qpath(path, &paths::STD_MEM_TRANSMUTE);
if args.len() == 1;
@@ -58,7 +58,7 @@ impl<'tcx> LateLintPass<'tcx> for TransmutingNull {
// Catching:
// `std::mem::transmute(0 as *const i32)`
if_chain! {
- if let ExprKind::Cast(ref inner_expr, ref _cast_ty) = args[0].kind;
+ if let ExprKind::Cast(inner_expr, _cast_ty) = args[0].kind;
if let ExprKind::Lit(ref lit) = inner_expr.kind;
if let LitKind::Int(0, _) = lit.node;
then {
@@ -69,7 +69,7 @@ impl<'tcx> LateLintPass<'tcx> for TransmutingNull {
// Catching:
// `std::mem::transmute(std::ptr::null::<i32>())`
if_chain! {
- if let ExprKind::Call(ref func1, ref args1) = args[0].kind;
+ if let ExprKind::Call(func1, args1) = args[0].kind;
if let ExprKind::Path(ref path1) = func1.kind;
if match_qpath(path1, &paths::STD_PTR_NULL);
if args1.is_empty();
diff --git a/clippy_lints/src/try_err.rs b/clippy_lints/src/try_err.rs
index e4799790d351..23a1953fface 100644
--- a/clippy_lints/src/try_err.rs
+++ b/clippy_lints/src/try_err.rs
@@ -60,13 +60,13 @@ impl<'tcx> LateLintPass<'tcx> for TryErr {
// };
if_chain! {
if !in_external_macro(cx.tcx.sess, expr.span);
- if let ExprKind::Match(ref match_arg, _, MatchSource::TryDesugar) = expr.kind;
- if let ExprKind::Call(ref match_fun, ref try_args) = match_arg.kind;
+ if let ExprKind::Match(match_arg, _, MatchSource::TryDesugar) = expr.kind;
+ if let ExprKind::Call(match_fun, try_args) = match_arg.kind;
if let ExprKind::Path(ref match_fun_path) = match_fun.kind;
if matches!(match_fun_path, QPath::LangItem(LangItem::TryIntoResult, _));
- if let Some(ref try_arg) = try_args.get(0);
- if let ExprKind::Call(ref err_fun, ref err_args) = try_arg.kind;
- if let Some(ref err_arg) = err_args.get(0);
+ if let Some(try_arg) = try_args.get(0);
+ if let ExprKind::Call(err_fun, err_args) = try_arg.kind;
+ if let Some(err_arg) = err_args.get(0);
if let ExprKind::Path(ref err_fun_path) = err_fun.kind;
if match_qpath(err_fun_path, &paths::RESULT_ERR);
if let Some(return_ty) = find_return_type(cx, &expr.kind);
@@ -123,9 +123,9 @@ impl<'tcx> LateLintPass<'tcx> for TryErr {
/// Finds function return type by examining return expressions in match arms.
fn find_return_type<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx ExprKind<'_>) -> Option<Ty<'tcx>> {
- if let ExprKind::Match(_, ref arms, MatchSource::TryDesugar) = expr {
+ if let ExprKind::Match(_, arms, MatchSource::TryDesugar) = expr {
for arm in arms.iter() {
- if let ExprKind::Ret(Some(ref ret)) = arm.body.kind {
+ if let ExprKind::Ret(Some(ret)) = arm.body.kind {
return Some(cx.typeck_results().expr_ty(ret));
}
}
diff --git a/clippy_lints/src/types/borrowed_box.rs b/clippy_lints/src/types/borrowed_box.rs
index d68c6db4e233..1425d8f3f37e 100644
--- a/clippy_lints/src/types/borrowed_box.rs
+++ b/clippy_lints/src/types/borrowed_box.rs
@@ -19,9 +19,9 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, lt: &Lifetime, m
if_chain! {
if let Some(def_id) = def.opt_def_id();
if Some(def_id) == cx.tcx.lang_items().owned_box();
- if let QPath::Resolved(None, ref path) = *qpath;
+ if let QPath::Resolved(None, path) = *qpath;
if let [ref bx] = *path.segments;
- if let Some(ref params) = bx.args;
+ if let Some(params) = bx.args;
if !params.parenthesized;
if let Some(inner) = params.args.iter().find_map(|arg| match arg {
GenericArg::Type(ty) => Some(ty),
@@ -86,11 +86,11 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, lt: &Lifetime, m
// Returns true if given type is `Any` trait.
fn is_any_trait(t: &hir::Ty<'_>) -> bool {
if_chain! {
- if let TyKind::TraitObject(ref traits, ..) = t.kind;
+ if let TyKind::TraitObject(traits, ..) = t.kind;
if !traits.is_empty();
// Only Send/Sync can be used as additional traits, so it is enough to
// check only the first trait.
- if match_path(&traits[0].trait_ref.path, &paths::ANY_TRAIT);
+ if match_path(traits[0].trait_ref.path, &paths::ANY_TRAIT);
then {
return true;
}
diff --git a/clippy_lints/src/types/mod.rs b/clippy_lints/src/types/mod.rs
index 12e1eba2ca66..d9b47a699dc3 100644
--- a/clippy_lints/src/types/mod.rs
+++ b/clippy_lints/src/types/mod.rs
@@ -278,9 +278,7 @@ impl<'tcx> LateLintPass<'tcx> for Types {
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'_>) {
match item.kind {
- ItemKind::Static(ref ty, _, _) | ItemKind::Const(ref ty, _) => {
- self.check_ty(cx, ty, CheckTyContext::default())
- },
+ ItemKind::Static(ty, _, _) | ItemKind::Const(ty, _) => self.check_ty(cx, ty, CheckTyContext::default()),
// functions, enums, structs, impls and traits are covered
_ => (),
}
@@ -288,7 +286,7 @@ impl<'tcx> LateLintPass<'tcx> for Types {
fn check_impl_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx ImplItem<'_>) {
match item.kind {
- ImplItemKind::Const(ref ty, _) | ImplItemKind::TyAlias(ref ty) => self.check_ty(
+ ImplItemKind::Const(ty, _) | ImplItemKind::TyAlias(ty) => self.check_ty(
cx,
ty,
CheckTyContext {
@@ -302,21 +300,21 @@ impl<'tcx> LateLintPass<'tcx> for Types {
}
fn check_field_def(&mut self, cx: &LateContext<'_>, field: &hir::FieldDef<'_>) {
- self.check_ty(cx, &field.ty, CheckTyContext::default());
+ self.check_ty(cx, field.ty, CheckTyContext::default());
}
fn check_trait_item(&mut self, cx: &LateContext<'_>, item: &TraitItem<'_>) {
match item.kind {
- TraitItemKind::Const(ref ty, _) | TraitItemKind::Type(_, Some(ref ty)) => {
+ TraitItemKind::Const(ty, _) | TraitItemKind::Type(_, Some(ty)) => {
self.check_ty(cx, ty, CheckTyContext::default())
},
- TraitItemKind::Fn(ref sig, _) => self.check_fn_decl(cx, &sig.decl, CheckTyContext::default()),
+ TraitItemKind::Fn(ref sig, _) => self.check_fn_decl(cx, sig.decl, CheckTyContext::default()),
TraitItemKind::Type(..) => (),
}
}
fn check_local(&mut self, cx: &LateContext<'_>, local: &Local<'_>) {
- if let Some(ref ty) = local.ty {
+ if let Some(ty) = local.ty {
self.check_ty(
cx,
ty,
@@ -342,7 +340,7 @@ impl Types {
self.check_ty(cx, input, context);
}
- if let FnRetTy::Return(ref ty) = decl.output {
+ if let FnRetTy::Return(ty) = decl.output {
self.check_ty(cx, ty, context);
}
}
@@ -383,7 +381,7 @@ impl Types {
}
}
match *qpath {
- QPath::Resolved(Some(ref ty), ref p) => {
+ QPath::Resolved(Some(ty), p) => {
context.is_nested_call = true;
self.check_ty(cx, ty, context);
for ty in p.segments.iter().flat_map(|seg| {
@@ -398,7 +396,7 @@ impl Types {
self.check_ty(cx, ty, context);
}
},
- QPath::Resolved(None, ref p) => {
+ QPath::Resolved(None, p) => {
context.is_nested_call = true;
for ty in p.segments.iter().flat_map(|seg| {
seg.args
@@ -412,10 +410,10 @@ impl Types {
self.check_ty(cx, ty, context);
}
},
- QPath::TypeRelative(ref ty, ref seg) => {
+ QPath::TypeRelative(ty, seg) => {
context.is_nested_call = true;
self.check_ty(cx, ty, context);
- if let Some(ref params) = seg.args {
+ if let Some(params) = seg.args {
for ty in params.args.iter().filter_map(|arg| match arg {
GenericArg::Type(ty) => Some(ty),
_ => None,
@@ -430,10 +428,10 @@ impl Types {
TyKind::Rptr(ref lt, ref mut_ty) => {
context.is_nested_call = true;
if !borrowed_box::check(cx, hir_ty, lt, mut_ty) {
- self.check_ty(cx, &mut_ty.ty, context);
+ self.check_ty(cx, mut_ty.ty, context);
}
},
- TyKind::Slice(ref ty) | TyKind::Array(ref ty, _) | TyKind::Ptr(MutTy { ref ty, .. }) => {
+ TyKind::Slice(ty) | TyKind::Array(ty, _) | TyKind::Ptr(MutTy { ty, .. }) => {
context.is_nested_call = true;
self.check_ty(cx, ty, context)
},
diff --git a/clippy_lints/src/types/type_complexity.rs b/clippy_lints/src/types/type_complexity.rs
index 9a4e9da3e2be..d8c4b67520d1 100644
--- a/clippy_lints/src/types/type_complexity.rs
+++ b/clippy_lints/src/types/type_complexity.rs
@@ -48,9 +48,9 @@ impl<'tcx> Visitor<'tcx> for TypeComplexityVisitor {
TyKind::Path(..) | TyKind::Slice(..) | TyKind::Tup(..) | TyKind::Array(..) => (10 * self.nest, 1),
// function types bring a lot of overhead
- TyKind::BareFn(ref bare) if bare.abi == Abi::Rust => (50 * self.nest, 1),
+ TyKind::BareFn(bare) if bare.abi == Abi::Rust => (50 * self.nest, 1),
- TyKind::TraitObject(ref param_bounds, _, _) => {
+ TyKind::TraitObject(param_bounds, _, _) => {
let has_lifetime_parameters = param_bounds.iter().any(|bound| {
bound
.bound_generic_params
diff --git a/clippy_lints/src/types/utils.rs b/clippy_lints/src/types/utils.rs
index 45f891ed7183..0fa75f8f0a9b 100644
--- a/clippy_lints/src/types/utils.rs
+++ b/clippy_lints/src/types/utils.rs
@@ -7,7 +7,7 @@ use rustc_span::source_map::Span;
pub(super) fn match_borrows_parameter(_cx: &LateContext<'_>, qpath: &QPath<'_>) -> Option<Span> {
let last = last_path_segment(qpath);
if_chain! {
- if let Some(ref params) = last.args;
+ if let Some(params) = last.args;
if !params.parenthesized;
if let Some(ty) = params.args.iter().find_map(|arg| match arg {
GenericArg::Type(ty) => Some(ty),
diff --git a/clippy_lints/src/types/vec_box.rs b/clippy_lints/src/types/vec_box.rs
index d2c373db261d..7a444174626f 100644
--- a/clippy_lints/src/types/vec_box.rs
+++ b/clippy_lints/src/types/vec_box.rs
@@ -22,7 +22,7 @@ pub(super) fn check(
if cx.tcx.is_diagnostic_item(sym::vec_type, def_id) {
if_chain! {
// Get the _ part of Vec<_>
- if let Some(ref last) = last_path_segment(qpath).args;
+ if let Some(last) = last_path_segment(qpath).args;
if let Some(ty) = last.args.iter().find_map(|arg| match arg {
GenericArg::Type(ty) => Some(ty),
_ => None,
@@ -33,7 +33,7 @@ pub(super) fn check(
if let Some(def_id) = res.opt_def_id();
if Some(def_id) == cx.tcx.lang_items().owned_box();
// At this point, we know ty is Box<T>, now get T
- if let Some(ref last) = last_path_segment(ty_qpath).args;
+ if let Some(last) = last_path_segment(ty_qpath).args;
if let Some(boxed_ty) = last.args.iter().find_map(|arg| match arg {
GenericArg::Type(ty) => Some(ty),
_ => None,
diff --git a/clippy_lints/src/undropped_manually_drops.rs b/clippy_lints/src/undropped_manually_drops.rs
index b6749069176b..f4f5e1233e35 100644
--- a/clippy_lints/src/undropped_manually_drops.rs
+++ b/clippy_lints/src/undropped_manually_drops.rs
@@ -35,7 +35,7 @@ declare_lint_pass!(UndroppedManuallyDrops => [UNDROPPED_MANUALLY_DROPS]);
impl LateLintPass<'tcx> for UndroppedManuallyDrops {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
- if let Some(ref args) = match_function_call(cx, expr, &paths::DROP) {
+ if let Some(args) = match_function_call(cx, expr, &paths::DROP) {
let ty = cx.typeck_results().expr_ty(&args[0]);
if is_type_lang_item(cx, ty, lang_items::LangItem::ManuallyDrop) {
span_lint_and_help(
diff --git a/clippy_lints/src/unit_return_expecting_ord.rs b/clippy_lints/src/unit_return_expecting_ord.rs
index cdc65abe47c3..47b95b18ffb7 100644
--- a/clippy_lints/src/unit_return_expecting_ord.rs
+++ b/clippy_lints/src/unit_return_expecting_ord.rs
@@ -138,7 +138,7 @@ fn check_arg<'tcx>(cx: &LateContext<'tcx>, arg: &'tcx Expr<'tcx>) -> Option<(Spa
impl<'tcx> LateLintPass<'tcx> for UnitReturnExpectingOrd {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) {
- if let ExprKind::MethodCall(_, _, ref args, _) = expr.kind {
+ if let ExprKind::MethodCall(_, _, args, _) = expr.kind {
let arg_indices = get_args_to_check(cx, expr);
for (i, trait_name) in arg_indices {
if i < args.len() {
diff --git a/clippy_lints/src/unit_types/let_unit_value.rs b/clippy_lints/src/unit_types/let_unit_value.rs
index 8698a718bbd8..fad647dfb266 100644
--- a/clippy_lints/src/unit_types/let_unit_value.rs
+++ b/clippy_lints/src/unit_types/let_unit_value.rs
@@ -9,8 +9,8 @@ use rustc_middle::lint::in_external_macro;
use super::LET_UNIT_VALUE;
pub(super) fn check(cx: &LateContext<'_>, stmt: &Stmt<'_>) {
- if let StmtKind::Local(ref local) = stmt.kind {
- if cx.typeck_results().pat_ty(&local.pat).is_unit() {
+ if let StmtKind::Local(local) = stmt.kind {
+ if cx.typeck_results().pat_ty(local.pat).is_unit() {
if in_external_macro(cx.sess(), stmt.span) || local.pat.span.from_expansion() {
return;
}
diff --git a/clippy_lints/src/unit_types/unit_arg.rs b/clippy_lints/src/unit_types/unit_arg.rs
index f77d811c2835..57be2d2f674c 100644
--- a/clippy_lints/src/unit_types/unit_arg.rs
+++ b/clippy_lints/src/unit_types/unit_arg.rs
@@ -54,7 +54,7 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>) {
fn is_questionmark_desugar_marked_call(expr: &Expr<'_>) -> bool {
use rustc_span::hygiene::DesugaringKind;
- if let ExprKind::Call(ref callee, _) = expr.kind {
+ if let ExprKind::Call(callee, _) = expr.kind {
callee.span.is_desugaring(DesugaringKind::QuestionMark)
} else {
false
diff --git a/clippy_lints/src/unit_types/unit_cmp.rs b/clippy_lints/src/unit_types/unit_cmp.rs
index b3077dec5d89..85257f3113cb 100644
--- a/clippy_lints/src/unit_types/unit_cmp.rs
+++ b/clippy_lints/src/unit_types/unit_cmp.rs
@@ -9,7 +9,7 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>) {
if expr.span.from_expansion() {
if let Some(callee) = expr.span.source_callee() {
if let ExpnKind::Macro(MacroKind::Bang, symbol) = callee.kind {
- if let ExprKind::Binary(ref cmp, ref left, _) = expr.kind {
+ if let ExprKind::Binary(ref cmp, left, _) = expr.kind {
let op = cmp.node;
if op.is_comparison() && cx.typeck_results().expr_ty(left).is_unit() {
let result = match &*symbol.as_str() {
@@ -34,7 +34,7 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>) {
return;
}
- if let ExprKind::Binary(ref cmp, ref left, _) = expr.kind {
+ if let ExprKind::Binary(ref cmp, left, _) = expr.kind {
let op = cmp.node;
if op.is_comparison() && cx.typeck_results().expr_ty(left).is_unit() {
let result = match op {
diff --git a/clippy_lints/src/unit_types/utils.rs b/clippy_lints/src/unit_types/utils.rs
index 4e194a05e8de..9a3750b2356b 100644
--- a/clippy_lints/src/unit_types/utils.rs
+++ b/clippy_lints/src/unit_types/utils.rs
@@ -1,5 +1,5 @@
use rustc_hir::{Expr, ExprKind};
pub(super) fn is_unit_literal(expr: &Expr<'_>) -> bool {
- matches!(expr.kind, ExprKind::Tup(ref slice) if slice.is_empty())
+ matches!(expr.kind, ExprKind::Tup(slice) if slice.is_empty())
}
diff --git a/clippy_lints/src/unnamed_address.rs b/clippy_lints/src/unnamed_address.rs
index 9ceb2c3ffe25..9cca05b1f1a6 100644
--- a/clippy_lints/src/unnamed_address.rs
+++ b/clippy_lints/src/unnamed_address.rs
@@ -77,7 +77,7 @@ impl LateLintPass<'_> for UnnamedAddress {
}
if_chain! {
- if let ExprKind::Binary(binop, ref left, ref right) = expr.kind;
+ if let ExprKind::Binary(binop, left, right) = expr.kind;
if is_comparison(binop.node);
if is_trait_ptr(cx, left) && is_trait_ptr(cx, right);
then {
@@ -93,7 +93,7 @@ impl LateLintPass<'_> for UnnamedAddress {
}
if_chain! {
- if let ExprKind::Call(ref func, [ref _left, ref _right]) = expr.kind;
+ if let ExprKind::Call(func, [ref _left, ref _right]) = expr.kind;
if let ExprKind::Path(ref func_qpath) = func.kind;
if let Some(def_id) = cx.qpath_res(func_qpath, func.hir_id).opt_def_id();
if match_def_path(cx, def_id, &paths::PTR_EQ) ||
@@ -114,7 +114,7 @@ impl LateLintPass<'_> for UnnamedAddress {
}
if_chain! {
- if let ExprKind::Binary(binop, ref left, ref right) = expr.kind;
+ if let ExprKind::Binary(binop, left, right) = expr.kind;
if is_comparison(binop.node);
if cx.typeck_results().expr_ty_adjusted(left).is_fn_ptr();
if cx.typeck_results().expr_ty_adjusted(right).is_fn_ptr();
diff --git a/clippy_lints/src/unnecessary_sort_by.rs b/clippy_lints/src/unnecessary_sort_by.rs
index e23bab5eba03..03711eb5b65e 100644
--- a/clippy_lints/src/unnecessary_sort_by.rs
+++ b/clippy_lints/src/unnecessary_sort_by.rs
@@ -187,15 +187,15 @@ fn detect_lint(cx: &LateContext<'_>, expr: &Expr<'_>) -> Option<LintTrigger> {
if method_path.ident.name == sym::cmp;
then {
let (closure_body, closure_arg, reverse) = if mirrored_exprs(
- &cx,
- &left_expr,
- &left_ident,
- &right_expr,
- &right_ident
+ cx,
+ left_expr,
+ left_ident,
+ right_expr,
+ right_ident
) {
- (Sugg::hir(cx, &left_expr, "..").to_string(), left_ident.name.to_string(), false)
- } else if mirrored_exprs(&cx, &left_expr, &right_ident, &right_expr, &left_ident) {
- (Sugg::hir(cx, &left_expr, "..").to_string(), right_ident.name.to_string(), true)
+ (Sugg::hir(cx, left_expr, "..").to_string(), left_ident.name.to_string(), false)
+ } else if mirrored_exprs(cx, left_expr, right_ident, right_expr, left_ident) {
+ (Sugg::hir(cx, left_expr, "..").to_string(), right_ident.name.to_string(), true)
} else {
return None;
};
diff --git a/clippy_lints/src/unnecessary_wraps.rs b/clippy_lints/src/unnecessary_wraps.rs
index c2be457e9dcf..5bb417cb1be4 100644
--- a/clippy_lints/src/unnecessary_wraps.rs
+++ b/clippy_lints/src/unnecessary_wraps.rs
@@ -103,7 +103,7 @@ impl<'tcx> LateLintPass<'tcx> for UnnecessaryWraps {
if_chain! {
if !in_macro(ret_expr.span);
// Check if a function call.
- if let ExprKind::Call(ref func, ref args) = ret_expr.kind;
+ if let ExprKind::Call(func, args) = ret_expr.kind;
// Get the Path of the function call.
if let ExprKind::Path(ref qpath) = func.kind;
// Check if OPTION_SOME or RESULT_OK, depending on return type.
diff --git a/clippy_lints/src/unused_io_amount.rs b/clippy_lints/src/unused_io_amount.rs
index 9990052e114b..024ab03fd418 100644
--- a/clippy_lints/src/unused_io_amount.rs
+++ b/clippy_lints/src/unused_io_amount.rs
@@ -36,13 +36,13 @@ declare_lint_pass!(UnusedIoAmount => [UNUSED_IO_AMOUNT]);
impl<'tcx> LateLintPass<'tcx> for UnusedIoAmount {
fn check_stmt(&mut self, cx: &LateContext<'_>, s: &hir::Stmt<'_>) {
let expr = match s.kind {
- hir::StmtKind::Semi(ref expr) | hir::StmtKind::Expr(ref expr) => &**expr,
+ hir::StmtKind::Semi(expr) | hir::StmtKind::Expr(expr) => expr,
_ => return,
};
match expr.kind {
- hir::ExprKind::Match(ref res, _, _) if is_try(expr).is_some() => {
- if let hir::ExprKind::Call(ref func, ref args) = res.kind {
+ hir::ExprKind::Match(res, _, _) if is_try(expr).is_some() => {
+ if let hir::ExprKind::Call(func, args) = res.kind {
if matches!(
func.kind,
hir::ExprKind::Path(hir::QPath::LangItem(hir::LangItem::TryIntoResult, _))
@@ -54,7 +54,7 @@ impl<'tcx> LateLintPass<'tcx> for UnusedIoAmount {
}
},
- hir::ExprKind::MethodCall(ref path, _, ref args, _) => match &*path.ident.as_str() {
+ hir::ExprKind::MethodCall(path, _, args, _) => match &*path.ident.as_str() {
"expect" | "unwrap" | "unwrap_or" | "unwrap_or_else" => {
check_method_call(cx, &args[0], expr);
},
@@ -67,7 +67,7 @@ impl<'tcx> LateLintPass<'tcx> for UnusedIoAmount {
}
fn check_method_call(cx: &LateContext<'_>, call: &hir::Expr<'_>, expr: &hir::Expr<'_>) {
- if let hir::ExprKind::MethodCall(ref path, _, _, _) = call.kind {
+ if let hir::ExprKind::MethodCall(path, _, _, _) = call.kind {
let symbol = &*path.ident.as_str();
let read_trait = match_trait_method(cx, call, &paths::IO_READ);
let write_trait = match_trait_method(cx, call, &paths::IO_WRITE);
diff --git a/clippy_lints/src/unused_unit.rs b/clippy_lints/src/unused_unit.rs
index 329ea49024bc..ce2d0b3ab2f2 100644
--- a/clippy_lints/src/unused_unit.rs
+++ b/clippy_lints/src/unused_unit.rs
@@ -45,7 +45,7 @@ impl EarlyLintPass for UnusedUnit {
fn check_block(&mut self, cx: &EarlyContext<'_>, block: &ast::Block) {
if_chain! {
- if let Some(ref stmt) = block.stmts.last();
+ if let Some(stmt) = block.stmts.last();
if let ast::StmtKind::Expr(ref expr) = stmt.kind;
if is_unit_expr(expr) && !stmt.span.from_expansion();
then {
diff --git a/clippy_lints/src/unwrap.rs b/clippy_lints/src/unwrap.rs
index fb29acca18a9..d4efee56efff 100644
--- a/clippy_lints/src/unwrap.rs
+++ b/clippy_lints/src/unwrap.rs
@@ -166,8 +166,8 @@ impl<'a, 'tcx> Visitor<'tcx> for UnwrappableVariablesVisitor<'a, 'tcx> {
} else {
// find `unwrap[_err]()` calls:
if_chain! {
- if let ExprKind::MethodCall(ref method_name, _, ref args, _) = expr.kind;
- if let ExprKind::Path(QPath::Resolved(None, ref path)) = args[0].kind;
+ if let ExprKind::MethodCall(method_name, _, args, _) = expr.kind;
+ if let ExprKind::Path(QPath::Resolved(None, path)) = args[0].kind;
if [sym::unwrap, sym!(unwrap_err)].contains(&method_name.ident.name);
let call_to_unwrap = method_name.ident.name == sym::unwrap;
if let Some(unwrappable) = self.unwrappables.iter()
diff --git a/clippy_lints/src/use_self.rs b/clippy_lints/src/use_self.rs
index 116cb8b1e1c7..c6a3c58a9a2a 100644
--- a/clippy_lints/src/use_self.rs
+++ b/clippy_lints/src/use_self.rs
@@ -104,7 +104,7 @@ impl<'tcx> LateLintPass<'tcx> for UseSelf {
of_trait,
..
}) => {
- let should_check = if let TyKind::Path(QPath::Resolved(_, ref item_path)) = hir_self_ty.kind {
+ let should_check = if let TyKind::Path(QPath::Resolved(_, item_path)) = hir_self_ty.kind {
let parameters = &item_path.segments.last().expect(SEGMENTS_MSG).args;
parameters.as_ref().map_or(true, |params| {
!params.parenthesized && !params.args.iter().any(|arg| matches!(arg, GenericArg::Lifetime(_)))
@@ -197,7 +197,7 @@ impl<'tcx> LateLintPass<'tcx> for UseSelf {
for (impl_hir_ty, trait_sem_ty) in impl_inputs_outputs.zip(trait_method_sig.inputs_and_output) {
if trait_sem_ty.walk().any(|inner| inner == self_ty.into()) {
let mut visitor = SkipTyCollector::default();
- visitor.visit_ty(&impl_hir_ty);
+ visitor.visit_ty(impl_hir_ty);
types_to_skip.extend(visitor.types_to_skip);
}
}
@@ -333,7 +333,7 @@ impl<'tcx> LateLintPass<'tcx> for UseSelf {
// unit enum variants (`Enum::A`)
ExprKind::Path(qpath) => {
if expr_ty_matches(cx, expr, self_ty) {
- span_lint_on_qpath_resolved(cx, &qpath, true);
+ span_lint_on_qpath_resolved(cx, qpath, true);
}
},
_ => (),
diff --git a/clippy_lints/src/useless_conversion.rs b/clippy_lints/src/useless_conversion.rs
index d893b271a206..7edb280be73e 100644
--- a/clippy_lints/src/useless_conversion.rs
+++ b/clippy_lints/src/useless_conversion.rs
@@ -53,17 +53,17 @@ impl<'tcx> LateLintPass<'tcx> for UselessConversion {
}
match e.kind {
- ExprKind::Match(_, ref arms, MatchSource::TryDesugar) => {
+ ExprKind::Match(_, arms, MatchSource::TryDesugar) => {
let e = match arms[0].body.kind {
- ExprKind::Ret(Some(ref e)) | ExprKind::Break(_, Some(ref e)) => e,
+ ExprKind::Ret(Some(e)) | ExprKind::Break(_, Some(e)) => e,
_ => return,
};
- if let ExprKind::Call(_, ref args) = e.kind {
+ if let ExprKind::Call(_, args) = e.kind {
self.try_desugar_arm.push(args[0].hir_id);
}
},
- ExprKind::MethodCall(ref name, .., ref args, _) => {
+ ExprKind::MethodCall(name, .., args, _) => {
if match_trait_method(cx, e, &paths::INTO) && &*name.ident.as_str() == "into" {
let a = cx.typeck_results().expr_ty(e);
let b = cx.typeck_results().expr_ty(&args[0]);
@@ -82,7 +82,7 @@ impl<'tcx> LateLintPass<'tcx> for UselessConversion {
}
if match_trait_method(cx, e, &paths::INTO_ITERATOR) && name.ident.name == sym::into_iter {
if let Some(parent_expr) = get_parent_expr(cx, e) {
- if let ExprKind::MethodCall(ref parent_name, ..) = parent_expr.kind {
+ if let ExprKind::MethodCall(parent_name, ..) = parent_expr.kind {
if parent_name.ident.name != sym::into_iter {
return;
}
@@ -124,7 +124,7 @@ impl<'tcx> LateLintPass<'tcx> for UselessConversion {
}
},
- ExprKind::Call(ref path, ref args) => {
+ ExprKind::Call(path, args) => {
if_chain! {
if args.len() == 1;
if let ExprKind::Path(ref qpath) = path.kind;
diff --git a/clippy_lints/src/utils/author.rs b/clippy_lints/src/utils/author.rs
index a92c987014f1..e70f8a09ebef 100644
--- a/clippy_lints/src/utils/author.rs
+++ b/clippy_lints/src/utils/author.rs
@@ -203,13 +203,13 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
print!(" if let ExprKind::");
let current = format!("{}.kind", self.current);
match expr.kind {
- ExprKind::Box(ref inner) => {
+ ExprKind::Box(inner) => {
let inner_pat = self.next("inner");
println!("Box(ref {}) = {};", inner_pat, current);
self.current = inner_pat;
self.visit_expr(inner);
},
- ExprKind::Array(ref elements) => {
+ ExprKind::Array(elements) => {
let elements_pat = self.next("elements");
println!("Array(ref {}) = {};", elements_pat, current);
println!(" if {}.len() == {};", elements_pat, elements.len());
@@ -218,7 +218,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.visit_expr(element);
}
},
- ExprKind::Call(ref func, ref args) => {
+ ExprKind::Call(func, args) => {
let func_pat = self.next("func");
let args_pat = self.next("args");
println!("Call(ref {}, ref {}) = {};", func_pat, args_pat, current);
@@ -230,14 +230,14 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.visit_expr(arg);
}
},
- ExprKind::MethodCall(ref _method_name, ref _generics, ref _args, ref _fn_span) => {
+ ExprKind::MethodCall(_method_name, ref _generics, _args, ref _fn_span) => {
println!(
"MethodCall(ref method_name, ref generics, ref args, ref fn_span) = {};",
current
);
println!(" // unimplemented: `ExprKind::MethodCall` is not further destructured at the moment");
},
- ExprKind::Tup(ref elements) => {
+ ExprKind::Tup(elements) => {
let elements_pat = self.next("elements");
println!("Tup(ref {}) = {};", elements_pat, current);
println!(" if {}.len() == {};", elements_pat, elements.len());
@@ -246,7 +246,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.visit_expr(element);
}
},
- ExprKind::Binary(ref op, ref left, ref right) => {
+ ExprKind::Binary(ref op, left, right) => {
let op_pat = self.next("op");
let left_pat = self.next("left");
let right_pat = self.next("right");
@@ -260,7 +260,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = right_pat;
self.visit_expr(right);
},
- ExprKind::Unary(ref op, ref inner) => {
+ ExprKind::Unary(ref op, inner) => {
let inner_pat = self.next("inner");
println!("Unary(UnOp::{:?}, ref {}) = {};", op, inner_pat, current);
self.current = inner_pat;
@@ -296,7 +296,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
},
}
},
- ExprKind::Cast(ref expr, ref ty) => {
+ ExprKind::Cast(expr, ty) => {
let cast_pat = self.next("expr");
let cast_ty = self.next("cast_ty");
let qp_label = self.next("qp");
@@ -310,13 +310,13 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = cast_pat;
self.visit_expr(expr);
},
- ExprKind::Type(ref expr, ref _ty) => {
+ ExprKind::Type(expr, _ty) => {
let cast_pat = self.next("expr");
println!("Type(ref {}, _) = {};", cast_pat, current);
self.current = cast_pat;
self.visit_expr(expr);
},
- ExprKind::Loop(ref body, _, desugaring, _) => {
+ ExprKind::Loop(body, _, desugaring, _) => {
let body_pat = self.next("body");
let des = loop_desugaring_name(desugaring);
let label_pat = self.next("label");
@@ -324,10 +324,10 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = body_pat;
self.visit_block(body);
},
- ExprKind::If(ref cond, ref then, ref opt_else) => {
+ ExprKind::If(cond, then, ref opt_else) => {
let cond_pat = self.next("cond");
let then_pat = self.next("then");
- if let Some(ref else_) = *opt_else {
+ if let Some(else_) = *opt_else {
let else_pat = self.next("else_");
println!(
"If(ref {}, ref {}, Some(ref {})) = {};",
@@ -343,7 +343,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = then_pat;
self.visit_expr(then);
},
- ExprKind::Match(ref expr, ref arms, desugaring) => {
+ ExprKind::Match(expr, arms, desugaring) => {
let des = desugaring_name(desugaring);
let expr_pat = self.next("expr");
let arms_pat = self.next("arms");
@@ -353,18 +353,18 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
println!(" if {}.len() == {};", arms_pat, arms.len());
for (i, arm) in arms.iter().enumerate() {
self.current = format!("{}[{}].body", arms_pat, i);
- self.visit_expr(&arm.body);
+ self.visit_expr(arm.body);
if let Some(ref guard) = arm.guard {
let guard_pat = self.next("guard");
println!(" if let Some(ref {}) = {}[{}].guard;", guard_pat, arms_pat, i);
match guard {
- hir::Guard::If(ref if_expr) => {
+ hir::Guard::If(if_expr) => {
let if_expr_pat = self.next("expr");
println!(" if let Guard::If(ref {}) = {};", if_expr_pat, guard_pat);
self.current = if_expr_pat;
self.visit_expr(if_expr);
},
- hir::Guard::IfLet(ref if_let_pat, ref if_let_expr) => {
+ hir::Guard::IfLet(if_let_pat, if_let_expr) => {
let if_let_pat_pat = self.next("pat");
let if_let_expr_pat = self.next("expr");
println!(
@@ -379,26 +379,26 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
}
}
self.current = format!("{}[{}].pat", arms_pat, i);
- self.visit_pat(&arm.pat);
+ self.visit_pat(arm.pat);
}
},
- ExprKind::Closure(ref _capture_clause, ref _func, _, _, _) => {
+ ExprKind::Closure(ref _capture_clause, _func, _, _, _) => {
println!("Closure(ref capture_clause, ref func, _, _, _) = {};", current);
println!(" // unimplemented: `ExprKind::Closure` is not further destructured at the moment");
},
- ExprKind::Yield(ref sub, _) => {
+ ExprKind::Yield(sub, _) => {
let sub_pat = self.next("sub");
println!("Yield(ref sub) = {};", current);
self.current = sub_pat;
self.visit_expr(sub);
},
- ExprKind::Block(ref block, _) => {
+ ExprKind::Block(block, _) => {
let block_pat = self.next("block");
println!("Block(ref {}) = {};", block_pat, current);
self.current = block_pat;
self.visit_block(block);
},
- ExprKind::Assign(ref target, ref value, _) => {
+ ExprKind::Assign(target, value, _) => {
let target_pat = self.next("target");
let value_pat = self.next("value");
println!(
@@ -410,7 +410,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = value_pat;
self.visit_expr(value);
},
- ExprKind::AssignOp(ref op, ref target, ref value) => {
+ ExprKind::AssignOp(ref op, target, value) => {
let op_pat = self.next("op");
let target_pat = self.next("target");
let value_pat = self.next("value");
@@ -424,7 +424,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = value_pat;
self.visit_expr(value);
},
- ExprKind::Field(ref object, ref field_ident) => {
+ ExprKind::Field(object, ref field_ident) => {
let obj_pat = self.next("object");
let field_name_pat = self.next("field_name");
println!("Field(ref {}, ref {}) = {};", obj_pat, field_name_pat, current);
@@ -432,7 +432,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = obj_pat;
self.visit_expr(object);
},
- ExprKind::Index(ref object, ref index) => {
+ ExprKind::Index(object, index) => {
let object_pat = self.next("object");
let index_pat = self.next("index");
println!("Index(ref {}, ref {}) = {};", object_pat, index_pat, current);
@@ -447,7 +447,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = path_pat;
self.print_qpath(path);
},
- ExprKind::AddrOf(kind, mutability, ref inner) => {
+ ExprKind::AddrOf(kind, mutability, inner) => {
let inner_pat = self.next("inner");
println!(
"AddrOf(BorrowKind::{:?}, Mutability::{:?}, ref {}) = {};",
@@ -458,7 +458,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
},
ExprKind::Break(ref _destination, ref opt_value) => {
let destination_pat = self.next("destination");
- if let Some(ref value) = *opt_value {
+ if let Some(value) = *opt_value {
let value_pat = self.next("value");
println!("Break(ref {}, Some(ref {})) = {};", destination_pat, value_pat, current);
self.current = value_pat;
@@ -474,7 +474,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
// FIXME: implement label printing
},
ExprKind::Ret(ref opt_value) => {
- if let Some(ref value) = *opt_value {
+ if let Some(value) = *opt_value {
let value_pat = self.next("value");
println!("Ret(Some(ref {})) = {};", value_pat, current);
self.current = value_pat;
@@ -491,10 +491,10 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
println!("LlvmInlineAsm(_) = {};", current);
println!(" // unimplemented: `ExprKind::LlvmInlineAsm` is not further destructured at the moment");
},
- ExprKind::Struct(ref path, ref fields, ref opt_base) => {
+ ExprKind::Struct(path, fields, ref opt_base) => {
let path_pat = self.next("path");
let fields_pat = self.next("fields");
- if let Some(ref base) = *opt_base {
+ if let Some(base) = *opt_base {
let base_pat = self.next("base");
println!(
"Struct(ref {}, ref {}, Some(ref {})) = {};",
@@ -516,7 +516,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = value_pat;
},
// FIXME: compute length (needs type info)
- ExprKind::Repeat(ref value, _) => {
+ ExprKind::Repeat(value, _) => {
let value_pat = self.next("value");
println!("Repeat(ref {}, _) = {};", value_pat, current);
println!("// unimplemented: repeat count check");
@@ -526,7 +526,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
ExprKind::Err => {
println!("Err = {}", current);
},
- ExprKind::DropTemps(ref expr) => {
+ ExprKind::DropTemps(expr) => {
let expr_pat = self.next("expr");
println!("DropTemps(ref {}) = {};", expr_pat, current);
self.current = expr_pat;
@@ -560,7 +560,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
BindingAnnotation::RefMut => "BindingAnnotation::RefMut",
};
let name_pat = self.next("name");
- if let Some(ref sub) = *sub {
+ if let Some(sub) = *sub {
let sub_pat = self.next("sub");
println!(
"Binding({}, _, {}, Some(ref {})) = {};",
@@ -573,7 +573,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
}
println!(" if {}.as_str() == \"{}\";", name_pat, ident.as_str());
},
- PatKind::Struct(ref path, ref fields, ignore) => {
+ PatKind::Struct(ref path, fields, ignore) => {
let path_pat = self.next("path");
let fields_pat = self.next("fields");
println!(
@@ -585,13 +585,13 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
println!(" if {}.len() == {};", fields_pat, fields.len());
println!(" // unimplemented: field checks");
},
- PatKind::Or(ref fields) => {
+ PatKind::Or(fields) => {
let fields_pat = self.next("fields");
println!("Or(ref {}) = {};", fields_pat, current);
println!(" if {}.len() == {};", fields_pat, fields.len());
println!(" // unimplemented: field checks");
},
- PatKind::TupleStruct(ref path, ref fields, skip_pos) => {
+ PatKind::TupleStruct(ref path, fields, skip_pos) => {
let path_pat = self.next("path");
let fields_pat = self.next("fields");
println!(
@@ -609,25 +609,25 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = path_pat;
self.print_qpath(path);
},
- PatKind::Tuple(ref fields, skip_pos) => {
+ PatKind::Tuple(fields, skip_pos) => {
let fields_pat = self.next("fields");
println!("Tuple(ref {}, {:?}) = {};", fields_pat, skip_pos, current);
println!(" if {}.len() == {};", fields_pat, fields.len());
println!(" // unimplemented: field checks");
},
- PatKind::Box(ref pat) => {
+ PatKind::Box(pat) => {
let pat_pat = self.next("pat");
println!("Box(ref {}) = {};", pat_pat, current);
self.current = pat_pat;
self.visit_pat(pat);
},
- PatKind::Ref(ref pat, muta) => {
+ PatKind::Ref(pat, muta) => {
let pat_pat = self.next("pat");
println!("Ref(ref {}, Mutability::{:?}) = {};", pat_pat, muta, current);
self.current = pat_pat;
self.visit_pat(pat);
},
- PatKind::Lit(ref lit_expr) => {
+ PatKind::Lit(lit_expr) => {
let lit_expr_pat = self.next("lit_expr");
println!("Lit(ref {}) = {}", lit_expr_pat, current);
self.current = lit_expr_pat;
@@ -645,10 +645,10 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = end_pat;
walk_list!(self, visit_expr, end);
},
- PatKind::Slice(ref start, ref middle, ref end) => {
+ PatKind::Slice(start, ref middle, end) => {
let start_pat = self.next("start");
let end_pat = self.next("end");
- if let Some(ref middle) = middle {
+ if let Some(middle) = middle {
let middle_pat = self.next("middle");
println!(
"Slice(ref {}, Some(ref {}), ref {}) = {};",
@@ -678,17 +678,17 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
let current = format!("{}.kind", self.current);
match s.kind {
// A local (let) binding:
- StmtKind::Local(ref local) => {
+ StmtKind::Local(local) => {
let local_pat = self.next("local");
println!("Local(ref {}) = {};", local_pat, current);
- if let Some(ref init) = local.init {
+ if let Some(init) = local.init {
let init_pat = self.next("init");
println!(" if let Some(ref {}) = {}.init;", init_pat, local_pat);
self.current = init_pat;
self.visit_expr(init);
}
self.current = format!("{}.pat", local_pat);
- self.visit_pat(&local.pat);
+ self.visit_pat(local.pat);
},
// An item binding:
StmtKind::Item(_) => {
@@ -696,7 +696,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
},
// Expr without trailing semi-colon (must have unit type):
- StmtKind::Expr(ref e) => {
+ StmtKind::Expr(e) => {
let e_pat = self.next("e");
println!("Expr(ref {}, _) = {}", e_pat, current);
self.current = e_pat;
@@ -704,7 +704,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
},
// Expr with trailing semi-colon (may have any type):
- StmtKind::Semi(ref e) => {
+ StmtKind::Semi(e) => {
let e_pat = self.next("e");
println!("Semi(ref {}, _) = {}", e_pat, current);
self.current = e_pat;
@@ -752,7 +752,7 @@ fn loop_desugaring_name(des: hir::LoopSource) -> &'static str {
fn print_path(path: &QPath<'_>, first: &mut bool) {
match *path {
- QPath::Resolved(_, ref path) => {
+ QPath::Resolved(_, path) => {
for segment in path.segments {
if *first {
*first = false;
@@ -762,7 +762,7 @@ fn print_path(path: &QPath<'_>, first: &mut bool) {
print!("{:?}", segment.ident.as_str());
}
},
- QPath::TypeRelative(ref ty, ref segment) => match ty.kind {
+ QPath::TypeRelative(ty, segment) => match ty.kind {
hir::TyKind::Path(ref inner_path) => {
print_path(inner_path, first);
if *first {
diff --git a/clippy_lints/src/utils/inspector.rs b/clippy_lints/src/utils/inspector.rs
index 6fd3c9d7dec2..32d34e8d31ea 100644
--- a/clippy_lints/src/utils/inspector.rs
+++ b/clippy_lints/src/utils/inspector.rs
@@ -47,7 +47,7 @@ impl<'tcx> LateLintPass<'tcx> for DeepCodeInspector {
match item.vis.node {
hir::VisibilityKind::Public => println!("public"),
hir::VisibilityKind::Crate(_) => println!("visible crate wide"),
- hir::VisibilityKind::Restricted { ref path, .. } => println!(
+ hir::VisibilityKind::Restricted { path, .. } => println!(
"visible in module `{}`",
rustc_hir_pretty::to_string(rustc_hir_pretty::NO_ANN, |s| s.print_path(path, false))
),
@@ -99,13 +99,13 @@ impl<'tcx> LateLintPass<'tcx> for DeepCodeInspector {
if !has_attr(cx.sess(), cx.tcx.hir().attrs(arm.hir_id)) {
return;
}
- print_pat(cx, &arm.pat, 1);
+ print_pat(cx, arm.pat, 1);
if let Some(ref guard) = arm.guard {
println!("guard:");
print_guard(cx, guard, 1);
}
println!("body:");
- print_expr(cx, &arm.body, 1);
+ print_expr(cx, arm.body, 1);
}
fn check_stmt(&mut self, cx: &LateContext<'tcx>, stmt: &'tcx hir::Stmt<'_>) {
@@ -113,17 +113,17 @@ impl<'tcx> LateLintPass<'tcx> for DeepCodeInspector {
return;
}
match stmt.kind {
- hir::StmtKind::Local(ref local) => {
+ hir::StmtKind::Local(local) => {
println!("local variable of type {}", cx.typeck_results().node_type(local.hir_id));
println!("pattern:");
- print_pat(cx, &local.pat, 0);
- if let Some(ref e) = local.init {
+ print_pat(cx, local.pat, 0);
+ if let Some(e) = local.init {
println!("init expression:");
print_expr(cx, e, 0);
}
},
hir::StmtKind::Item(_) => println!("item decl"),
- hir::StmtKind::Expr(ref e) | hir::StmtKind::Semi(ref e) => print_expr(cx, e, 0),
+ hir::StmtKind::Expr(e) | hir::StmtKind::Semi(e) => print_expr(cx, e, 0),
}
}
// fn check_foreign_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx
@@ -151,7 +151,7 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
cx.typeck_results().adjustments().get(expr.hir_id)
);
match expr.kind {
- hir::ExprKind::Box(ref e) => {
+ hir::ExprKind::Box(e) => {
println!("{}Box", ind);
print_expr(cx, e, indent + 1);
},
@@ -161,7 +161,7 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
print_expr(cx, e, indent + 1);
}
},
- hir::ExprKind::Call(ref func, args) => {
+ hir::ExprKind::Call(func, args) => {
println!("{}Call", ind);
println!("{}function:", ind);
print_expr(cx, func, indent + 1);
@@ -170,7 +170,7 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
print_expr(cx, arg, indent + 1);
}
},
- hir::ExprKind::MethodCall(ref path, _, args, _) => {
+ hir::ExprKind::MethodCall(path, _, args, _) => {
println!("{}MethodCall", ind);
println!("{}method name: {}", ind, path.ident.name);
for arg in args {
@@ -183,7 +183,7 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
print_expr(cx, e, indent + 1);
}
},
- hir::ExprKind::Binary(op, ref lhs, ref rhs) => {
+ hir::ExprKind::Binary(op, lhs, rhs) => {
println!("{}Binary", ind);
println!("{}op: {:?}", ind, op.node);
println!("{}lhs:", ind);
@@ -191,7 +191,7 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
println!("{}rhs:", ind);
print_expr(cx, rhs, indent + 1);
},
- hir::ExprKind::Unary(op, ref inner) => {
+ hir::ExprKind::Unary(op, inner) => {
println!("{}Unary", ind);
println!("{}op: {:?}", ind, op);
print_expr(cx, inner, indent + 1);
@@ -200,12 +200,12 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
println!("{}Lit", ind);
println!("{}{:?}", ind, lit);
},
- hir::ExprKind::Cast(ref e, ref target) => {
+ hir::ExprKind::Cast(e, target) => {
println!("{}Cast", ind);
print_expr(cx, e, indent + 1);
println!("{}target type: {:?}", ind, target);
},
- hir::ExprKind::Type(ref e, ref target) => {
+ hir::ExprKind::Type(e, target) => {
println!("{}Type", ind);
print_expr(cx, e, indent + 1);
println!("{}target type: {:?}", ind, target);
@@ -213,16 +213,16 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
hir::ExprKind::Loop(..) => {
println!("{}Loop", ind);
},
- hir::ExprKind::If(ref cond, _, ref else_opt) => {
+ hir::ExprKind::If(cond, _, ref else_opt) => {
println!("{}If", ind);
println!("{}condition:", ind);
print_expr(cx, cond, indent + 1);
- if let Some(ref els) = *else_opt {
+ if let Some(els) = *else_opt {
println!("{}else:", ind);
print_expr(cx, els, indent + 1);
}
},
- hir::ExprKind::Match(ref cond, _, ref source) => {
+ hir::ExprKind::Match(cond, _, ref source) => {
println!("{}Match", ind);
println!("{}condition:", ind);
print_expr(cx, cond, indent + 1);
@@ -232,21 +232,21 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
println!("{}Closure", ind);
println!("{}clause: {:?}", ind, clause);
},
- hir::ExprKind::Yield(ref sub, _) => {
+ hir::ExprKind::Yield(sub, _) => {
println!("{}Yield", ind);
print_expr(cx, sub, indent + 1);
},
hir::ExprKind::Block(_, _) => {
println!("{}Block", ind);
},
- hir::ExprKind::Assign(ref lhs, ref rhs, _) => {
+ hir::ExprKind::Assign(lhs, rhs, _) => {
println!("{}Assign", ind);
println!("{}lhs:", ind);
print_expr(cx, lhs, indent + 1);
println!("{}rhs:", ind);
print_expr(cx, rhs, indent + 1);
},
- hir::ExprKind::AssignOp(ref binop, ref lhs, ref rhs) => {
+ hir::ExprKind::AssignOp(ref binop, lhs, rhs) => {
println!("{}AssignOp", ind);
println!("{}op: {:?}", ind, binop.node);
println!("{}lhs:", ind);
@@ -254,31 +254,31 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
println!("{}rhs:", ind);
print_expr(cx, rhs, indent + 1);
},
- hir::ExprKind::Field(ref e, ident) => {
+ hir::ExprKind::Field(e, ident) => {
println!("{}Field", ind);
println!("{}field name: {}", ind, ident.name);
println!("{}struct expr:", ind);
print_expr(cx, e, indent + 1);
},
- hir::ExprKind::Index(ref arr, ref idx) => {
+ hir::ExprKind::Index(arr, idx) => {
println!("{}Index", ind);
println!("{}array expr:", ind);
print_expr(cx, arr, indent + 1);
println!("{}index expr:", ind);
print_expr(cx, idx, indent + 1);
},
- hir::ExprKind::Path(hir::QPath::Resolved(ref ty, ref path)) => {
+ hir::ExprKind::Path(hir::QPath::Resolved(ref ty, path)) => {
println!("{}Resolved Path, {:?}", ind, ty);
println!("{}path: {:?}", ind, path);
},
- hir::ExprKind::Path(hir::QPath::TypeRelative(ref ty, ref seg)) => {
+ hir::ExprKind::Path(hir::QPath::TypeRelative(ty, seg)) => {
println!("{}Relative Path, {:?}", ind, ty);
println!("{}seg: {:?}", ind, seg);
},
hir::ExprKind::Path(hir::QPath::LangItem(lang_item, ..)) => {
println!("{}Lang Item Path, {:?}", ind, lang_item.name());
},
- hir::ExprKind::AddrOf(kind, ref muta, ref e) => {
+ hir::ExprKind::AddrOf(kind, ref muta, e) => {
println!("{}AddrOf", ind);
println!("kind: {:?}", kind);
println!("mutability: {:?}", muta);
@@ -286,18 +286,18 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
},
hir::ExprKind::Break(_, ref e) => {
println!("{}Break", ind);
- if let Some(ref e) = *e {
+ if let Some(e) = *e {
print_expr(cx, e, indent + 1);
}
},
hir::ExprKind::Continue(_) => println!("{}Again", ind),
hir::ExprKind::Ret(ref e) => {
println!("{}Ret", ind);
- if let Some(ref e) = *e {
+ if let Some(e) = *e {
print_expr(cx, e, indent + 1);
}
},
- hir::ExprKind::InlineAsm(ref asm) => {
+ hir::ExprKind::InlineAsm(asm) => {
println!("{}InlineAsm", ind);
println!("{}template: {}", ind, InlineAsmTemplatePiece::to_string(asm.template));
println!("{}options: {:?}", ind, asm.options);
@@ -322,7 +322,7 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
}
}
},
- hir::ExprKind::LlvmInlineAsm(ref asm) => {
+ hir::ExprKind::LlvmInlineAsm(asm) => {
let inputs = &asm.inputs_exprs;
let outputs = &asm.outputs_exprs;
println!("{}LlvmInlineAsm", ind);
@@ -335,14 +335,14 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
print_expr(cx, e, indent + 1);
}
},
- hir::ExprKind::Struct(ref path, fields, ref base) => {
+ hir::ExprKind::Struct(path, fields, ref base) => {
println!("{}Struct", ind);
println!("{}path: {:?}", ind, path);
for field in fields {
println!("{}field \"{}\":", ind, field.ident.name);
- print_expr(cx, &field.expr, indent + 1);
+ print_expr(cx, field.expr, indent + 1);
}
- if let Some(ref base) = *base {
+ if let Some(base) = *base {
println!("{}base:", ind);
print_expr(cx, base, indent + 1);
}
@@ -352,7 +352,7 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
println!("{}anon_const:", ind);
print_expr(cx, &cx.tcx.hir().body(anon_const.body).value, indent + 1);
},
- hir::ExprKind::Repeat(ref val, ref anon_const) => {
+ hir::ExprKind::Repeat(val, ref anon_const) => {
println!("{}Repeat", ind);
println!("{}value:", ind);
print_expr(cx, val, indent + 1);
@@ -362,7 +362,7 @@ fn print_expr(cx: &LateContext<'_>, expr: &hir::Expr<'_>, indent: usize) {
hir::ExprKind::Err => {
println!("{}Err", ind);
},
- hir::ExprKind::DropTemps(ref e) => {
+ hir::ExprKind::DropTemps(e) => {
println!("{}DropTemps", ind);
print_expr(cx, e, indent + 1);
},
@@ -375,7 +375,7 @@ fn print_item(cx: &LateContext<'_>, item: &hir::Item<'_>) {
match item.vis.node {
hir::VisibilityKind::Public => println!("public"),
hir::VisibilityKind::Crate(_) => println!("visible crate wide"),
- hir::VisibilityKind::Restricted { ref path, .. } => println!(
+ hir::VisibilityKind::Restricted { path, .. } => println!(
"visible in module `{}`",
rustc_hir_pretty::to_string(rustc_hir_pretty::NO_ANN, |s| s.print_path(path, false))
),
@@ -395,7 +395,7 @@ fn print_item(cx: &LateContext<'_>, item: &hir::Item<'_>) {
println!("weird extern crate without a crate id");
}
},
- hir::ItemKind::Use(ref path, ref kind) => println!("{:?}, {:?}", path, kind),
+ hir::ItemKind::Use(path, ref kind) => println!("{:?}, {:?}", path, kind),
hir::ItemKind::Static(..) => println!("static item of type {:#?}", cx.tcx.type_of(did)),
hir::ItemKind::Const(..) => println!("const item of type {:#?}", cx.tcx.type_of(did)),
hir::ItemKind::Fn(..) => {
@@ -404,7 +404,7 @@ fn print_item(cx: &LateContext<'_>, item: &hir::Item<'_>) {
},
hir::ItemKind::Mod(..) => println!("module"),
hir::ItemKind::ForeignMod { abi, .. } => println!("foreign module with abi: {}", abi),
- hir::ItemKind::GlobalAsm(ref asm) => println!("global asm: {:?}", asm),
+ hir::ItemKind::GlobalAsm(asm) => println!("global asm: {:?}", asm),
hir::ItemKind::TyAlias(..) => {
println!("type alias for {:?}", cx.tcx.type_of(did));
},
@@ -454,7 +454,7 @@ fn print_pat(cx: &LateContext<'_>, pat: &hir::Pat<'_>, indent: usize) {
println!("{}Binding", ind);
println!("{}mode: {:?}", ind, mode);
println!("{}name: {}", ind, ident.name);
- if let Some(ref inner) = *inner {
+ if let Some(inner) = *inner {
println!("{}inner:", ind);
print_pat(cx, inner, indent + 1);
}
@@ -479,7 +479,7 @@ fn print_pat(cx: &LateContext<'_>, pat: &hir::Pat<'_>, indent: usize) {
if field.is_shorthand {
println!("{} in shorthand notation", ind);
}
- print_pat(cx, &field.pat, indent + 1);
+ print_pat(cx, field.pat, indent + 1);
}
},
hir::PatKind::TupleStruct(ref path, fields, opt_dots_position) => {
@@ -496,11 +496,11 @@ fn print_pat(cx: &LateContext<'_>, pat: &hir::Pat<'_>, indent: usize) {
print_pat(cx, field, indent + 1);
}
},
- hir::PatKind::Path(hir::QPath::Resolved(ref ty, ref path)) => {
+ hir::PatKind::Path(hir::QPath::Resolved(ref ty, path)) => {
println!("{}Resolved Path, {:?}", ind, ty);
println!("{}path: {:?}", ind, path);
},
- hir::PatKind::Path(hir::QPath::TypeRelative(ref ty, ref seg)) => {
+ hir::PatKind::Path(hir::QPath::TypeRelative(ty, seg)) => {
println!("{}Relative Path, {:?}", ind, ty);
println!("{}seg: {:?}", ind, seg);
},
@@ -516,16 +516,16 @@ fn print_pat(cx: &LateContext<'_>, pat: &hir::Pat<'_>, indent: usize) {
print_pat(cx, field, indent + 1);
}
},
- hir::PatKind::Box(ref inner) => {
+ hir::PatKind::Box(inner) => {
println!("{}Box", ind);
print_pat(cx, inner, indent + 1);
},
- hir::PatKind::Ref(ref inner, ref muta) => {
+ hir::PatKind::Ref(inner, ref muta) => {
println!("{}Ref", ind);
println!("{}mutability: {:?}", ind, muta);
print_pat(cx, inner, indent + 1);
},
- hir::PatKind::Lit(ref e) => {
+ hir::PatKind::Lit(e) => {
println!("{}Lit", ind);
print_expr(cx, e, indent + 1);
},
@@ -549,7 +549,7 @@ fn print_pat(cx: &LateContext<'_>, pat: &hir::Pat<'_>, indent: usize) {
print_pat(cx, pat, indent + 1);
}
println!("i:");
- if let Some(ref pat) = *range {
+ if let Some(pat) = *range {
print_pat(cx, pat, indent + 1);
}
println!("[y, z]:");
diff --git a/clippy_lints/src/utils/internal_lints.rs b/clippy_lints/src/utils/internal_lints.rs
index d5a13c135b1d..cf8039d6059b 100644
--- a/clippy_lints/src/utils/internal_lints.rs
+++ b/clippy_lints/src/utils/internal_lints.rs
@@ -353,12 +353,12 @@ impl<'tcx> LateLintPass<'tcx> for LintWithoutLintPass {
return;
}
- if let hir::ItemKind::Static(ref ty, Mutability::Not, body_id) = item.kind {
+ if let hir::ItemKind::Static(ty, Mutability::Not, body_id) = item.kind {
if is_lint_ref_type(cx, ty) {
let expr = &cx.tcx.hir().body(body_id).value;
if_chain! {
- if let ExprKind::AddrOf(_, _, ref inner_exp) = expr.kind;
- if let ExprKind::Struct(_, ref fields, _) = inner_exp.kind;
+ if let ExprKind::AddrOf(_, _, inner_exp) = expr.kind;
+ if let ExprKind::Struct(_, fields, _) = inner_exp.kind;
let field = fields
.iter()
.find(|f| f.ident.as_str() == "desc")
@@ -385,7 +385,7 @@ impl<'tcx> LateLintPass<'tcx> for LintWithoutLintPass {
{
if let hir::ItemKind::Impl(hir::Impl {
of_trait: None,
- items: ref impl_item_refs,
+ items: impl_item_refs,
..
}) = item.kind
{
@@ -437,7 +437,7 @@ fn is_lint_ref_type<'tcx>(cx: &LateContext<'tcx>, ty: &Ty<'_>) -> bool {
if let TyKind::Rptr(
_,
MutTy {
- ty: ref inner,
+ ty: inner,
mutbl: Mutability::Not,
},
) = ty.kind
@@ -498,7 +498,7 @@ impl<'tcx> LateLintPass<'tcx> for CompilerLintFunctions {
}
if_chain! {
- if let ExprKind::MethodCall(ref path, _, ref args, _) = expr.kind;
+ if let ExprKind::MethodCall(path, _, args, _) = expr.kind;
let fn_name = path.ident;
if let Some(sugg) = self.map.get(&*fn_name.as_str());
let ty = cx.typeck_results().expr_ty(&args[0]).peel_refs();
@@ -577,7 +577,7 @@ impl<'tcx> LateLintPass<'tcx> for CollapsibleCalls {
}
if_chain! {
- if let ExprKind::Call(ref func, ref and_then_args) = expr.kind;
+ if let ExprKind::Call(func, and_then_args) = expr.kind;
if let ExprKind::Path(ref path) = func.kind;
if match_qpath(path, &["span_lint_and_then"]);
if and_then_args.len() == 5;
@@ -587,7 +587,7 @@ impl<'tcx> LateLintPass<'tcx> for CollapsibleCalls {
let stmts = &block.stmts;
if stmts.len() == 1 && block.expr.is_none();
if let StmtKind::Semi(only_expr) = &stmts[0].kind;
- if let ExprKind::MethodCall(ref ps, _, ref span_call_args, _) = &only_expr.kind;
+ if let ExprKind::MethodCall(ps, _, span_call_args, _) = &only_expr.kind;
then {
let and_then_snippets = get_and_then_snippets(cx, and_then_args);
let mut sle = SpanlessEq::new(cx).deny_side_effects();
@@ -762,7 +762,7 @@ impl<'tcx> LateLintPass<'tcx> for MatchTypeOnDiagItem {
// Check if this is a call to utils::match_type()
if let ExprKind::Call(fn_path, [context, ty, ty_path]) = expr.kind;
if let ExprKind::Path(fn_qpath) = &fn_path.kind;
- if match_qpath(&fn_qpath, &["utils", "match_type"]);
+ if match_qpath(fn_qpath, &["utils", "match_type"]);
// Extract the path to the matched type
if let Some(segments) = path_to_matched_type(cx, ty_path);
let segments: Vec<&str> = segments.iter().map(|sym| &**sym).collect();
diff --git a/clippy_lints/src/vec.rs b/clippy_lints/src/vec.rs
index bc2eb88114e0..febd4b6ff7b3 100644
--- a/clippy_lints/src/vec.rs
+++ b/clippy_lints/src/vec.rs
@@ -49,7 +49,7 @@ impl<'tcx> LateLintPass<'tcx> for UselessVec {
if_chain! {
if let ty::Ref(_, ty, _) = cx.typeck_results().expr_ty_adjusted(expr).kind();
if let ty::Slice(..) = ty.kind();
- if let ExprKind::AddrOf(BorrowKind::Ref, mutability, ref addressee) = expr.kind;
+ if let ExprKind::AddrOf(BorrowKind::Ref, mutability, addressee) = expr.kind;
if let Some(vec_args) = higher::vec_macro(cx, addressee);
then {
self.check_vec_macro(cx, &vec_args, mutability, expr.span);
diff --git a/clippy_lints/src/vec_resize_to_zero.rs b/clippy_lints/src/vec_resize_to_zero.rs
index e035d3c5cade..5540e87405ff 100644
--- a/clippy_lints/src/vec_resize_to_zero.rs
+++ b/clippy_lints/src/vec_resize_to_zero.rs
@@ -30,7 +30,7 @@ declare_lint_pass!(VecResizeToZero => [VEC_RESIZE_TO_ZERO]);
impl<'tcx> LateLintPass<'tcx> for VecResizeToZero {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
if_chain! {
- if let hir::ExprKind::MethodCall(path_segment, _, ref args, _) = expr.kind;
+ if let hir::ExprKind::MethodCall(path_segment, _, args, _) = expr.kind;
if let Some(method_def_id) = cx.typeck_results().type_dependent_def_id(expr.hir_id);
if match_def_path(cx, method_def_id, &paths::VEC_RESIZE) && args.len() == 3;
if let ExprKind::Lit(Spanned { node: LitKind::Int(0, _), .. }) = args[1].kind;
diff --git a/clippy_lints/src/zero_div_zero.rs b/clippy_lints/src/zero_div_zero.rs
index 3b4890ad5606..350b1cf25ff0 100644
--- a/clippy_lints/src/zero_div_zero.rs
+++ b/clippy_lints/src/zero_div_zero.rs
@@ -31,7 +31,7 @@ impl<'tcx> LateLintPass<'tcx> for ZeroDiv {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
// check for instances of 0.0/0.0
if_chain! {
- if let ExprKind::Binary(ref op, ref left, ref right) = expr.kind;
+ if let ExprKind::Binary(ref op, left, right) = expr.kind;
if let BinOpKind::Div = op.node;
// TODO - constant_simple does not fold many operations involving floats.
// That's probably fine for this lint - it's pretty unlikely that someone would
diff --git a/clippy_lints/src/zero_sized_map_values.rs b/clippy_lints/src/zero_sized_map_values.rs
index 2abd033e2a07..f93f0047f514 100644
--- a/clippy_lints/src/zero_sized_map_values.rs
+++ b/clippy_lints/src/zero_sized_map_values.rs
@@ -50,7 +50,7 @@ impl LateLintPass<'_> for ZeroSizedMapValues {
if !in_trait_impl(cx, hir_ty.hir_id);
let ty = ty_from_hir_ty(cx, hir_ty);
if is_type_diagnostic_item(cx, ty, sym::hashmap_type) || match_type(cx, ty, &paths::BTREEMAP);
- if let Adt(_, ref substs) = ty.kind();
+ if let Adt(_, substs) = ty.kind();
let ty = substs.type_at(1);
// Do this to prevent `layout_of` crashing, being unable to fully normalize `ty`.
if is_normalizable(cx, cx.param_env, ty);
diff --git a/src/driver.rs b/src/driver.rs
index b6aed862e895..fa0c5f01430b 100644
--- a/src/driver.rs
+++ b/src/driver.rs
@@ -99,17 +99,17 @@ impl rustc_driver::Callbacks for ClippyCallbacks {
config.parse_sess_created = Some(Box::new(move |parse_sess| {
track_clippy_args(parse_sess, &clippy_args_var);
}));
- config.register_lints = Some(Box::new(move |sess, mut lint_store| {
+ config.register_lints = Some(Box::new(move |sess, lint_store| {
// technically we're ~guaranteed that this is none but might as well call anything that
// is there already. Certainly it can't hurt.
if let Some(previous) = &previous {
(previous)(sess, lint_store);
}
- let conf = clippy_lints::read_conf(&[], &sess);
- clippy_lints::register_plugins(&mut lint_store, &sess, &conf);
- clippy_lints::register_pre_expansion_lints(&mut lint_store);
- clippy_lints::register_renamed(&mut lint_store);
+ let conf = clippy_lints::read_conf(&[], sess);
+ clippy_lints::register_plugins(lint_store, sess, &conf);
+ clippy_lints::register_pre_expansion_lints(lint_store);
+ clippy_lints::register_renamed(lint_store);
}));
// FIXME: #4825; This is required, because Clippy lints that are based on MIR have to be
@@ -191,7 +191,7 @@ fn report_clippy_ice(info: &panic::PanicInfo<'_>, bug_report_url: &str) {
];
for note in &xs {
- handler.note_without_error(¬e);
+ handler.note_without_error(note);
}
// If backtraces are enabled, also print the query stack
diff --git a/tests/compile-test.rs b/tests/compile-test.rs
index 0594663786ce..f4d354f0bf94 100644
--- a/tests/compile-test.rs
+++ b/tests/compile-test.rs
@@ -98,7 +98,7 @@ fn default_config() -> compiletest::Config {
fn run_mode(cfg: &mut compiletest::Config) {
cfg.mode = TestMode::Ui;
cfg.src_base = Path::new("tests").join("ui");
- compiletest::run_tests(&cfg);
+ compiletest::run_tests(cfg);
}
fn run_internal_tests(cfg: &mut compiletest::Config) {
@@ -108,7 +108,7 @@ fn run_internal_tests(cfg: &mut compiletest::Config) {
}
cfg.mode = TestMode::Ui;
cfg.src_base = Path::new("tests").join("ui-internal");
- compiletest::run_tests(&cfg);
+ compiletest::run_tests(cfg);
}
fn run_ui_toml(config: &mut compiletest::Config) {
@@ -136,7 +136,7 @@ fn run_ui_toml(config: &mut compiletest::Config) {
base: config.src_base.clone(),
relative_dir: dir_path.file_name().unwrap().into(),
};
- let test_name = compiletest::make_test_name(&config, &paths);
+ let test_name = compiletest::make_test_name(config, &paths);
let index = tests
.iter()
.position(|test| test.desc.name == test_name)
@@ -150,10 +150,10 @@ fn run_ui_toml(config: &mut compiletest::Config) {
config.mode = TestMode::Ui;
config.src_base = Path::new("tests").join("ui-toml").canonicalize().unwrap();
- let tests = compiletest::make_tests(&config);
+ let tests = compiletest::make_tests(config);
let manifest_dir = var("CARGO_MANIFEST_DIR").unwrap_or_default();
- let res = run_tests(&config, tests);
+ let res = run_tests(config, tests);
set_var("CARGO_MANIFEST_DIR", &manifest_dir);
match res {
Ok(true) => {},
@@ -221,7 +221,7 @@ fn run_ui_cargo(config: &mut compiletest::Config) {
base: config.src_base.clone(),
relative_dir: src_path.strip_prefix(&config.src_base).unwrap().into(),
};
- let test_name = compiletest::make_test_name(&config, &paths);
+ let test_name = compiletest::make_test_name(config, &paths);
let index = tests
.iter()
.position(|test| test.desc.name == test_name)
@@ -240,11 +240,11 @@ fn run_ui_cargo(config: &mut compiletest::Config) {
config.mode = TestMode::Ui;
config.src_base = Path::new("tests").join("ui-cargo").canonicalize().unwrap();
- let tests = compiletest::make_tests(&config);
+ let tests = compiletest::make_tests(config);
let current_dir = env::current_dir().unwrap();
let conf_dir = var("CLIPPY_CONF_DIR").unwrap_or_default();
- let res = run_tests(&config, &config.filters, tests);
+ let res = run_tests(config, &config.filters, tests);
env::set_current_dir(current_dir).unwrap();
set_var("CLIPPY_CONF_DIR", conf_dir);
diff --git a/tests/ui/borrow_interior_mutable_const/others.rs b/tests/ui/borrow_interior_mutable_const/others.rs
index ea25729d11d4..4327f12c37c8 100644
--- a/tests/ui/borrow_interior_mutable_const/others.rs
+++ b/tests/ui/borrow_interior_mutable_const/others.rs
@@ -1,5 +1,9 @@
#![warn(clippy::borrow_interior_mutable_const)]
-#![allow(clippy::declare_interior_mutable_const, clippy::ref_in_deref)]
+#![allow(
+ clippy::declare_interior_mutable_const,
+ clippy::ref_in_deref,
+ clippy::needless_borrow
+)]
#![allow(const_item_mutation)]
use std::borrow::Cow;
diff --git a/tests/ui/borrow_interior_mutable_const/others.stderr b/tests/ui/borrow_interior_mutable_const/others.stderr
index 9a908cf30e94..f146b97cf611 100644
--- a/tests/ui/borrow_interior_mutable_const/others.stderr
+++ b/tests/ui/borrow_interior_mutable_const/others.stderr
@@ -1,5 +1,5 @@
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:54:5
+ --> $DIR/others.rs:58:5
|
LL | ATOMIC.store(1, Ordering::SeqCst); //~ ERROR interior mutability
| ^^^^^^
@@ -8,7 +8,7 @@ LL | ATOMIC.store(1, Ordering::SeqCst); //~ ERROR interior mutability
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:55:16
+ --> $DIR/others.rs:59:16
|
LL | assert_eq!(ATOMIC.load(Ordering::SeqCst), 5); //~ ERROR interior mutability
| ^^^^^^
@@ -16,7 +16,7 @@ LL | assert_eq!(ATOMIC.load(Ordering::SeqCst), 5); //~ ERROR interior mutabi
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:58:22
+ --> $DIR/others.rs:62:22
|
LL | let _once_ref = &ONCE_INIT; //~ ERROR interior mutability
| ^^^^^^^^^
@@ -24,7 +24,7 @@ LL | let _once_ref = &ONCE_INIT; //~ ERROR interior mutability
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:59:25
+ --> $DIR/others.rs:63:25
|
LL | let _once_ref_2 = &&ONCE_INIT; //~ ERROR interior mutability
| ^^^^^^^^^
@@ -32,7 +32,7 @@ LL | let _once_ref_2 = &&ONCE_INIT; //~ ERROR interior mutability
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:60:27
+ --> $DIR/others.rs:64:27
|
LL | let _once_ref_4 = &&&&ONCE_INIT; //~ ERROR interior mutability
| ^^^^^^^^^
@@ -40,7 +40,7 @@ LL | let _once_ref_4 = &&&&ONCE_INIT; //~ ERROR interior mutability
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:61:26
+ --> $DIR/others.rs:65:26
|
LL | let _once_mut = &mut ONCE_INIT; //~ ERROR interior mutability
| ^^^^^^^^^
@@ -48,7 +48,7 @@ LL | let _once_mut = &mut ONCE_INIT; //~ ERROR interior mutability
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:72:14
+ --> $DIR/others.rs:76:14
|
LL | let _ = &ATOMIC_TUPLE; //~ ERROR interior mutability
| ^^^^^^^^^^^^
@@ -56,7 +56,7 @@ LL | let _ = &ATOMIC_TUPLE; //~ ERROR interior mutability
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:73:14
+ --> $DIR/others.rs:77:14
|
LL | let _ = &ATOMIC_TUPLE.0; //~ ERROR interior mutability
| ^^^^^^^^^^^^
@@ -64,7 +64,7 @@ LL | let _ = &ATOMIC_TUPLE.0; //~ ERROR interior mutability
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:74:19
+ --> $DIR/others.rs:78:19
|
LL | let _ = &(&&&&ATOMIC_TUPLE).0; //~ ERROR interior mutability
| ^^^^^^^^^^^^
@@ -72,7 +72,7 @@ LL | let _ = &(&&&&ATOMIC_TUPLE).0; //~ ERROR interior mutability
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:75:14
+ --> $DIR/others.rs:79:14
|
LL | let _ = &ATOMIC_TUPLE.0[0]; //~ ERROR interior mutability
| ^^^^^^^^^^^^
@@ -80,7 +80,7 @@ LL | let _ = &ATOMIC_TUPLE.0[0]; //~ ERROR interior mutability
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:76:13
+ --> $DIR/others.rs:80:13
|
LL | let _ = ATOMIC_TUPLE.0[0].load(Ordering::SeqCst); //~ ERROR interior mutability
| ^^^^^^^^^^^^
@@ -88,7 +88,7 @@ LL | let _ = ATOMIC_TUPLE.0[0].load(Ordering::SeqCst); //~ ERROR interior mu
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:82:13
+ --> $DIR/others.rs:86:13
|
LL | let _ = ATOMIC_TUPLE.0[0]; //~ ERROR interior mutability
| ^^^^^^^^^^^^
@@ -96,7 +96,7 @@ LL | let _ = ATOMIC_TUPLE.0[0]; //~ ERROR interior mutability
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:87:5
+ --> $DIR/others.rs:91:5
|
LL | CELL.set(2); //~ ERROR interior mutability
| ^^^^
@@ -104,7 +104,7 @@ LL | CELL.set(2); //~ ERROR interior mutability
= help: assign this const to a local or static variable, and use the variable here
error: a `const` item with interior mutability should not be borrowed
- --> $DIR/others.rs:88:16
+ --> $DIR/others.rs:92:16
|
LL | assert_eq!(CELL.get(), 6); //~ ERROR interior mutability
| ^^^^
diff --git a/tests/ui/collapsible_match2.rs b/tests/ui/collapsible_match2.rs
index 8372a2124773..542e69484276 100644
--- a/tests/ui/collapsible_match2.rs
+++ b/tests/ui/collapsible_match2.rs
@@ -1,5 +1,10 @@
#![warn(clippy::collapsible_match)]
-#![allow(clippy::needless_return, clippy::no_effect, clippy::single_match)]
+#![allow(
+ clippy::needless_return,
+ clippy::no_effect,
+ clippy::single_match,
+ clippy::needless_borrow
+)]
fn lint_cases(opt_opt: Option<Option<u32>>, res_opt: Result<Option<u32>, String>) {
// if guards on outer match
diff --git a/tests/ui/collapsible_match2.stderr b/tests/ui/collapsible_match2.stderr
index c8a445ef369d..ffef32d1fde9 100644
--- a/tests/ui/collapsible_match2.stderr
+++ b/tests/ui/collapsible_match2.stderr
@@ -1,5 +1,5 @@
error: unnecessary nested match
- --> $DIR/collapsible_match2.rs:8:34
+ --> $DIR/collapsible_match2.rs:13:34
|
LL | Ok(val) if make() => match val {
| __________________________________^
@@ -10,7 +10,7 @@ LL | | },
|
= note: `-D clippy::collapsible-match` implied by `-D warnings`
help: the outer pattern can be modified to include the inner pattern
- --> $DIR/collapsible_match2.rs:8:16
+ --> $DIR/collapsible_match2.rs:13:16
|
LL | Ok(val) if make() => match val {
| ^^^ replace this binding
@@ -18,7 +18,7 @@ LL | Some(n) => foo(n),
| ^^^^^^^ with this pattern
error: unnecessary nested match
- --> $DIR/collapsible_match2.rs:15:24
+ --> $DIR/collapsible_match2.rs:20:24
|
LL | Ok(val) => match val {
| ________________________^
@@ -28,7 +28,7 @@ LL | | },
| |_____________^
|
help: the outer pattern can be modified to include the inner pattern
- --> $DIR/collapsible_match2.rs:15:16
+ --> $DIR/collapsible_match2.rs:20:16
|
LL | Ok(val) => match val {
| ^^^ replace this binding
@@ -36,7 +36,7 @@ LL | Some(n) => foo(n),
| ^^^^^^^ with this pattern
error: unnecessary nested match
- --> $DIR/collapsible_match2.rs:29:29
+ --> $DIR/collapsible_match2.rs:34:29
|
LL | $pat => match $e {
| _____________________________^
@@ -49,7 +49,7 @@ LL | mac!(res_opt => Ok(val), val => Some(n), foo(n));
| ------------------------------------------------- in this macro invocation
|
help: the outer pattern can be modified to include the inner pattern
- --> $DIR/collapsible_match2.rs:41:28
+ --> $DIR/collapsible_match2.rs:46:28
|
LL | mac!(res_opt => Ok(val), val => Some(n), foo(n));
| ^^^ ^^^^^^^ with this pattern
@@ -58,7 +58,7 @@ LL | mac!(res_opt => Ok(val), val => Some(n), foo(n));
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: unnecessary nested match
- --> $DIR/collapsible_match2.rs:46:20
+ --> $DIR/collapsible_match2.rs:51:20
|
LL | Some(s) => match *s {
| ____________________^
@@ -68,7 +68,7 @@ LL | | },
| |_________^
|
help: the outer pattern can be modified to include the inner pattern
- --> $DIR/collapsible_match2.rs:46:14
+ --> $DIR/collapsible_match2.rs:51:14
|
LL | Some(s) => match *s {
| ^ replace this binding
@@ -76,7 +76,7 @@ LL | [n] => foo(n),
| ^^^ with this pattern
error: unnecessary nested match
- --> $DIR/collapsible_match2.rs:55:24
+ --> $DIR/collapsible_match2.rs:60:24
|
LL | Some(ref s) => match &*s {
| ________________________^
@@ -86,7 +86,7 @@ LL | | },
| |_________^
|
help: the outer pattern can be modified to include the inner pattern
- --> $DIR/collapsible_match2.rs:55:14
+ --> $DIR/collapsible_match2.rs:60:14
|
LL | Some(ref s) => match &*s {
| ^^^^^ replace this binding
diff --git a/tests/ui/escape_analysis.rs b/tests/ui/escape_analysis.rs
index d26f48fc68f8..13e2b6c7a2e7 100644
--- a/tests/ui/escape_analysis.rs
+++ b/tests/ui/escape_analysis.rs
@@ -101,7 +101,7 @@ fn warn_match() {
let x = box A;
match &x {
// not moved
- ref y => (),
+ y => (),
}
}
@@ -111,7 +111,7 @@ fn nowarn_large_array() {
let x = box [1; 10000];
match &x {
// not moved
- ref y => (),
+ y => (),
}
}
diff --git a/tests/ui/implicit_clone.rs b/tests/ui/implicit_clone.rs
index 19101522163f..cef71cf79d79 100644
--- a/tests/ui/implicit_clone.rs
+++ b/tests/ui/implicit_clone.rs
@@ -66,7 +66,7 @@ fn main() {
let _ = vec.to_vec();
let vec_ref = &vec;
- let _ = return_owned_from_slice(&vec_ref);
+ let _ = return_owned_from_slice(vec_ref);
let _ = vec_ref.to_owned();
let _ = vec_ref.to_vec();
diff --git a/tests/ui/into_iter_on_ref.fixed b/tests/ui/into_iter_on_ref.fixed
index 7f92d0dbdc97..b77f17944d89 100644
--- a/tests/ui/into_iter_on_ref.fixed
+++ b/tests/ui/into_iter_on_ref.fixed
@@ -1,5 +1,5 @@
// run-rustfix
-#![allow(clippy::useless_vec)]
+#![allow(clippy::useless_vec, clippy::needless_borrow)]
#![warn(clippy::into_iter_on_ref)]
struct X;
diff --git a/tests/ui/into_iter_on_ref.rs b/tests/ui/into_iter_on_ref.rs
index 416056d3fdb9..3854bb05af8f 100644
--- a/tests/ui/into_iter_on_ref.rs
+++ b/tests/ui/into_iter_on_ref.rs
@@ -1,5 +1,5 @@
// run-rustfix
-#![allow(clippy::useless_vec)]
+#![allow(clippy::useless_vec, clippy::needless_borrow)]
#![warn(clippy::into_iter_on_ref)]
struct X;
diff --git a/tests/ui/ref_option_ref.rs b/tests/ui/ref_option_ref.rs
index b2c275d68afa..2df45c927d71 100644
--- a/tests/ui/ref_option_ref.rs
+++ b/tests/ui/ref_option_ref.rs
@@ -9,7 +9,7 @@
static THRESHOLD: i32 = 10;
static REF_THRESHOLD: &Option<&i32> = &Some(&THRESHOLD);
const CONST_THRESHOLD: &i32 = &10;
-const REF_CONST: &Option<&i32> = &Some(&CONST_THRESHOLD);
+const REF_CONST: &Option<&i32> = &Some(CONST_THRESHOLD);
type RefOptRefU32<'a> = &'a Option<&'a u32>;
type RefOptRef<'a, T> = &'a Option<&'a T>;
diff --git a/tests/ui/ref_option_ref.stderr b/tests/ui/ref_option_ref.stderr
index 4e7fc8000611..b61334758e85 100644
--- a/tests/ui/ref_option_ref.stderr
+++ b/tests/ui/ref_option_ref.stderr
@@ -9,7 +9,7 @@ LL | static REF_THRESHOLD: &Option<&i32> = &Some(&THRESHOLD);
error: since `&` implements the `Copy` trait, `&Option<&T>` can be simplified to `Option<&T>`
--> $DIR/ref_option_ref.rs:12:18
|
-LL | const REF_CONST: &Option<&i32> = &Some(&CONST_THRESHOLD);
+LL | const REF_CONST: &Option<&i32> = &Some(CONST_THRESHOLD);
| ^^^^^^^^^^^^^ help: try: `Option<&i32>`
error: since `&` implements the `Copy` trait, `&Option<&T>` can be simplified to `Option<&T>`
diff --git a/tests/ui/stable_sort_primitive.fixed b/tests/ui/stable_sort_primitive.fixed
index 8f8f56659315..f5f18169df29 100644
--- a/tests/ui/stable_sort_primitive.fixed
+++ b/tests/ui/stable_sort_primitive.fixed
@@ -20,7 +20,7 @@ fn main() {
// Negative examples: behavior changes if made unstable
let mut vec = vec![1, 3, 2];
vec.sort_by_key(|i| i / 2);
- vec.sort_by(|a, b| (a + b).cmp(&b));
+ vec.sort_by(|&a, &b| (a + b).cmp(&b));
// negative examples - Not of a primitive type
let mut vec_of_complex = vec![String::from("hello"), String::from("world!")];
vec_of_complex.sort();
diff --git a/tests/ui/stable_sort_primitive.rs b/tests/ui/stable_sort_primitive.rs
index f9bd97790671..8149c5638e0f 100644
--- a/tests/ui/stable_sort_primitive.rs
+++ b/tests/ui/stable_sort_primitive.rs
@@ -20,7 +20,7 @@ fn main() {
// Negative examples: behavior changes if made unstable
let mut vec = vec![1, 3, 2];
vec.sort_by_key(|i| i / 2);
- vec.sort_by(|a, b| (a + b).cmp(&b));
+ vec.sort_by(|&a, &b| (a + b).cmp(&b));
// negative examples - Not of a primitive type
let mut vec_of_complex = vec![String::from("hello"), String::from("world!")];
vec_of_complex.sort();