From d11a8ac71e6084f841c3c9283b231278e7f8eee8 Mon Sep 17 00:00:00 2001 From: binarycat Date: Thu, 24 Oct 2024 12:34:07 -0500 Subject: [PATCH 1/2] add instructions for triaging ICE issues based off of disscussion in https://rust-lang.zulipchat.com/#narrow/channel/242269-t-release.2Ftriage/topic/Please.20make.20sure.20to.20label.20ICEs.20by.20source.20region --- src/release/issue-triaging.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/release/issue-triaging.md b/src/release/issue-triaging.md index 070604a29..f5b46d2bf 100644 --- a/src/release/issue-triaging.md +++ b/src/release/issue-triaging.md @@ -54,6 +54,16 @@ To see a list of all labels, check out the "labels" page next to the search bar [IRLO]: https://internals.rust-lang.org/ [Discord]: https://discord.gg/rust-lang +### ICE Triage +For [Issues that have both I-ICE and needs-triage](https://github.com/rust-lang/rust/issues?q=is%3Aissue%20state%3Aopen%20label%3AI-ICE%20label%3Aneeds-triage) +* If it an older (like latest stable) version of rust, ask for or check the latest nightly (potentially check for duplicates) +* If it does not have a reproduction, comment asking for one and add S-needs-repro. if there isn't one for around a month it should generally be closed. +* If the reproduction is not minimal, add `E-needs-mcve` or create a Minimal Complete and Verifyable Example yourself. +* Add `A-*` labels based on the code that causes the issue (check backtraces!), + and the nature of the repro (eg. if the repro is a weird trait impl or the backtrace points to `rustc_trait_selection`, add `A-traits`) +* Add `F-*`, `requires-*`, and `regression-*` labels as appropriate. + + ## Further triaging For issues that have been through the initial triaging step (that is, don't have the `needs-triage` label anymore), there are usually From 002a7eae2633821b39c578036d5db43381db423b Mon Sep 17 00:00:00 2001 From: binarycat Date: Thu, 24 Oct 2024 13:42:48 -0500 Subject: [PATCH 2/2] add more info about ICE triage --- src/release/issue-triaging.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/release/issue-triaging.md b/src/release/issue-triaging.md index f5b46d2bf..cfee6c5e4 100644 --- a/src/release/issue-triaging.md +++ b/src/release/issue-triaging.md @@ -56,12 +56,15 @@ To see a list of all labels, check out the "labels" page next to the search bar ### ICE Triage For [Issues that have both I-ICE and needs-triage](https://github.com/rust-lang/rust/issues?q=is%3Aissue%20state%3Aopen%20label%3AI-ICE%20label%3Aneeds-triage) -* If it an older (like latest stable) version of rust, ask for or check the latest nightly (potentially check for duplicates) +* Check that the issue is actually an ICE, and not more accuratly described with `I-crash` or `I-hang`. +* If it is an older (like latest stable) version of rust, ask for or check the latest nightly. +* Check for duplicates, but don't close as duplicate unless you're sure they represent the same underlying issue. + Prefer simply linking to the issue as possibly related/duplicate. * If it does not have a reproduction, comment asking for one and add S-needs-repro. if there isn't one for around a month it should generally be closed. -* If the reproduction is not minimal, add `E-needs-mcve` or create a Minimal Complete and Verifyable Example yourself. +* If the reproduction is not minimal, add `E-needs-mcve` or create a Minimal Complete and Verifible Example yourself. * Add `A-*` labels based on the code that causes the issue (check backtraces!), and the nature of the repro (eg. if the repro is a weird trait impl or the backtrace points to `rustc_trait_selection`, add `A-traits`) -* Add `F-*`, `requires-*`, and `regression-*` labels as appropriate. +* Add `T-*`, `WG-*`, `PG-*`, `F-*`, `requires-*`, and `regression-*` labels as appropriate. ## Further triaging