Apply suggestions from code review

ABouttefeux · Joshua Nelson · ABouttefeux · commit 03c710bf8923 · 2021-05-01T11:54:57.000+02:00
Co-authored-by: Joshua Nelson &lt;joshua@yottadb.com&gt;
diff --git a/src/librustdoc/config.rs b/src/librustdoc/config.rs
@@ -462,7 +462,7 @@ impl Options {
         let no_run = matches.opt_present("no-run");
 
         if !should_test && no_run {
-            diag.struct_err("option --no-run should be used with --test").emit();
+            diag.err("the `--test` flag must be passed to enable `--no-run`");
             return Err(1);
         }
 
diff --git a/src/test/rustdoc-ui/no-run-flag-error.rs b/src/test/rustdoc-ui/no-run-flag-error.rs
@@ -1,5 +1,6 @@
 // test the behavior of the --no-run flag without the --test flag
 
 // compile-flags:-Z unstable-options --no-run --test-args=--test-threads=1
+// error-pattern: the `--test` flag must be passed
 
 pub fn f() {}
diff --git a/src/test/rustdoc-ui/no-run-flag-error.stderr b/src/test/rustdoc-ui/no-run-flag-error.stderr
@@ -1,2 +1,2 @@
-error: option --no-run should be used with --test
+error: the `--test` flag must be passed to enable `--no-run`
 

Original file line number	Diff line number	Diff line change
`@@ -462,7 +462,7 @@ impl Options {`
`462`	`462`	`let no_run = matches.opt_present("no-run");`
`463`	`463`
`464`	`464`	`if !should_test && no_run {`
`465`		`- diag.struct_err("option --no-run should be used with --test").emit();`
	`465`	+ diag.err("the `--test` flag must be passed to enable `--no-run`");
`466`	`466`	`return Err(1);`
`467`	`467`	`}`
`468`	`468`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`		`-error: option --no-run should be used with --test`
	`1`	+error: the `--test` flag must be passed to enable `--no-run`
`2`	`2`