Skip to content

Commit 07f1fde

Browse files
committed
Auto merge of #75161 - sunfishcode:wasm-no-threads, r=alexcrichton
Remove the `--no-threads` workaround for wasm targets. Remove `--no-threads` from the wasm-ld command-line, which was a workaround for [an old bug] which was fixed in LLVM 9.0, and is no longer needed. Also, the `--no-threads` option has been [removed upstream]. [an old bug]: https://bugs.llvm.org/show_bug.cgi?id=41508 [removed upstream]: https://reviews.llvm.org/D76885 r? @alexcrichton
2 parents f9d422e + 1a3e4d8 commit 07f1fde

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/librustc_target/spec/wasm32_base.rs

-7
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,6 @@ pub fn options() -> TargetOptions {
1010
clang_args.push(format!("-Wl,{}", arg));
1111
};
1212

13-
// There have been reports in the wild (rustwasm/wasm-bindgen#119) of
14-
// using threads causing weird hangs and bugs. Disable it entirely as
15-
// this isn't yet the bottleneck of compilation at all anyway.
16-
//
17-
// FIXME: we should file an upstream issue with LLD about this
18-
arg("--no-threads");
19-
2013
// By default LLD only gives us one page of stack (64k) which is a
2114
// little small. Default to a larger stack closer to other PC platforms
2215
// (1MB) and users can always inject their own link-args to override this.

0 commit comments

Comments
 (0)