Skip to content

Commit 186cbfa

Browse files
Replace FIXME with explanation
1 parent 7f3ec5e commit 186cbfa

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/librustc_typeck/astconv.rs

+4-2
Original file line numberDiff line numberDiff line change
@@ -1345,7 +1345,8 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
13451345
let (assoc_ident, def_scope) =
13461346
tcx.adjust_ident_and_get_scope(binding.item_name, candidate.def_id(), hir_ref_id);
13471347

1348-
// FIXME(ecstaticmorse): Can this use `find_by_name_and_kind` instead?
1348+
// We have already adjusted the item name above, so compare with `ident.modern()` instead
1349+
// of calling `filter_by_name_and_kind`.
13491350
let assoc_ty = tcx
13501351
.associated_items(candidate.def_id())
13511352
.filter_by_name_unhygienic(assoc_ident.name)
@@ -2198,7 +2199,8 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
21982199
let (assoc_ident, def_scope) =
21992200
tcx.adjust_ident_and_get_scope(assoc_ident, trait_did, hir_ref_id);
22002201

2201-
// FIXME(ecstaticmorse): Can this use `find_by_name_and_namespace` instead?
2202+
// We have already adjusted the item name above, so compare with `ident.modern()` instead
2203+
// of calling `filter_by_name_and_kind`.
22022204
let item = tcx
22032205
.associated_items(trait_did)
22042206
.in_definition_order()

0 commit comments

Comments
 (0)