Skip to content

Commit 1ad91bb

Browse files
committed
Remove some low-value use renamings.
There are a few common abbreviations like `use rustc_ast as ast` and `use rust_hir as hir` for names that are used a lot. But there are also some cases where a crate is renamed just once in the whole codebase, and that ends up making things harder to read rather than easier. This commit removes them.
1 parent 9b3ef54 commit 1ad91bb

File tree

4 files changed

+10
-15
lines changed

4 files changed

+10
-15
lines changed

compiler/rustc_errors/src/diagnostic_impls.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ use rustc_span::symbol::{Ident, MacroRulesNormalizedIdent, Symbol};
1313
use rustc_span::Span;
1414
use rustc_target::abi::TargetDataLayoutErrors;
1515
use rustc_target::spec::{PanicStrategy, SplitDebuginfo, StackProtector, TargetTriple};
16-
use rustc_type_ir as type_ir;
16+
use rustc_type_ir::{ClosureKind, FloatTy};
1717
use std::backtrace::Backtrace;
1818
use std::borrow::Cow;
1919
use std::fmt;
@@ -196,7 +196,7 @@ impl IntoDiagArg for ast::token::TokenKind {
196196
}
197197
}
198198

199-
impl IntoDiagArg for type_ir::FloatTy {
199+
impl IntoDiagArg for FloatTy {
200200
fn into_diag_arg(self) -> DiagArgValue {
201201
DiagArgValue::Str(Cow::Borrowed(self.name_str()))
202202
}
@@ -252,7 +252,7 @@ impl IntoDiagArg for Level {
252252
}
253253
}
254254

255-
impl IntoDiagArg for type_ir::ClosureKind {
255+
impl IntoDiagArg for ClosureKind {
256256
fn into_diag_arg(self) -> DiagArgValue {
257257
DiagArgValue::Str(self.as_str().into())
258258
}

compiler/rustc_hir_typeck/src/pat.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ use rustc_hir::pat_util::EnumerateAndAdjustIterator;
1010
use rustc_hir::{self as hir, BindingMode, ByRef, HirId, Mutability, Pat, PatKind};
1111
use rustc_infer::infer;
1212
use rustc_infer::infer::type_variable::TypeVariableOrigin;
13-
use rustc_lint as lint;
1413
use rustc_middle::mir::interpret::ErrorHandled;
1514
use rustc_middle::ty::{self, Ty, TypeVisitableExt};
1615
use rustc_session::lint::builtin::NON_EXHAUSTIVE_OMITTED_PATTERNS;
@@ -684,7 +683,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
684683
{
685684
// `mut x` resets the binding mode in edition <= 2021.
686685
self.tcx.emit_node_span_lint(
687-
lint::builtin::DEREFERENCING_MUT_BINDING,
686+
rustc_lint::builtin::DEREFERENCING_MUT_BINDING,
688687
pat.hir_id,
689688
pat.span,
690689
errors::DereferencingMutBinding { span: pat.span },

compiler/rustc_interface/src/passes.rs

+2-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ use crate::proc_macro_decls;
44
use crate::util;
55

66
use rustc_ast::{self as ast, visit};
7-
use rustc_borrowck as mir_borrowck;
87
use rustc_codegen_ssa::traits::CodegenBackend;
98
use rustc_data_structures::parallel;
109
use rustc_data_structures::steal::Steal;
@@ -20,7 +19,6 @@ use rustc_middle::arena::Arena;
2019
use rustc_middle::dep_graph::DepGraph;
2120
use rustc_middle::ty::{self, GlobalCtxt, RegisteredTools, TyCtxt};
2221
use rustc_middle::util::Providers;
23-
use rustc_mir_build as mir_build;
2422
use rustc_parse::{parse_crate_from_file, parse_crate_from_source_str, validate_attr};
2523
use rustc_passes::{abi_test, hir_stats, layout_test};
2624
use rustc_resolve::Resolver;
@@ -616,8 +614,8 @@ pub static DEFAULT_QUERY_PROVIDERS: LazyLock<Providers> = LazyLock::new(|| {
616614
proc_macro_decls::provide(providers);
617615
rustc_const_eval::provide(providers);
618616
rustc_middle::hir::provide(providers);
619-
mir_borrowck::provide(providers);
620-
mir_build::provide(providers);
617+
rustc_borrowck::provide(providers);
618+
rustc_mir_build::provide(providers);
621619
rustc_mir_transform::provide(providers);
622620
rustc_monomorphize::provide(providers);
623621
rustc_privacy::provide(providers);

compiler/rustc_interface/src/util.rs

+4-6
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,16 @@ use rustc_data_structures::sync;
77
use rustc_metadata::{load_symbol_from_dylib, DylibError};
88
use rustc_middle::ty::CurrentGcx;
99
use rustc_parse::validate_attr;
10-
use rustc_session as session;
11-
use rustc_session::config::{Cfg, OutFileName, OutputFilenames, OutputTypes};
10+
use rustc_session::config::{host_triple, Cfg, OutFileName, OutputFilenames, OutputTypes};
1211
use rustc_session::filesearch::sysroot_candidates;
1312
use rustc_session::lint::{self, BuiltinLintDiag, LintBuffer};
14-
use rustc_session::{filesearch, Session};
13+
use rustc_session::output::{categorize_crate_type, CRATE_TYPES};
14+
use rustc_session::{filesearch, EarlyDiagCtxt, Session};
1515
use rustc_span::edit_distance::find_best_match_for_name;
1616
use rustc_span::edition::Edition;
1717
use rustc_span::source_map::SourceMapInputs;
1818
use rustc_span::symbol::sym;
1919
use rustc_target::spec::Target;
20-
use session::output::{categorize_crate_type, CRATE_TYPES};
21-
use session::EarlyDiagCtxt;
2220
use std::env::consts::{DLL_PREFIX, DLL_SUFFIX};
2321
use std::path::{Path, PathBuf};
2422
use std::sync::atomic::{AtomicBool, Ordering};
@@ -286,7 +284,7 @@ fn get_codegen_sysroot(
286284
"cannot load the default codegen backend twice"
287285
);
288286

289-
let target = session::config::host_triple();
287+
let target = host_triple();
290288
let sysroot_candidates = sysroot_candidates();
291289

292290
let sysroot = iter::once(sysroot)

0 commit comments

Comments
 (0)