fix unused lint

Author: b-naber

compiler/rustc_hir_typeck/src/expr.rs

@@ -190,7 +190,6 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
 
     /// Check an expr with an expectation type which may be used to eagerly
     /// guide inference when evaluating that expr.
-    #[instrument(skip(self, expr), level = "debug")]
     pub(super) fn check_expr_with_expectation(
         &self,
         expr: &'tcx hir::Expr<'tcx>,

compiler/rustc_metadata/src/creader.rs

@@ -34,7 +34,7 @@ use rustc_session::search_paths::PathKind;
 use rustc_span::edition::Edition;
 use rustc_span::{DUMMY_SP, Ident, Span, Symbol, sym};
 use rustc_target::spec::{PanicStrategy, Target, TargetTuple};
-use tracing::{debug, info, trace};
+use tracing::{debug, info, instrument, trace};
 
 use crate::errors;
 use crate::locator::{CrateError, CrateLocator, CratePaths};
@@ -1225,11 +1225,14 @@ impl<'a, 'tcx> CrateLoader<'a, 'tcx> {
         }
     }
 
+    #[instrument(skip(self, krate), level = "debug")]
     fn report_unused_deps(&mut self, krate: &ast::Crate) {
         // Make a point span rather than covering the whole file
         let span = krate.spans.inner_span.shrink_to_lo();
         // Complain about anything left over
         for (name, entry) in self.sess.opts.externs.iter() {
+            debug!(?name, ?entry);
+            debug!("used_extern_options: {:?}", self.used_extern_options);
             if let ExternLocation::FoundInLibrarySearchDirectories = entry.location {
                 // Don't worry about pathless `--extern foo` sysroot references
                 continue;

compiler/rustc_resolve/src/build_reduced_graph.rs

@@ -162,12 +162,12 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
         ident: Ident,
         finalize: bool,
     ) -> Module<'ra> {
-        if let Some(module) = self.module_map.get(&def_id) {
-            return *module;
+        if finalize {
+            self.used_extern_options.insert(ident.name);
         }
 
-        if finalize {
-            self.crate_loader(|c| c.process_path_extern(ident.name, ident.span));
+        if let Some(module) = self.module_map.get(&def_id) {
+            return *module;
         }
 
         let def_kind = self.cstore().def_kind_untracked(def_id);
@@ -1036,7 +1036,7 @@ impl<'a, 'ra, 'tcx> BuildReducedGraphVisitor<'a, 'ra, 'tcx> {
             });
             crate_id.map(|crate_id| {
                 self.r.extern_crate_map.insert(local_def_id, crate_id);
-                self.r.create_module_for_external_crate(crate_id.as_def_id(), ident, false)
+                self.r.create_module_for_external_crate(crate_id.as_def_id(), ident, true)
             })
         }
         .map(|module| {

compiler/rustc_resolve/src/lib.rs

@@ -2189,6 +2189,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                             NameBindingKind::Module(module) => match module.kind {
                                 ModuleKind::NamespaceCrate(..) => {
                                     // This is a virtual module
+                                    debug!("{:?} is virtual module", norm_ident);
                                 }
                                 _ => {
                                     self.crate_loader(|c| {
@@ -2208,7 +2209,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                 }
                 binding
             } else {
-                let crate_root = if finalize {
+                let crate_module = if finalize {
                     if let Some(crate_id) =
                         self.crate_loader(|c| c.maybe_process_path_extern(ident.name))
                     {
@@ -2242,9 +2243,9 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                     }
                 };
 
-                debug!(?crate_root);
+                debug!(?crate_module);
                 let vis = ty::Visibility::<DefId>::Public;
-                (crate_root, vis, DUMMY_SP, LocalExpnId::ROOT).to_name_binding(self.arenas)
+                (crate_module, vis, DUMMY_SP, LocalExpnId::ROOT).to_name_binding(self.arenas)
             })
         });
 

compiler/rustc_session/src/options.rs

@@ -2335,7 +2335,7 @@ options! {
     mutable_noalias: bool = (true, parse_bool, [TRACKED],
         "emit noalias metadata for mutable references (default: yes)"),
     namespaced_crates: bool = (false, parse_bool, [TRACKED],
-        "allow crates to be nested in other crates (default: no)"),
+        "allow crates to be namespaced by other crates (default: no)"),
     next_solver: NextSolverConfig = (NextSolverConfig::default(), parse_next_solver_config, [TRACKED],
         "enable and configure the next generation trait solver used by rustc"),
     nll_facts: bool = (false, parse_bool, [UNTRACKED],