Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 983148a

Browse files
NoratriebNoratrieb
authoredMay 30, 2023
Rollup merge of #111543 - Urgau:uplift_invalid_utf8_in_unchecked, r=WaffleLapkin
Uplift `clippy::invalid_utf8_in_unchecked` lint This PR aims at uplifting the `clippy::invalid_utf8_in_unchecked` lint into two lints. ## `invalid_from_utf8_unchecked` (deny-by-default) The `invalid_from_utf8_unchecked` lint checks for calls to `std::str::from_utf8_unchecked` and `std::str::from_utf8_unchecked_mut` with an invalid UTF-8 literal. ### Example ```rust unsafe { std::str::from_utf8_unchecked(b"cl\x82ippy"); } ``` ### Explanation Creating such a `str` would result in undefined behavior as per documentation for `std::str::from_utf8_unchecked` and `std::str::from_utf8_unchecked_mut`. ## `invalid_from_utf8` (warn-by-default) The `invalid_from_utf8` lint checks for calls to `std::str::from_utf8` and `std::str::from_utf8_mut` with an invalid UTF-8 literal. ### Example ```rust std::str::from_utf8(b"ru\x82st"); ``` ### Explanation Trying to create such a `str` would always return an error as per documentation for `std::str::from_utf8` and `std::str::from_utf8_mut`. ----- Mostly followed the instructions for uplifting a clippy lint described here: #99696 (review) ``@rustbot`` label: +I-lang-nominated r? compiler ----- For Clippy: changelog: Moves: Uplifted `clippy::invalid_utf8_in_unchecked` into rustc
2 parents ccffdd7 + b84c190 commit 983148a

File tree

19 files changed

+423
-168
lines changed

19 files changed

+423
-168
lines changed
 

‎compiler/rustc_lint/messages.ftl

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,14 @@ lint_improper_ctypes_union_layout_help = consider adding a `#[repr(C)]` or `#[re
304304
lint_improper_ctypes_union_layout_reason = this union has unspecified layout
305305
lint_improper_ctypes_union_non_exhaustive = this union is non-exhaustive
306306
307+
# FIXME: we should ordinalize $valid_up_to when we add support for doing so
308+
lint_invalid_from_utf8_checked = calls to `{$method}` with a invalid literal always return an error
309+
.label = the literal was valid UTF-8 up to the {$valid_up_to} bytes
310+
311+
# FIXME: we should ordinalize $valid_up_to when we add support for doing so
312+
lint_invalid_from_utf8_unchecked = calls to `{$method}` with a invalid literal are undefined behavior
313+
.label = the literal was valid UTF-8 up to the {$valid_up_to} bytes
314+
307315
lint_lintpass_by_hand = implementing `LintPass` by hand
308316
.help = try using `declare_lint_pass!` or `impl_lint_pass!` instead
309317

‎compiler/rustc_lint/src/invalid_from_utf8.rs

Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
use std::str::Utf8Error;
2+
3+
use rustc_ast::{BorrowKind, LitKind};
4+
use rustc_hir::{Expr, ExprKind};
5+
use rustc_span::source_map::Spanned;
6+
use rustc_span::sym;
7+
8+
use crate::lints::InvalidFromUtf8Diag;
9+
use crate::{LateContext, LateLintPass, LintContext};
10+
11+
declare_lint! {
12+
/// The `invalid_from_utf8_unchecked` lint checks for calls to
13+
/// `std::str::from_utf8_unchecked` and `std::str::from_utf8_unchecked_mut`
14+
/// with an invalid UTF-8 literal.
15+
///
16+
/// ### Example
17+
///
18+
/// ```rust,compile_fail
19+
/// # #[allow(unused)]
20+
/// unsafe {
21+
/// std::str::from_utf8_unchecked(b"Ru\x82st");
22+
/// }
23+
/// ```
24+
///
25+
/// {{produces}}
26+
///
27+
/// ### Explanation
28+
///
29+
/// Creating such a `str` would result in undefined behavior as per documentation
30+
/// for `std::str::from_utf8_unchecked` and `std::str::from_utf8_unchecked_mut`.
31+
pub INVALID_FROM_UTF8_UNCHECKED,
32+
Deny,
33+
"using a non UTF-8 literal in `std::str::from_utf8_unchecked`"
34+
}
35+
36+
declare_lint! {
37+
/// The `invalid_from_utf8` lint checks for calls to
38+
/// `std::str::from_utf8` and `std::str::from_utf8_mut`
39+
/// with an invalid UTF-8 literal.
40+
///
41+
/// ### Example
42+
///
43+
/// ```rust
44+
/// # #[allow(unused)]
45+
/// std::str::from_utf8(b"Ru\x82st");
46+
/// ```
47+
///
48+
/// {{produces}}
49+
///
50+
/// ### Explanation
51+
///
52+
/// Trying to create such a `str` would always return an error as per documentation
53+
/// for `std::str::from_utf8` and `std::str::from_utf8_mut`.
54+
pub INVALID_FROM_UTF8,
55+
Warn,
56+
"using a non UTF-8 literal in `std::str::from_utf8`"
57+
}
58+
59+
declare_lint_pass!(InvalidFromUtf8 => [INVALID_FROM_UTF8_UNCHECKED, INVALID_FROM_UTF8]);
60+
61+
impl<'tcx> LateLintPass<'tcx> for InvalidFromUtf8 {
62+
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) {
63+
if let ExprKind::Call(path, [arg]) = expr.kind
64+
&& let ExprKind::Path(ref qpath) = path.kind
65+
&& let Some(def_id) = cx.qpath_res(qpath, path.hir_id).opt_def_id()
66+
&& let Some(diag_item) = cx.tcx.get_diagnostic_name(def_id)
67+
&& [sym::str_from_utf8, sym::str_from_utf8_mut,
68+
sym::str_from_utf8_unchecked, sym::str_from_utf8_unchecked_mut].contains(&diag_item)
69+
{
70+
let lint = |utf8_error: Utf8Error| {
71+
let label = arg.span;
72+
let method = diag_item.as_str().strip_prefix("str_").unwrap();
73+
let method = format!("std::str::{method}");
74+
let valid_up_to = utf8_error.valid_up_to();
75+
let is_unchecked_variant = diag_item.as_str().contains("unchecked");
76+
77+
cx.emit_spanned_lint(
78+
if is_unchecked_variant { INVALID_FROM_UTF8_UNCHECKED } else { INVALID_FROM_UTF8 },
79+
expr.span,
80+
if is_unchecked_variant {
81+
InvalidFromUtf8Diag::Unchecked { method, valid_up_to, label }
82+
} else {
83+
InvalidFromUtf8Diag::Checked { method, valid_up_to, label }
84+
}
85+
)
86+
};
87+
88+
match &arg.kind {
89+
ExprKind::Lit(Spanned { node: lit, .. }) => {
90+
if let LitKind::ByteStr(bytes, _) = &lit
91+
&& let Err(utf8_error) = std::str::from_utf8(bytes)
92+
{
93+
lint(utf8_error);
94+
}
95+
},
96+
ExprKind::AddrOf(BorrowKind::Ref, _, Expr { kind: ExprKind::Array(args), .. }) => {
97+
let elements = args.iter().map(|e|{
98+
match &e.kind {
99+
ExprKind::Lit(Spanned { node: lit, .. }) => match lit {
100+
LitKind::Byte(b) => Some(*b),
101+
LitKind::Int(b, _) => Some(*b as u8),
102+
_ => None
103+
}
104+
_ => None
105+
}
106+
}).collect::<Option<Vec<_>>>();
107+
108+
if let Some(elements) = elements
109+
&& let Err(utf8_error) = std::str::from_utf8(&elements)
110+
{
111+
lint(utf8_error);
112+
}
113+
}
114+
_ => {}
115+
}
116+
}
117+
}
118+
}

‎compiler/rustc_lint/src/lib.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ mod expect;
6060
mod for_loops_over_fallibles;
6161
pub mod hidden_unicode_codepoints;
6262
mod internal;
63+
mod invalid_from_utf8;
6364
mod late;
6465
mod let_underscore;
6566
mod levels;
@@ -102,6 +103,7 @@ use enum_intrinsics_non_enums::EnumIntrinsicsNonEnums;
102103
use for_loops_over_fallibles::*;
103104
use hidden_unicode_codepoints::*;
104105
use internal::*;
106+
use invalid_from_utf8::*;
105107
use let_underscore::*;
106108
use map_unit_fn::*;
107109
use methods::*;
@@ -207,6 +209,7 @@ late_lint_methods!(
207209
HardwiredLints: HardwiredLints,
208210
ImproperCTypesDeclarations: ImproperCTypesDeclarations,
209211
ImproperCTypesDefinitions: ImproperCTypesDefinitions,
212+
InvalidFromUtf8: InvalidFromUtf8,
210213
VariantSizeDifferences: VariantSizeDifferences,
211214
BoxPointers: BoxPointers,
212215
PathStatements: PathStatements,

‎compiler/rustc_lint/src/lints.rs

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -699,6 +699,25 @@ pub struct ForgetCopyDiag<'a> {
699699
pub label: Span,
700700
}
701701

702+
// invalid_from_utf8.rs
703+
#[derive(LintDiagnostic)]
704+
pub enum InvalidFromUtf8Diag {
705+
#[diag(lint_invalid_from_utf8_unchecked)]
706+
Unchecked {
707+
method: String,
708+
valid_up_to: usize,
709+
#[label]
710+
label: Span,
711+
},
712+
#[diag(lint_invalid_from_utf8_checked)]
713+
Checked {
714+
method: String,
715+
valid_up_to: usize,
716+
#[label]
717+
label: Span,
718+
},
719+
}
720+
702721
// hidden_unicode_codepoints.rs
703722
#[derive(LintDiagnostic)]
704723
#[diag(lint_hidden_unicode_codepoints)]

‎compiler/rustc_span/src/symbol.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1454,6 +1454,10 @@ symbols! {
14541454
stop_after_dataflow,
14551455
store,
14561456
str,
1457+
str_from_utf8,
1458+
str_from_utf8_mut,
1459+
str_from_utf8_unchecked,
1460+
str_from_utf8_unchecked_mut,
14571461
str_split_whitespace,
14581462
str_trim,
14591463
str_trim_end,

‎library/alloc/tests/str.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
#![cfg_attr(not(bootstrap), allow(invalid_from_utf8))]
2+
13
use std::assert_matches::assert_matches;
24
use std::borrow::Cow;
35
use std::cmp::Ordering::{Equal, Greater, Less};

‎library/core/src/str/converts.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ use super::Utf8Error;
8484
#[stable(feature = "rust1", since = "1.0.0")]
8585
#[rustc_const_stable(feature = "const_str_from_utf8_shared", since = "1.63.0")]
8686
#[rustc_allow_const_fn_unstable(str_internals)]
87+
#[rustc_diagnostic_item = "str_from_utf8"]
8788
pub const fn from_utf8(v: &[u8]) -> Result<&str, Utf8Error> {
8889
// FIXME: This should use `?` again, once it's `const`
8990
match run_utf8_validation(v) {
@@ -127,6 +128,7 @@ pub const fn from_utf8(v: &[u8]) -> Result<&str, Utf8Error> {
127128
/// errors that can be returned.
128129
#[stable(feature = "str_mut_extras", since = "1.20.0")]
129130
#[rustc_const_unstable(feature = "const_str_from_utf8", issue = "91006")]
131+
#[rustc_diagnostic_item = "str_from_utf8_mut"]
130132
pub const fn from_utf8_mut(v: &mut [u8]) -> Result<&mut str, Utf8Error> {
131133
// This should use `?` again, once it's `const`
132134
match run_utf8_validation(v) {
@@ -167,6 +169,7 @@ pub const fn from_utf8_mut(v: &mut [u8]) -> Result<&mut str, Utf8Error> {
167169
#[must_use]
168170
#[stable(feature = "rust1", since = "1.0.0")]
169171
#[rustc_const_stable(feature = "const_str_from_utf8_unchecked", since = "1.55.0")]
172+
#[rustc_diagnostic_item = "str_from_utf8_unchecked"]
170173
pub const unsafe fn from_utf8_unchecked(v: &[u8]) -> &str {
171174
// SAFETY: the caller must guarantee that the bytes `v` are valid UTF-8.
172175
// Also relies on `&str` and `&[u8]` having the same layout.
@@ -194,6 +197,7 @@ pub const unsafe fn from_utf8_unchecked(v: &[u8]) -> &str {
194197
#[must_use]
195198
#[stable(feature = "str_mut_extras", since = "1.20.0")]
196199
#[rustc_const_unstable(feature = "const_str_from_utf8_unchecked_mut", issue = "91005")]
200+
#[rustc_diagnostic_item = "str_from_utf8_unchecked_mut"]
197201
pub const unsafe fn from_utf8_unchecked_mut(v: &mut [u8]) -> &mut str {
198202
// SAFETY: the caller must guarantee that the bytes `v`
199203
// are valid UTF-8, thus the cast to `*mut str` is safe.

‎src/tools/clippy/clippy_lints/src/declared_lints.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ pub(crate) static LINTS: &[&crate::LintInfo] = &[
212212
crate::instant_subtraction::UNCHECKED_DURATION_SUBTRACTION_INFO,
213213
crate::int_plus_one::INT_PLUS_ONE_INFO,
214214
crate::invalid_upcast_comparisons::INVALID_UPCAST_COMPARISONS_INFO,
215-
crate::invalid_utf8_in_unchecked::INVALID_UTF8_IN_UNCHECKED_INFO,
216215
crate::items_after_statements::ITEMS_AFTER_STATEMENTS_INFO,
217216
crate::items_after_test_module::ITEMS_AFTER_TEST_MODULE_INFO,
218217
crate::iter_not_returning_iterator::ITER_NOT_RETURNING_ITERATOR_INFO,

‎src/tools/clippy/clippy_lints/src/invalid_utf8_in_unchecked.rs

Lines changed: 0 additions & 74 deletions
This file was deleted.

‎src/tools/clippy/clippy_lints/src/lib.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ mod inline_fn_without_body;
157157
mod instant_subtraction;
158158
mod int_plus_one;
159159
mod invalid_upcast_comparisons;
160-
mod invalid_utf8_in_unchecked;
161160
mod items_after_statements;
162161
mod items_after_test_module;
163162
mod iter_not_returning_iterator;
@@ -937,7 +936,6 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
937936
store.register_late_pass(move |_| Box::new(manual_retain::ManualRetain::new(msrv())));
938937
let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
939938
store.register_late_pass(move |_| Box::new(operators::Operators::new(verbose_bit_mask_threshold)));
940-
store.register_late_pass(|_| Box::new(invalid_utf8_in_unchecked::InvalidUtf8InUnchecked));
941939
store.register_late_pass(|_| Box::<std_instead_of_core::StdReexports>::default());
942940
store.register_late_pass(move |_| Box::new(instant_subtraction::InstantSubtraction::new(msrv())));
943941
store.register_late_pass(|_| Box::new(partialeq_to_none::PartialeqToNone));

‎src/tools/clippy/clippy_lints/src/renamed_lints.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ pub static RENAMED_LINTS: &[(&str, &str)] = &[
4343
("clippy::into_iter_on_array", "array_into_iter"),
4444
("clippy::invalid_atomic_ordering", "invalid_atomic_ordering"),
4545
("clippy::invalid_ref", "invalid_value"),
46+
("clippy::invalid_utf8_in_unchecked", "invalid_from_utf8_unchecked"),
4647
("clippy::let_underscore_drop", "let_underscore_drop"),
4748
("clippy::mem_discriminant_non_enum", "enum_intrinsics_non_enums"),
4849
("clippy::panic_params", "non_fmt_panics"),

‎src/tools/clippy/tests/ui/invalid_utf8_in_unchecked.rs

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎src/tools/clippy/tests/ui/invalid_utf8_in_unchecked.stderr

Lines changed: 0 additions & 22 deletions
This file was deleted.

‎src/tools/clippy/tests/ui/rename.fixed

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
#![allow(array_into_iter)]
3939
#![allow(invalid_atomic_ordering)]
4040
#![allow(invalid_value)]
41+
#![allow(invalid_from_utf8_unchecked)]
4142
#![allow(let_underscore_drop)]
4243
#![allow(enum_intrinsics_non_enums)]
4344
#![allow(non_fmt_panics)]
@@ -87,6 +88,7 @@
8788
#![warn(array_into_iter)]
8889
#![warn(invalid_atomic_ordering)]
8990
#![warn(invalid_value)]
91+
#![warn(invalid_from_utf8_unchecked)]
9092
#![warn(let_underscore_drop)]
9193
#![warn(enum_intrinsics_non_enums)]
9294
#![warn(non_fmt_panics)]

‎src/tools/clippy/tests/ui/rename.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
#![allow(array_into_iter)]
3939
#![allow(invalid_atomic_ordering)]
4040
#![allow(invalid_value)]
41+
#![allow(invalid_from_utf8_unchecked)]
4142
#![allow(let_underscore_drop)]
4243
#![allow(enum_intrinsics_non_enums)]
4344
#![allow(non_fmt_panics)]
@@ -87,6 +88,7 @@
8788
#![warn(clippy::into_iter_on_array)]
8889
#![warn(clippy::invalid_atomic_ordering)]
8990
#![warn(clippy::invalid_ref)]
91+
#![warn(clippy::invalid_utf8_in_unchecked)]
9092
#![warn(clippy::let_underscore_drop)]
9193
#![warn(clippy::mem_discriminant_non_enum)]
9294
#![warn(clippy::panic_params)]

‎src/tools/clippy/tests/ui/rename.stderr

Lines changed: 55 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -1,292 +1,298 @@
11
error: lint `clippy::almost_complete_letter_range` has been renamed to `clippy::almost_complete_range`
2-
--> $DIR/rename.rs:49:9
2+
--> $DIR/rename.rs:50:9
33
|
44
LL | #![warn(clippy::almost_complete_letter_range)]
55
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::almost_complete_range`
66
|
77
= note: `-D renamed-and-removed-lints` implied by `-D warnings`
88

99
error: lint `clippy::blacklisted_name` has been renamed to `clippy::disallowed_names`
10-
--> $DIR/rename.rs:50:9
10+
--> $DIR/rename.rs:51:9
1111
|
1212
LL | #![warn(clippy::blacklisted_name)]
1313
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::disallowed_names`
1414

1515
error: lint `clippy::block_in_if_condition_expr` has been renamed to `clippy::blocks_in_if_conditions`
16-
--> $DIR/rename.rs:51:9
16+
--> $DIR/rename.rs:52:9
1717
|
1818
LL | #![warn(clippy::block_in_if_condition_expr)]
1919
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::blocks_in_if_conditions`
2020

2121
error: lint `clippy::block_in_if_condition_stmt` has been renamed to `clippy::blocks_in_if_conditions`
22-
--> $DIR/rename.rs:52:9
22+
--> $DIR/rename.rs:53:9
2323
|
2424
LL | #![warn(clippy::block_in_if_condition_stmt)]
2525
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::blocks_in_if_conditions`
2626

2727
error: lint `clippy::box_vec` has been renamed to `clippy::box_collection`
28-
--> $DIR/rename.rs:53:9
28+
--> $DIR/rename.rs:54:9
2929
|
3030
LL | #![warn(clippy::box_vec)]
3131
| ^^^^^^^^^^^^^^^ help: use the new name: `clippy::box_collection`
3232

3333
error: lint `clippy::const_static_lifetime` has been renamed to `clippy::redundant_static_lifetimes`
34-
--> $DIR/rename.rs:54:9
34+
--> $DIR/rename.rs:55:9
3535
|
3636
LL | #![warn(clippy::const_static_lifetime)]
3737
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::redundant_static_lifetimes`
3838

3939
error: lint `clippy::cyclomatic_complexity` has been renamed to `clippy::cognitive_complexity`
40-
--> $DIR/rename.rs:55:9
40+
--> $DIR/rename.rs:56:9
4141
|
4242
LL | #![warn(clippy::cyclomatic_complexity)]
4343
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::cognitive_complexity`
4444

4545
error: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`
46-
--> $DIR/rename.rs:56:9
46+
--> $DIR/rename.rs:57:9
4747
|
4848
LL | #![warn(clippy::derive_hash_xor_eq)]
4949
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq`
5050

5151
error: lint `clippy::disallowed_method` has been renamed to `clippy::disallowed_methods`
52-
--> $DIR/rename.rs:57:9
52+
--> $DIR/rename.rs:58:9
5353
|
5454
LL | #![warn(clippy::disallowed_method)]
5555
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::disallowed_methods`
5656

5757
error: lint `clippy::disallowed_type` has been renamed to `clippy::disallowed_types`
58-
--> $DIR/rename.rs:58:9
58+
--> $DIR/rename.rs:59:9
5959
|
6060
LL | #![warn(clippy::disallowed_type)]
6161
| ^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::disallowed_types`
6262

6363
error: lint `clippy::eval_order_dependence` has been renamed to `clippy::mixed_read_write_in_expression`
64-
--> $DIR/rename.rs:59:9
64+
--> $DIR/rename.rs:60:9
6565
|
6666
LL | #![warn(clippy::eval_order_dependence)]
6767
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::mixed_read_write_in_expression`
6868

6969
error: lint `clippy::identity_conversion` has been renamed to `clippy::useless_conversion`
70-
--> $DIR/rename.rs:60:9
70+
--> $DIR/rename.rs:61:9
7171
|
7272
LL | #![warn(clippy::identity_conversion)]
7373
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::useless_conversion`
7474

7575
error: lint `clippy::if_let_some_result` has been renamed to `clippy::match_result_ok`
76-
--> $DIR/rename.rs:61:9
76+
--> $DIR/rename.rs:62:9
7777
|
7878
LL | #![warn(clippy::if_let_some_result)]
7979
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::match_result_ok`
8080

8181
error: lint `clippy::integer_arithmetic` has been renamed to `clippy::arithmetic_side_effects`
82-
--> $DIR/rename.rs:62:9
82+
--> $DIR/rename.rs:63:9
8383
|
8484
LL | #![warn(clippy::integer_arithmetic)]
8585
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::arithmetic_side_effects`
8686

8787
error: lint `clippy::logic_bug` has been renamed to `clippy::overly_complex_bool_expr`
88-
--> $DIR/rename.rs:63:9
88+
--> $DIR/rename.rs:64:9
8989
|
9090
LL | #![warn(clippy::logic_bug)]
9191
| ^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::overly_complex_bool_expr`
9292

9393
error: lint `clippy::new_without_default_derive` has been renamed to `clippy::new_without_default`
94-
--> $DIR/rename.rs:64:9
94+
--> $DIR/rename.rs:65:9
9595
|
9696
LL | #![warn(clippy::new_without_default_derive)]
9797
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::new_without_default`
9898

9999
error: lint `clippy::option_and_then_some` has been renamed to `clippy::bind_instead_of_map`
100-
--> $DIR/rename.rs:65:9
100+
--> $DIR/rename.rs:66:9
101101
|
102102
LL | #![warn(clippy::option_and_then_some)]
103103
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::bind_instead_of_map`
104104

105105
error: lint `clippy::option_expect_used` has been renamed to `clippy::expect_used`
106-
--> $DIR/rename.rs:66:9
106+
--> $DIR/rename.rs:67:9
107107
|
108108
LL | #![warn(clippy::option_expect_used)]
109109
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::expect_used`
110110

111111
error: lint `clippy::option_map_unwrap_or` has been renamed to `clippy::map_unwrap_or`
112-
--> $DIR/rename.rs:67:9
112+
--> $DIR/rename.rs:68:9
113113
|
114114
LL | #![warn(clippy::option_map_unwrap_or)]
115115
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::map_unwrap_or`
116116

117117
error: lint `clippy::option_map_unwrap_or_else` has been renamed to `clippy::map_unwrap_or`
118-
--> $DIR/rename.rs:68:9
118+
--> $DIR/rename.rs:69:9
119119
|
120120
LL | #![warn(clippy::option_map_unwrap_or_else)]
121121
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::map_unwrap_or`
122122

123123
error: lint `clippy::option_unwrap_used` has been renamed to `clippy::unwrap_used`
124-
--> $DIR/rename.rs:69:9
124+
--> $DIR/rename.rs:70:9
125125
|
126126
LL | #![warn(clippy::option_unwrap_used)]
127127
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::unwrap_used`
128128

129129
error: lint `clippy::ref_in_deref` has been renamed to `clippy::needless_borrow`
130-
--> $DIR/rename.rs:70:9
130+
--> $DIR/rename.rs:71:9
131131
|
132132
LL | #![warn(clippy::ref_in_deref)]
133133
| ^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::needless_borrow`
134134

135135
error: lint `clippy::result_expect_used` has been renamed to `clippy::expect_used`
136-
--> $DIR/rename.rs:71:9
136+
--> $DIR/rename.rs:72:9
137137
|
138138
LL | #![warn(clippy::result_expect_used)]
139139
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::expect_used`
140140

141141
error: lint `clippy::result_map_unwrap_or_else` has been renamed to `clippy::map_unwrap_or`
142-
--> $DIR/rename.rs:72:9
142+
--> $DIR/rename.rs:73:9
143143
|
144144
LL | #![warn(clippy::result_map_unwrap_or_else)]
145145
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::map_unwrap_or`
146146

147147
error: lint `clippy::result_unwrap_used` has been renamed to `clippy::unwrap_used`
148-
--> $DIR/rename.rs:73:9
148+
--> $DIR/rename.rs:74:9
149149
|
150150
LL | #![warn(clippy::result_unwrap_used)]
151151
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::unwrap_used`
152152

153153
error: lint `clippy::single_char_push_str` has been renamed to `clippy::single_char_add_str`
154-
--> $DIR/rename.rs:74:9
154+
--> $DIR/rename.rs:75:9
155155
|
156156
LL | #![warn(clippy::single_char_push_str)]
157157
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::single_char_add_str`
158158

159159
error: lint `clippy::stutter` has been renamed to `clippy::module_name_repetitions`
160-
--> $DIR/rename.rs:75:9
160+
--> $DIR/rename.rs:76:9
161161
|
162162
LL | #![warn(clippy::stutter)]
163163
| ^^^^^^^^^^^^^^^ help: use the new name: `clippy::module_name_repetitions`
164164

165165
error: lint `clippy::to_string_in_display` has been renamed to `clippy::recursive_format_impl`
166-
--> $DIR/rename.rs:76:9
166+
--> $DIR/rename.rs:77:9
167167
|
168168
LL | #![warn(clippy::to_string_in_display)]
169169
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::recursive_format_impl`
170170

171171
error: lint `clippy::zero_width_space` has been renamed to `clippy::invisible_characters`
172-
--> $DIR/rename.rs:77:9
172+
--> $DIR/rename.rs:78:9
173173
|
174174
LL | #![warn(clippy::zero_width_space)]
175175
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::invisible_characters`
176176

177177
error: lint `clippy::clone_double_ref` has been renamed to `suspicious_double_ref_op`
178-
--> $DIR/rename.rs:78:9
178+
--> $DIR/rename.rs:79:9
179179
|
180180
LL | #![warn(clippy::clone_double_ref)]
181181
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `suspicious_double_ref_op`
182182

183183
error: lint `clippy::drop_bounds` has been renamed to `drop_bounds`
184-
--> $DIR/rename.rs:79:9
184+
--> $DIR/rename.rs:80:9
185185
|
186186
LL | #![warn(clippy::drop_bounds)]
187187
| ^^^^^^^^^^^^^^^^^^^ help: use the new name: `drop_bounds`
188188

189189
error: lint `clippy::drop_copy` has been renamed to `dropping_copy_types`
190-
--> $DIR/rename.rs:80:9
190+
--> $DIR/rename.rs:81:9
191191
|
192192
LL | #![warn(clippy::drop_copy)]
193193
| ^^^^^^^^^^^^^^^^^ help: use the new name: `dropping_copy_types`
194194

195195
error: lint `clippy::drop_ref` has been renamed to `dropping_references`
196-
--> $DIR/rename.rs:81:9
196+
--> $DIR/rename.rs:82:9
197197
|
198198
LL | #![warn(clippy::drop_ref)]
199199
| ^^^^^^^^^^^^^^^^ help: use the new name: `dropping_references`
200200

201201
error: lint `clippy::for_loop_over_option` has been renamed to `for_loops_over_fallibles`
202-
--> $DIR/rename.rs:82:9
202+
--> $DIR/rename.rs:83:9
203203
|
204204
LL | #![warn(clippy::for_loop_over_option)]
205205
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `for_loops_over_fallibles`
206206

207207
error: lint `clippy::for_loop_over_result` has been renamed to `for_loops_over_fallibles`
208-
--> $DIR/rename.rs:83:9
208+
--> $DIR/rename.rs:84:9
209209
|
210210
LL | #![warn(clippy::for_loop_over_result)]
211211
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `for_loops_over_fallibles`
212212

213213
error: lint `clippy::for_loops_over_fallibles` has been renamed to `for_loops_over_fallibles`
214-
--> $DIR/rename.rs:84:9
214+
--> $DIR/rename.rs:85:9
215215
|
216216
LL | #![warn(clippy::for_loops_over_fallibles)]
217217
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `for_loops_over_fallibles`
218218

219219
error: lint `clippy::forget_copy` has been renamed to `forgetting_copy_types`
220-
--> $DIR/rename.rs:85:9
220+
--> $DIR/rename.rs:86:9
221221
|
222222
LL | #![warn(clippy::forget_copy)]
223223
| ^^^^^^^^^^^^^^^^^^^ help: use the new name: `forgetting_copy_types`
224224

225225
error: lint `clippy::forget_ref` has been renamed to `forgetting_references`
226-
--> $DIR/rename.rs:86:9
226+
--> $DIR/rename.rs:87:9
227227
|
228228
LL | #![warn(clippy::forget_ref)]
229229
| ^^^^^^^^^^^^^^^^^^ help: use the new name: `forgetting_references`
230230

231231
error: lint `clippy::into_iter_on_array` has been renamed to `array_into_iter`
232-
--> $DIR/rename.rs:87:9
232+
--> $DIR/rename.rs:88:9
233233
|
234234
LL | #![warn(clippy::into_iter_on_array)]
235235
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `array_into_iter`
236236

237237
error: lint `clippy::invalid_atomic_ordering` has been renamed to `invalid_atomic_ordering`
238-
--> $DIR/rename.rs:88:9
238+
--> $DIR/rename.rs:89:9
239239
|
240240
LL | #![warn(clippy::invalid_atomic_ordering)]
241241
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `invalid_atomic_ordering`
242242

243243
error: lint `clippy::invalid_ref` has been renamed to `invalid_value`
244-
--> $DIR/rename.rs:89:9
244+
--> $DIR/rename.rs:90:9
245245
|
246246
LL | #![warn(clippy::invalid_ref)]
247247
| ^^^^^^^^^^^^^^^^^^^ help: use the new name: `invalid_value`
248248

249+
error: lint `clippy::invalid_utf8_in_unchecked` has been renamed to `invalid_from_utf8_unchecked`
250+
--> $DIR/rename.rs:91:9
251+
|
252+
LL | #![warn(clippy::invalid_utf8_in_unchecked)]
253+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `invalid_from_utf8_unchecked`
254+
249255
error: lint `clippy::let_underscore_drop` has been renamed to `let_underscore_drop`
250-
--> $DIR/rename.rs:90:9
256+
--> $DIR/rename.rs:92:9
251257
|
252258
LL | #![warn(clippy::let_underscore_drop)]
253259
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `let_underscore_drop`
254260

255261
error: lint `clippy::mem_discriminant_non_enum` has been renamed to `enum_intrinsics_non_enums`
256-
--> $DIR/rename.rs:91:9
262+
--> $DIR/rename.rs:93:9
257263
|
258264
LL | #![warn(clippy::mem_discriminant_non_enum)]
259265
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `enum_intrinsics_non_enums`
260266

261267
error: lint `clippy::panic_params` has been renamed to `non_fmt_panics`
262-
--> $DIR/rename.rs:92:9
268+
--> $DIR/rename.rs:94:9
263269
|
264270
LL | #![warn(clippy::panic_params)]
265271
| ^^^^^^^^^^^^^^^^^^^^ help: use the new name: `non_fmt_panics`
266272

267273
error: lint `clippy::positional_named_format_parameters` has been renamed to `named_arguments_used_positionally`
268-
--> $DIR/rename.rs:93:9
274+
--> $DIR/rename.rs:95:9
269275
|
270276
LL | #![warn(clippy::positional_named_format_parameters)]
271277
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `named_arguments_used_positionally`
272278

273279
error: lint `clippy::temporary_cstring_as_ptr` has been renamed to `temporary_cstring_as_ptr`
274-
--> $DIR/rename.rs:94:9
280+
--> $DIR/rename.rs:96:9
275281
|
276282
LL | #![warn(clippy::temporary_cstring_as_ptr)]
277283
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `temporary_cstring_as_ptr`
278284

279285
error: lint `clippy::unknown_clippy_lints` has been renamed to `unknown_lints`
280-
--> $DIR/rename.rs:95:9
286+
--> $DIR/rename.rs:97:9
281287
|
282288
LL | #![warn(clippy::unknown_clippy_lints)]
283289
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `unknown_lints`
284290

285291
error: lint `clippy::unused_label` has been renamed to `unused_labels`
286-
--> $DIR/rename.rs:96:9
292+
--> $DIR/rename.rs:98:9
287293
|
288294
LL | #![warn(clippy::unused_label)]
289295
| ^^^^^^^^^^^^^^^^^^^^ help: use the new name: `unused_labels`
290296

291-
error: aborting due to 48 previous errors
297+
error: aborting due to 49 previous errors
292298

‎tests/ui/lint/invalid_from_utf8.rs

Lines changed: 93 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,93 @@
1+
// check-pass
2+
3+
#![feature(concat_bytes)]
4+
#![warn(invalid_from_utf8_unchecked)]
5+
#![warn(invalid_from_utf8)]
6+
7+
pub fn from_utf8_unchecked_mut() {
8+
// Valid
9+
unsafe {
10+
std::str::from_utf8_unchecked_mut(&mut [99, 108, 105, 112, 112, 121]);
11+
std::str::from_utf8_unchecked_mut(&mut [b'c', b'l', b'i', b'p', b'p', b'y']);
12+
13+
let x = 0xA0;
14+
std::str::from_utf8_unchecked_mut(&mut [0xC0, x]);
15+
}
16+
17+
// Invalid
18+
unsafe {
19+
std::str::from_utf8_unchecked_mut(&mut [99, 108, 130, 105, 112, 112, 121]);
20+
//~^ WARN calls to `std::str::from_utf8_unchecked_mut`
21+
std::str::from_utf8_unchecked_mut(&mut [b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']);
22+
//~^ WARN calls to `std::str::from_utf8_unchecked_mut`
23+
}
24+
}
25+
26+
pub fn from_utf8_unchecked() {
27+
// Valid
28+
unsafe {
29+
std::str::from_utf8_unchecked(&[99, 108, 105, 112, 112, 121]);
30+
std::str::from_utf8_unchecked(&[b'c', b'l', b'i', b'p', b'p', b'y']);
31+
std::str::from_utf8_unchecked(b"clippy");
32+
33+
let x = 0xA0;
34+
std::str::from_utf8_unchecked(&[0xC0, x]);
35+
}
36+
37+
// Invalid
38+
unsafe {
39+
std::str::from_utf8_unchecked(&[99, 108, 130, 105, 112, 112, 121]);
40+
//~^ WARN calls to `std::str::from_utf8_unchecked`
41+
std::str::from_utf8_unchecked(&[b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']);
42+
//~^ WARN calls to `std::str::from_utf8_unchecked`
43+
std::str::from_utf8_unchecked(b"cl\x82ippy");
44+
//~^ WARN calls to `std::str::from_utf8_unchecked`
45+
std::str::from_utf8_unchecked(concat_bytes!(b"cl", b"\x82ippy"));
46+
//~^ WARN calls to `std::str::from_utf8_unchecked`
47+
}
48+
}
49+
50+
pub fn from_utf8_mut() {
51+
// Valid
52+
{
53+
std::str::from_utf8_mut(&mut [99, 108, 105, 112, 112, 121]);
54+
std::str::from_utf8_mut(&mut [b'c', b'l', b'i', b'p', b'p', b'y']);
55+
56+
let x = 0xa0;
57+
std::str::from_utf8_mut(&mut [0xc0, x]);
58+
}
59+
60+
// Invalid
61+
{
62+
std::str::from_utf8_mut(&mut [99, 108, 130, 105, 112, 112, 121]);
63+
//~^ WARN calls to `std::str::from_utf8_mut`
64+
std::str::from_utf8_mut(&mut [b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']);
65+
//~^ WARN calls to `std::str::from_utf8_mut`
66+
}
67+
}
68+
69+
pub fn from_utf8() {
70+
// Valid
71+
{
72+
std::str::from_utf8(&[99, 108, 105, 112, 112, 121]);
73+
std::str::from_utf8(&[b'c', b'l', b'i', b'p', b'p', b'y']);
74+
std::str::from_utf8(b"clippy");
75+
76+
let x = 0xA0;
77+
std::str::from_utf8(&[0xC0, x]);
78+
}
79+
80+
// Invalid
81+
{
82+
std::str::from_utf8(&[99, 108, 130, 105, 112, 112, 121]);
83+
//~^ WARN calls to `std::str::from_utf8`
84+
std::str::from_utf8(&[b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']);
85+
//~^ WARN calls to `std::str::from_utf8`
86+
std::str::from_utf8(b"cl\x82ippy");
87+
//~^ WARN calls to `std::str::from_utf8`
88+
std::str::from_utf8(concat_bytes!(b"cl", b"\x82ippy"));
89+
//~^ WARN calls to `std::str::from_utf8`
90+
}
91+
}
92+
93+
fn main() {}

‎tests/ui/lint/invalid_from_utf8.stderr

Lines changed: 110 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,110 @@
1+
warning: calls to `std::str::from_utf8_unchecked_mut` with a invalid literal are undefined behavior
2+
--> $DIR/invalid_from_utf8.rs:19:9
3+
|
4+
LL | std::str::from_utf8_unchecked_mut(&mut [99, 108, 130, 105, 112, 112, 121]);
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------^
6+
| |
7+
| the literal was valid UTF-8 up to the 2 bytes
8+
|
9+
note: the lint level is defined here
10+
--> $DIR/invalid_from_utf8.rs:4:9
11+
|
12+
LL | #![warn(invalid_from_utf8_unchecked)]
13+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
14+
15+
warning: calls to `std::str::from_utf8_unchecked_mut` with a invalid literal are undefined behavior
16+
--> $DIR/invalid_from_utf8.rs:21:9
17+
|
18+
LL | std::str::from_utf8_unchecked_mut(&mut [b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']);
19+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------------^
20+
| |
21+
| the literal was valid UTF-8 up to the 2 bytes
22+
23+
warning: calls to `std::str::from_utf8_unchecked` with a invalid literal are undefined behavior
24+
--> $DIR/invalid_from_utf8.rs:39:9
25+
|
26+
LL | std::str::from_utf8_unchecked(&[99, 108, 130, 105, 112, 112, 121]);
27+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-----------------------------------^
28+
| |
29+
| the literal was valid UTF-8 up to the 2 bytes
30+
31+
warning: calls to `std::str::from_utf8_unchecked` with a invalid literal are undefined behavior
32+
--> $DIR/invalid_from_utf8.rs:41:9
33+
|
34+
LL | std::str::from_utf8_unchecked(&[b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']);
35+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------------------------^
36+
| |
37+
| the literal was valid UTF-8 up to the 2 bytes
38+
39+
warning: calls to `std::str::from_utf8_unchecked` with a invalid literal are undefined behavior
40+
--> $DIR/invalid_from_utf8.rs:43:9
41+
|
42+
LL | std::str::from_utf8_unchecked(b"cl\x82ippy");
43+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------^
44+
| |
45+
| the literal was valid UTF-8 up to the 2 bytes
46+
47+
warning: calls to `std::str::from_utf8_unchecked` with a invalid literal are undefined behavior
48+
--> $DIR/invalid_from_utf8.rs:45:9
49+
|
50+
LL | std::str::from_utf8_unchecked(concat_bytes!(b"cl", b"\x82ippy"));
51+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------^
52+
| |
53+
| the literal was valid UTF-8 up to the 2 bytes
54+
55+
warning: calls to `std::str::from_utf8_mut` with a invalid literal always return an error
56+
--> $DIR/invalid_from_utf8.rs:62:9
57+
|
58+
LL | std::str::from_utf8_mut(&mut [99, 108, 130, 105, 112, 112, 121]);
59+
| ^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------^
60+
| |
61+
| the literal was valid UTF-8 up to the 2 bytes
62+
|
63+
note: the lint level is defined here
64+
--> $DIR/invalid_from_utf8.rs:5:9
65+
|
66+
LL | #![warn(invalid_from_utf8)]
67+
| ^^^^^^^^^^^^^^^^^
68+
69+
warning: calls to `std::str::from_utf8_mut` with a invalid literal always return an error
70+
--> $DIR/invalid_from_utf8.rs:64:9
71+
|
72+
LL | std::str::from_utf8_mut(&mut [b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']);
73+
| ^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------------^
74+
| |
75+
| the literal was valid UTF-8 up to the 2 bytes
76+
77+
warning: calls to `std::str::from_utf8` with a invalid literal always return an error
78+
--> $DIR/invalid_from_utf8.rs:82:9
79+
|
80+
LL | std::str::from_utf8(&[99, 108, 130, 105, 112, 112, 121]);
81+
| ^^^^^^^^^^^^^^^^^^^^-----------------------------------^
82+
| |
83+
| the literal was valid UTF-8 up to the 2 bytes
84+
85+
warning: calls to `std::str::from_utf8` with a invalid literal always return an error
86+
--> $DIR/invalid_from_utf8.rs:84:9
87+
|
88+
LL | std::str::from_utf8(&[b'c', b'l', b'\x82', b'i', b'p', b'p', b'y']);
89+
| ^^^^^^^^^^^^^^^^^^^^----------------------------------------------^
90+
| |
91+
| the literal was valid UTF-8 up to the 2 bytes
92+
93+
warning: calls to `std::str::from_utf8` with a invalid literal always return an error
94+
--> $DIR/invalid_from_utf8.rs:86:9
95+
|
96+
LL | std::str::from_utf8(b"cl\x82ippy");
97+
| ^^^^^^^^^^^^^^^^^^^^-------------^
98+
| |
99+
| the literal was valid UTF-8 up to the 2 bytes
100+
101+
warning: calls to `std::str::from_utf8` with a invalid literal always return an error
102+
--> $DIR/invalid_from_utf8.rs:88:9
103+
|
104+
LL | std::str::from_utf8(concat_bytes!(b"cl", b"\x82ippy"));
105+
| ^^^^^^^^^^^^^^^^^^^^---------------------------------^
106+
| |
107+
| the literal was valid UTF-8 up to the 2 bytes
108+
109+
warning: 12 warnings emitted
110+

‎tests/ui/process/process-panic-after-fork.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
#![feature(never_type)]
1212
#![feature(panic_always_abort)]
1313

14+
#![allow(invalid_from_utf8)]
15+
1416
extern crate libc;
1517

1618
use std::alloc::{GlobalAlloc, Layout};

0 commit comments

Comments
 (0)
Please sign in to comment.