Skip to content

Commit abb6162

Browse files
committed
auto merge of #13220 : brson/rust/from_iter, r=thestinger
2 parents 6281299 + ee05219 commit abb6162

15 files changed

+22
-22
lines changed

src/doc/guide-container.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ vectors is as follows:
278278
279279
~~~ {.ignore}
280280
impl<A> FromIterator<A> for ~[A] {
281-
pub fn from_iterator<T: Iterator<A>>(iterator: &mut T) -> ~[A] {
281+
pub fn from_iter<T: Iterator<A>>(iterator: &mut T) -> ~[A] {
282282
let (lower, _) = iterator.size_hint();
283283
let mut xs = with_capacity(lower);
284284
for x in iterator {

src/libcollections/dlist.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ impl<A> DoubleEndedIterator<A> for MoveItems<A> {
582582
}
583583

584584
impl<A> FromIterator<A> for DList<A> {
585-
fn from_iterator<T: Iterator<A>>(iterator: T) -> DList<A> {
585+
fn from_iter<T: Iterator<A>>(iterator: T) -> DList<A> {
586586
let mut ret = DList::new();
587587
ret.extend(iterator);
588588
ret

src/libcollections/hashmap.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1356,7 +1356,7 @@ pub type Values<'a, K, V> =
13561356
iter::Map<'static, (&'a K, &'a V), &'a V, Entries<'a, K, V>>;
13571357

13581358
impl<K: TotalEq + Hash<S>, V, S, H: Hasher<S> + Default> FromIterator<(K, V)> for HashMap<K, V, H> {
1359-
fn from_iterator<T: Iterator<(K, V)>>(iter: T) -> HashMap<K, V, H> {
1359+
fn from_iter<T: Iterator<(K, V)>>(iter: T) -> HashMap<K, V, H> {
13601360
let (lower, _) = iter.size_hint();
13611361
let mut map = HashMap::with_capacity_and_hasher(lower, Default::default());
13621362
map.extend(iter);
@@ -1540,7 +1540,7 @@ impl<T: TotalEq + Hash<S> + fmt::Show, S, H: Hasher<S>> fmt::Show for HashSet<T,
15401540
}
15411541

15421542
impl<T: TotalEq + Hash<S>, S, H: Hasher<S> + Default> FromIterator<T> for HashSet<T, H> {
1543-
fn from_iterator<I: Iterator<T>>(iter: I) -> HashSet<T, H> {
1543+
fn from_iter<I: Iterator<T>>(iter: I) -> HashSet<T, H> {
15441544
let (lower, _) = iter.size_hint();
15451545
let mut set = HashSet::with_capacity_and_hasher(lower, Default::default());
15461546
set.extend(iter);

src/libcollections/priority_queue.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ impl<'a, T> Iterator<&'a T> for Items<'a, T> {
193193
}
194194

195195
impl<T: Ord> FromIterator<T> for PriorityQueue<T> {
196-
fn from_iterator<Iter: Iterator<T>>(iter: Iter) -> PriorityQueue<T> {
196+
fn from_iter<Iter: Iterator<T>>(iter: Iter) -> PriorityQueue<T> {
197197
let mut q = PriorityQueue::new();
198198
q.extend(iter);
199199
q

src/libcollections/ringbuf.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ impl<A: Eq> Eq for RingBuf<A> {
386386
}
387387

388388
impl<A> FromIterator<A> for RingBuf<A> {
389-
fn from_iterator<T: Iterator<A>>(iterator: T) -> RingBuf<A> {
389+
fn from_iter<T: Iterator<A>>(iterator: T) -> RingBuf<A> {
390390
let (lower, _) = iterator.size_hint();
391391
let mut deq = RingBuf::with_capacity(lower);
392392
deq.extend(iterator);
@@ -778,7 +778,7 @@ mod tests {
778778
}
779779

780780
#[test]
781-
fn test_from_iterator() {
781+
fn test_from_iter() {
782782
use std::iter;
783783
let v = ~[1,2,3,4,5,6,7];
784784
let deq: RingBuf<int> = v.iter().map(|&x| x).collect();

src/libcollections/treemap.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -971,7 +971,7 @@ fn remove<K: TotalOrd, V>(node: &mut Option<~TreeNode<K, V>>,
971971
}
972972

973973
impl<K: TotalOrd, V> FromIterator<(K, V)> for TreeMap<K, V> {
974-
fn from_iterator<T: Iterator<(K, V)>>(iter: T) -> TreeMap<K, V> {
974+
fn from_iter<T: Iterator<(K, V)>>(iter: T) -> TreeMap<K, V> {
975975
let mut map = TreeMap::new();
976976
map.extend(iter);
977977
map
@@ -988,7 +988,7 @@ impl<K: TotalOrd, V> Extendable<(K, V)> for TreeMap<K, V> {
988988
}
989989

990990
impl<T: TotalOrd> FromIterator<T> for TreeSet<T> {
991-
fn from_iterator<Iter: Iterator<T>>(iter: Iter) -> TreeSet<T> {
991+
fn from_iter<Iter: Iterator<T>>(iter: Iter) -> TreeSet<T> {
992992
let mut set = TreeSet::new();
993993
set.extend(iter);
994994
set

src/libcollections/trie.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ impl<T> TrieMap<T> {
261261
}
262262

263263
impl<T> FromIterator<(uint, T)> for TrieMap<T> {
264-
fn from_iterator<Iter: Iterator<(uint, T)>>(iter: Iter) -> TrieMap<T> {
264+
fn from_iter<Iter: Iterator<(uint, T)>>(iter: Iter) -> TrieMap<T> {
265265
let mut map = TrieMap::new();
266266
map.extend(iter);
267267
map
@@ -346,7 +346,7 @@ impl TrieSet {
346346
}
347347

348348
impl FromIterator<uint> for TrieSet {
349-
fn from_iterator<Iter: Iterator<uint>>(iter: Iter) -> TrieSet {
349+
fn from_iter<Iter: Iterator<uint>>(iter: Iter) -> TrieSet {
350350
let mut set = TrieSet::new();
351351
set.extend(iter);
352352
set

src/libstd/iter.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ use mem;
7676
/// Conversion from an `Iterator`
7777
pub trait FromIterator<A> {
7878
/// Build a container with elements from an external iterator.
79-
fn from_iterator<T: Iterator<A>>(iterator: T) -> Self;
79+
fn from_iter<T: Iterator<A>>(iterator: T) -> Self;
8080
}
8181

8282
/// A type growable from an `Iterator` implementation
@@ -460,7 +460,7 @@ pub trait Iterator<A> {
460460
/// ```
461461
#[inline]
462462
fn collect<B: FromIterator<A>>(&mut self) -> B {
463-
FromIterator::from_iterator(self.by_ref())
463+
FromIterator::from_iter(self.by_ref())
464464
}
465465

466466
/// Loops through `n` iterations, returning the `n`th element of the
@@ -2336,7 +2336,7 @@ mod tests {
23362336
#[test]
23372337
fn test_counter_from_iter() {
23382338
let it = count(0, 5).take(10);
2339-
let xs: ~[int] = FromIterator::from_iterator(it);
2339+
let xs: ~[int] = FromIterator::from_iter(it);
23402340
assert_eq!(xs, ~[0, 5, 10, 15, 20, 25, 30, 35, 40, 45]);
23412341
}
23422342

src/libstd/option.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ pub fn collect<T, Iter: Iterator<Option<T>>, V: FromIterator<T>>(iter: Iter) ->
593593
}
594594
});
595595

596-
let v: V = FromIterator::from_iterator(iter.by_ref());
596+
let v: V = FromIterator::from_iter(iter.by_ref());
597597

598598
if iter.state {
599599
None

src/libstd/result.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ pub fn collect<T, E, Iter: Iterator<Result<T, E>>, V: FromIterator<T>>(iter: Ite
230230
}
231231
});
232232

233-
let v: V = FromIterator::from_iterator(iter.by_ref());
233+
let v: V = FromIterator::from_iter(iter.by_ref());
234234

235235
match iter.state {
236236
Some(err) => Err(err),

src/libstd/slice.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -2891,7 +2891,7 @@ impl<T> Drop for MoveItems<T> {
28912891
pub type RevMoveItems<T> = Rev<MoveItems<T>>;
28922892

28932893
impl<A> FromIterator<A> for ~[A] {
2894-
fn from_iterator<T: Iterator<A>>(mut iterator: T) -> ~[A] {
2894+
fn from_iter<T: Iterator<A>>(mut iterator: T) -> ~[A] {
28952895
let (lower, _) = iterator.size_hint();
28962896
let mut xs = with_capacity(lower);
28972897
for x in iterator {

src/libstd/str.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -3019,7 +3019,7 @@ impl Clone for ~str {
30193019

30203020
impl FromIterator<char> for ~str {
30213021
#[inline]
3022-
fn from_iterator<T: Iterator<char>>(iterator: T) -> ~str {
3022+
fn from_iter<T: Iterator<char>>(iterator: T) -> ~str {
30233023
let (lower, _) = iterator.size_hint();
30243024
let mut buf = with_capacity(lower);
30253025
buf.extend(iterator);

src/libstd/vec.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ impl<T:Clone> Clone for Vec<T> {
305305
}
306306

307307
impl<T> FromIterator<T> for Vec<T> {
308-
fn from_iterator<I:Iterator<T>>(mut iterator: I) -> Vec<T> {
308+
fn from_iter<I:Iterator<T>>(mut iterator: I) -> Vec<T> {
309309
let (lower, _) = iterator.size_hint();
310310
let mut vector = Vec::with_capacity(lower);
311311
for element in iterator {

src/libsyntax/owned_slice.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ impl<T> Container for OwnedSlice<T> {
126126
}
127127

128128
impl<T> FromIterator<T> for OwnedSlice<T> {
129-
fn from_iterator<I: Iterator<T>>(mut iter: I) -> OwnedSlice<T> {
129+
fn from_iter<I: Iterator<T>>(mut iter: I) -> OwnedSlice<T> {
130130
OwnedSlice::from_vec(iter.collect())
131131
}
132132
}

src/libsyntax/util/small_vector.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ impl<T> Container for SmallVector<T> {
2929
}
3030

3131
impl<T> FromIterator<T> for SmallVector<T> {
32-
fn from_iterator<I: Iterator<T>>(iter: I) -> SmallVector<T> {
32+
fn from_iter<I: Iterator<T>>(iter: I) -> SmallVector<T> {
3333
let mut v = Zero;
3434
v.extend(iter);
3535
v
@@ -167,7 +167,7 @@ mod test {
167167
}
168168

169169
#[test]
170-
fn test_from_iterator() {
170+
fn test_from_iter() {
171171
let v: SmallVector<int> = (vec!(1, 2, 3)).move_iter().collect();
172172
assert_eq!(3, v.len());
173173
assert_eq!(&1, v.get(0));

0 commit comments

Comments
 (0)