Remove redundant help

Author: estebank

compiler/rustc_const_eval/messages.ftl

@@ -421,7 +421,6 @@ const_eval_unstable_in_stable_exposed =
     .bypass_sugg = otherwise, as a last resort `#[rustc_allow_const_fn_unstable]` can be used to bypass stability checks (this requires team approval)
 
 const_eval_unstable_intrinsic = `{$name}` is not yet stable as a const intrinsic
-    .help = add `#![feature({$feature})]` to the crate attributes to enable
 const_eval_unstable_intrinsic_suggestion = add `#![feature({$feature})]` to the crate attributes to enable
 
 const_eval_unterminated_c_string =

compiler/rustc_const_eval/src/errors.rs

@@ -123,7 +123,6 @@ pub(crate) struct UnstableConstFn {
 
 #[derive(Diagnostic)]
 #[diag(const_eval_unstable_intrinsic)]
-#[help]
 pub(crate) struct UnstableIntrinsic {
     #[primary_span]
     pub span: Span,
@@ -135,7 +134,7 @@ pub(crate) struct UnstableIntrinsic {
         applicability = "machine-applicable"
     )]
     pub suggestion: Option<Span>,
-    #[help]
+    #[help(const_eval_unstable_intrinsic_suggestion)]
     pub help: bool,
 }
 

tests/ui/consts/const-unstable-intrinsic.stderr

@@ -24,7 +24,6 @@ error: `size_of_val` is not yet stable as a const intrinsic
 LL |         unstable_intrinsic::size_of_val(&x);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-   = help: add `#![feature(unstable)]` to the crate attributes to enable
 help: add `#![feature(unstable)]` to the crate attributes to enable
    |
 LL + #![feature("unstable")]
@@ -36,7 +35,6 @@ error: `min_align_of_val` is not yet stable as a const intrinsic
 LL |         unstable_intrinsic::min_align_of_val(&x);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-   = help: add `#![feature(unstable)]` to the crate attributes to enable
 help: add `#![feature(unstable)]` to the crate attributes to enable
    |
 LL + #![feature("unstable")]