Skip to content

Commit c3fe0b9

Browse files
committed
auto merge of #5369 : thestinger/rust/iter, r=z0w0
This can eventually be implemented on other sequence containers like `deque` (it's missing `each` too at the moment).
2 parents 4bf5ad6 + c64a5d2 commit c3fe0b9

File tree

3 files changed

+33
-7
lines changed

3 files changed

+33
-7
lines changed

src/libcore/iter.rs

+4
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@ pub trait ReverseIter<A>: BaseIter<A> {
3131
pure fn each_reverse(&self, blk: &fn(&A) -> bool);
3232
}
3333

34+
pub trait MutableIter<A>: BaseIter<A> {
35+
fn each_mut(&mut self, blk: &fn(&mut A) -> bool);
36+
}
37+
3438
pub trait ExtendedIter<A> {
3539
pure fn eachi(&self, blk: &fn(uint, v: &A) -> bool);
3640
pure fn all(&self, blk: &fn(&A) -> bool) -> bool;

src/libcore/prelude.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,9 @@ pub use clone::Clone;
2727
pub use cmp::{Eq, Ord, TotalOrd, Ordering, Less, Equal, Greater};
2828
pub use container::{Container, Mutable, Map, Set};
2929
pub use hash::Hash;
30-
pub use iter::{BaseIter, ReverseIter, ExtendedIter, EqIter, CopyableIter};
31-
pub use iter::{CopyableOrderedIter, CopyableNonstrictIter, Times};
30+
pub use iter::{BaseIter, ReverseIter, MutableIter, ExtendedIter, EqIter};
31+
pub use iter::{CopyableIter, CopyableOrderedIter, CopyableNonstrictIter};
32+
pub use iter::Times;
3233
pub use num::NumCast;
3334
pub use path::GenericPath;
3435
pub use path::Path;

src/libcore/vec.rs

+26-5
Original file line numberDiff line numberDiff line change
@@ -1357,7 +1357,7 @@ pub pure fn each<T>(v: &r/[T], f: &fn(&r/T) -> bool) {
13571357
/// a vector with mutable contents and you would like
13581358
/// to mutate the contents as you iterate.
13591359
#[inline(always)]
1360-
pub fn each_mut<T>(v: &mut [T], f: &fn(elem: &mut T) -> bool) {
1360+
pub fn each_mut<T>(v: &'r mut [T], f: &fn(elem: &'r mut T) -> bool) {
13611361
let mut i = 0;
13621362
let n = v.len();
13631363
while i < n {
@@ -2280,11 +2280,9 @@ pub mod bytes {
22802280
// ___________________________________________________________________________
22812281
// ITERATION TRAIT METHODS
22822282

2283-
impl<A> iter::BaseIter<A> for &self/[A] {
2283+
impl<A> iter::BaseIter<A> for &'self [A] {
22842284
#[inline(always)]
2285-
pub pure fn each(&self, blk: &fn(v: &'self A) -> bool) {
2286-
each(*self, blk)
2287-
}
2285+
pure fn each(&self, blk: &fn(v: &'self A) -> bool) { each(*self, blk) }
22882286
#[inline(always)]
22892287
pure fn size_hint(&self) -> Option<uint> { Some(self.len()) }
22902288
}
@@ -2305,6 +2303,29 @@ impl<A> iter::BaseIter<A> for @[A] {
23052303
pure fn size_hint(&self) -> Option<uint> { Some(self.len()) }
23062304
}
23072305

2306+
impl<A> iter::MutableIter<A> for &'self mut [A] {
2307+
#[inline(always)]
2308+
fn each_mut(&mut self, blk: &fn(v: &'self mut A) -> bool) {
2309+
each_mut(*self, blk)
2310+
}
2311+
}
2312+
2313+
// FIXME(#4148): This should be redundant
2314+
impl<A> iter::MutableIter<A> for ~[A] {
2315+
#[inline(always)]
2316+
fn each_mut(&mut self, blk: &fn(v: &'self mut A) -> bool) {
2317+
each_mut(*self, blk)
2318+
}
2319+
}
2320+
2321+
// FIXME(#4148): This should be redundant
2322+
impl<A> iter::MutableIter<A> for @mut [A] {
2323+
#[inline(always)]
2324+
fn each_mut(&mut self, blk: &fn(v: &mut A) -> bool) {
2325+
each_mut(*self, blk)
2326+
}
2327+
}
2328+
23082329
impl<A> iter::ExtendedIter<A> for &self/[A] {
23092330
pub pure fn eachi(&self, blk: &fn(uint, v: &A) -> bool) {
23102331
iter::eachi(self, blk)

0 commit comments

Comments
 (0)