Skip to content

Commit cb07fd8

Browse files
committed
Miri CI: test aarch64-apple-darwin in PRs instead of the x86_64 target
1 parent a8e4c68 commit cb07fd8

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ MIRIFLAGS="-Zmiri-force-intrinsic-fallback --cfg force_intrinsic_fallback -O -Zm
5353
case $HOST_TARGET in
5454
x86_64-unknown-linux-gnu)
5555
# Only this branch runs in PR CI.
56-
# Fully test all main OSes, including a 32bit target.
57-
python3 "$X_PY" test --stage 2 src/tools/miri src/tools/miri/cargo-miri --target x86_64-apple-darwin
56+
# Fully test all main OSes, and all main architectures.
57+
python3 "$X_PY" test --stage 2 src/tools/miri src/tools/miri/cargo-miri --target aarch64-apple-darwin
5858
python3 "$X_PY" test --stage 2 src/tools/miri src/tools/miri/cargo-miri --target i686-pc-windows-msvc
5959
# Only run "pass" tests for the remaining targets, which is quite a bit faster.
6060
python3 "$X_PY" test --stage 2 src/tools/miri --target x86_64-pc-windows-gnu --test-args pass
@@ -69,7 +69,7 @@ case $HOST_TARGET in
6969
#FIXME: Re-enable this once CI issues are fixed
7070
# See <https://github.com/rust-lang/rust/issues/127883>
7171
# For now, these tests are moved to `x86_64-msvc-ext2` in `src/ci/github-actions/jobs.yml`.
72-
#python3 "$X_PY" test --stage 2 src/tools/miri --target aarch64-apple-darwin --test-args pass
72+
#python3 "$X_PY" test --stage 2 src/tools/miri --target x86_64-apple-darwin --test-args pass
7373
;;
7474
*)
7575
echo "FATAL: unexpected host $HOST_TARGET"

src/ci/github-actions/jobs.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,11 +522,13 @@ auto:
522522
- name: x86_64-msvc-ext2
523523
env:
524524
SCRIPT: >
525-
python x.py test --stage 2 src/tools/miri --target aarch64-apple-darwin --test-args pass &&
525+
python x.py test --stage 2 src/tools/miri --target x86_64-apple-darwin --test-args pass &&
526526
python x.py test --stage 2 src/tools/miri --target x86_64-pc-windows-gnu --test-args pass &&
527527
python x.py miri --stage 2 library/core --test-args notest &&
528528
python x.py miri --stage 2 library/alloc --test-args notest &&
529529
python x.py miri --stage 2 library/std --test-args notest
530+
# The last 3 lines smoke-test `x.py miri`. This doesn't run any actual tests (that would take
531+
# too long), but it ensures that the crates build properly when tested with Miri.
530532
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-lld
531533
<<: *job-windows
532534

0 commit comments

Comments
 (0)