Skip to content

Commit cbad1da

Browse files
committed
vec: remove eachi
replaced by the `enumerate` method from std::iterator
1 parent 62dc4e0 commit cbad1da

File tree

6 files changed

+12
-53
lines changed

6 files changed

+12
-53
lines changed

src/compiletest/runtest.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ fn check_expected_errors(expected_errors: ~[errors::ExpectedError],
358358
// is the ending point, and * represents ANSI color codes.
359359
for ProcRes.stderr.line_iter().advance |line| {
360360
let mut was_expected = false;
361-
for vec::eachi(expected_errors) |i, ee| {
361+
for expected_errors.iter().enumerate().advance |(i, ee)| {
362362
if !found_flags[i] {
363363
debug!("prefix=%s ee.kind=%s ee.msg=%s line=%s",
364364
prefixes[i], ee.kind, ee.msg, line);

src/librustc/middle/trans/cabi.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ impl FnType {
4343
let fnty = T_fn(atys, rty);
4444
let llfn = decl(fnty);
4545

46-
for vec::eachi(self.attrs) |i, a| {
46+
for self.attrs.iter().enumerate().advance |(i, a)| {
4747
match *a {
4848
option::Some(attr) => {
4949
unsafe {
@@ -100,7 +100,7 @@ impl FnType {
100100
ret_def: bool,
101101
llargbundle: ValueRef,
102102
llretval: ValueRef) {
103-
for vec::eachi(self.attrs) |i, a| {
103+
for self.attrs.iter().enumerate().advance |(i, a)| {
104104
match *a {
105105
option::Some(attr) => {
106106
unsafe {

src/librustc/middle/trans/closure.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ pub fn store_environment(bcx: block,
225225

226226
// Copy expr values into boxed bindings.
227227
let mut bcx = bcx;
228-
for vec::eachi(bound_values) |i, bv| {
228+
for bound_values.iter().enumerate().advance |(i, bv)| {
229229
debug!("Copy %s into closure", bv.to_str(ccx));
230230

231231
if ccx.sess.asm_comments() {

src/librustc/middle/trans/glue.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ pub fn trans_struct_drop(bcx: block,
462462

463463
// Drop the fields
464464
let field_tys = ty::struct_fields(bcx.tcx(), class_did, substs);
465-
for vec::eachi(field_tys) |i, fld| {
465+
for field_tys.iter().enumerate().advance |(i, fld)| {
466466
let llfld_a = adt::trans_field_ptr(bcx, repr, v0, 0, i);
467467
bcx = drop_ty(bcx, llfld_a, fld.mt.ty);
468468
}

src/libstd/vec.rs

-41
Original file line numberDiff line numberDiff line change
@@ -1427,21 +1427,6 @@ pub fn each<'r,T>(v: &'r [T], f: &fn(&'r T) -> bool) -> bool {
14271427
return !broke;
14281428
}
14291429

1430-
/**
1431-
* Iterates over a vector's elements and indices
1432-
*
1433-
* Return true to continue, false to break.
1434-
*/
1435-
#[inline]
1436-
pub fn eachi<'r,T>(v: &'r [T], f: &fn(uint, v: &'r T) -> bool) -> bool {
1437-
let mut i = 0;
1438-
for each(v) |p| {
1439-
if !f(i, p) { return false; }
1440-
i += 1;
1441-
}
1442-
return true;
1443-
}
1444-
14451430
/**
14461431
* Iterate over all permutations of vector `v`.
14471432
*
@@ -3259,17 +3244,6 @@ mod tests {
32593244
assert_eq!(i, 6);
32603245
}
32613246

3262-
#[test]
3263-
fn test_eachi() {
3264-
let mut i = 0;
3265-
for eachi([1, 2, 3]) |j, v| {
3266-
if i == 0 { assert!(*v == 1); }
3267-
assert_eq!(j + 1u, *v as uint);
3268-
i += *v;
3269-
}
3270-
assert_eq!(i, 6);
3271-
}
3272-
32733247
#[test]
32743248
fn test_each_ret_len0() {
32753249
let a0 : [int, .. 0] = [];
@@ -4111,21 +4085,6 @@ mod tests {
41114085
};
41124086
}
41134087

4114-
#[test]
4115-
#[ignore(windows)]
4116-
#[should_fail]
4117-
fn test_eachi_fail() {
4118-
let v = [(~0, @0), (~0, @0), (~0, @0), (~0, @0)];
4119-
let mut i = 0;
4120-
do eachi(v) |_i, _elt| {
4121-
if i == 2 {
4122-
fail!()
4123-
}
4124-
i += 0;
4125-
false
4126-
};
4127-
}
4128-
41294088
#[test]
41304089
#[ignore(windows)]
41314090
#[should_fail]

src/test/bench/shootout-chameneos-redux.rs

+7-7
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ use std::uint;
2323
use std::vec;
2424

2525
fn print_complements() {
26-
let all = ~[Blue, Red, Yellow];
27-
for vec::each(all) |aa| {
28-
for vec::each(all) |bb| {
29-
io::println(show_color(*aa) + " + " + show_color(*bb) +
30-
" -> " + show_color(transform(*aa, *bb)));
26+
let all = [Blue, Red, Yellow];
27+
for all.iter().advance |aa| {
28+
for all.iter().advance |bb| {
29+
println(show_color(*aa) + " + " + show_color(*bb) +
30+
" -> " + show_color(transform(*aa, *bb)));
3131
}
3232
}
3333
}
@@ -49,7 +49,7 @@ fn show_color(cc: color) -> ~str {
4949

5050
fn show_color_list(set: ~[color]) -> ~str {
5151
let mut out = ~"";
52-
for vec::eachi(set) |_ii, col| {
52+
for set.iter().advance |col| {
5353
out += " ";
5454
out += show_color(*col);
5555
}
@@ -182,7 +182,7 @@ fn rendezvous(nn: uint, set: ~[color]) {
182182
}
183183

184184
// tell each creature to stop
185-
for vec::eachi(to_creature) |_ii, to_one| {
185+
for to_creature.iter().advance |to_one| {
186186
to_one.send(None);
187187
}
188188

0 commit comments

Comments
 (0)