Skip to content

Commit d33cab1

Browse files
committed
Auto merge of #27172 - alexcrichton:snapshots, r=brson
Enables bootstrapping a 32-bit MSVC host compiler! Closes #26602
2 parents 39a780d + 24c5e49 commit d33cab1

File tree

6 files changed

+12
-32
lines changed

6 files changed

+12
-32
lines changed

src/liballoc/lib.rs

-17
Original file line numberDiff line numberDiff line change
@@ -135,20 +135,3 @@ pub fn oom() -> ! {
135135
// allocate.
136136
unsafe { core::intrinsics::abort() }
137137
}
138-
139-
// FIXME(#14344): When linking liballoc with libstd, this library will be linked
140-
// as an rlib (it only exists as an rlib). It turns out that an
141-
// optimized standard library doesn't actually use *any* symbols
142-
// from this library. Everything is inlined and optimized away.
143-
// This means that linkers will actually omit the object for this
144-
// file, even though it may be needed in the future.
145-
//
146-
// To get around this for now, we define a dummy symbol which
147-
// will never get inlined so the stdlib can call it. The stdlib's
148-
// reference to this symbol will cause this library's object file
149-
// to get linked in to libstd successfully (the linker won't
150-
// optimize it out).
151-
#[doc(hidden)]
152-
#[unstable(feature = "issue_14344_fixme")]
153-
#[cfg(stage0)]
154-
pub fn fixme_14344_be_sure_to_link_to_collections() {}

src/libcollections/lib.rs

-7
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,6 @@ pub mod btree_set {
133133
pub use btree::set::*;
134134
}
135135

136-
137-
// FIXME(#14344) this shouldn't be necessary
138-
#[doc(hidden)]
139-
#[unstable(feature = "issue_14344_fixme")]
140-
#[cfg(stage0)]
141-
pub fn fixme_14344_be_sure_to_link_to_collections() {}
142-
143136
#[cfg(not(test))]
144137
mod std {
145138
pub use core::ops; // RangeFull

src/libcollections/string.rs

-3
Original file line numberDiff line numberDiff line change
@@ -979,23 +979,20 @@ impl ops::Index<ops::RangeFull> for String {
979979
}
980980
}
981981

982-
#[cfg(not(stage0))]
983982
#[stable(feature = "derefmut_for_string", since = "1.2.0")]
984983
impl ops::IndexMut<ops::Range<usize>> for String {
985984
#[inline]
986985
fn index_mut(&mut self, index: ops::Range<usize>) -> &mut str {
987986
&mut self[..][index]
988987
}
989988
}
990-
#[cfg(not(stage0))]
991989
#[stable(feature = "derefmut_for_string", since = "1.2.0")]
992990
impl ops::IndexMut<ops::RangeTo<usize>> for String {
993991
#[inline]
994992
fn index_mut(&mut self, index: ops::RangeTo<usize>) -> &mut str {
995993
&mut self[..][index]
996994
}
997995
}
998-
#[cfg(not(stage0))]
999996
#[stable(feature = "derefmut_for_string", since = "1.2.0")]
1000997
impl ops::IndexMut<ops::RangeFrom<usize>> for String {
1001998
#[inline]

src/liblibc/lib.rs

-4
Original file line numberDiff line numberDiff line change
@@ -6535,8 +6535,4 @@ pub mod funcs {
65356535
}
65366536
}
65376537

6538-
#[doc(hidden)]
6539-
#[cfg(stage0)]
6540-
pub fn issue_14344_workaround() {} // FIXME #14344 force linkage to happen correctly
6541-
65426538
#[test] fn work_on_windows() { } // FIXME #10872 needed for a happy windows

src/libstd/sys/windows/thread_local.rs

+4-1
Original file line numberDiff line numberDiff line change
@@ -231,9 +231,12 @@ pub static p_thread_callback: unsafe extern "system" fn(LPVOID, DWORD,
231231
LPVOID) =
232232
on_tls_callback;
233233

234-
#[cfg(target_env = "msvc")]
234+
#[cfg(all(target_env = "msvc", target_pointer_width = "64"))]
235235
#[link_args = "/INCLUDE:_tls_used"]
236236
extern {}
237+
#[cfg(all(target_env = "msvc", target_pointer_width = "32"))]
238+
#[link_args = "/INCLUDE:__tls_used"]
239+
extern {}
237240

238241
#[allow(warnings)]
239242
unsafe extern "system" fn on_tls_callback(h: LPVOID,

src/snapshots.txt

+8
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
S 2015-07-17 d4432b3
2+
linux-i386 93f6216a35d3bed3cedf244c9aff4cd716336bd9
3+
linux-x86_64 d8f4967fc71a153c925faecf95a7feadf7e463a4
4+
macos-i386 29852c4d4b5a851f16d627856a279cae5bf9bd01
5+
macos-x86_64 1a20259899321062a0325edb1d22990f05d18708
6+
winnt-i386 df50210f41db9a6f2968be5773b8e3bae32bb823
7+
winnt-x86_64 d7774b724988485652781a804bdf8e05d28ead48
8+
19
S 2015-05-24 ba0e1cd
210
bitrig-x86_64 2a710e16e3e3ef3760df1f724d66b3af34c1ef3f
311
freebsd-x86_64 370db40613f5c08563ed7e38357826dd42d4e0f8

0 commit comments

Comments
 (0)