Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit ea34c47

Browse files
committedJan 3, 2024
Temporarily disable M1 runners on GitHub Actions
This commit temporarily reverts the addition of M1 runners on GitHub Actions to work around a billing issue related to their beta.
1 parent e51e98d commit ea34c47

File tree

2 files changed

+35
-11
lines changed

2 files changed

+35
-11
lines changed
 

‎.github/workflows/ci.yml‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -361,8 +361,8 @@ jobs:
361361
os: macos-13
362362
- name: dist-aarch64-apple
363363
env:
364-
SCRIPT: "./x.py dist bootstrap --include-default-paths --host=aarch64-apple-darwin --target=aarch64-apple-darwin"
365-
RUST_CONFIGURE_ARGS: "--enable-full-tools --enable-sanitizers --enable-profiler --set rust.jemalloc --set llvm.ninja=false --set rust.lto=thin"
364+
SCRIPT: "./x.py dist bootstrap --include-default-paths --stage 2"
365+
RUST_CONFIGURE_ARGS: "--build=x86_64-apple-darwin --host=aarch64-apple-darwin --target=aarch64-apple-darwin --enable-full-tools --enable-sanitizers --enable-profiler --disable-docs --set rust.jemalloc --set llvm.ninja=false"
366366
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
367367
SELECT_XCODE: /Applications/Xcode_13.4.1.app
368368
USE_XCODE_CLANG: 1
@@ -372,11 +372,12 @@ jobs:
372372
NO_DEBUG_ASSERTIONS: 1
373373
NO_OVERFLOW_CHECKS: 1
374374
DIST_REQUIRE_ALL_TOOLS: 1
375-
os: macos-13-xlarge
375+
JEMALLOC_SYS_WITH_LG_PAGE: 14
376+
os: macos-13
376377
- name: aarch64-apple
377378
env:
378-
SCRIPT: "./x.py --stage 2 test --host=aarch64-apple-darwin --target=aarch64-apple-darwin"
379-
RUST_CONFIGURE_ARGS: "--enable-sanitizers --enable-profiler --set rust.jemalloc --set llvm.ninja=false"
379+
SCRIPT: "./x.py --stage 2 test"
380+
RUST_CONFIGURE_ARGS: "--build=x86_64-apple-darwin --host=aarch64-apple-darwin --target=aarch64-apple-darwin --enable-sanitizers --enable-profiler --set rust.jemalloc --set llvm.ninja=false"
380381
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
381382
SELECT_XCODE: /Applications/Xcode_13.4.1.app
382383
USE_XCODE_CLANG: 1
@@ -385,7 +386,8 @@ jobs:
385386
NO_LLVM_ASSERTIONS: 1
386387
NO_DEBUG_ASSERTIONS: 1
387388
NO_OVERFLOW_CHECKS: 1
388-
os: macos-13-xlarge
389+
JEMALLOC_SYS_WITH_LG_PAGE: 14
390+
os: macos-13
389391
- name: x86_64-msvc
390392
env:
391393
RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-msvc --enable-profiler"

‎src/ci/github-actions/ci.yml‎

Lines changed: 27 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -553,14 +553,17 @@ jobs:
553553
# This target only needs to support 11.0 and up as nothing else supports the hardware
554554
- name: dist-aarch64-apple
555555
env:
556-
SCRIPT: ./x.py dist bootstrap --include-default-paths --host=aarch64-apple-darwin --target=aarch64-apple-darwin
556+
SCRIPT: ./x.py dist bootstrap --include-default-paths --stage 2
557557
RUST_CONFIGURE_ARGS: >-
558+
--build=x86_64-apple-darwin
559+
--host=aarch64-apple-darwin
560+
--target=aarch64-apple-darwin
558561
--enable-full-tools
559562
--enable-sanitizers
560563
--enable-profiler
564+
--disable-docs
561565
--set rust.jemalloc
562566
--set llvm.ninja=false
563-
--set rust.lto=thin
564567
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
565568
SELECT_XCODE: /Applications/Xcode_13.4.1.app
566569
USE_XCODE_CLANG: 1
@@ -570,13 +573,24 @@ jobs:
570573
NO_DEBUG_ASSERTIONS: 1
571574
NO_OVERFLOW_CHECKS: 1
572575
DIST_REQUIRE_ALL_TOOLS: 1
573-
<<: *job-macos-m1
576+
# Corresponds to 16K page size
577+
#
578+
# Shouldn't be needed if jemalloc-sys is updated to
579+
# handle this platform like iOS or if we build on
580+
# aarch64-apple-darwin itself.
581+
#
582+
# https://github.com/gnzlbg/jemallocator/blob/c27a859e98e3cb790dc269773d9da71a1e918458/jemalloc-sys/build.rs#L237
583+
JEMALLOC_SYS_WITH_LG_PAGE: 14
584+
<<: *job-macos-xl
574585

575586
# This target only needs to support 11.0 and up as nothing else supports the hardware
576587
- name: aarch64-apple
577588
env:
578-
SCRIPT: ./x.py --stage 2 test --host=aarch64-apple-darwin --target=aarch64-apple-darwin
589+
SCRIPT: ./x.py --stage 2 test
579590
RUST_CONFIGURE_ARGS: >-
591+
--build=x86_64-apple-darwin
592+
--host=aarch64-apple-darwin
593+
--target=aarch64-apple-darwin
580594
--enable-sanitizers
581595
--enable-profiler
582596
--set rust.jemalloc
@@ -589,7 +603,15 @@ jobs:
589603
NO_LLVM_ASSERTIONS: 1
590604
NO_DEBUG_ASSERTIONS: 1
591605
NO_OVERFLOW_CHECKS: 1
592-
<<: *job-macos-m1
606+
# Corresponds to 16K page size
607+
#
608+
# Shouldn't be needed if jemalloc-sys is updated to
609+
# handle this platform like iOS or if we build on
610+
# aarch64-apple-darwin itself.
611+
#
612+
# https://github.com/gnzlbg/jemallocator/blob/c27a859e98e3cb790dc269773d9da71a1e918458/jemalloc-sys/build.rs#L237
613+
JEMALLOC_SYS_WITH_LG_PAGE: 14
614+
<<: *job-macos-xl
593615

594616
######################
595617
# Windows Builders #

0 commit comments

Comments
 (0)
Please sign in to comment.