Skip to content

Commit f125b71

Browse files
committed
Add FIXME comments regarding issue #11526.
1 parent 472dfe7 commit f125b71

File tree

3 files changed

+22
-0
lines changed

3 files changed

+22
-0
lines changed

src/libstd/num/f32.rs

+7
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,9 @@ delegate!(
9696
fn tanh(n: c_float) -> c_float = cmath::c_float::tanh
9797
)
9898

99+
// FIXME(#11621): These constants should be deprecated once CTFE is implemented
100+
// in favour of calling their respective functions in `Bounded` and `Float`.
101+
99102
pub static RADIX: uint = 2u;
100103

101104
pub static MANTISSA_DIGITS: uint = 53u;
@@ -122,6 +125,10 @@ pub static NEG_INFINITY: f32 = -1.0_f32/0.0_f32;
122125
pub mod consts {
123126
// FIXME (requires Issue #1433 to fix): replace with mathematical
124127
// staticants from cmath.
128+
129+
// FIXME(#11621): These constants should be deprecated once CTFE is
130+
// implemented in favour of calling their respective functions in `Real`.
131+
125132
/// Archimedes' constant
126133
pub static PI: f32 = 3.14159265358979323846264338327950288_f32;
127134

src/libstd/num/f64.rs

+7
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,9 @@ delegate!(
101101

102102
// FIXME (#1433): obtain these in a different way
103103

104+
// FIXME(#11621): These constants should be deprecated once CTFE is implemented
105+
// in favour of calling their respective functions in `Bounded` and `Float`.
106+
104107
pub static RADIX: uint = 2u;
105108

106109
pub static MANTISSA_DIGITS: uint = 53u;
@@ -129,6 +132,10 @@ pub static NEG_INFINITY: f64 = -1.0_f64/0.0_f64;
129132
pub mod consts {
130133
// FIXME (requires Issue #1433 to fix): replace with mathematical
131134
// constants from cmath.
135+
136+
// FIXME(#11621): These constants should be deprecated once CTFE is
137+
// implemented in favour of calling their respective functions in `Real`.
138+
132139
/// Archimedes' constant
133140
pub static PI: f64 = 3.14159265358979323846264338327950288_f64;
134141

src/libstd/num/int_macros.rs

+8
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,19 @@
1313

1414
macro_rules! int_module (($T:ty, $bits:expr) => (
1515

16+
// FIXME(#11621): Should be deprecated once CTFE is implemented in favour of
17+
// calling the `mem::size_of` function.
1618
pub static bits : uint = $bits;
19+
// FIXME(#11621): Should be deprecated once CTFE is implemented in favour of
20+
// calling the `mem::size_of` function.
1721
pub static bytes : uint = ($bits / 8);
1822

23+
// FIXME(#11621): Should be deprecated once CTFE is implemented in favour of
24+
// calling the `Bounded::min_value` function.
1925
pub static min_value: $T = (-1 as $T) << (bits - 1);
2026
// FIXME(#9837): Compute min_value like this so the high bits that shouldn't exist are 0.
27+
// FIXME(#11621): Should be deprecated once CTFE is implemented in favour of
28+
// calling the `Bounded::max_value` function.
2129
pub static max_value: $T = !min_value;
2230

2331
impl CheckedDiv for $T {

0 commit comments

Comments
 (0)