Skip to content

Commit fa18328

Browse files
committed
auto merge of #14725 : aochagavia/rust/show, r=alexcrichton
2 parents 01eb0ce + 9731c28 commit fa18328

File tree

2 files changed

+52
-0
lines changed

2 files changed

+52
-0
lines changed

src/libcollections/dlist.rs

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
use core::prelude::*;
2525

2626
use alloc::owned::Box;
27+
use core::fmt;
2728
use core::iter;
2829
use core::mem;
2930
use core::ptr;
@@ -608,6 +609,19 @@ impl<A: Clone> Clone for DList<A> {
608609
}
609610
}
610611

612+
impl<A: fmt::Show> fmt::Show for DList<A> {
613+
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
614+
try!(write!(f, "["));
615+
616+
for (i, e) in self.iter().enumerate() {
617+
if i != 0 { try!(write!(f, ", ")); }
618+
try!(write!(f, "{}", *e));
619+
}
620+
621+
write!(f, "]")
622+
}
623+
}
624+
611625
#[cfg(test)]
612626
mod tests {
613627
use std::prelude::*;
@@ -1027,6 +1041,17 @@ mod tests {
10271041
}
10281042
}
10291043

1044+
#[test]
1045+
fn test_show() {
1046+
let list: DList<int> = range(0, 10).collect();
1047+
assert!(list.to_str().as_slice() == "[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]");
1048+
1049+
let list: DList<&str> = vec!["just", "one", "test", "more"].iter()
1050+
.map(|&s| s)
1051+
.collect();
1052+
assert!(list.to_str().as_slice() == "[just, one, test, more]");
1053+
}
1054+
10301055
#[cfg(test)]
10311056
fn fuzz_test(sz: int) {
10321057
let mut m: DList<int> = DList::new();

src/libcollections/smallintmap.rs

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
use core::prelude::*;
1919

20+
use core::fmt;
2021
use core::iter::{Enumerate, FilterMap};
2122
use core::mem::replace;
2223

@@ -176,6 +177,18 @@ impl<V:Clone> SmallIntMap<V> {
176177
}
177178
}
178179

180+
impl<V: fmt::Show> fmt::Show for SmallIntMap<V> {
181+
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
182+
try!(write!(f, r"\{"));
183+
184+
for (i, (k, v)) in self.iter().enumerate() {
185+
if i != 0 { try!(write!(f, ", ")); }
186+
try!(write!(f, "{}: {}", k, *v));
187+
}
188+
189+
write!(f, r"\}")
190+
}
191+
}
179192

180193
macro_rules! iterator {
181194
(impl $name:ident -> $elem:ty, $getter:ident) => {
@@ -461,6 +474,20 @@ mod test_map {
461474
assert!(called);
462475
m.insert(2, box 1);
463476
}
477+
478+
#[test]
479+
fn test_show() {
480+
let mut map = SmallIntMap::new();
481+
let empty = SmallIntMap::<int>::new();
482+
483+
map.insert(1, 2);
484+
map.insert(3, 4);
485+
486+
let map_str = map.to_str();
487+
let map_str = map_str.as_slice();
488+
assert!(map_str == "{1: 2, 3: 4}" || map_str == "{3: 4, 1: 2}");
489+
assert_eq!(format!("{}", empty), "{}".to_string());
490+
}
464491
}
465492

466493
#[cfg(test)]

0 commit comments

Comments
 (0)