Skip to content

Don't build Miri tool by default #100139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Noratrieb opened this issue Aug 4, 2022 · 3 comments
Closed

Don't build Miri tool by default #100139

Noratrieb opened this issue Aug 4, 2022 · 3 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Noratrieb
Copy link
Member

When setting extended = true in the config.toml, bootstrap also builds all the tools, including Miri. Since Miri doesn't always build, this can cause problems like in #100134. There is another option to only build a set of tools using tools = [] (this doesn't contain "miri" in the example form, which is a little odd, it should probably be added there as well).

rust-demangler is already excluded by default (unless profiling is enabled), so I think it would make sense to disable Miri by default as well (unless there's some good reason to not do it).

@Noratrieb
Copy link
Member Author

@rustbot label +A-bootstrap

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 4, 2022
@RalfJung
Copy link
Member

This is already implemented for stable/beta builds:

rust/src/bootstrap/tool.rs

Lines 807 to 809 in 3395094

// By default, on nightly/dev enable all tools, else only
// build stable tools.
$stable || builder.build.unstable_features(),

I guess we could extend this to all builds, but then I am not sure if CI would still build these tools.

@jyn514
Copy link
Member

jyn514 commented Sep 15, 2022

I don't think this is the right fix, see #100134 (comment).

@jyn514 jyn514 closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

4 participants