You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
oli-obk opened this issue
Nov 4, 2022
· 1 comment
· Fixed by #103984
Assignees
Labels
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
fix up all the mk_const call sites to make them stop using ty::ConstS and instead pass the two fields as arguments
The text was updated successfully, but these errors were encountered:
oli-obk
added
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
labels
Nov 4, 2022
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
We keep repeating this, but it adds no helpful information for readers of the call site, it's just boilerplate and noise.
Steps:
mk_const_internal
instead ofmk_const
. This is what generates the currentmk_const
function.mk_const
function next to https://github.com/rust-lang/rust/blob/b66cf6fe168e10dcbfed4320a5e84c0c28eee814/compiler/rustc_middle/src/ty/context.rs#L2644 that takes two arguments and forwards them to amk_const_internal(ty::ConstS { val, kind }
mk_const
call sites to make them stop usingty::ConstS
and instead pass the two fields as argumentsThe text was updated successfully, but these errors were encountered: