Skip to content

deno ICE with RUSTFLAGS=" -Z threads=8" #117786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
littledivy opened this issue Nov 10, 2023 · 1 comment
Closed

deno ICE with RUSTFLAGS=" -Z threads=8" #117786

littledivy opened this issue Nov 10, 2023 · 1 comment
Labels
C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@littledivy
Copy link

Comping deno (large project) with -Z threads=8 triggers an ICE.

Deno takes ~7mins to compile (release) on M1 - It would be great to see speedups brought by -Z threads.

To reproduce

git clone --recurse-submodules https://github.com/denoland/deno
RUSTFLAGS="-Z threads=8" cargo +nightly build --release -p deno

Backtrace

thread '<unnamed>' panicked at compiler/rustc_query_system/src/query/job.rs:543:9:
deadlock detected
stack backtrace:
   0:        0x104bd4270 - std::backtrace::Backtrace::create::hd93532a1a94bd2fd
   1:        0x10dff2d38 - <alloc[e142c9bf9c63cfc4]::boxed::Box<rustc_driver_impl[1a98898d3f3a38ed]::install_ice_hook::{closure#0}> as core[4e0a19b8f4e7b450]::ops::function::Fn<(&dyn for<'a, 'b> core[4e0a19b8f4e7b450]::ops::function::Fn<(&'a core[4e0a19b8f4e7b450]::panic::panic_info::PanicInfo<'b>,), Output = ()> + core[4e0a19b8f4e7b450]::marker::Send + core[4e0a19b8f4e7b450]::marker::Sync, &core[4e0a19b8f4e7b450]::panic::panic_info::PanicInfo)>>::call
   2:        0x104bec16c - std::panicking::rust_panic_with_hook::h9625542414b348eb
   3:        0x104bebf10 - std::panicking::begin_panic_handler::{{closure}}::hb4fa343c314105dc
   4:        0x104be9720 - std::sys_common::backtrace::__rust_end_short_backtrace::he263cec7b035e782
   5:        0x104bebcd0 - _rust_begin_unwind
   6:        0x104c450b8 - core::panicking::panic_fmt::h624e311b541e9a0d
   7:        0x10f402c6c - rustc_query_system[2c5cf56d08163fd7]::query::job::deadlock
   8:        0x10e003a58 - std[f37625d93cba7df1]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[6fd153b9b61224af]::util::run_in_thread_pool_with_globals<rustc_interface[6fd153b9b61224af]::interface::run_compiler<(), rustc_driver_impl[1a98898d3f3a38ed]::run_compiler::{closure#0}>::{closure#0}, ()>::{closure#2}::{closure#1}, ()>
   9:        0x10dfd4cfc - <<std[f37625d93cba7df1]::thread::Builder>::spawn_unchecked_<rustc_interface[6fd153b9b61224af]::util::run_in_thread_pool_with_globals<rustc_interface[6fd153b9b61224af]::interface::run_compiler<core[4e0a19b8f4e7b450]::result::Result<(), rustc_span[7d3d88934d9d268]::ErrorGuaranteed>, rustc_driver_impl[1a98898d3f3a38ed]::run_compiler::{closure#1}>::{closure#0}, core[4e0a19b8f4e7b450]::result::Result<(), rustc_span[7d3d88934d9d268]::ErrorGuaranteed>>::{closure#2}::{closure#1}, ()>::{closure#1} as core[4e0a19b8f4e7b450]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  10:        0x104bf4368 - std::sys::unix::thread::Thread::new::thread_start::h6af77cae4d08b8df
  11:        0x18495206c - __pthread_deallocate


rustc version: 1.75.0-nightly (0f44eb32f 2023-11-09)
platform: aarch64-apple-darwin⏎
@littledivy littledivy added C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 10, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 10, 2023
@littledivy
Copy link
Author

Ah sorry, there is already one open issue for deno.

Closing as duplicate of #117767

@littledivy littledivy closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2023
@fmease fmease removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants