Skip to content

compiletest: pin or restrict supported external dependency versions #128392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jieyouxu opened this issue Jul 30, 2024 · 1 comment
Open

compiletest: pin or restrict supported external dependency versions #128392

jieyouxu opened this issue Jul 30, 2024 · 1 comment
Labels
A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. E-needs-design This issue needs exploration and design to see how and if we can fix/implement it T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

To the best of my knowledge, test suites supported by compiletest currently rely on external dependencies in e.g. ui or run-make test suites but we do not have any sanity checks on their versions or even the specific external dependency used. For example, which C/C++ compilers are picked for a given environment usually calls out to something like the cc crate, but we don't otherwise pin them down. This makes reproducing the tests locally very challenging or near impossible. Or for Python, I don't think we sanity check which Python versions are "supported" by the test suites.
@jieyouxu jieyouxu added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-compiletest Area: The compiletest test runner labels Jul 30, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 30, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 30, 2024
@jieyouxu
Copy link
Member Author

This behavior is also replicated by the run-make-support library which obviously isn't ideal either.

@jieyouxu jieyouxu added the A-run-make Area: port run-make Makefiles to rmake.rs label Jul 30, 2024
@jieyouxu jieyouxu mentioned this issue Sep 24, 2024
Merged
@jieyouxu jieyouxu added E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. E-needs-design This issue needs exploration and design to see how and if we can fix/implement it T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. E-needs-design This issue needs exploration and design to see how and if we can fix/implement it T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
compiletest maintenance and improvements
Status: Backlog
Oxidizing run-make tests
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieyouxu @rustbot