Skip to content

compiletest: needs-* directive handling mixes : and name-val/name-comment separator #133765

New issue
New issue
Open
Parent:Tracking Issue for compiletest directive handling bugs and papercuts
Open
compiletest: needs-* directive handling mixes : and name-val/name-comment separator#133765
Parent:#131425
Labels
A-compiletestArea: The compiletest test runnerC-bugCategory: This is a bug.E-hardCall for participation: Hard difficulty. Experience needed to fix: A lot.E-tediousCall for participation: An issue involves lots of work and is better handled as many small tasks.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
@jieyouxu

Description

@jieyouxu
jieyouxu
opened on Dec 2, 2024
Member

Remark: I didn't want to adjust how directives accept : for name-value form vs name-comment form in this PR, so this temporarily accepts //@ needs-target-has-atomic 8,16,ptr but I want to only accept the colon form in the future.

Originally posted by @jieyouxu in #133736 (comment)

Activity

rustbot
added
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Dec 2, 2024
jieyouxu
added
A-compiletestArea: The compiletest test runner
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
C-bugCategory: This is a bug.
and removed
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Dec 2, 2024
jieyouxu
added this to compiletest maintenance and improvementson Dec 2, 2024
github-project-automation
moved this to Backlog in compiletest maintenance and improvementson Dec 2, 2024
jieyouxu
added
E-hardCall for participation: Hard difficulty. Experience needed to fix: A lot.
E-tediousCall for participation: An issue involves lots of work and is better handled as many small tasks.
on Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerC-bugCategory: This is a bug.E-hardCall for participation: Hard difficulty. Experience needed to fix: A lot.E-tediousCall for participation: An issue involves lots of work and is better handled as many small tasks.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    Development

    No branches or pull requests

      Participants

      @jieyouxu@rustbot

      Issue actions
        compiletest: `needs-*` directive handling mixes `:` and ` ` name-val/name-comment separator · Issue #133765 · rust-lang/rust