Skip to content

Valgrind sometimes takes a very long time on some tests #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Mar 4, 2012 · 6 comments
Closed

Valgrind sometimes takes a very long time on some tests #1922

brson opened this issue Mar 4, 2012 · 6 comments
Assignees
@brson
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows

Comments

@brson
Copy link
Contributor

brson commented Mar 4, 2012

One of the bots has currently been spending 30 minutes valgrinding task-perf-word-count. This makes me think something is going terribly wrong with memory management. Possibly related to native stacks.
@brson brson mentioned this issue Mar 4, 2012
Closed
@brson
Copy link
Contributor Author

brson commented Mar 4, 2012

This could be related to #1527, since I seem to be able to reproduce this behavior with optimizations on, but not off. We could be getting into a scenario where we repeatedly reallocate hunks of stack, pissing off valgrind.

@brson
Copy link
Contributor Author

brson commented Mar 4, 2012

It could even be just the act of preparing the stack segments for valgrind that makes it so slow - it's a fairly expensive operation that involves setting a status bit for every byte of the stack.

@ghost ghost assigned brson Mar 4, 2012
@brson
Copy link
Contributor Author

brson commented Mar 4, 2012

Actually, I can't reproduce this locally. I had a build take 12 hours last night on one of the bots.

@brson
Copy link
Contributor Author

brson commented Mar 4, 2012

Some investigation leads me to believe this could be a result of some pathological locking behavior in rust_port_detach.

@brson brson mentioned this issue Mar 4, 2012
Closed
@brson
Copy link
Contributor Author

brson commented Mar 5, 2012

I'm confident now that #1924 is the reason the linux bots randomly take ridiculous amounts of time.

@brson
Copy link
Contributor Author

brson commented Mar 8, 2012

Fixed.

@brson brson closed this as completed Mar 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brson