Skip to content

os::copy_file needs to copy the execution bit #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erickt opened this issue Jun 13, 2012 · 2 comments
Closed

os::copy_file needs to copy the execution bit #2579

erickt opened this issue Jun 13, 2012 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@erickt
Copy link
Contributor

erickt commented Jun 13, 2012

Cargo briefly used os::copy_file, but switched back to shelling out to cp in order to preserve the execution bit (See #2456). We should update os::copy_file to add this functionality.
@graydon
Copy link
Contributor

graydon commented Mar 22, 2013

non-critical for 0.6, de-milestoning

@catamorphism
Copy link
Contributor

I fixed this a while ago; see the test os::tests::copy_file_ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@graydon @erickt @catamorphism