Skip to content

HIR: remove ids from the AST #28144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nrc opened this issue Sep 1, 2015 · 3 comments
Closed

HIR: remove ids from the AST #28144

nrc opened this issue Sep 1, 2015 · 3 comments
Labels
A-HIR Area: The high-level intermediate representation (HIR)

Comments

@nrc
Copy link
Member

nrc commented Sep 1, 2015

I think only the HIR needs ids.
@nrc
Copy link
Member Author

nrc commented Sep 1, 2015

Note that this is not as simple as just removing the fields and assigning ids to the HIR, rather than the AST - we currently use ids from the AST for identifying AST nodes in save-analysis.

@nrc nrc mentioned this issue Sep 1, 2015
Closed
@steveklabnik steveklabnik added the A-HIR Area: The high-level intermediate representation (HIR) label Sep 3, 2015
@steveklabnik
Copy link
Member

Triage: no idea.

@nikomatsakis
Copy link
Contributor

I sort of think we should close this. It's kind of a complex question and I don't think having this bug is helpful really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-HIR Area: The high-level intermediate representation (HIR)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @nikomatsakis @nrc