-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Improve Error Handling chapter #28298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks to me like adding it to the book would require a major rewrite of it (The blog post) because it is written in a different style from the book (author talks about "I"). |
Yes! How should we do this? The article is in markdown here: https://github.com/BurntSushi/blog/blob/master/content/post/rust-error-handling.md (Well, mostly markdown. There are a few custom constructs for my questionable attempt at making sure all code compiles.) They should be easy to lift out. Should I do that and submit an initial PR? Should it be a guide? (There is already |
Maybe we could replace the error handling guide with @BurntSushi's article? |
It is a really awesome article. It would definitely be worth it to adapt it for the Rust book. |
Yes, that'd be the intention, basically, to replace the existing guide. I wouldn't be opposed to "import wholesale, change from I to we", frankly. Can't say more, but I don't think extra editing is important at first. (should be able to say soon) |
Regex to the rescue! |
I'd be willing to do this. |
OK, I'm working on the initial PR now. |
Oh. I just finished doing it. Whoops. |
I put the pull request up at #28301. |
This was fixed with the merging of #28301 |
A long while back, @BurntSushi wrote http://blog.burntsushi.net/rust-error-handling/ . It is awesome, and deserves to be in the book in some form. Last we talked, @BurntSushi was okay with us using it from a licensing perspective.
The text was updated successfully, but these errors were encountered: