Skip to content

Miscompilation since rustc 1.32.0-nightly (04fdb44f5 2018-11-03) #56069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ordian opened this issue Nov 19, 2018 · 3 comments
Closed

Miscompilation since rustc 1.32.0-nightly (04fdb44f5 2018-11-03) #56069

ordian opened this issue Nov 19, 2018 · 3 comments
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.

Comments

@ordian
Copy link

ordian commented Nov 19, 2018

parity-ethereum tests (in module ethcore-miner, sorry don't have time to minimize the test case) fail since nightly-2018-11-04, but pass on stable, beta and nightly-2018-11-03:

❯ rustup toolchain install nightly-2018-11-03
nightly-2018-11-03-x86_64-unknown-linux-gnu installed - rustc 1.32.0-nightly (8b096314a 2018-11-02)
❯ cargo +nightly-2018-11-03 test -p ethcore-miner
test result: ok. 57 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
❯ rustup toolchain install nightly-2018-11-04 
nightly-2018-11-04-x86_64-unknown-linux-gnu installed - rustc 1.32.0-nightly (04fdb44f5 2018-11-03)
❯ cargo +nightly-2018-11-04 test -p ethcore-miner
test result: FAILED. 50 passed; 7 failed; 0 ignored; 0 measured; 0 filtered out
@Centril Centril added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Nov 19, 2018
@nagisa
Copy link
Member

nagisa commented Nov 22, 2018

Took a short look at this during the T-compiler meeting. It would be ideal to have a smaller reproduction case to work off as it does not immediately clear whether this is an actual bug in the compiler.

@nikic
Copy link
Contributor

nikic commented Nov 22, 2018

The big item in 8b09631...04fdb44 is the jemalloc removal. It would be good to check whether explicitly enabling jemalloc fixes the issue. (And by "fix" I mean "hide" -- this would indicate memory corruption.)

@ordian
Copy link
Author

ordian commented Nov 22, 2018

Ah, right, I guess this is related to heapsize crate we're using, which requires jemalloc to work properly if I'm not mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.
Projects
None yet
Development

No branches or pull requests

4 participants