From 4879078f2ee5c99c8d84336049164b560c0b757f Mon Sep 17 00:00:00 2001 From: Oliver Middleton Date: Wed, 11 Nov 2015 14:25:08 +0000 Subject: [PATCH 1/2] Allow none Sized types in assert_eq! format_args! doesn't support none Sized types so we should just pass it the references to left_val and right_val. This fixes `assert_eq!([1, 2, 3][..], vec![1, 2, 3][..])` for example. --- src/libcore/macros.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcore/macros.rs b/src/libcore/macros.rs index 5b5f59d5ddbb7..0a0fcd23afbb8 100644 --- a/src/libcore/macros.rs +++ b/src/libcore/macros.rs @@ -89,7 +89,7 @@ macro_rules! assert_eq { (left_val, right_val) => { if !(*left_val == *right_val) { panic!("assertion failed: `(left == right)` \ - (left: `{:?}`, right: `{:?}`)", *left_val, *right_val) + (left: `{:?}`, right: `{:?}`)", left_val, right_val) } } } From 780581e8a1233f744329f37b6de10177069fbd86 Mon Sep 17 00:00:00 2001 From: Oliver Middleton Date: Wed, 11 Nov 2015 22:08:20 +0000 Subject: [PATCH 2/2] Add test for assert_eq! with none Sized types --- src/test/run-pass/assert-eq-macro-unsized.rs | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 src/test/run-pass/assert-eq-macro-unsized.rs diff --git a/src/test/run-pass/assert-eq-macro-unsized.rs b/src/test/run-pass/assert-eq-macro-unsized.rs new file mode 100644 index 0000000000000..e21d3ef0ed068 --- /dev/null +++ b/src/test/run-pass/assert-eq-macro-unsized.rs @@ -0,0 +1,13 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +pub fn main() { + assert_eq!([1, 2, 3][..], vec![1, 2, 3][..]); +}