From 6d63d3b8889d36afbabcf6e70ad8710139c7b253 Mon Sep 17 00:00:00 2001 From: est31 Date: Sun, 29 May 2022 01:00:24 +0200 Subject: [PATCH] Remove "sys isn't exported yet" phrase The oldest occurence is from 9e224c2bf18ebf8f871efb2e1aba43ed7970ebb7, which is from the pre-1.0 days. In the years since then, std::sys still hasn't been exported, and the last attempt was met with strong criticism: https://github.com/rust-lang/rust/pull/97151 Thus, removing the "yet" part makes a lot of sense. --- library/std/src/sys/unix/locks/pthread_mutex.rs | 1 - library/std/src/sys_common/thread_local_dtor.rs | 2 +- library/std/src/sys_common/thread_local_key.rs | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/library/std/src/sys/unix/locks/pthread_mutex.rs b/library/std/src/sys/unix/locks/pthread_mutex.rs index 09cfa2f50eced..76840ce74dd60 100644 --- a/library/std/src/sys/unix/locks/pthread_mutex.rs +++ b/library/std/src/sys/unix/locks/pthread_mutex.rs @@ -16,7 +16,6 @@ pub unsafe fn raw(m: &Mutex) -> *mut libc::pthread_mutex_t { unsafe impl Send for Mutex {} unsafe impl Sync for Mutex {} -#[allow(dead_code)] // sys isn't exported yet impl Mutex { pub const fn new() -> Mutex { // Might be moved to a different address, so it is better to avoid diff --git a/library/std/src/sys_common/thread_local_dtor.rs b/library/std/src/sys_common/thread_local_dtor.rs index f9971fb6f21ef..1d13a7171b035 100644 --- a/library/std/src/sys_common/thread_local_dtor.rs +++ b/library/std/src/sys_common/thread_local_dtor.rs @@ -11,7 +11,7 @@ //! or implement something more efficient. #![unstable(feature = "thread_local_internals", issue = "none")] -#![allow(dead_code)] // sys isn't exported yet +#![allow(dead_code)] use crate::ptr; use crate::sys_common::thread_local_key::StaticKey; diff --git a/library/std/src/sys_common/thread_local_key.rs b/library/std/src/sys_common/thread_local_key.rs index 32cd56416655f..70beebe86d20b 100644 --- a/library/std/src/sys_common/thread_local_key.rs +++ b/library/std/src/sys_common/thread_local_key.rs @@ -46,7 +46,7 @@ #![allow(non_camel_case_types)] #![unstable(feature = "thread_local_internals", issue = "none")] -#![allow(dead_code)] // sys isn't exported yet +#![allow(dead_code)] #[cfg(test)] mod tests;