Skip to content

./x.py check #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikomatsakis opened this issue Mar 12, 2018 · 10 comments
Closed

./x.py check #84

nikomatsakis opened this issue Mar 12, 2018 · 10 comments
Labels
E-easy Difficulty: might be a good place for a beginner

Comments

@nikomatsakis
Copy link
Contributor

So I've recently discovered that ./x.py check is actually really dang fast -- we should add a note about it in the "how to build compiler" section. It's in particular very useful when you're doing some kind of "type-based refactoring", like renaming a method, or changing the signature of some function.

@mark-i-m mark-i-m added E-help-wanted Call for participation: extra help is wanted E-easy Difficulty: might be a good place for a beginner labels Mar 12, 2018
@rajcspsg
Copy link
Contributor

@nikomatsakis @mark-i-m - can I take this easy issue?

@mark-i-m mark-i-m removed the E-help-wanted Call for participation: extra help is wanted label Apr 13, 2018
@mark-i-m
Copy link
Member

Go for it :)

@rajcspsg
Copy link
Contributor

rajcspsg commented Apr 17, 2018

@nikomatsakis - I've updated the this file correct?
Also, I see the document has already something related to x.py build command for rustc.

@rajcspsg
Copy link
Contributor

@nikomatsakis @mark-i-m - I see documentation related to https://forge.rust-lang.org/x-py.html.
Do I've to move the contents here as mentioned in this issue 98?

@mark-i-m
Copy link
Member

I've updated the this file correct?
Also, I see the document has already something related to x.py build command for rustc.

Yep, that's the right file. It already had content on some of the other x.py commands, but not for check.

I see documentation related to https://forge.rust-lang.org/x-py.html.
Do I've to move the contents here as mentioned in this issue 98?

Hmm... I think it would be good to do, but not in this PR. I also think it is distinct from #98... Could you open a new issue for it?

@rajcspsg
Copy link
Contributor

@mark-i-m

I will update the below content in that file. Please let me know if it is fine.

`./x.py check` is really fast to build the rust compiler. 
It is, in particular, very useful when you're doing some kind of "type-based refactoring", like renaming a method, or changing the signature of some function.

Also, I will open new issue move copying contents from https://forge.rust-lang.org/x-py.html.

@mark-i-m
Copy link
Member

mark-i-m commented May 8, 2018

Ping @rajcspsg Any updates?

@rajcspsg
Copy link
Contributor

@mark-i-m Sorry for delay. I didn't noticed when you 👍 my comment.
I've created PR for this issue #129.

@rajcspsg
Copy link
Contributor

@mark-i-m I've created new issue #130 for documentation from https://forge.rust-lang.org/x-py.html.

@mark-i-m
Copy link
Member

@rajcspsg Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Difficulty: might be a good place for a beginner
Projects
None yet
Development

No branches or pull requests

3 participants