Skip to content

Add clap to compile benchmarks #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mark-Simulacrum opened this issue Feb 20, 2018 · 3 comments
Closed

Add clap to compile benchmarks #183

Mark-Simulacrum opened this issue Feb 20, 2018 · 3 comments

Comments

@Mark-Simulacrum
Copy link
Member

No description provided.

@eddyb
Copy link
Member

eddyb commented Feb 21, 2018

In my case, clap-rs/clap#1143 brings the build with my WIP MIR pass from 3h to 30s.
It just happened that RLS depends on v2.29.0 (clap-rs/clap@e962f2c), while the fix is in v2.29.1.
So if we want a stress test out of clap, we have to use v2.29.0. cc @kbknapp

@kbknapp
Copy link

kbknapp commented Feb 22, 2018

Let me know if you need anything from my end, I'll keep an eye on this issue in case.

@Mark-Simulacrum
Copy link
Member Author

Added clap at e962f2ceced8c04105ad12a4ca719daf2942667b, collection has begun.

@eddyb eddyb mentioned this issue Jun 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eddyb @Mark-Simulacrum @kbknapp