-
Notifications
You must be signed in to change notification settings - Fork 10.6k
v6 beta feedback 🥰 #1960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging @orhun because you were willing to test it 🥰 |
Thanks for your efforts put into this! I stumbled on an error while installing:
I fixed this issue by running |
@norraell I will add a note about this to the README. Thanks :D |
@norraell The README is now updated to include |
Hello, thanks for the ping! I got this error right off the bat:
I'm assuming this is due to my custom cargo setup (global [build]
target-dir = "/drv/cargo/target" So |
@orhun Thank you for reporting this issue 😅 Would it be fine if I create the file Otherwise, I would need to add the |
Don't think so, I think it would be best to not mess with the user's configuration.
Or you can simply read
What do you think? |
It is not that easy because Cargo looks for the config file in the current directory and all parent directories. You would also need to find out what I guess I will just parse that JSON then :P |
Ouf, unfortunately I'm not aware of a crate that might help with that :/ |
FeedbackHere is my feedback. I already know Rust, but I never looked at Here are my solutions for reference. I'm using
1)
|
Hi Jan @dotjpg3141, thank you very much for your very valuable detailed feedback. I can't express how much it means to me, thank you for your time 🤗🤗🤗 I will probably need days to fix all the issues that you mentioned and give you a detailed reply. |
Now I'm getting this:
I think it requires to be run in a Cargo project directory where |
@orhun Oh well, this one is embarrassing… I shouldn't release anything that late in the night and should definitely add more tests. Anyway, it should work in |
No worries, all seems good now. I haven't tested the exercises but the the prompt/TUI is working smoothly for me. Great job! I can look into this more in depth in the following days probably. |
Fixed
This is a problem with the used terminal (
This is very weird, but I hope that it doesn't happen in a modern terminal like Windows Terminal. Could you please try it out?
Fixed
I am afraid that we can't do anything about this. The most important thing is that Rust-Analyzer provides autocompletion, goto definition, rename and so on. Warnings and errors are shown by Rustlings anyway.
I tried to reproduce these two issues related to the order of exercises but I couldn't. What happens if you enter Could you please post the content of the hidden file I will fix the things that you pointed out about the exercises and Clippy later. Thank you again for your very valuable feedback 🥰 |
Love the new direction rustlings is taking! One issue I'm having: |
I used 2) Encoding/Display error
Yep. This seems to be an issue of 3) Invisible input text
That doesn't seem to make a difference. windows-terminal.mp45) Quiz / 6) Progress bar
This is the content of `.rustlings-state.txt`.
Text content of the list (without the `next` column).
This are my local files (after This happened when I pressed next.mp4 |
Would it be possible to keep around nix as an installation method in v6? |
No, because I don't use Nix and will not maintain it. You can package it then because v6 will be a standalone binary that you can install with |
I was taking a look at |
It might also be helpful to have an "ideal solution" for each exercise. |
This is one of the main features of v6 :D Handling solutions is already implemented. I just need to find some time to write the solutions: https://github.com/rust-lang/rustlings/tree/v6/solutions |
Oh, nice! I think I can try contributing to that if it goes in a pull request. |
Also, I think it'd be neat if users had an option to automatically open the next exercise in their editor after completing the current one. |
I plan to write them myself first and then improvements are welcome :D
This should also be partially solved since v6 shows you the path of the next exercise as a link in your terminal. Clicking on the link opens the file in your editor. |
I didn't find a way to really fix it, but now (
Thank you for sharing all the info. This looks good to me! (not a bug, but a source of confusion) The reason why some exercises like This was fine before having the interactive list. But now that the list exists and allows you to opt into skipping an exercise, I think we should disable skipping on saving the file of a later exercise. Going back is fine though. I will implement this in the next beta version :) Thank you again @dotjpg3141 🥰 |
Done in |
@vgroenewold I don't have enough information to reproduce this. Could you please tell me what command you tried to run and in which directory? Could you please share the exact error message? Thanks 😊 |
That makes a lot of sense. This is probably what happened. |
Version 6 is released now. Thank you all for your feedback 🥰 |
After about a month of intensive work, I am happy announce the beta release of version 6 🎉
It is a full rewrite of the command line tool. Therefore, I hope to find some people willing to test it and provide some feedback here 🥰
You can try it by following the instructions in the README of the
v6
branch. NOTE: You don't need to clone the Rustlings repository anymore.Your feedback is welcome, as detailed as you want 🥰
But don't focus on the exercises. These didn't really change in v6.
Points to consider in the feedback
cargo install
rustlings/
directoryrustlings
inside therustlings/
directory):h
orhint
)l
orlist
in the watch mode):c
)solutions/
directory after the exercise is done--help
Known issues
intro1
doesn't make a lot of sense anymoreThe text was updated successfully, but these errors were encountered: